[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-28 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385707975 ## File path: extensions/http-curl/tests/HTTPIntegrationBase.h ## @@ -91,4 +87,74 @@ void

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-27 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385210528 ## File path: libminifi/include/core/state/nodes/MetricsBase.h ## @@ -228,6 +228,20 @@ cla

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-27 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385206542 ## File path: extensions/http-curl/tests/HTTPHandlers.h ## @@ -343,4 +345,104 @@ class Del

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-27 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385203258 ## File path: extensions/http-curl/tests/C2JstackTest.cpp ## @@ -45,123 +45,114 @@ #inclu

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-27 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r385202159 ## File path: extensions/coap/tests/CoapIntegrationBase.h ## @@ -41,13 +41,13 @@ class Coa

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378143151 ## File path: libminifi/src/FlowController.cpp ## @@ -931,6 +942,35 @@ int16_t FlowContro

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378147512 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -553,6 +577,20 @@ void C2Agent::handle_de

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378143395 ## File path: libminifi/src/FlowController.cpp ## @@ -931,6 +942,35 @@ int16_t FlowContro

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378143506 ## File path: libminifi/src/FlowController.cpp ## @@ -931,6 +942,35 @@ int16_t FlowContro

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat.

2020-02-12 Thread GitBox
arpadboda commented on a change in pull request #734: MINIFICPP-1157 Implement lightweight C2 heartbeat. URL: https://github.com/apache/nifi-minifi-cpp/pull/734#discussion_r378146683 ## File path: libminifi/src/c2/C2Agent.cpp ## @@ -315,16 +317,35 @@ void C2Agent::performH