[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #621: MINIFICPP-959: Review librdkafka thread safety

2019-08-16 Thread GitBox
bakaid commented on a change in pull request #621: MINIFICPP-959: Review librdkafka thread safety URL: https://github.com/apache/nifi-minifi-cpp/pull/621#discussion_r314647651 ## File path: extensions/librdkafka/KafkaConnection.h ## @@ -0,0 +1,217 @@ +/** + * Licensed to t

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #621: MINIFICPP-959: Review librdkafka thread safety

2019-08-16 Thread GitBox
bakaid commented on a change in pull request #621: MINIFICPP-959: Review librdkafka thread safety URL: https://github.com/apache/nifi-minifi-cpp/pull/621#discussion_r314647065 ## File path: extensions/librdkafka/PublishKafka.cpp ## @@ -319,27 +320,29 @@ void PublishKafka::

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #621: MINIFICPP-959: Review librdkafka thread safety

2019-08-16 Thread GitBox
bakaid commented on a change in pull request #621: MINIFICPP-959: Review librdkafka thread safety URL: https://github.com/apache/nifi-minifi-cpp/pull/621#discussion_r314649513 ## File path: extensions/librdkafka/KafkaPool.h ## @@ -0,0 +1,67 @@ +/** + * Licensed to the Apac

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #621: MINIFICPP-959: Review librdkafka thread safety

2019-08-12 Thread GitBox
bakaid commented on a change in pull request #621: MINIFICPP-959: Review librdkafka thread safety URL: https://github.com/apache/nifi-minifi-cpp/pull/621#discussion_r312985818 ## File path: extensions/librdkafka/PublishKafka.h ## @@ -275,9 +80,12 @@ class KafkaPool {