[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class

2020-02-24 Thread GitBox
bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r383145068 ## File path: extensions/http-curl/tests/unit/HTTPStreamingCallbackTests.cpp ## @@

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class

2020-02-21 Thread GitBox
bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r382657022 ## File path: libminifi/include/utils/HTTPClient.h ## @@ -219,16 +232,15 @@ class

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class

2020-02-21 Thread GitBox
bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r382656213 ## File path: extensions/http-curl/client/HTTPCallback.h ## @@ -33,148 +34,195 @@

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class

2020-02-21 Thread GitBox
bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r382654840 ## File path: libminifi/include/utils/HTTPClient.h ## @@ -201,15 +211,18 @@ class

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class

2020-02-20 Thread GitBox
bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r382149656 ## File path: libminifi/include/utils/HTTPClient.h ## @@ -185,11 +185,19 @@ class

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class

2020-02-20 Thread GitBox
bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r382143123 ## File path: libminifi/include/utils/HTTPClient.h ## @@ -201,15 +209,18 @@ class

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class

2020-02-20 Thread GitBox
bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r382142566 ## File path: extensions/http-curl/client/HTTPCallback.h ## @@ -33,148 +34,195 @@

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class

2020-02-18 Thread GitBox
bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r380881814 ## File path: extensions/http-curl/client/HTTPCallback.h ## @@ -33,148 +34,195 @@

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class

2020-02-18 Thread GitBox
bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r380881814 ## File path: extensions/http-curl/client/HTTPCallback.h ## @@ -33,148 +34,195 @@

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class

2020-02-18 Thread GitBox
bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r380879464 ## File path: extensions/http-curl/client/HTTPCallback.h ## @@ -33,148 +34,195 @@

[GitHub] [nifi-minifi-cpp] bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class

2020-02-18 Thread GitBox
bakaid commented on a change in pull request #740: MINIFICPP-1144 - Fix HTTPCallback freeze and refactor class URL: https://github.com/apache/nifi-minifi-cpp/pull/740#discussion_r380878311 ## File path: libminifi/include/utils/HTTPClient.h ## @@ -201,15 +209,18 @@ class