[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

fgerlits commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r634441394 ## File path: libminifi/src/utils/FileReaderCallback.cpp ## @@ -0,0 +1,72 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

fgerlits commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r634437724 ## File path: extensions/standard-processors/processors/GetFile.cpp ## @@ -158,76 +147,89 @@ void GetFile::onSchedule(core::ProcessContext

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

fgerlits commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r630912957 ## File path: extensions/standard-processors/processors/GetFile.cpp ## @@ -158,76 +147,89 @@ void GetFile::onSchedule(core::ProcessContext

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

fgerlits commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r630911063 ## File path: extensions/standard-processors/processors/GetFile.cpp ## @@ -158,76 +147,89 @@ void GetFile::onSchedule(core::ProcessContext

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

fgerlits commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r629374185 ## File path: libminifi/src/utils/FileReaderCallback.cpp ## @@ -0,0 +1,72 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

fgerlits commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r629371618 ## File path: extensions/standard-processors/tests/unit/GetFileTests.cpp ## @@ -91,12 +113,30 @@ TEST_CASE("GetFile: MaxSize", "[getFileFifo]")

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1064: MINIFICPP-987 Improve error handling in GetFile

fgerlits commented on a change in pull request #1064: URL: https://github.com/apache/nifi-minifi-cpp/pull/1064#discussion_r629371159 ## File path: extensions/standard-processors/processors/GetFile.cpp ## @@ -159,47 +148,54 @@ void GetFile::onSchedule(core::ProcessContext