[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-12 Thread GitBox
lordgamez commented on a change in pull request #866: URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r469172626 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +352,54 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-12 Thread GitBox
lordgamez commented on a change in pull request #866: URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r469172275 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +362,56 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-11 Thread GitBox
lordgamez commented on a change in pull request #866: URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r46867 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +362,56 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-11 Thread GitBox
lordgamez commented on a change in pull request #866: URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r46867 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +362,56 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-11 Thread GitBox
lordgamez commented on a change in pull request #866: URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r468625451 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -252,36 +255,43 @@ bool MergeContent::processBin(core::ProcessContext *context, core::

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-11 Thread GitBox
lordgamez commented on a change in pull request #866: URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r468595660 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +362,56 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-11 Thread GitBox
lordgamez commented on a change in pull request #866: URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r468590741 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +362,56 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-11 Thread GitBox
lordgamez commented on a change in pull request #866: URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r468496921 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +362,56 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-11 Thread GitBox
lordgamez commented on a change in pull request #866: URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r468422943 ## File path: extensions/libarchive/MergeContent.h ## @@ -259,6 +261,42 @@ class ZipMerge: public ArchiveMerge, public MergeBin { } }; +clas

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-11 Thread GitBox
lordgamez commented on a change in pull request #866: URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r468422943 ## File path: extensions/libarchive/MergeContent.h ## @@ -259,6 +261,42 @@ class ZipMerge: public ArchiveMerge, public MergeBin { } }; +clas

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-11 Thread GitBox
lordgamez commented on a change in pull request #866: URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r468409914 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -342,6 +362,56 @@ std::shared_ptr ZipMerge::merge(core::ProcessContext *context, c

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-11 Thread GitBox
lordgamez commented on a change in pull request #866: URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r468403366 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -271,6 +281,16 @@ bool MergeContent::processBin(core::ProcessContext *context, core::P

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-11 Thread GitBox
lordgamez commented on a change in pull request #866: URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r468390009 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -271,6 +281,16 @@ bool MergeContent::processBin(core::ProcessContext *context, core::P

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #866: MINIFICPP-1321 Support attribute strategies in MergeContent processor

2020-08-11 Thread GitBox
lordgamez commented on a change in pull request #866: URL: https://github.com/apache/nifi-minifi-cpp/pull/866#discussion_r46831 ## File path: extensions/libarchive/MergeContent.cpp ## @@ -140,6 +146,10 @@ void MergeContent::onSchedule(core::ProcessContext *context, core::P