[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1316: MINIFICPP-1687 Signal error on UUID collision

2022-04-29 Thread GitBox
lordgamez commented on code in PR #1316: URL: https://github.com/apache/nifi-minifi-cpp/pull/1316#discussion_r861558365 ## libminifi/include/core/yaml/YamlConfiguration.h: ## @@ -277,6 +278,7 @@ class YamlConfiguration : public FlowConfiguration { * @return the parse

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1316: MINIFICPP-1687 Signal error on UUID collision

2022-04-27 Thread GitBox
lordgamez commented on code in PR #1316: URL: https://github.com/apache/nifi-minifi-cpp/pull/1316#discussion_r859602656 ## libminifi/src/core/yaml/YamlConfiguration.cpp: ## @@ -908,6 +914,14 @@ YAML::Node YamlConfiguration::getOptionalField(const YAML::Node& yamlNode, const

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1316: MINIFICPP-1687 Signal error on UUID collision

2022-04-27 Thread GitBox
lordgamez commented on code in PR #1316: URL: https://github.com/apache/nifi-minifi-cpp/pull/1316#discussion_r859602325 ## libminifi/include/core/yaml/YamlConfiguration.h: ## @@ -277,6 +278,7 @@ class YamlConfiguration : public FlowConfiguration { * @return the parse