[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

lordgamez commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1301503268 ## libminifi/include/utils/net/AsioSocketUtils.h: ## @@ -89,28 +94,71 @@ class AsioSocketConnection : public io::BaseStream { } private: +#ifndef WIN32

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

lordgamez commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1301430406 ## libminifi/include/utils/net/AsioSocketUtils.h: ## @@ -63,6 +64,64 @@ asio::awaitable> handshake(SslSocket& socket, asio:: asio::ssl::context getSslCo

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

lordgamez commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1301222466 ## libminifi/include/utils/net/AsioSocketUtils.h: ## @@ -63,6 +64,64 @@ asio::awaitable> handshake(SslSocket& socket, asio:: asio::ssl::context getSslCo

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

lordgamez commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1301243478 ## libminifi/include/utils/net/AsioSocketUtils.h: ## @@ -63,6 +64,64 @@ asio::awaitable> handshake(SslSocket& socket, asio:: asio::ssl::context getSslCo

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

lordgamez commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1301222466 ## libminifi/include/utils/net/AsioSocketUtils.h: ## @@ -63,6 +64,64 @@ asio::awaitable> handshake(SslSocket& socket, asio:: asio::ssl::context getSslCo

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

lordgamez commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1287003841 ## libminifi/include/core/Processor.h: ## Review Comment: Updated in 9c5203b1db3be04c310bc47be0e1199fb0c85102 -- This is an automated message from th

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

lordgamez commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1286992898 ## libminifi/include/core/Processor.h: ## Review Comment: Oh, I only saw the clang tidy failure in `HTTPClient` (probably the other clang run), but I'll

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

lordgamez commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1286959204 ## libminifi/include/utils/net/AsioSocketUtils.h: ## @@ -63,6 +64,64 @@ asio::awaitable> handshake(SslSocket& socket, asio:: asio::ssl::context getSslCo

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

lordgamez commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1281626222 ## libminifi/include/utils/net/AsioSocketUtils.h: ## @@ -61,6 +62,64 @@ asio::awaitable> handshake(SslSocket& socket, asio:: asio::ssl::context getSslCo

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

lordgamez commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1281623154 ## libminifi/src/utils/net/DNS.cpp: ## @@ -15,85 +15,20 @@ * limitations under the License. */ #include "utils/net/DNS.h" + +#ifndef WIN32 +#include +#e

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

lordgamez commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1281622857 ## libminifi/src/utils/net/DNS.cpp: ## @@ -127,4 +69,9 @@ nonstd::expected reverseDnsLookup(const asio::ip:: return results->host_name(); } +std::strin

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

lordgamez commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1281594319 ## libminifi/include/core/state/nodes/DeviceInformation.h: ## Review Comment: The logic was already moved in https://github.com/apache/nifi-minifi-cpp/p

[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1599: MINIFICPP-2152 Remove own server and client socket implementations

lordgamez commented on code in PR #1599: URL: https://github.com/apache/nifi-minifi-cpp/pull/1599#discussion_r1280379349 ## libminifi/include/utils/net/Socket.h: ## Review Comment: Updated in 1081ccfb9608f8f9dd7933cf48b66cb684276837 ## libminifi/include/utils/net