[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

martinzink commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r640505246 ## File path: extensions/pdh/PerformanceDataMonitor.cpp ## @@ -45,9 +45,13 @@ core::Property PerformanceDataMonitor::CustomPDHCounters(

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

martinzink commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r640505129 ## File path: extensions/pdh/tests/PerformanceDataMonitorTests.cpp ## @@ -136,8 +136,9 @@

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

martinzink commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r640503174 ## File path: extensions/pdh/PerformanceDataMonitor.cpp ## @@ -45,9 +45,13 @@ core::Property PerformanceDataMonitor::CustomPDHCounters(

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

martinzink commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r640503174 ## File path: extensions/pdh/PerformanceDataMonitor.cpp ## @@ -45,9 +45,13 @@ core::Property PerformanceDataMonitor::CustomPDHCounters(

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

martinzink commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r640448605 ## File path: extensions/pdh/PerformanceDataMonitor.cpp ## @@ -264,16 +281,29 @@ void

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

martinzink commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r640448605 ## File path: extensions/pdh/PerformanceDataMonitor.cpp ## @@ -264,16 +281,29 @@ void

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

martinzink commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r640448121 ## File path: extensions/pdh/PerformanceDataMonitor.cpp ## @@ -249,32 +265,56 @@ void

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

martinzink commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r640383528 ## File path: extensions/pdh/PerformanceDataMonitor.cpp ## @@ -102,25 +108,36 @@ void PerformanceDataMonitor::onTrigger(core::ProcessContext*

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

martinzink commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r640380661 ## File path: extensions/pdh/PerformanceDataMonitor.cpp ## @@ -249,32 +265,56 @@ void

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

martinzink commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r639893584 ## File path: extensions/pdh/tests/PerformanceDataCounterTests.cpp ## @@ -122,8 +122,8 @@ TEST_CASE("PDHCounterDataCollectionTest",

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

martinzink commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r639760892 ## File path: libminifi/include/utils/MathUtils.h ## @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

martinzink commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r639761624 ## File path: libminifi/include/utils/MathUtils.h ## @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or