[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r640767159 ## File path: extensions/libarchive/CompressContent.h ## @@ -190,16 +189,11 @@ class CompressContent: public core::Processor { return ret;

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r640756106 ## File path: libminifi/src/io/InputStream.cpp ## @@ -84,9 +85,9 @@ int InputStream::read(std::string &str, bool widen) { } std::vector buf

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r640755701 ## File path: libminifi/test/BufferReader.h ## @@ -44,7 +44,7 @@ class BufferReader : public org::apache::nifi::minifi::InputStreamCallback { }

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r640755398 ## File path: extensions/http-curl/tests/HTTPHandlers.h ## @@ -214,7 +214,7 @@ class FlowFileResponder : public ServerAwareHandler { minifi:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r640755520 ## File path: libminifi/test/archive-tests/CompressContentTests.cpp ## @@ -41,29 +41,23 @@ #include "processors/PutFile.h" #include "utils/file/F

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r640755085 ## File path: libminifi/include/io/Stream.h ## @@ -24,14 +24,23 @@ namespace nifi { namespace minifi { namespace io { +inline bool isError(cons

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r639767608 ## File path: libminifi/test/BufferReader.h ## @@ -44,7 +44,7 @@ class BufferReader : public org::apache::nifi::minifi::InputStreamCallback { }

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r639766408 ## File path: libminifi/src/io/InputStream.cpp ## @@ -84,9 +85,9 @@ int InputStream::read(std::string &str, bool widen) { } std::vector buf

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r639710821 ## File path: libminifi/include/io/Stream.h ## @@ -24,14 +24,23 @@ namespace nifi { namespace minifi { namespace io { +inline bool isError(cons

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r639708731 ## File path: extensions/tensorflow/TFExtractTopLabels.cpp ## @@ -134,9 +136,9 @@ int64_t TFExtractTopLabels::LabelsReadCallback::process(const st

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r601385022 ## File path: extensions/mqtt/processors/PublishMQTT.h ## @@ -74,19 +77,21 @@ class PublishMQTT : public processors::AbstractMQTTProcessor {

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r601384653 ## File path: extensions/libarchive/CompressContent.h ## @@ -190,16 +189,11 @@ class CompressContent: public core::Processor { return ret;

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r601315940 ## File path: extensions/libarchive/CompressContent.h ## @@ -190,16 +189,11 @@ class CompressContent: public core::Processor { return ret;

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596888000 ## File path: extensions/script/lua/LuaBaseStream.cpp ## @@ -52,16 +52,11 @@ std::string LuaBaseStream::read(size_t len) { // 0 <= n < s.siz

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596876156 ## File path: extensions/script/lua/LuaBaseStream.cpp ## @@ -52,16 +52,11 @@ std::string LuaBaseStream::read(size_t len) { // 0 <= n < s.siz

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596871602 ## File path: extensions/script/lua/LuaBaseStream.cpp ## @@ -52,16 +52,11 @@ std::string LuaBaseStream::read(size_t len) { // 0 <= n < s.siz

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596871602 ## File path: extensions/script/lua/LuaBaseStream.cpp ## @@ -52,16 +52,11 @@ std::string LuaBaseStream::read(size_t len) { // 0 <= n < s.siz

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596846495 ## File path: libminifi/test/rocksdb-tests/DBContentRepositoryTests.cpp ## @@ -179,7 +179,7 @@ TEST_CASE("Delete NonExistent Claim", "[TestDBCR4]")

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596846391 ## File path: libminifi/test/rocksdb-tests/ContentSessionTests.cpp ## @@ -56,11 +56,10 @@ const std::shared_ptr& operator>>(const std::shared_ptr<

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596202026 ## File path: libminifi/test/rocksdb-tests/ContentSessionTests.cpp ## @@ -56,11 +56,10 @@ const std::shared_ptr& operator>>(const std::shared_ptr<

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596199210 ## File path: libminifi/test/rocksdb-tests/ContentSessionTests.cpp ## @@ -56,11 +56,10 @@ const std::shared_ptr& operator>>(const std::shared_ptr<

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596138026 ## File path: libminifi/src/sitetosite/SiteToSiteClient.cpp ## @@ -31,47 +31,37 @@ namespace sitetosite { int SiteToSiteClient::readResponse(con

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596136746 ## File path: thirdparty/google-styleguide/run_linter.sh ## @@ -40,5 +40,7 @@ done HEADERS=`find $INCLUDE_DIRS -name '*.h' | sort | uniq | tr '\

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596134706 ## File path: libminifi/src/io/InputStream.cpp ## @@ -30,42 +30,43 @@ namespace nifi { namespace minifi { namespace io { -int InputStream::read

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596134706 ## File path: libminifi/src/io/InputStream.cpp ## @@ -30,42 +30,43 @@ namespace nifi { namespace minifi { namespace io { -int InputStream::read

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596134134 ## File path: libminifi/test/rocksdb-tests/DBContentRepositoryTests.cpp ## @@ -140,7 +140,7 @@ TEST_CASE("Test Empty Claim", "[TestDBCR3]") { st

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596133924 ## File path: libminifi/src/sitetosite/SiteToSiteClient.cpp ## @@ -31,47 +31,43 @@ namespace sitetosite { int SiteToSiteClient::readResponse(con

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596130219 ## File path: libminifi/src/io/tls/SecureDescriptorStream.cpp ## @@ -71,34 +71,29 @@ int SecureDescriptorStream::write(const uint8_t *value, int s

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596129693 ## File path: libminifi/src/c2/ControllerSocketProtocol.cpp ## @@ -248,11 +248,11 @@ void ControllerSocketProtocol::initialize(core::controller::C

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596129303 ## File path: extensions/standard-processors/processors/ExtractText.cpp ## @@ -126,22 +125,22 @@ int64_t ExtractText::ReadCallback::process(const

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596131314 ## File path: libminifi/test/archive-tests/MergeFileTests.cpp ## @@ -111,8 +111,8 @@ std::vector read_archives(const FixedBuffer& input) { clas

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596130219 ## File path: libminifi/src/io/tls/SecureDescriptorStream.cpp ## @@ -71,34 +71,29 @@ int SecureDescriptorStream::write(const uint8_t *value, int s

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596129693 ## File path: libminifi/src/c2/ControllerSocketProtocol.cpp ## @@ -248,11 +248,11 @@ void ControllerSocketProtocol::initialize(core::controller::C

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596129303 ## File path: extensions/standard-processors/processors/ExtractText.cpp ## @@ -126,22 +125,22 @@ int64_t ExtractText::ReadCallback::process(const

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r596073337 ## File path: libminifi/include/io/InputStream.h ## @@ -39,43 +39,43 @@ class InputStream : public virtual Stream { * reads a byte array from t

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r595929512 ## File path: thirdparty/google-styleguide/run_linter.sh ## @@ -40,5 +40,7 @@ done HEADERS=`find $INCLUDE_DIRS -name '*.h' | sort | uniq | tr '\

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r595866436 ## File path: libminifi/src/FlowFileRecord.cpp ## @@ -181,12 +179,12 @@ std::shared_ptr FlowFileRecord::DeSerialize(io::InputStream& inS }

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r595866093 ## File path: libminifi/include/sitetosite/SiteToSiteClient.h ## @@ -65,19 +67,14 @@ class SiteToSiteClient : public core::Connectable { _

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r595865441 ## File path: extensions/sftp/client/SFTPClient.cpp ## @@ -577,20 +577,20 @@ bool SFTPClient::putFile(const std::string& path, io::BaseStream& inp

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r595865232 ## File path: extensions/script/python/PyBaseStream.cpp ## @@ -49,13 +49,11 @@ py::bytes PyBaseStream::read(size_t len) { std::vector buffer(l

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r595820660 ## File path: libminifi/src/FlowFileRecord.cpp ## @@ -181,12 +179,12 @@ std::shared_ptr FlowFileRecord::DeSerialize(io::InputStream& inS }

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r595819327 ## File path: extensions/standard-processors/processors/ExtractText.cpp ## @@ -126,22 +125,22 @@ int64_t ExtractText::ReadCallback::process(const

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r595291226 ## File path: libminifi/include/io/InputStream.h ## @@ -39,43 +39,43 @@ class InputStream : public virtual Stream { * reads a byte array from t

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r595288401 ## File path: libminifi/src/io/tls/SecureDescriptorStream.cpp ## @@ -71,34 +71,29 @@ int SecureDescriptorStream::write(const uint8_t *value, int s

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r595284802 ## File path: libminifi/src/c2/ControllerSocketProtocol.cpp ## @@ -248,11 +248,11 @@ void ControllerSocketProtocol::initialize(core::controller::C

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r595282360 ## File path: libminifi/include/io/InputStream.h ## @@ -39,43 +39,43 @@ class InputStream : public virtual Stream { * reads a byte array from t

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r595277807 ## File path: extensions/standard-processors/processors/ExtractText.cpp ## @@ -126,22 +125,22 @@ int64_t ExtractText::ReadCallback::process(const

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1028: MINIFICPP-1507 convert InputStream::read to size_t

szaszm commented on a change in pull request #1028: URL: https://github.com/apache/nifi-minifi-cpp/pull/1028#discussion_r595274724 ## File path: extensions/sftp/client/SFTPClient.cpp ## @@ -577,20 +577,20 @@ bool SFTPClient::putFile(const std::string& path, io::BaseStream& inp