[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

szaszm commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635316167 ## File path: libminifi/src/Configure.cpp ## @@ -37,6 +37,10 @@ bool Configure::get(const std::string& key, std::string& value) const { bool

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

szaszm commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635299532 ## File path: libminifi/include/core/logging/Logger.h ## @@ -68,13 +69,32 @@ inline T conditional_conversion(T t) { } template -inline

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

szaszm commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635293708 ## File path: libminifi/src/Configure.cpp ## @@ -37,6 +37,10 @@ bool Configure::get(const std::string& key, std::string& value) const { bool

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

szaszm commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r633704910 ## File path: libminifi/include/core/logging/Logger.h ## @@ -68,13 +69,32 @@ inline T conditional_conversion(T t) { } template -inline

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

szaszm commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r633702768 ## File path: libminifi/include/core/logging/Logger.h ## @@ -68,13 +69,32 @@ inline T conditional_conversion(T t) { } template -inline