[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

2021-05-27 Thread GitBox
szaszm commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r640492155 ## File path: extensions/pdh/PerformanceDataMonitor.cpp ## @@ -45,9 +45,13 @@ core::Property PerformanceDataMonitor::CustomPDHCounters( core::Prop

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

2021-05-26 Thread GitBox
szaszm commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r639858130 ## File path: extensions/pdh/tests/PerformanceDataCounterTests.cpp ## @@ -122,8 +122,8 @@ TEST_CASE("PDHCounterDataCollectionTest", "[pdhcounterda

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

2021-05-25 Thread GitBox
szaszm commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r638895278 ## File path: libminifi/include/utils/MathUtils.h ## @@ -0,0 +1,43 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more +

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1081: MINIFICPP-1565: Minor improvements to PerformanceDataMonitor

2021-05-25 Thread GitBox
szaszm commented on a change in pull request #1081: URL: https://github.com/apache/nifi-minifi-cpp/pull/1081#discussion_r638890480 ## File path: extensions/pdh/PerformanceDataMonitor.cpp ## @@ -45,9 +45,15 @@ core::Property PerformanceDataMonitor::CustomPDHCounters( core::Prop