[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1249: MINIFICPP-1669 Use std::byte for buffers

szaszm commented on a change in pull request #1249: URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r800716297 ## File path: libminifi/include/utils/StringUtils.h ## @@ -423,46 +416,37 @@ class StringUtils { * @param base64_length the length of base64

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1249: MINIFICPP-1669 Use std::byte for buffers

szaszm commented on a change in pull request #1249: URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r800672928 ## File path: controller/Controller.h ## @@ -111,12 +111,12 @@ int getFullConnections(std::unique_ptr so org::apache::nifi::minifi::io::BufferS

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1249: MINIFICPP-1669 Use std::byte for buffers

szaszm commented on a change in pull request #1249: URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r800672706 ## File path: extensions/standard-processors/processors/DefragmentText.cpp ## @@ -187,7 +187,7 @@ struct ReadFlowFileContent : public InputStreamCa

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1249: MINIFICPP-1669 Use std::byte for buffers

szaszm commented on a change in pull request #1249: URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r800672565 ## File path: libminifi/include/c2/PayloadSerializer.h ## @@ -209,7 +209,7 @@ class PayloadSerializer { } return node; } - static C2P

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1249: MINIFICPP-1669 Use std::byte for buffers

szaszm commented on a change in pull request #1249: URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r800672312 ## File path: libminifi/include/io/ClientSocket.h ## @@ -137,8 +137,8 @@ class Socket : public BaseStream { * @param buflen * @param retrie

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1249: MINIFICPP-1669 Use std::byte for buffers

szaszm commented on a change in pull request #1249: URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r800672107 ## File path: libminifi/include/utils/ByteArrayCallback.h ## @@ -46,7 +42,7 @@ class ByteInputCallBack : public InputStreamCallback { if (stre

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1249: MINIFICPP-1669 Use std::byte for buffers

szaszm commented on a change in pull request #1249: URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r800669223 ## File path: libminifi/src/utils/StringUtils.cpp ## @@ -268,8 +321,8 @@ bool StringUtils::from_hex(uint8_t* data, size_t* data_length, const char

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1249: MINIFICPP-1669 Use std::byte for buffers

szaszm commented on a change in pull request #1249: URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r800669223 ## File path: libminifi/src/utils/StringUtils.cpp ## @@ -268,8 +321,8 @@ bool StringUtils::from_hex(uint8_t* data, size_t* data_length, const char

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1249: MINIFICPP-1669 Use std::byte for buffers

szaszm commented on a change in pull request #1249: URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r800652661 ## File path: libminifi/include/io/AtomicEntryStream.h ## @@ -131,23 +132,24 @@ size_t AtomicEntryStream::write(const uint8_t *value, size_t size)

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1249: MINIFICPP-1669 Use std::byte for buffers

szaszm commented on a change in pull request #1249: URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r800636829 ## File path: extensions/opencv/FrameIO.h ## @@ -57,18 +57,17 @@ class FrameReadCallback : public InputStreamCallback { ~FrameReadCallback() ove

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1249: MINIFICPP-1669 Use std::byte for buffers

szaszm commented on a change in pull request #1249: URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r798126742 ## File path: libminifi/include/c2/PayloadSerializer.h ## @@ -209,7 +209,7 @@ class PayloadSerializer { } return node; } - static C2P

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1249: MINIFICPP-1669 Use std::byte for buffers

szaszm commented on a change in pull request #1249: URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r798126300 ## File path: extensions/standard-processors/processors/DefragmentText.cpp ## @@ -187,7 +187,7 @@ struct ReadFlowFileContent : public InputStreamCa

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1249: MINIFICPP-1669 Use std::byte for buffers

szaszm commented on a change in pull request #1249: URL: https://github.com/apache/nifi-minifi-cpp/pull/1249#discussion_r798125860 ## File path: extensions/opencv/FrameIO.h ## @@ -57,18 +57,17 @@ class FrameReadCallback : public InputStreamCallback { ~FrameReadCallback() ove