[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-04-23 Thread GitBox
szaszm commented on a change in pull request #605: URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r413844725 ## File path: extensions/windows-event-log/Bookmark.cpp ## @@ -222,7 +184,7 @@ bool Bookmark::getBookmarkXmlFromFile(std::wstring& bookmarkXml) {

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-04-20 Thread GitBox
szaszm commented on a change in pull request #605: URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r408966137 ## File path: libminifi/test/keyvalue-tests/CMakeLists.txt ## @@ -0,0 +1,42 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +#

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-03-10 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r390305696 ## File path: libminifi/include/core/ProcessContext.h ## @@ -193,6

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366338253 ## File path: libminifi/include/core/CoreComponentState.h ## @@ -0,0

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r365972219 ## File path: extensions/sftp/processors/ListSFTP.cpp ## @@ -507,85

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366363894 ## File path:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366336466 ## File path:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366341543 ## File path: libminifi/include/core/ProcessContext.h ## @@ -193,6

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366293138 ## File path:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366362750 ## File path: libminifi/test/integration/IntegrationBase.h ## @@ -109,6

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366331618 ## File path:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366295034 ## File path:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366315698 ## File path:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366339331 ## File path: libminifi/include/core/ProcessContext.h ## @@ -77,6 +85,21

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366334449 ## File path:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366350235 ## File path: libminifi/test/TestBase.cpp ## @@ -30,6 +30,25 @@

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366361947 ## File path: libminifi/test/TestBase.h ## @@ -304,7 +323,7 @@ class

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366347534 ## File path:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st…

2020-01-14 Thread GitBox
szaszm commented on a change in pull request #605: MINIFICPP-550 - Implement RocksDB controller service and component st… URL: https://github.com/apache/nifi-minifi-cpp/pull/605#discussion_r366301930 ## File path: libminifi/include/core/ProcessContext.h ## @@ -193,6