mtien-apache commented on pull request #319:
URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-849866685
Closed in favor of https://github.com/apache/nifi/pull/5107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mtien-apache commented on pull request #319:
URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-840183039
Pushed commits that addresses all remaining changes and PR feedback. The PR
is ready for a full review.
@sardell Would you review the frontend changes?
mtien-apache commented on pull request #319:
URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-832217308
> In the Actions drop-down, "Import new version" is always highlighted even
when another selection has the focus.
>
>
mtien-apache commented on pull request #319:
URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-832204208
Pushed a commit:
- Added a new `ExportedVersionedFlowSnapshot` object
- Fixed Import New Version dialog to show the next version to be imported
- Refactored
mtien-apache commented on pull request #319:
URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-831591230
> > Related to my last comment, here are the messages in the error dialogs I
have found so far:
> >
> > * Non flow definition JSON file: "Cannot create versioned
mtien-apache commented on pull request #319:
URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-828895145
Pushed 2 commits:
- Handled the scenario when an invalid snapshot file is uploaded during
Import New Flow @andrewmlim
- Refactored client side API import
mtien-apache commented on pull request #319:
URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-827030107
> Hey @mtien-apache - thanks for all your work on this. @andrewmlim 's
comments all make sense to me and I would proceed with his recommendations. RE
the Delete button
mtien-apache commented on pull request #319:
URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-825935715
@andrewmlim Thanks for reviewing!
- The UI changes make sense to me, especially if the names will match what's
in the documentation and NiFi.
@moranr Do you
mtien-apache commented on pull request #319:
URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-823772139
I have pushed a commit that resolves the importing and exporting issues
found by @bbende, as well as addressing other feedback found above this
comment.
Thanks
mtien-apache commented on pull request #319:
URL: https://github.com/apache/nifi-registry/pull/319#issuecomment-822703531
This PR is still WIP, but is open for initial review. I still need to add
integration tests and resolve some styling issues, specifically with text
alignment in the
10 matches
Mail list logo
