Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/104
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the featur
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r119173661
--- Diff: thirdparty/spdlog-0.13.0/include/spdlog/fmt/bundled/format.h ---
@@ -1,29 +1,29 @@
/*
-Formatting library for C++
-
-Copyrig
Github user apiri commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r119377373
--- Diff: thirdparty/spdlog-0.13.0/cmake/Config.cmake.in ---
@@ -0,0 +1,24 @@
+#
*
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118706272
--- Diff: libminifi/test/TestBase.h ---
@@ -21,35 +21,104 @@
#include
#include
#include
+#include
#include "ResourceCla
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118705983
--- Diff: libminifi/test/TestBase.h ---
@@ -21,35 +21,104 @@
#include
#include
#include
+#include
#include "ResourceCla
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704850
--- Diff: libminifi/include/core/logging/LoggerConfiguration.h ---
@@ -0,0 +1,147 @@
+/**
+ * @file LoggerConfiguration.h
+ * Logger cl
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704917
--- Diff: libminifi/test/TestBase.h ---
@@ -21,35 +21,104 @@
#include
#include
#include
+#include
#include "ResourceCla
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704895
--- Diff: libminifi/include/utils/StringUtils.h ---
@@ -89,6 +89,25 @@ class StringUtils {
s.end());
return s;
}
+
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704804
--- Diff: libminifi/include/core/controller/ControllerService.h ---
@@ -64,7 +64,7 @@ class ControllerService : public ConfigurableComponent,
publ
Github user brosander commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118704784
--- Diff: libminifi/include/Site2SitePeer.h ---
@@ -72,8 +73,8 @@ class Site2SitePeer : public
org::apache::nifi::minifi::io::BaseStream {
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118497254
--- Diff: conf/minifi-log.properties ---
@@ -0,0 +1,42 @@
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contribut
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118527831
--- Diff: libminifi/test/TestBase.h ---
@@ -21,35 +21,104 @@
#include
#include
#include
+#include
#include "ResourceClai
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118500266
--- Diff: libminifi/include/core/logging/LoggerConfiguration.h ---
@@ -0,0 +1,147 @@
+/**
+ * @file LoggerConfiguration.h
+ * Logger cla
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118524108
--- Diff: libminifi/include/utils/StringUtils.h ---
@@ -89,6 +89,25 @@ class StringUtils {
s.end());
return s;
}
+
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118497504
--- Diff: libminifi/include/core/controller/ControllerService.h ---
@@ -64,7 +64,7 @@ class ControllerService : public ConfigurableComponent,
publi
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118527482
--- Diff: libminifi/test/TestBase.h ---
@@ -21,35 +21,104 @@
#include
#include
#include
+#include
#include "ResourceClai
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104#discussion_r118496711
--- Diff: libminifi/include/Site2SitePeer.h ---
@@ -72,8 +73,8 @@ class Site2SitePeer : public
org::apache::nifi::minifi::io::BaseStream {
e
GitHub user brosander opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/104
MINIFI-296 - Configurable logging, spdlog 0.13.0
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask
18 matches
Mail list logo
