Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/360
---
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r205800065
--- Diff: extensions/librdkafka/PublishKafka.h ---
@@ -28,6 +28,7 @@
#include "core/Property.h"
#include "core/logging/LoggerConfiguration
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r198911858
--- Diff: extensions/librdkafka/PublishKafka.h ---
@@ -28,6 +28,7 @@
#include "core/Property.h"
#include "core/logging/LoggerConfiguration
Github user dtrodrigues commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r198361089
--- Diff: extensions/librdkafka/PublishKafka.h ---
@@ -28,6 +28,7 @@
#include "core/Property.h"
#include "core/logging/LoggerConfigurat
Github user dtrodrigues commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r198360594
--- Diff: extensions/librdkafka/PublishKafka.h ---
@@ -115,14 +121,35 @@ class PublishKafka: public core::Processor {
buffer.reserve(m
Github user dtrodrigues commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r198359374
--- Diff: extensions/librdkafka/PublishKafka.cpp ---
@@ -262,7 +269,7 @@ void PublishKafka::onTrigger(const
std::shared_ptr &contex
if (f
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r197826693
--- Diff: extensions/librdkafka/PublishKafka.cpp ---
@@ -262,7 +269,7 @@ void PublishKafka::onTrigger(const
std::shared_ptr &contex
if (flow
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r197824984
--- Diff: extensions/librdkafka/PublishKafka.h ---
@@ -115,14 +121,35 @@ class PublishKafka: public core::Processor {
buffer.reserve(max_
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/360#discussion_r197824393
--- Diff: extensions/librdkafka/PublishKafka.h ---
@@ -28,6 +28,7 @@
#include "core/Property.h"
#include "core/logging/LoggerConfiguration
GitHub user dtrodrigues opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/360
MINIFICPP-427 - add PublishKafka headers support
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we as
10 matches
Mail list logo
