Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/985
@trixpan The patch does not apply cleanly to 0.x. Would you mind posting
another PR for that branch specifically.
---
If your project is set up for it, you can reply to this email and have your
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/985
@mcgilman would you mind pushing this commit to 0.x as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/985
@ijokarumawak
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/985
@apiri, @mcgilman
I did a few new tweaks so that job sequence is:
1. rat check (before_install)
2. parallel compile with skipTests (install)
3. style check and test via mvn
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/985
@apiri makes complete sense. afaik this can be achieved using
`mvn apache-rat:check and checkstyle:check `
so I added the above command to the before_install stage of the travis job.
Github user apiri commented on the issue:
https://github.com/apache/nifi/pull/985
Seems fair, although I would almost prefer that the two items get flipped
in terms of testing. Always run contrib check (without tests) during the build
and then run the full test suite. In the linked
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/985
Matt, the profile is still being run but it run after compilation.
First (install) travis performs a multi threaded mvn build. Immediately
aftet this completes it runs a mvn checkstyle:check
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/985
@trixpan I'm not sure we want to move away from the contrib-check profile
as this also ran through the rat plugin which verified files contained license
headers, etc.
@apiri Would like to
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/985
Seems like moving `mvn -T2.0C clean install` to travis install phase and
`mvn checkstyle:check` to the script phase did the trick.
around 25% reduction in build time and a far more reliable
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/985
@mcgillman, what do you think about leaving the - T2.0C setting to speed up
build and adding an extra post-compile step to run - Pcontrib-check single
threaded (this is similar to spark's approach)?
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/985
Just quickly glancing, I think that the contrib-check profile has issues
with multi-threaded builds. We've seen issues with it in the past.
---
If your project is set up for it, you can reply to
Github user trixpan commented on the issue:
https://github.com/apache/nifi/pull/985
@mcgilman
can you please review this and if in agreement merge it to master?
Current travis-ci settings seem to be unable to reliably build nifi. I
fiddled with Xmx settings, enabled
12 matches
Mail list logo
