rfellows merged PR #8320:
URL: https://github.com/apache/nifi/pull/8320
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
rfellows commented on PR #8320:
URL: https://github.com/apache/nifi/pull/8320#issuecomment-1921862901
> > 4. The error (red) color is very bright and jumps off the screen a bit
too much IMO.
> >
> >
rfellows commented on code in PR #8320:
URL: https://github.com/apache/nifi/pull/8320#discussion_r1474853232
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/nifi.scss:
##
@@ -65,6 +65,53 @@
scottyaslan commented on PR #8320:
URL: https://github.com/apache/nifi/pull/8320#issuecomment-1921775225
> Overall, this is AWESOME! Thanks @scottyaslan. I did find a handful of
things that could be addressed, but I'm happy if we want to include those in
some follow-up commit for
scottyaslan commented on code in PR #8320:
URL: https://github.com/apache/nifi/pull/8320#discussion_r1474750822
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/ui/common/status-history/_status-history.component-theme.scss:
scottyaslan commented on code in PR #8320:
URL: https://github.com/apache/nifi/pull/8320#discussion_r1474750138
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/nifi.scss:
##
@@ -65,6 +65,53 @@
rfellows commented on code in PR #8320:
URL: https://github.com/apache/nifi/pull/8320#discussion_r1474731942
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/nifi.scss:
##
@@ -65,6 +65,53 @@
scottyaslan commented on code in PR #8320:
URL: https://github.com/apache/nifi/pull/8320#discussion_r1474721812
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/nifi.scss:
##
@@ -65,6 +65,53 @@
rfellows commented on code in PR #8320:
URL: https://github.com/apache/nifi/pull/8320#discussion_r1474561240
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/nifi.scss:
##
@@ -65,6 +65,53 @@
scottyaslan commented on PR #8320:
URL: https://github.com/apache/nifi/pull/8320#issuecomment-1921580141
Thanks @joewitt and thanks @rfellows for the reviews! I have pushed a fix
for the extension creation dialog input field styles. I also noticed that the
canvas search input field was
rfellows commented on PR #8320:
URL: https://github.com/apache/nifi/pull/8320#issuecomment-1921351175
> When you drag a processor on the graph then start typing in a name to
filter on the text is not visible when in dark mode.
@scottyaslan this input in question isn't wrapped in a
rfellows commented on PR #8320:
URL: https://github.com/apache/nifi/pull/8320#issuecomment-1921282451
reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
joewitt commented on PR #8320:
URL: https://github.com/apache/nifi/pull/8320#issuecomment-1920203567
happens whether purple theme is activated or not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
joewitt commented on PR #8320:
URL: https://github.com/apache/nifi/pull/8320#issuecomment-1920192095
Very cool.
When you drag a processor on the graph then start typing in a name to filter
on the text is not visible when in dark mode.
This is with the purple theme activated
14 matches
Mail list logo
