rfellows merged PR #8608:
URL: https://github.com/apache/nifi/pull/8608
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@nifi.apache.o
scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557839018
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/purple.scss:
##
@@ -126,15 +38,14 @@ $material-them
scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557807976
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-board-
scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557805191
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/styles/_app.scss:
##
@@ -127,186 +131,274 @@
}
}
-
scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557802982
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/_canvas.component-theme.scss:
#
scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557793416
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/manager/port-manager.service.ts:
rfellows commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557755170
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-board-lis
james-elliott commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557714973
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/bulletins/ui/bulletin-board/bulletin-board-list/bulletin-boar
james-elliott commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557682396
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/manager/port-manager.service.ts:
##
scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557680975
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/purple.scss:
##
@@ -126,15 +38,14 @@ $material-them
james-elliott commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557670266
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/ui/canvas/_canvas.component-theme.scss:
###
rfellows commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1557642603
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/assets/themes/purple.scss:
##
@@ -126,15 +38,14 @@ $material-theme-l
scottyaslan commented on PR #8608:
URL: https://github.com/apache/nifi/pull/8608#issuecomment-2043682891
> Found a few things. One of which is that it doesn't build with the purple
theme selected...
>
> running:
>
> ```
> ./mvnw -T 2 clean install -DskipTests
-P\!minify-and
scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1556403601
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/summary/ui/process-group-status-listing/process-group-status-ta
scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1556402640
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/manager/process-group-manager.service.ts:
scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1556400673
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/flow-designer/service/manager/process-group-manager.service.ts:
scottyaslan commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1556399872
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/common/add-tenant-to-policy-dialog/add-tenan
rfellows commented on code in PR #8608:
URL: https://github.com/apache/nifi/pull/8608#discussion_r1556093084
##
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-frontend/src/main/nifi/src/app/pages/access-policies/ui/common/add-tenant-to-policy-dialog/add-tenant-t
rfellows commented on PR #8608:
URL: https://github.com/apache/nifi/pull/8608#issuecomment-2042826726
reviewing...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubs
19 matches
Mail list logo
