Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-04-11 Thread via GitHub
szaszm closed pull request #1721: MINIFICPP-2277 Add virtualenv support for python processors URL: https://github.com/apache/nifi-minifi-cpp/pull/1721 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-04-10 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1559539605 ## extensions/python/PythonDependencyInstaller.cpp: ## @@ -0,0 +1,166 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-04-10 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1559538680 ## extensions/python/PythonDependencyInstaller.cpp: ## @@ -0,0 +1,166 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * c

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-04-10 Thread via GitHub
adamdebreceni commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1559466021 ## extensions/python/PythonDependencyInstaller.cpp: ## @@ -0,0 +1,166 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-04-10 Thread via GitHub
adamdebreceni commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1559462716 ## extensions/python/PythonDependencyInstaller.cpp: ## @@ -0,0 +1,166 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-04-10 Thread via GitHub
adamdebreceni commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1559445576 ## extensions/python/PythonDependencyInstaller.cpp: ## @@ -0,0 +1,166 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more +

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-04-10 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1559104966 ## libminifi/src/Configuration.cpp: ## @@ -152,7 +152,11 @@ const std::unordered_map

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-04-05 Thread via GitHub
szaszm commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1553978828 ## libminifi/src/Configuration.cpp: ## @@ -152,7 +152,11 @@ const std::unordered_map

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-26 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1539722380 ## extensions/python/PythonDependencyInstaller.h: ## @@ -0,0 +1,45 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * cont

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-26 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1539723152 ## extensions/python/PythonScriptEngine.h: ## @@ -84,7 +48,7 @@ class PythonScriptEngine { PythonScriptEngine& operator=(const PythonScriptEngine& other) =

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-20 Thread via GitHub
szaszm commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1532242813 ## extensions/python/PythonDependencyInstaller.h: ## @@ -0,0 +1,45 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contrib

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-13 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1522863070 ## extensions/python/PythonConfigState.h: ## @@ -0,0 +1,50 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-13 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1522853483 ## extensions/python/ExecutePythonProcessor.h: ## @@ -35,10 +35,6 @@ #include "PythonScriptEngine.h" #include "PythonScriptEngine.h" -#if defined(__GNUC__

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-11 Thread via GitHub
szaszm commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1519830502 ## extensions/python/PythonConfigState.h: ## @@ -0,0 +1,50 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-11 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1519685441 ## extensions/python/PythonConfigState.h: ## @@ -0,0 +1,50 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-11 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1519636902 ## extensions/python/PythonScriptEngine.cpp: ## @@ -68,6 +67,73 @@ void initThreads() { #pragma warning(pop) #endif } + +std::string encapsulateCommandInQu

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-11 Thread via GitHub
szaszm commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1519487010 ## extensions/python/PythonConfigState.h: ## @@ -0,0 +1,50 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor lic

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-08 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1517807712 ## encrypt-config/tests/ConfigFileEncryptorTests.cpp: ## @@ -77,7 +77,7 @@ TEST_CASE("ConfigFileEncryptor can encrypt the sensitive properties", "[encrypt-

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-08 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1517807712 ## encrypt-config/tests/ConfigFileEncryptorTests.cpp: ## @@ -77,7 +77,7 @@ TEST_CASE("ConfigFileEncryptor can encrypt the sensitive properties", "[encrypt-

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-08 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1517821922 ## extensions/python/PythonConfigState.h: ## @@ -0,0 +1,50 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-08 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1517807712 ## encrypt-config/tests/ConfigFileEncryptorTests.cpp: ## @@ -77,7 +77,7 @@ TEST_CASE("ConfigFileEncryptor can encrypt the sensitive properties", "[encrypt-

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-08 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1517806663 ## docker/python-verify/conda.Dockerfile: ## @@ -31,14 +31,12 @@ USER root RUN wget https://repo.anaconda.com/archive/Anaconda3-2023.09-0-Linux-x86_64.sh -P

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-08 Thread via GitHub
szaszm commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1511271227 ## docker/python-verify/conda.Dockerfile: ## @@ -31,14 +31,12 @@ USER root RUN wget https://repo.anaconda.com/archive/Anaconda3-2023.09-0-Linux-x86_64.sh -P /t

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-06 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1514070824 ## extensions/python/PythonScriptEngine.cpp: ## @@ -68,6 +67,73 @@ void initThreads() { #pragma warning(pop) #endif } + +std::string encapsulateCommandInQu

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-06 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1514069231 ## extensions/python/PythonConfigState.h: ## @@ -0,0 +1,67 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-06 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1514068298 ## extensions/python/PYTHON.md: ## @@ -155,10 +158,33 @@ In the flow configuration these Python processors can be referenced by their ful Due to some diff

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-06 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1514067762 ## docker/test/integration/cluster/containers/MinifiContainer.py: ## @@ -33,7 +33,11 @@ def __init__(self): self.enable_prometheus = False s

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1513224888 ## extensions/python/PythonScriptEngine.cpp: ## @@ -68,6 +67,73 @@ void initThreads() { #pragma warning(pop) #endif } + +std::string encapsulateCommandInQu

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
lordgamez commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1513218719 ## docker/python-verify/conda.Dockerfile: ## @@ -31,14 +31,12 @@ USER root RUN wget https://repo.anaconda.com/archive/Anaconda3-2023.09-0-Linux-x86_64.sh -P

Re: [PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-03-05 Thread via GitHub
fgerlits commented on code in PR #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721#discussion_r1512842925 ## extensions/python/PYTHON.md: ## @@ -155,10 +158,33 @@ In the flow configuration these Python processors can be referenced by their ful Due to some diffe

[PR] MINIFICPP-2277 Add virtualenv support for python processors [nifi-minifi-cpp]

2024-01-26 Thread via GitHub
lordgamez opened a new pull request, #1721: URL: https://github.com/apache/nifi-minifi-cpp/pull/1721 https://issues.apache.org/jira/browse/MINIFICPP-2277 --- Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of