exceptionfactory commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1775953704
You're welcome @dan-s1. I am verifying the changes for the support branch, I
updated the Jira to resolved for 2.0.0, and should be able to include 1.24.0
shortly.
--
This is an a
dan-s1 commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1775941691
@exceptionfactory Thank you! I am not sure if there is a delay or not but in
Jira I still see the status as Patch Available.
--
This is an automated message from the Apache Git Service.
To
exceptionfactory closed pull request #7665: NIFI-11197 Initial check in for
Yaml record reader
URL: https://github.com/apache/nifi/pull/7665
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the speci
exceptionfactory commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1775094328
n@dan-s1 In the course of runtime testing, I found an issue with the Max
String Length property value being `null` in `storePropertyValues` in
`JsonTreeReader`. This is understandab
exceptionfactory commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1367234754
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonParserFactory.java:
##
@@ -23,27 +23,20 @
dan-s1 commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1367185418
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonParserFactory.java:
##
@@ -23,27 +23,20 @@
impor
exceptionfactory commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1367180160
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonRecordSource.java:
##
@@ -29,6 +30,11 @@
exceptionfactory commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1367179198
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonParserFactory.java:
##
@@ -23,27 +23,20 @
dan-s1 commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1367170067
##
nifi-nar-bundles/nifi-extension-utils/nifi-record-utils/nifi-json-record-utils/src/main/java/org/apache/nifi/json/JsonRecordSource.java:
##
@@ -29,6 +30,11 @@
public
dan-s1 commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1772781514
@exceptionfactory Any chance this can make 1.24?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go t
dan-s1 commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1765429075
@exceptionfactory The failed build seems to not have to do with any of my
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to G
exceptionfactory commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1765209620
Thanks for the updates @dan-s1, I will take a closer look soon.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
dan-s1 commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1765207530
@exceptionfactory I resolved the conflicts but mistakenly rebased and
squashed the commits. I believe all the changes you had requested are all in
there. Is that okay?
--
This is an automa
exceptionfactory commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1764582630
> @exceptionfactory The problem with static is I need many of the properties
which are defined in instance methods in `SchemaRegistryService`. I basically
want to mimic `getSupporte
dan-s1 commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1764574517
@exceptionfactory The problem with static is I need many of the properties
which are defined in instance methods in `SchemaRegistryService`. I basically
want to mimic `getSupportedPropertyDes
exceptionfactory commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1764530205
> @exceptionfactory Then would it be okay to have in `YamlTreeReader` code
like:
>
> ```
> @Override
> protected List getSupportedPropertyDescriptors() {
>
dan-s1 commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1764514871
> @dan-s1 Just out of (genuine) curiosity, what prompted this feature? I
have never seen anyone use YAML as anything other than a configuration file
format. What horror story/interesting use
dan-s1 commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1764511710
> > @exceptionfactory I am trying to rework my code to handle the changes
made in #7823 for NIFI-12153. What I am discovering is that YAML supports
comments and there is no way to turn off pa
MikeThomsen commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1762850896
@dan-s1 Just out of (genuine) curiosity, what prompted this feature? I have
never seen anyone use YAML as anything other than a configuration file format.
What horror story/interesting u
exceptionfactory commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1762354391
> @exceptionfactory I am trying to rework my code to handle the changes made
in #7823 for NIFI-12153. What I am discovering is that YAML supports comments
and there is no way to tur
dan-s1 commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1762022382
@exceptionfactory I am trying to rework my code to handle the changes made
in #7823 for NIFI-12153. What I am discovering is that YAML supports comments
and there is no way to turn off parsin
dan-s1 commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1753340884
@exceptionfactory There are conflicts (I guess obviously) I will try to
resolve and then push.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
exceptionfactory commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-175951
@dan-s1 The failure appears to be an intermittent issue based on heap space
for the build. We may need to address that separately, but it is not a concern
for this PR.
Howeve
dan-s1 commented on PR #7665:
URL: https://github.com/apache/nifi/pull/7665#issuecomment-1753319713
@exceptionfactory I see three out of the four builds succeeded but I do not
see a reason for the one that failed. Also I am not sure why are there
conflicts. Please advise.
--
This is an a
dan-s1 commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1350266069
##
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/yaml/TestYamlTreeRowRecordRead
exceptionfactory commented on code in PR #7665:
URL: https://github.com/apache/nifi/pull/7665#discussion_r1348154405
##
nifi-nar-bundles/nifi-standard-services/nifi-record-serialization-services-bundle/nifi-record-serialization-services/src/test/java/org/apache/nifi/yaml/TestYamlTreeRow
26 matches
Mail list logo
