Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]

2023-10-20 Thread via GitHub
exceptionfactory closed pull request #7891: NIFI-12239 - Add OS/Java details at startup in bootstrap log URL: https://github.com/apache/nifi/pull/7891 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]

2023-10-20 Thread via GitHub
exceptionfactory commented on code in PR #7891: URL: https://github.com/apache/nifi/pull/7891#discussion_r1366910027 ## nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java: ## @@ -1165,13 +1168,22 @@ public void start(final boolean monitor) throws IOException {

Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]

2023-10-20 Thread via GitHub
pvillard31 commented on code in PR #7891: URL: https://github.com/apache/nifi/pull/7891#discussion_r1366714024 ## nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java: ## @@ -1165,13 +1168,22 @@ public void start(final boolean monitor) throws IOException {

Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]

2023-10-20 Thread via GitHub
pvillard31 commented on code in PR #7891: URL: https://github.com/apache/nifi/pull/7891#discussion_r1366712339 ## nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java: ## @@ -1165,13 +1168,22 @@ public void start(final boolean monitor) throws IOException {

Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]

2023-10-19 Thread via GitHub
exceptionfactory commented on code in PR #7891: URL: https://github.com/apache/nifi/pull/7891#discussion_r1366390227 ## nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java: ## @@ -1392,6 +1404,33 @@ public boolean accept(final File dir, final String filename) {

Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]

2023-10-17 Thread via GitHub
pvillard31 commented on PR #7891: URL: https://github.com/apache/nifi/pull/7891#issuecomment-1766798572 Updated with your suggestion -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific c

Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]

2023-10-17 Thread via GitHub
pvillard31 commented on PR #7891: URL: https://github.com/apache/nifi/pull/7891#issuecomment-1766764306 New format: 2023-10-17 18:24:24,923 INFO [main] org.apache.nifi.bootstrap.RunNiFi {totalPhysicalMemoryMB=16384, xmx=1g, cores=16, javaVersion=21, maxOpenFileDescriptors=102

Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]

2023-10-17 Thread via GitHub
pvillard31 commented on PR #7891: URL: https://github.com/apache/nifi/pull/7891#issuecomment-1766744739 Yeah JSON was kind of a default choice to ease automatic parsing of this data but a KV approach is fine with me too, will update -- This is an automated message from the Apache Git Serv

Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]

2023-10-17 Thread via GitHub
exceptionfactory commented on code in PR #7891: URL: https://github.com/apache/nifi/pull/7891#discussion_r1362384318 ## nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java: ## @@ -1165,13 +1171,22 @@ public void start(final boolean monitor) throws IOException {

Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]

2023-10-17 Thread via GitHub
pvillard31 commented on code in PR #7891: URL: https://github.com/apache/nifi/pull/7891#discussion_r1362383549 ## nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java: ## @@ -1392,6 +1407,45 @@ public boolean accept(final File dir, final String filename) {

Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]

2023-10-17 Thread via GitHub
pvillard31 commented on code in PR #7891: URL: https://github.com/apache/nifi/pull/7891#discussion_r1362380042 ## nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java: ## @@ -1165,13 +1171,22 @@ public void start(final boolean monitor) throws IOException {

Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]

2023-10-17 Thread via GitHub
exceptionfactory commented on code in PR #7891: URL: https://github.com/apache/nifi/pull/7891#discussion_r1362369758 ## nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java: ## @@ -1165,13 +1171,22 @@ public void start(final boolean monitor) throws IOException {

Re: [PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]

2023-10-17 Thread via GitHub
exceptionfactory commented on code in PR #7891: URL: https://github.com/apache/nifi/pull/7891#discussion_r136239 ## nifi-bootstrap/src/main/java/org/apache/nifi/bootstrap/RunNiFi.java: ## @@ -1392,6 +1407,45 @@ public boolean accept(final File dir, final String filename) {

[PR] NIFI-12239 - Add OS/Java details at startup in bootstrap log [nifi]

2023-10-17 Thread via GitHub
pvillard31 opened a new pull request, #7891: URL: https://github.com/apache/nifi/pull/7891 # Summary [NIFI-0](https://issues.apache.org/jira/browse/NIFI-12239) - Add OS/Java details at startup in bootstrap log Example of the added log: 2023-10-17 17:26:33,501