GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/970
Cluster - Two Phase Commit clean up
NIFI-2694:
- Addressing instances where phase one objects were being referenced
instead of phase two objects.
- Code clean up.
You can merge this pull
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/993
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/968
Looks good @scottyaslan. Found one minor issue when reloading controller
services from the different tables (process group vs controller settings). I've
addressed the bug in this commit [1]. I'm
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/969
My only concern is the potential confusion over the API itself. This is
currently driven by `getSupportedDynamicPropertyDescriptor` which can
conditionally support a user defined property. The method
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/973
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/973
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/975
Thanks @YolandaMDavis! I've merged this into master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/996
Thanks @ijokarumawak. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1014
Correct authorization when destination changes
NIFI-2768:
- Ensuring we correctly enforce authorization when the destination of a
connection changes. This includes source, destination
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1020
Ensuring responses from the REST API are compressed
NIFI-2771:
- Using GzipHandler instead of GzipFilter.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1000
Thanks @patricker! Following Mark's suggestion and your update, I've gone
ahead and merged this into master.
---
If your project is set up for it, you can reply to this email and have your
reply
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/982
Thanks @YolandaMDavis! This looks good. I've verified the changes in all of
our supported browsers. Just a heads up, I've made a couple minor changes to
some spacing/formatting to be more consistent
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1000
Thanks for the PR @patricker! The proposed solution makes sense to me but I
would love to get @markap14 input before signing off as I know he's much more
familiar with this part of the codebase
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/982
@YolandaMDavis Thanks for the PR! A couple comments...
- I ran into an issue running on Edge. The svg that is downloaded appears
to contain an additional xmlns attribute in the svg tag
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1013
Ensuring the root group is included in /resources
NIFI-2766:
- Ensuring the root group is included in /resources.
You can merge this pull request into a Git repository by running:
$ git
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1011
Handle UI race condition
NIFI-2719:
- Caching components recently added/removed in case ajax requests are
received out of order. This is not an issue for modifications of existing
components
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1023
Ensuring Connection zIndex is honored
NIFI-2707:
- Ensuring that connections are always sorted accordingly to their zIndex.
This preserves the 'bring to front' settings.
You can merge
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1065
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1065
Looks good @YolandaMDavis! This has been merged to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1061
Thanks @trixpan! This has been merged to the 0.x branch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1042
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1061
I was just going to comment that I can't seem to get the Java 7 builds to
pass. Still not sure if it's related to your changes or not though. I'll sit
tight until you update.
I don't have
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1068
Ensuring Custom UI requests are correctly replicated when clustered
NIFI-2824:
- Updating replication logic to account for the potential replication
target and then invoking the corresponding
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1042
@jvwing I'll just squash those changes into your commit before I push. Just
wanted to communicate before I do that. Thanks!
---
If your project is set up for it, you can reply to this email
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1080
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1078
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1079
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1077
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1079
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1074
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1074
Thanks @pvillard31! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1096
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1096
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1089
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1085
Looks good @trixpan! Thanks this has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1099
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1109
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1082
The proposed changes seem to help introduce some space from the upper left
hand corner of the canvas but don't seem to account for the entire width of the
graph controls. Could it possible
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1082
Reviewing..
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1095
Cluster - Merging response when the node is the Cluster Cooridinator
NIFI-2777:
NIFI-2856:
- Only performing response merging when the node is the cluster
cooridinator even
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1109
Thanks @markap14! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1106
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1106
Looks good @scottyaslan! This has been merged to master. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1089
Looks good @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1094
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1038
Correcting download URIs for OTPs
NIFI-2797:
- Correcting download URIs for OTPs.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mcgilman
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1042#discussion_r79892940
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/cluster/nf-cluster-table.js
---
@@ -377,190
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1042#discussion_r79894191
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/cluster/nf-cluster-table.js
---
@@ -24,13 +24,275
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1028
Restore upstream/downstream connections dialog
NIFI-1870:
- Restoring the upstream/downstream connections dialog.
You can merge this pull request into a Git repository by running:
$ git
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1029
Fixed issue uploading templates into descendant Process Groups
NIFI-2785:
- Ensure the URL is updated when uploading a template to ensure it's going
to the appropriate Process Group.
You can
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1031
Saving flow after Template removal
NIFI-2792:
- Ensuring the flow is saved when a template is deleted.
You can merge this pull request into a Git repository by running:
$ git pull https
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1030
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1030
Thanks @scottyaslan! This looks good and addressed the build issues I was
seeing in my Windows VM. Also verified offline build.
This has been merged to master.
---
If your project is set
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/993
Thanks @markap14. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1028
Good catch @bbende. Will update shortly... Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/882
Looks good. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/892
Appears to contain a failing test... Will address
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/893
Addressing UI issue with tooltip when a PropertyDescriptor contains special
characters
NIFI-2596:
- Adding tooltip for property descriptor on mouse enter of table cell.
You can merge this pull
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/892
Updated PR to address failing unit test
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/888
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/884
Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman closed the pull request at:
https://github.com/apache/nifi/pull/884
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/941
@trixpan @JPercivall I've opened a new PR-943 that is rebased against
current master. The commits that were lost did address the contrib check issues
along with some other features/bugs. Since we
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/943
NIFI-2635 - Reopen Cluster Two Phase Commit
PR for the last two commits that were lost when merging PR-333. I've
updated the commits for the current state of master.
You can merge this pull request
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/956
Thanks @ijokarumawak. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/957
Looks like we're still pulling in $sanitize through bower and referencing
it in script tags.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/957
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/894
Thanks @scottyaslan. This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/852
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/933
NiFi-2635 Cluster - Two phase commit
- Using the request from the validation phase in the execution phase.
- Fixing missing REST API documentation.
- Ensuring two phase commit only runs from
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/935
UI - Fixing check to determine if save is required
NIFI-2647:
- Referencing correct components when checking if save is required.
You can merge this pull request into a Git repository by running
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/962
Reviewing
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/962
Thanks @ijokarumawak! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1078
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1077
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1069
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1042
@jvwing Just finished up testing and everything looks good. This has been
merged to master. I did find another minor issue with sorting the table but I
updated the sort method accordingly. Thanks
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1064
Good call. Will update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1087
Not showing View Configuration context menu option for Process Groups
NIFI-2843:
- Removing the View Configuration menu item from the context menu on
Process Groups.
You can merge this pull
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1086
Hiding the template upload dialog after form submission
NIFI-2837:
- Immediately hiding the template dialog after clicking the Upload button
to prevent an accidental re-submission.
You can
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1090
UI - Policy Management Improvements
NIFI-2849:
- Showing process group name when possible.
- Providing a link to jump to the process group defined in the effective
policy.
- Preventing
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1080
@pvillard31,
Following some of the discussion on the mailing list recently and the
original commentary on the JIRA [1], I'd like to propose shifting from an icon
based approach when back
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1040
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1063
Creating REST API documentation
NIFI-2796:
- Fixing incorrect documentation for the cluster summary endpoint.
- Fixing typo in root type name.
You can merge this pull request into a Git
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/985
@trixpan The patch does not apply cleanly to 0.x. Would you mind posting
another PR for that branch specifically.
---
If your project is set up for it, you can reply to this email and have your
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1040
@scottyaslan Looks like I'm seeing the same behavior with the tables in the
Summary page. Can we update those as well?
---
If your project is set up for it, you can reply to this email and have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1069
Thanks @scottyaslan! This has been merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1064
Thanks @JPercivall, I've updated the logic to verify the move is allowed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1061
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/583
Thanks for the update! I'm going to be in and out the next few days. Just a
heads up, I might not be able to revisit until later this week. Thanks again!
---
If your project is set up for it, you
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1185
@JPercivall PR is updated. Thanks again!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1185
Will do! Thanks for reviewing and thanks to @beugley doing most of the work
on this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1188
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
GitHub user mcgilman opened a pull request:
https://github.com/apache/nifi/pull/1189
Remove legacy site to site code to ensure port availability is accurate
NIFI-3002:
- Removing legacy code when retrieving site to site details when the target
instance is this local NiFi
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1191
I have verified that the ellipsis have been restored to the descriptions of
the new Processor, Controller Service, and Reporting Task table. However, it
appears as though we are still using
Github user mcgilman commented on the issue:
https://github.com/apache/nifi/pull/1191
Reviewing...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1188#discussion_r87585309
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/users/nf-users-table.js
---
@@ -470,6 +470,214
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1188#discussion_r87585264
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/users/nf-users-table.js
---
@@ -470,6 +470,214
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1188#discussion_r87588152
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/WEB-INF/partials/users/user-policies-dialog.jsp
Github user mcgilman commented on a diff in the pull request:
https://github.com/apache/nifi/pull/1188#discussion_r87586238
--- Diff:
nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-web/nifi-web-ui/src/main/webapp/js/nf/users/nf-users-table.js
---
@@ -470,6 +470,214
201 - 300 of 1112 matches
Mail list logo
