[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15660270#comment-15660270
]
Tristan Nixon commented on OPENNLP-776:
---
I'm not seeing any changes on trunk, is th
[
https://issues.apache.org/jira/browse/OPENNLP-857?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15660268#comment-15660268
]
Tristan Nixon commented on OPENNLP-857:
---
I'm not seeing this in the trunk code, whe
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15644259#comment-15644259
]
Tristan Nixon commented on OPENNLP-776:
---
I've been swamped with other work, but I s
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616763#comment-15616763
]
Tristan Nixon commented on OPENNLP-776:
---
Great, I'll give the patch at try ASAP and
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15616742#comment-15616742
]
Tristan Nixon commented on OPENNLP-776:
---
Thanks, I think this patch looks good!
I h
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545918#comment-15545918
]
Tristan Nixon edited comment on OPENNLP-776 at 10/4/16 4:44 PM:
---
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545918#comment-15545918
]
Tristan Nixon commented on OPENNLP-776:
---
Sorry, I probably should have removed that
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545832#comment-15545832
]
Tristan Nixon commented on OPENNLP-776:
---
But that's not what my implementation does
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545791#comment-15545791
]
Tristan Nixon commented on OPENNLP-776:
---
Well, it's a bit of a messy type hierarchy
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545610#comment-15545610
]
Tristan Nixon commented on OPENNLP-776:
---
It's not about the JVM version, it's about
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15545536#comment-15545536
]
Tristan Nixon commented on OPENNLP-776:
---
Thanks, that's great!
While it is true th
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tristan Nixon updated OPENNLP-776:
--
Attachment: serializable-basemodel.patch
Patch to make BaseModel serializable
> Model Objects
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15428454#comment-15428454
]
Tristan Nixon commented on OPENNLP-776:
---
Good point. I thought the only way to prov
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tristan Nixon updated OPENNLP-776:
--
Attachment: serialization_proxy.patch
Patch containing modifications to model classes to provid
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15427213#comment-15427213
]
Tristan Nixon commented on OPENNLP-776:
---
True, you don't need setters for serializa
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412332#comment-15412332
]
Tristan Nixon commented on OPENNLP-776:
---
This pattern is quite common in frameworks
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15412320#comment-15412320
]
Tristan Nixon commented on OPENNLP-776:
---
There are some slight differences dependin
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tristan Nixon updated OPENNLP-776:
--
Attachment: (was: externalizable.patch)
> Model Objects should be Serializable
> --
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tristan Nixon updated OPENNLP-776:
--
Attachment: externalizable.patch
Also model classes can't be final if we're going to inherit fr
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tristan Nixon updated OPENNLP-776:
--
Attachment: externalizable.patch
Actually, there is one more thing that must happen for this to
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tristan Nixon updated OPENNLP-776:
--
Attachment: (was: model-constructors.patch)
> Model Objects should be Serializable
> --
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tristan Nixon updated OPENNLP-776:
--
Attachment: (was: BaseModel-serialization.patch)
> Model Objects should be Serializable
> -
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15383308#comment-15383308
]
Tristan Nixon commented on OPENNLP-776:
---
Finally returning to this after more than
[
https://issues.apache.org/jira/browse/OPENNLP-857?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tristan Nixon updated OPENNLP-857:
--
Attachment: ParserToolTokenize.patch
My patch
> ParserTool should take use Tokenizer instance.
Tristan Nixon created OPENNLP-857:
-
Summary: ParserTool should take use Tokenizer instance. It should
not use java.util.StringTokenizer
Key: OPENNLP-857
URL: https://issues.apache.org/jira/browse/OPENNLP-857
[
https://issues.apache.org/jira/browse/OPENNLP-808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15169432#comment-15169432
]
Tristan Nixon commented on OPENNLP-808:
---
A simple way to deal with this is to wrap
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550604#comment-14550604
]
Tristan Nixon commented on OPENNLP-776:
---
It does not make the (de-)serialization pr
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tristan Nixon updated OPENNLP-776:
--
Attachment: model-constructors.patch
I realized that for automatic de-serialization, all models
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14550561#comment-14550561
]
Tristan Nixon commented on OPENNLP-776:
---
You're totally welcome! Let me know when t
[
https://issues.apache.org/jira/browse/OPENNLP-776?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tristan Nixon updated OPENNLP-776:
--
Attachment: BaseModel-serialization.patch
My patch
> Model Objects should be Serializable
> --
Tristan Nixon created OPENNLP-776:
-
Summary: Model Objects should be Serializable
Key: OPENNLP-776
URL: https://issues.apache.org/jira/browse/OPENNLP-776
Project: OpenNLP
Issue Type: Improvem
31 matches
Mail list logo
