[GitHub] markusthoemmes opened a new pull request #3368: Soften DockerExampleContainerTests.

2018-02-27 Thread GitBox
markusthoemmes opened a new pull request #3368: Soften DockerExampleContainerTests. URL: https://github.com/apache/incubator-openwhisk/pull/3368 This test fails in different environments with different exceptions. This commit only aims to resolve the immediate issue. A proper RCA for test

[GitHub] markusthoemmes commented on issue #3343: Support time-series DB using Kamon Tag, and optional granular metric.

2018-02-27 Thread GitBox
markusthoemmes commented on issue #3343: Support time-series DB using Kamon Tag, and optional granular metric. URL: https://github.com/apache/incubator-openwhisk/pull/3343#issuecomment-369146488 @upgle it's taking me so long because there is a test failure in RuncClient tests. It is curre

[GitHub] markusthoemmes opened a new pull request #3367: Narrow exclude to run needed tests.

2018-02-27 Thread GitBox
markusthoemmes opened a new pull request #3367: Narrow exclude to run needed tests. URL: https://github.com/apache/incubator-openwhisk/pull/3367 Some of our important tests do **not** run today because the exclude of "*Cli*" also covers "Client" tests, which is not suspected.

[GitHub] markusthoemmes commented on a change in pull request #3366: Adds method deleteAttachments to ArtifactStore

2018-02-27 Thread GitBox
markusthoemmes commented on a change in pull request #3366: Adds method deleteAttachments to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/pull/3366#discussion_r171157851 ## File path: tests/build.gradle ## @@ -66,7 +66,8 @@ dependencies { compile

[GitHub] chetanmeh opened a new pull request #3366: Adds method deleteAttachments to ArtifactStore

2018-02-27 Thread GitBox
chetanmeh opened a new pull request #3366: Adds method deleteAttachments to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/pull/3366 PR which implements the proposal at #3356 This is an automated message fro

[GitHub] pritidesai closed issue #334: Unit Test - filesystemreader.go

2018-02-27 Thread GitBox
pritidesai closed issue #334: Unit Test - filesystemreader.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/334 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] pritidesai commented on issue #334: Unit Test - filesystemreader.go

2018-02-27 Thread GitBox
pritidesai commented on issue #334: Unit Test - filesystemreader.go URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/334#issuecomment-369105887 No longer applicable as this module was deleted as part of PR #759 ---

[GitHub] kameshsampath commented on issue #3365: Make EntryPoint Optional for Java Kind

2018-02-27 Thread GitBox
kameshsampath commented on issue #3365: Make EntryPoint Optional for Java Kind URL: https://github.com/apache/incubator-openwhisk/issues/3365#issuecomment-369105598 @csantanapr - I need help here as I never worked on `scala` to make the entrypoint optional in the controller -

[GitHub] kameshsampath commented on issue #18: Rebase OW JavaRuntime to fabric8 java image

2018-02-27 Thread GitBox
kameshsampath commented on issue #18: Rebase OW JavaRuntime to fabric8 java image URL: https://github.com/apache/incubator-openwhisk-runtime-java/issues/18#issuecomment-369104563 > Can you elaborate more on why fabric8 based on centos? IMHO since its a redhat sponsored project we tr

[GitHub] kameshsampath opened a new issue #3365: Make EntryPoint Optional for Java Kind

2018-02-27 Thread GitBox
kameshsampath opened a new issue #3365: Make EntryPoint Optional for Java Kind URL: https://github.com/apache/incubator-openwhisk/issues/3365 With the https://github.com/apache/incubator-openwhisk-runtime-java/issues/12 , its related update in CLI https://github.com/apache/incubator-open

[GitHub] csantanapr closed pull request #259: Update CURL Tests

2018-02-27 Thread GitBox
csantanapr closed pull request #259: Update CURL Tests URL: https://github.com/apache/incubator-openwhisk-catalog/pull/259 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] mrutkows closed issue #681: proper handling of 'default' package name

2018-02-27 Thread GitBox
mrutkows closed issue #681: proper handling of 'default' package name URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/681 This is an automated message from the Apache Git Service. To respond to the message

[GitHub] mrutkows closed pull request #754: Adding support for default package

2018-02-27 Thread GitBox
mrutkows closed pull request #754: Adding support for default package URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/754 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this i

[GitHub] jasonpet opened a new pull request #131: Add health monitoring support

2018-02-27 Thread GitBox
jasonpet opened a new pull request #131: Add health monitoring support URL: https://github.com/apache/incubator-openwhisk-package-alarms/pull/131 Add optional time-triggered self monitor support to the alarms provider. If turned on the monitoring status can be viewed in the existing health

[GitHub] pritidesai commented on issue #754: Adding support for default package

2018-02-27 Thread GitBox
pritidesai commented on issue #754: Adding support for default package URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/754#issuecomment-369069971 thank you @mrutkows for the review, these changes have been tested against managed deployment as well. Here the high level flo

[GitHub] pritidesai commented on issue #754: Adding support for default package

2018-02-27 Thread GitBox
pritidesai commented on issue #754: Adding support for default package URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/754#issuecomment-369069971 thank you @mrutkows for the review, these changes have been tested against managed deployment as well. Here the high level flo

[GitHub] mrutkows closed pull request #759: removing support for use-default flag

2018-02-27 Thread GitBox
mrutkows closed pull request #759: removing support for use-default flag URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/759 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As thi

[GitHub] mrutkows closed issue #694: filesystemreader.go: "searching for Action code.." code block incomplete

2018-02-27 Thread GitBox
mrutkows closed issue #694: filesystemreader.go: "searching for Action code.." code block incomplete URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/694 This is an automated message from the Apache Git Se

[GitHub] mrutkows closed issue #748: ReadProjectDirectory() does not appear to work; uses default package

2018-02-27 Thread GitBox
mrutkows closed issue #748: ReadProjectDirectory() does not appear to work; uses default package URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/748 This is an automated message from the Apache Git Servic

[GitHub] pritidesai commented on a change in pull request #754: Adding support for default package

2018-02-27 Thread GitBox
pritidesai commented on a change in pull request #754: Adding support for default package URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/754#discussion_r171104579 ## File path: deployers/servicedeployer.go ## @@ -1136,9 +1137,15 @@ func (deployer *Servi

[GitHub] mrutkows commented on a change in pull request #754: Adding support for default package

2018-02-27 Thread GitBox
mrutkows commented on a change in pull request #754: Adding support for default package URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/754#discussion_r171093601 ## File path: deployers/servicedeployer.go ## @@ -945,7 +946,7 @@ func (deployer *ServiceDep

[GitHub] mrutkows commented on a change in pull request #754: Adding support for default package

2018-02-27 Thread GitBox
mrutkows commented on a change in pull request #754: Adding support for default package URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/754#discussion_r171094297 ## File path: parsers/manifest_parser.go ## @@ -322,6 +323,13 @@ func (dm *YAMLParser) Compo

[GitHub] mrutkows commented on a change in pull request #754: Adding support for default package

2018-02-27 Thread GitBox
mrutkows commented on a change in pull request #754: Adding support for default package URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/754#discussion_r171093335 ## File path: deployers/servicedeployer.go ## @@ -703,9 +701,16 @@ func (deployer *ServiceDe

[GitHub] mrutkows commented on a change in pull request #754: Adding support for default package

2018-02-27 Thread GitBox
mrutkows commented on a change in pull request #754: Adding support for default package URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/754#discussion_r171094167 ## File path: deployers/servicedeployer.go ## @@ -1136,9 +1137,15 @@ func (deployer *Service

[GitHub] mrutkows commented on a change in pull request #754: Adding support for default package

2018-02-27 Thread GitBox
mrutkows commented on a change in pull request #754: Adding support for default package URL: https://github.com/apache/incubator-openwhisk-wskdeploy/pull/754#discussion_r171094079 ## File path: deployers/servicedeployer.go ## @@ -1136,9 +1137,15 @@ func (deployer *Service

[GitHub] dubeejw commented on a change in pull request #3216: Download Nginx Tarball from OpenWhisk CLI release, rather than constructing file-by-file

2018-02-27 Thread GitBox
dubeejw commented on a change in pull request #3216: Download Nginx Tarball from OpenWhisk CLI release, rather than constructing file-by-file URL: https://github.com/apache/incubator-openwhisk/pull/3216#discussion_r171092945 ## File path: ansible/roles/cli/tasks/deploy.yml ###

[GitHub] pritidesai opened a new issue #761: Whisk Deploy - Report OW assets

2018-02-27 Thread GitBox
pritidesai opened a new issue #761: Whisk Deploy - Report OW assets URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/761 There has been discussion going on that we should add a new functionality in `wskdeploy` such that it produces a status report of all OW entities from

[GitHub] csantanapr closed pull request #101: Add information on some env variables to README

2018-02-27 Thread GitBox
csantanapr closed pull request #101: Add information on some env variables to README URL: https://github.com/apache/incubator-openwhisk-devtools/pull/101 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provena

[GitHub] dubeejw closed pull request #227: Support new trigger "rules" field

2018-02-27 Thread GitBox
dubeejw closed pull request #227: Support new trigger "rules" field URL: https://github.com/apache/incubator-openwhisk-cli/pull/227 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] pritidesai commented on issue #758: Deprecate interactive mode in wskdeploy

2018-02-27 Thread GitBox
pritidesai commented on issue #758: Deprecate interactive mode in wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/758#issuecomment-369018371 sure @mrutkows we can, in that case, can we rename `--allow-interactive` and `-i` to `--dryrun` (as per @lionelvillard'

[GitHub] csantanapr closed pull request #3335: Allow container tests to run without a proxy.

2018-02-27 Thread GitBox
csantanapr closed pull request #3335: Allow container tests to run without a proxy. URL: https://github.com/apache/incubator-openwhisk/pull/3335 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As

[GitHub] csantanapr commented on issue #3335: Allow container tests to run without a proxy.

2018-02-27 Thread GitBox
csantanapr commented on issue #3335: Allow container tests to run without a proxy. URL: https://github.com/apache/incubator-openwhisk/pull/3335#issuecomment-369027354 _?que Dios nos coja confesados!_ merging... ? This is an

[GitHub] csantanapr commented on issue #3335: Allow container tests to run without a proxy.

2018-02-27 Thread GitBox
csantanapr commented on issue #3335: Allow container tests to run without a proxy. URL: https://github.com/apache/incubator-openwhisk/pull/3335#issuecomment-369027354 _?que Dios nos coja confesados!_ merging... This is an au

[GitHub] beemarie closed pull request #16: WIP: Basic code cleanup

2018-02-27 Thread GitBox
beemarie closed pull request #16: WIP: Basic code cleanup URL: https://github.com/apache/incubator-openwhisk-package-deploy/pull/16 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] pritidesai commented on issue #694: filesystemreader.go: "searching for Action code.." code block incomplete

2018-02-27 Thread GitBox
pritidesai commented on issue #694: filesystemreader.go: "searching for Action code.." code block incomplete URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/694#issuecomment-369024623 filesystemreader is going away with PR #759

[GitHub] jonpspri commented on issue #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases

2018-02-27 Thread GitBox
jonpspri commented on issue #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases URL: https://github.com/apache/incubator-openwhisk/pull/3358#issuecomment-369020284 @csantanapr Please look at latest. OpenJDK 8 seems to be installing for everything now. ---

[GitHub] dubeejw closed pull request #20: Defect for delete of preinstalled directory

2018-02-27 Thread GitBox
dubeejw closed pull request #20: Defect for delete of preinstalled directory URL: https://github.com/apache/incubator-openwhisk-package-deploy/pull/20 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] pritidesai commented on issue #758: Deprecate interactive mode in wskdeploy

2018-02-27 Thread GitBox
pritidesai commented on issue #758: Deprecate interactive mode in wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/758#issuecomment-369018371 sure @mrutkows we can, in that case, we should rename `--allow-interactive` and `-i` to `--report`. Also, there are som

[GitHub] mdeuser commented on issue #3364: Add retries to some entity "update" tests

2018-02-27 Thread GitBox
mdeuser commented on issue #3364: Add retries to some entity "update" tests URL: https://github.com/apache/incubator-openwhisk/pull/3364#issuecomment-369017803 @markusthoemmes - here's the update per our discussion. would you mind reviewing when you have the chance. thanks!

[GitHub] mdeuser opened a new pull request #3364: Add retries to some entity "update" tests

2018-02-27 Thread GitBox
mdeuser opened a new pull request #3364: Add retries to some entity "update" tests URL: https://github.com/apache/incubator-openwhisk/pull/3364 Fix for the following kind of automated test failure recently observed ``` system.basic.WskBasicTests > Wsk Package REST should create, updat

[GitHub] pritidesai closed issue #718: Go fmt - please produce the corrupted list of files

2018-02-27 Thread GitBox
pritidesai closed issue #718: Go fmt - please produce the corrupted list of files URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/718 This is an automated message from the Apache Git Service. To respond

[GitHub] pritidesai commented on issue #718: Go fmt - please produce the corrupted list of files

2018-02-27 Thread GitBox
pritidesai commented on issue #718: Go fmt - please produce the corrupted list of files URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/718#issuecomment-369014326 Fixed with PR #743 This is an automated

[GitHub] rabbah closed pull request #3326: Make SplunkLogStore tests more resilient.

2018-02-27 Thread GitBox
rabbah closed pull request #3326: Make SplunkLogStore tests more resilient. URL: https://github.com/apache/incubator-openwhisk/pull/3326 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] markusthoemmes commented on issue #3357: Remove usages of replace and replaceAll on the hotpath.

2018-02-27 Thread GitBox
markusthoemmes commented on issue #3357: Remove usages of replace and replaceAll on the hotpath. URL: https://github.com/apache/incubator-openwhisk/pull/3357#issuecomment-369007580 @rabbah updated to only contain removal of `replaceAll` in container naming. Not as pressing but still good

[GitHub] csantanapr closed pull request #176: Only fetch action code when saving or copying an action

2018-02-27 Thread GitBox
csantanapr closed pull request #176: Only fetch action code when saving or copying an action URL: https://github.com/apache/incubator-openwhisk-cli/pull/176 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of prov

[GitHub] akrabat commented on issue #100: Add prefix to PROJECT_HOME and CATALOG_HOME

2018-02-27 Thread GitBox
akrabat commented on issue #100: Add prefix to PROJECT_HOME and CATALOG_HOME URL: https://github.com/apache/incubator-openwhisk-devtools/pull/100#issuecomment-369004872 @jthomas: https://github.com/apache/incubator-openwhisk-devtools/pull/101 ---

[GitHub] akrabat opened a new pull request #101: Add information on some env variables to README

2018-02-27 Thread GitBox
akrabat opened a new pull request #101: Add information on some env variables to README URL: https://github.com/apache/incubator-openwhisk-devtools/pull/101 PROJECT_HOME is now OPENWHISK_PROJECT_HOME. Also add information about some of the other environment variables that can be set.

[GitHub] bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer

2018-02-27 Thread GitBox
bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer URL: https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r171042727 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesClient

[GitHub] bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer

2018-02-27 Thread GitBox
bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer URL: https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r171043476 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesClient

[GitHub] bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer

2018-02-27 Thread GitBox
bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer URL: https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r171044427 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesContai

[GitHub] bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer

2018-02-27 Thread GitBox
bwmcadams commented on a change in pull request #3338: implement suspend/resume for KubernetesContainer URL: https://github.com/apache/incubator-openwhisk/pull/3338#discussion_r171043184 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/kubernetes/KubernetesClient

[GitHub] pritidesai closed issue #708: redeploy manifest with rule leaves as disables

2018-02-27 Thread GitBox
pritidesai closed issue #708: redeploy manifest with rule leaves as disables URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/708 This is an automated message from the Apache Git Service. To respond to the

[GitHub] pritidesai commented on issue #708: redeploy manifest with rule leaves as disables

2018-02-27 Thread GitBox
pritidesai commented on issue #708: redeploy manifest with rule leaves as disables URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/708#issuecomment-368998586 Just tested against IBM Cloud Functions, this issue has been fixed with: https://github.com/apache/incubator-op

[GitHub] jthomas commented on issue #100: Add prefix to PROJECT_HOME and CATALOG_HOME

2018-02-27 Thread GitBox
jthomas commented on issue #100: Add prefix to PROJECT_HOME and CATALOG_HOME URL: https://github.com/apache/incubator-openwhisk-devtools/pull/100#issuecomment-368994836 @akrabat Can you update the docs with new var? https://github.com/apache/incubator-openwhisk-devtools/blob/ddf939c7a2c082

[GitHub] mrutkows closed pull request #50: Add the license header to all the source code files

2018-02-27 Thread GitBox
mrutkows closed pull request #50: Add the license header to all the source code files URL: https://github.com/apache/incubator-openwhisk-release/pull/50 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenan

[GitHub] markusthoemmes commented on issue #3357: Remove usages of replace and replaceAll on the hotpath.

2018-02-27 Thread GitBox
markusthoemmes commented on issue #3357: Remove usages of replace and replaceAll on the hotpath. URL: https://github.com/apache/incubator-openwhisk/pull/3357#issuecomment-368991313 Superseded by #3362 This is an automated m

[GitHub] jthomas commented on issue #3346: Integrate kube deployment?

2018-02-27 Thread GitBox
jthomas commented on issue #3346: Integrate kube deployment? URL: https://github.com/apache/incubator-openwhisk/issues/3346#issuecomment-368990701 As a short term improvement, should we improve the docs to list all the deployment options and point to the external repos? -

[GitHub] markusthoemmes commented on issue #3313: Add the support to package source code

2018-02-27 Thread GitBox
markusthoemmes commented on issue #3313: Add the support to package source code URL: https://github.com/apache/incubator-openwhisk/pull/3313#issuecomment-368989312 @houshengbo is this still valid? This is an automated message

[GitHub] markusthoemmes commented on issue #3363: Ansible image name overrides and bump NGinx to 1.13.9

2018-02-27 Thread GitBox
markusthoemmes commented on issue #3363: Ansible image name overrides and bump NGinx to 1.13.9 URL: https://github.com/apache/incubator-openwhisk/pull/3363#issuecomment-368989076 Could you add some context to the description please? What do we gain by this change? I like the ansibl

[GitHub] markusthoemmes closed pull request #3347: Generic Pooling REST Client

2018-02-27 Thread GitBox
markusthoemmes closed pull request #3347: Generic Pooling REST Client URL: https://github.com/apache/incubator-openwhisk/pull/3347 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a forei

[GitHub] kameshsampath commented on issue #233: Making entrypoint optional for Java Actions

2018-02-27 Thread GitBox
kameshsampath commented on issue #233: Making entrypoint optional for Java Actions URL: https://github.com/apache/incubator-openwhisk-cli/issues/233#issuecomment-368986442 @csantanapr am not sure we can add this issue to java-runtime improvements epic ---

[GitHub] dubeejw commented on issue #3347: Generic Pooling REST Client

2018-02-27 Thread GitBox
dubeejw commented on issue #3347: Generic Pooling REST Client URL: https://github.com/apache/incubator-openwhisk/pull/3347#issuecomment-368986256 PG3 1925 ? This is an automated message from the Apache Git Service. To respon

[GitHub] kameshsampath opened a new issue #233: Making entrypoint optional for Java Actions

2018-02-27 Thread GitBox
kameshsampath opened a new issue #233: Making entrypoint optional for Java Actions URL: https://github.com/apache/incubator-openwhisk-cli/issues/233 With https://github.com/apache/incubator-openwhisk-runtime-java/issues/14 the Java Actions will be able to infer the entrypoint via Main-Clas

[GitHub] beemarie commented on issue #20: Defect for delete of preinstalled directory

2018-02-27 Thread GitBox
beemarie commented on issue #20: Defect for delete of preinstalled directory URL: https://github.com/apache/incubator-openwhisk-package-deploy/pull/20#issuecomment-368982921 @dubeejw please take a look & merge when you get a chance. Jason reviewed earlier. ---

[GitHub] csantanapr commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases

2018-02-27 Thread GitBox
csantanapr commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases URL: https://github.com/apache/incubator-openwhisk/pull/3358#discussion_r171020137 ## File path: tools/ubuntu-setup/all.sh ## @@ -10,15 +18,35

[GitHub] jonpspri commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases

2018-02-27 Thread GitBox
jonpspri commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases URL: https://github.com/apache/incubator-openwhisk/pull/3358#discussion_r171019319 ## File path: tools/ubuntu-setup/all.sh ## @@ -10,15 +18,35 @@

[GitHub] dgrove-oss commented on a change in pull request #154: container network/dns converted to PureConfig

2018-02-27 Thread GitBox
dgrove-oss commented on a change in pull request #154: container network/dns converted to PureConfig URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/154#discussion_r171017930 ## File path: kubernetes/invoker/invoker.yml ## @@ -93,12 +93,12 @@ spec:

[GitHub] dgrove-oss commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

2018-02-27 Thread GitBox
dgrove-oss commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r171016731 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainerFact

[GitHub] jonpspri opened a new pull request #3363: Ansible image name overrides and bump NGinx to 1.13.9

2018-02-27 Thread GitBox
jonpspri opened a new pull request #3363: Ansible image name overrides and bump NGinx to 1.13.9 URL: https://github.com/apache/incubator-openwhisk/pull/3363 Add the ability to override image names to the ansible playbooks. Bump Nginx version to 1.13.9 Move responsiblity for do

[GitHub] dgrove-oss commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

2018-02-27 Thread GitBox
dgrove-oss commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r171016731 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainerFact

[GitHub] markusthoemmes opened a new pull request #3362: Make ActivationId implementation leaner.

2018-02-27 Thread GitBox
markusthoemmes opened a new pull request #3362: Make ActivationId implementation leaner. URL: https://github.com/apache/incubator-openwhisk/pull/3362 ActivationId is today essentially a wrapper around `UUID`. This is not necessary though. Subsequent operations (serdes for instance) are unn

[GitHub] csantanapr commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases

2018-02-27 Thread GitBox
csantanapr commented on a change in pull request #3358: Update to tools/ubuntu-setup to support xenial and later Ubuntu releases URL: https://github.com/apache/incubator-openwhisk/pull/3358#discussion_r171008630 ## File path: tools/ubuntu-setup/all.sh ## @@ -10,15 +18,35

[GitHub] csantanapr closed pull request #11: Switch to Maven based dependency

2018-02-27 Thread GitBox
csantanapr closed pull request #11: Switch to Maven based dependency URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/11 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this

[GitHub] tysonnorris commented on a change in pull request #154: container network/dns converted to PureConfig

2018-02-27 Thread GitBox
tysonnorris commented on a change in pull request #154: container network/dns converted to PureConfig URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/154#discussion_r171003517 ## File path: kubernetes/invoker/invoker.yml ## @@ -93,12 +93,12 @@ spec:

[GitHub] tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

2018-02-27 Thread GitBox
tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r170998685 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainerFac

[GitHub] tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

2018-02-27 Thread GitBox
tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r170996623 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainerFac

[GitHub] tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110

2018-02-27 Thread GitBox
tysonnorris commented on a change in pull request #3211: implement ContainerFactory.cpuShare to fix #3110 URL: https://github.com/apache/incubator-openwhisk/pull/3211#discussion_r170996623 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/docker/DockerContainerFac

[GitHub] kameshsampath closed pull request #19: [WIP] Java Improvements

2018-02-27 Thread GitBox
kameshsampath closed pull request #19: [WIP] Java Improvements URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/19 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a f

[GitHub] vvraskin opened a new pull request #3361: Monitor kafka queue for all consumers

2018-02-27 Thread GitBox
vvraskin opened a new pull request #3361: Monitor kafka queue for all consumers URL: https://github.com/apache/incubator-openwhisk/pull/3361 Use internal kafka consumer metrics to monitor kafka queue for a particular topic. @markusthoemmes -

[GitHub] rabbah closed pull request #3215: adding namePrefix config to ContainerArgsConfig

2018-02-27 Thread GitBox
rabbah closed pull request #3215: adding namePrefix config to ContainerArgsConfig URL: https://github.com/apache/incubator-openwhisk/pull/3215 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As th

[GitHub] mrutkows commented on issue #758: Deprecate interactive mode in wskdeploy

2018-02-27 Thread GitBox
mrutkows commented on issue #758: Deprecate interactive mode in wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/758#issuecomment-368945574 @pritidesai we will preserve the interactive flag as a means to stop/verify assets before deployment ---

[GitHub] mrutkows commented on issue #758: Deprecate interactive mode in wskdeploy

2018-02-27 Thread GitBox
mrutkows commented on issue #758: Deprecate interactive mode in wskdeploy URL: https://github.com/apache/incubator-openwhisk-wskdeploy/issues/758#issuecomment-368943641 @csantanapr already gutted 90% of this... the only part left is "report" which we plan to perhaps preserve as part of a "

[GitHub] rabbah commented on issue #3215: adding namePrefix config to ContainerArgsConfig

2018-02-27 Thread GitBox
rabbah commented on issue #3215: adding namePrefix config to ContainerArgsConfig URL: https://github.com/apache/incubator-openwhisk/pull/3215#issuecomment-368943549 @markusthoemmes I'm going to merge this first - you'll need to update your pr. -

[GitHub] chetanmeh commented on issue #3356: Add method to delete attachment to ArtifactStore

2018-02-27 Thread GitBox
chetanmeh commented on issue #3356: Add method to delete attachment to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/issues/3356#issuecomment-368923722 Currently when any entity is deleted we do not have entity instance. So this would make it tricky to implement `delete

[GitHub] kameshsampath opened a new pull request #19: [WIP] Java Improvements

2018-02-27 Thread GitBox
kameshsampath opened a new pull request #19: [WIP] Java Improvements URL: https://github.com/apache/incubator-openwhisk-runtime-java/pull/19 WIP - rebased docker image Signed-off-by: Kamesh Sampath This is an autom

[GitHub] houshengbo opened a new pull request #50: Add the license header to all the source code files

2018-02-27 Thread GitBox
houshengbo opened a new pull request #50: Add the license header to all the source code files URL: https://github.com/apache/incubator-openwhisk-release/pull/50 This is an automated message from the Apache Git Service. To re

[GitHub] chetanmeh commented on issue #3356: Add method to delete attachment to ArtifactStore

2018-02-27 Thread GitBox
chetanmeh commented on issue #3356: Add method to delete attachment to ArtifactStore URL: https://github.com/apache/incubator-openwhisk/issues/3356#issuecomment-368923722 Currently when any entity is deleted we do not have entity instance. So this would make it tricky to implement `delete

[GitHub] jonpspri commented on issue #3133: Subtle changes to support S390X deployment of OpenWhisk

2018-02-27 Thread GitBox
jonpspri commented on issue #3133: Subtle changes to support S390X deployment of OpenWhisk URL: https://github.com/apache/incubator-openwhisk/pull/3133#issuecomment-368919819 I moved the changes to tools/ubuntu-setup into #3358

[GitHub] jonpspri opened a new pull request #3360: Set mode of wsk to executable

2018-02-27 Thread GitBox
jonpspri opened a new pull request #3360: Set mode of wsk to executable URL: https://github.com/apache/incubator-openwhisk/pull/3360 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] markusthoemmes opened a new pull request #3359: Change all empty collection creations to an explicit call to `empty`.

2018-02-27 Thread GitBox
markusthoemmes opened a new pull request #3359: Change all empty collection creations to an explicit call to `empty`. URL: https://github.com/apache/incubator-openwhisk/pull/3359 `Collection.empty` is optimized for less allocations, less work in general and more clear to read. ---

[GitHub] rabbah commented on a change in pull request #3357: Remove usages of replace and replaceAll on the hotpath.

2018-02-27 Thread GitBox
rabbah commented on a change in pull request #3357: Remove usages of replace and replaceAll on the hotpath. URL: https://github.com/apache/incubator-openwhisk/pull/3357#discussion_r170959370 ## File path: common/scala/src/main/scala/whisk/core/entity/ActivationId.scala ##

[GitHub] jonpspri opened a new pull request #3358: Update to tools/ubuntu-setup to support xenail and later releases

2018-02-27 Thread GitBox
jonpspri opened a new pull request #3358: Update to tools/ubuntu-setup to support xenail and later releases URL: https://github.com/apache/incubator-openwhisk/pull/3358 Updated to tools/ubuntu-setup/*.sh to support xenial and later versions of Ubuntu as part of the install process. Trusty

[GitHub] sven-lange-last commented on a change in pull request #3357: Remove usages of replace and replaceAll on the hotpath.

2018-02-27 Thread GitBox
sven-lange-last commented on a change in pull request #3357: Remove usages of replace and replaceAll on the hotpath. URL: https://github.com/apache/incubator-openwhisk/pull/3357#discussion_r170956585 ## File path: common/scala/src/main/scala/whisk/core/entity/ActivationId.scala ##

[GitHub] csantanapr commented on issue #18: Rebase OW JavaRuntime to fabric8 java image

2018-02-27 Thread GitBox
csantanapr commented on issue #18: Rebase OW JavaRuntime to fabric8 java image URL: https://github.com/apache/incubator-openwhisk-runtime-java/issues/18#issuecomment-368910992 Can you elaborate more on why `fabric8` based on centos? Instead of using standard openjdk image ubuntu/debian b

[GitHub] csantanapr commented on issue #18: Rebase OW JavaRuntime to fabric8 java image

2018-02-27 Thread GitBox
csantanapr commented on issue #18: Rebase OW JavaRuntime to fabric8 java image URL: https://github.com/apache/incubator-openwhisk-runtime-java/issues/18#issuecomment-368910992 Can you elaborate more on why `fabric8` based on centos? Instead of using standard openjdk image ubuntu/debian b

[GitHub] rabbah commented on a change in pull request #3357: Remove usages of replace and replaceAll on the hotpath.

2018-02-27 Thread GitBox
rabbah commented on a change in pull request #3357: Remove usages of replace and replaceAll on the hotpath. URL: https://github.com/apache/incubator-openwhisk/pull/3357#discussion_r170953953 ## File path: core/invoker/src/main/scala/whisk/core/containerpool/ContainerProxy.scala #

[GitHub] markusthoemmes opened a new pull request #3357: Remove usages of replace and replaceAll on the hotpath.

2018-02-27 Thread GitBox
markusthoemmes opened a new pull request #3357: Remove usages of replace and replaceAll on the hotpath. URL: https://github.com/apache/incubator-openwhisk/pull/3357 replace(String, String) and replaceAll(String, String) will compile regex patterns implicitly. This creates a lot of unnecess

[GitHub] dubeejw commented on issue #3347: Generic Pooling REST Client

2018-02-27 Thread GitBox
dubeejw commented on issue #3347: Generic Pooling REST Client URL: https://github.com/apache/incubator-openwhisk/pull/3347#issuecomment-368761340 PG2 2862 ? This is an automated message from the Apache Git Service. To respon

[GitHub] jonpspri opened a new pull request #229: Travis local cli

2018-02-27 Thread GitBox
jonpspri opened a new pull request #229: Travis local cli URL: https://github.com/apache/incubator-openwhisk-cli/pull/229 See https://github.com/apache/incubator-openwhisk/issues/3329 These changes to the travis build script should cause it to exercise the CLI copy logic in the ansib

[GitHub] jonpspri closed pull request #229: Travis local cli

2018-02-27 Thread GitBox
jonpspri closed pull request #229: Travis local cli URL: https://github.com/apache/incubator-openwhisk-cli/pull/229 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull request

  1   2   >