rabbah commented on issue #304: API Gateway Path Parameters For Query Params?
URL:
https://github.com/apache/incubator-openwhisk-apigateway/issues/304#issuecomment-394961053
Calling apis that use query parameters not well designed just confuses the
issue --- which is whether the gateway sh
codecov-io commented on issue #3709: Inlined attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3709#issuecomment-392498401
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3709?src=pr&el=h1)
Report
> Merging
[#3709](https://codecov.io/gh/apache/incub
codecov-io commented on issue #3709: Inlined attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3709#issuecomment-392498401
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3709?src=pr&el=h1)
Report
> Merging
[#3709](https://codecov.io/gh/apache/incub
chetanmeh commented on a change in pull request #3709: Inlined attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3709#discussion_r193291365
##
File path:
common/scala/src/main/scala/whisk/core/database/CouchDbRestStore.scala
##
@@ -356,13 +356,21 @@ clas
chetanmeh commented on a change in pull request #3685: Enable test code
coverage collection for containers
URL:
https://github.com/apache/incubator-openwhisk/pull/3685#discussion_r193289869
##
File path: ansible/templates/whisk.properties.j2
##
@@ -7,6 +7,7 @@ testing.aut
remore opened a new pull request #3725: Add Ruby2.5 runtime support
URL: https://github.com/apache/incubator-openwhisk/pull/3725
This PR adds a new ruby:2.5 kind to allow Ruby methods like this:
```
def main(param)
{ :result => param.upcase }
end
```
## Descriptio
mrutkows commented on issue #179: Do we need to add JIRA automation (changes.md
gen) and track Fix Versions
URL:
https://github.com/apache/incubator-openwhisk-release/issues/179#issuecomment-394923196
If we can minimize reliance on JIRA the better since most Contributors and
Committers on
mrutkows opened a new issue #179: Do we need to add JIRA automation (changes.md
gen) and track Fix Versions
URL: https://github.com/apache/incubator-openwhisk-release/issues/179
Please read what Apache Beam does with JIRA here:
https://beam.apache.org/contribute/release-guide/
-
mrutkows opened a new issue #178: Verify each TAR has changes(.md or .txt)
included
URL: https://github.com/apache/incubator-openwhisk-release/issues/178
and perhaps make sure hat this file gets checked into main OW github as
well..
I know we have a utility/script Daisy produced,
mrutkows opened a new issue #177: Can we remove gradle-wrapper.jar from TAR
files?
URL: https://github.com/apache/incubator-openwhisk-release/issues/177
We identified this as the only/last remaining .jar files in our source
release, but it was indicated to me that we could not build withou
tysonnorris commented on a change in pull request #3507: allow use of string
for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193262565
##
File path: common/scala/src/main/scala/whisk/core/entity/InstanceId.scala
##
@@ -22,7 +22,2
tysonnorris commented on a change in pull request #3507: allow use of string
for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193261481
##
File path: common/scala/src/main/scala/whisk/core/entity/InstanceId.scala
##
@@ -22,7 +22,2
rabbah commented on issue #3707: enable concurrent runs on ActionContainer test
utility
URL:
https://github.com/apache/incubator-openwhisk/pull/3707#issuecomment-394897713
Will try to go through this tonight or tomorrow. Thanks for the nudge.
-
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193257065
##
File path: common/scala/src/main/scala/whisk/core/entity/InstanceId.scala
##
@@ -22,7 +22,20 @@
tysonnorris commented on issue #3707: enable concurrent runs on ActionContainer
test utility
URL:
https://github.com/apache/incubator-openwhisk/pull/3707#issuecomment-394897470
@markusthoemmes @rabbah approval?
This is an a
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193256960
##
File path: common/scala/src/main/scala/whisk/core/entity/InstanceId.scala
##
@@ -22,7 +22,20 @@
tysonnorris commented on a change in pull request #3507: allow use of string
for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193256614
##
File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala
##
@@ -113,
tysonnorris commented on a change in pull request #3507: allow use of string
for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193256457
##
File path:
core/controller/src/main/scala/whisk/core/controller/Controller.scala
##
@@ -20
rabbah commented on a change in pull request #3685: Enable test code coverage
collection for containers
URL:
https://github.com/apache/incubator-openwhisk/pull/3685#discussion_r193256394
##
File path: ansible/templates/whisk.properties.j2
##
@@ -7,6 +7,7 @@ testing.auth={
tysonnorris commented on a change in pull request #3507: allow use of string
for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193256190
##
File path: common/scala/src/main/scala/whisk/core/entity/InstanceId.scala
##
@@ -22,7 +22,2
rabbah commented on a change in pull request #3704: Provide graceful shutdown
for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r193255126
##
File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala
##
@@ -284,4 +29
rabbah commented on a change in pull request #3704: Provide graceful shutdown
for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r193255025
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
##
@@ -178,
rabbah commented on a change in pull request #3704: Provide graceful shutdown
for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r193254857
##
File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala
##
@@ -284,4 +29
codecov-io commented on issue #3707: enable concurrent runs on ActionContainer
test utility
URL:
https://github.com/apache/incubator-openwhisk/pull/3707#issuecomment-392093713
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3707?src=pr&el=h1)
Report
> :exclamation:
rabbah commented on issue #3709: Inlined attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3709#issuecomment-394894026
Thanks for adding the additional tests.
Needs a PG.
This is an automated message
rabbah commented on a change in pull request #3709: Inlined attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3709#discussion_r193253978
##
File path: common/scala/src/main/resources/application.conf
##
@@ -114,6 +114,14 @@ whisk {
actions-ddoc =
rabbah commented on a change in pull request #3709: Inlined attachments
URL:
https://github.com/apache/incubator-openwhisk/pull/3709#discussion_r192448176
##
File path:
common/scala/src/main/scala/whisk/core/database/CouchDbRestStore.scala
##
@@ -356,13 +356,21 @@ class C
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193253274
##
File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala
##
@@ -113,13 +1
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193252341
##
File path:
core/controller/src/main/scala/whisk/core/controller/Controller.scala
##
@@ -202,7 +
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193252805
##
File path:
tests/src/test/scala/whisk/core/controller/test/WebActionsApiTests.scala
##
@@ -1747
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193252633
##
File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala
##
@@ -113,13 +1
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193251981
##
File path: common/scala/src/main/scala/whisk/core/entity/InstanceId.scala
##
@@ -22,7 +22,20 @@
rabbah commented on a change in pull request #3507: allow use of string for
controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#discussion_r193252899
##
File path:
tests/src/test/scala/whisk/core/entity/test/StringInstanceIdTests.scala
##
@@ -0,0 +
rabbah commented on issue #3507: allow use of string for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-394890455
I’ll take it.
This is an automated message from the Apache Git Se
tysonnorris commented on issue #3507: allow use of string for controller id
URL:
https://github.com/apache/incubator-openwhisk/pull/3507#issuecomment-394889004
Looking for a review on this so I can get it merged
This is an au
pritidesai commented on a change in pull request #950: Continue spec.
conversion to markdown and add navigation
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/950#discussion_r193249050
##
File path: specification/html/spec_actions.md
##
@@ -19,87 +19,44
codecov-io commented on issue #3704: Provide graceful shutdown for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-391821150
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3704?src=pr&el=h1)
Report
> Merging
[#3704](https://codecov.
dubee commented on issue #3704: Provide graceful shutdown for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-394859642
@rabbah, @markusthoemmes, made some changes to prevent the mentioned race
condition with the activation feed. Now the feed is being poll
houshengbo closed pull request #176: Rename the release directory
URL: https://github.com/apache/incubator-openwhisk-release/pull/176
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this is a fo
houshengbo closed issue #169: Allow user to change to use their chose JDK and
document (multiple repos)
URL: https://github.com/apache/incubator-openwhisk-release/issues/169
This is an automated message from the Apache Git S
houshengbo closed pull request #3720: Update the document regarding Open JDK
and Oracle JDK
URL: https://github.com/apache/incubator-openwhisk/pull/3720
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenan
codecov-io commented on issue #3720: Update the document regarding Open JDK and
Oracle JDK
URL:
https://github.com/apache/incubator-openwhisk/pull/3720#issuecomment-393983807
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3720?src=pr&el=h1)
Report
> Merging
[#3720]
csantanapr closed pull request #210: Helm: Enhance pod configuration
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/pull/210
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:
As this
dubee commented on issue #3704: Provide graceful shutdown for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-394823506
Looks like there is another queue in `MessageConsumer` that should be
drained before `activationFeed` is completely terminated. For the
dubee commented on issue #3704: Provide graceful shutdown for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-394823506
Looks like there is another queue in `MessageConsumer` that should be
drained before `activationFeed` is completely terminated. For the
dubee commented on issue #3704: Provide graceful shutdown for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-394823506
Looks like there is another queue in `MessageConsumer` that should be
drained before `activationFeed` is completely terminated. For the
houshengbo closed pull request #3504: use alpine-java base image (alpine 3.7 +
oracle 8u162b12_server-jre)
URL: https://github.com/apache/incubator-openwhisk/pull/3504
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the s
codecov-io commented on issue #3720: Update the document regarding Open JDK and
Oracle JDK
URL:
https://github.com/apache/incubator-openwhisk/pull/3720#issuecomment-393983807
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3720?src=pr&el=h1)
Report
> Merging
[#3720]
dubee commented on issue #3704: Provide graceful shutdown for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-394823506
Looks like there is another queue in `MessageConsumer` that should be
drained before `activationFeed` is completely terminated. For the
dubee commented on issue #3704: Provide graceful shutdown for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-394823506
Looks like there is another queue in `MessageConsumer` that should be
drained before `activationFeed` is completely terminated. For the
csantanapr commented on a change in pull request #210: Helm: Enhance pod
configuration
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/pull/210#discussion_r193186714
##
File path: helm/templates/NOTES.txt
##
@@ -1,5 +1,9 @@
Thank you for installing {{ .Cha
rabbah commented on issue #946: runtimes
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/pull/946#issuecomment-394824255
Thanks @pritidesai for the all these patches and enhancements. I will review
and try with my local dev environment.
---
dubee commented on issue #3704: Provide graceful shutdown for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#issuecomment-394823506
Looks like there is another queue in `MessageConsumer` that should be
drained before `activationFeed` is completely terminated.
---
pritidesai commented on issue #929: if manifest read fails, wskdeploy should
not read details from hardcoded manifest
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/929#issuecomment-394823404
Reading hardcoded values can be disabled using `--strict` flag.
pritidesai commented on issue #928: hardcoded protocol does not allow for http
to be used
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/928#issuecomment-394823180
This can be disabled using `--strict` flag.
```
./wskdeploy -m tests/dat/manifest_validate_act
pritidesai commented on issue #927: action deployed when runtime is deprecated
URL:
https://github.com/apache/incubator-openwhisk-wskdeploy/issues/927#issuecomment-394822771
Yes, with PR #946 and using `--strict` flag, we can disable automatic
remapping of runtimes.
--
codecov-io commented on issue #3504: use alpine-java base image (alpine 3.7 +
oracle 8u162b12_server-jre)
URL:
https://github.com/apache/incubator-openwhisk/pull/3504#issuecomment-385123620
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3504?src=pr&el=h1)
Report
> M
codecov-io commented on issue #3504: use alpine-java base image (alpine 3.7 +
oracle 8u162b12_server-jre)
URL:
https://github.com/apache/incubator-openwhisk/pull/3504#issuecomment-385123620
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3504?src=pr&el=h1)
Report
> M
codecov-io commented on issue #3720: Update the document regarding Open JDK and
Oracle JDK
URL:
https://github.com/apache/incubator-openwhisk/pull/3720#issuecomment-393983807
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3720?src=pr&el=h1)
Report
> Merging
[#3720]
houshengbo opened a new pull request #176: Rename the release directory
URL: https://github.com/apache/incubator-openwhisk-release/pull/176
This is an automated message from the Apache Git Service.
To respond to the message,
markusthoemmes commented on a change in pull request #3704: Provide graceful
shutdown for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r193161349
##
File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala
##
@@ -2
markusthoemmes commented on a change in pull request #3704: Provide graceful
shutdown for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r193162108
##
File path:
core/invoker/src/main/scala/whisk/core/containerpool/ContainerPool.scala
##
houshengbo commented on a change in pull request #3720: Update the document
regarding Open JDK and Oracle JDK
URL:
https://github.com/apache/incubator-openwhisk/pull/3720#discussion_r193161527
##
File path: tools/ubuntu-setup/java8.sh
##
@@ -19,10 +19,20 @@
set -e
set -
markusthoemmes commented on a change in pull request #3704: Provide graceful
shutdown for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r193161349
##
File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala
##
@@ -2
dubee commented on a change in pull request #3704: Provide graceful shutdown
for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r193109317
##
File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala
##
@@ -284,4 +290
mrutkows commented on a change in pull request #3720: Update the document
regarding Open JDK and Oracle JDK
URL:
https://github.com/apache/incubator-openwhisk/pull/3720#discussion_r193090140
##
File path: tools/ubuntu-setup/java8.sh
##
@@ -19,10 +19,20 @@
set -e
set -x
mrutkows commented on a change in pull request #3720: Update the document
regarding Open JDK and Oracle JDK
URL:
https://github.com/apache/incubator-openwhisk/pull/3720#discussion_r193089780
##
File path: tools/ubuntu-setup/java8.sh
##
@@ -19,10 +19,20 @@
set -e
set -x
dgrove-oss commented on issue #211: Controller pod shuts down with no errors
after start
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/issues/211#issuecomment-394692272
ok, thanks. So it looks like kafka isn't the problem.
Another thought, are you perhaps running 2
vcosqui commented on issue #211: Controller pod shuts down with no errors after
start
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/issues/211#issuecomment-394689113
Probably I did, sorry
here is other log example where the kafka topic creation is skipped due to
pr
dgrove-oss commented on issue #211: Controller pod shuts down with no errors
after start
URL:
https://github.com/apache/incubator-openwhisk-deploy-kube/issues/211#issuecomment-394687074
I would expect to see some messages early in the log noting that the
controller had managed to create a
vcosqui opened a new issue #211: Controller pod shuts down with no errors after
start
URL: https://github.com/apache/incubator-openwhisk-deploy-kube/issues/211
Dear openwhisk team
After some time succesfully playing with the vagrant installation of
openwhisk, now I am trying to setu
codecov-io commented on issue #3570: ArtifactStore implementation for MongoDB
URL:
https://github.com/apache/incubator-openwhisk/pull/3570#issuecomment-386234242
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/3570?src=pr&el=h1)
Report
> Merging
[#3570](https://codec
cbickel closed pull request #3697: Add equals method to ensure that ByteSize
instances satisfy Comparable contract
URL: https://github.com/apache/incubator-openwhisk/pull/3697
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below f
markusthoemmes commented on a change in pull request #3704: Provide graceful
shutdown for invoker
URL:
https://github.com/apache/incubator-openwhisk/pull/3704#discussion_r192994858
##
File path: core/invoker/src/main/scala/whisk/core/invoker/InvokerReactive.scala
##
@@ -2
codecov-io commented on issue #2282: Distributed tracing support #2192
URL:
https://github.com/apache/incubator-openwhisk/pull/2282#issuecomment-391308983
#
[Codecov](https://codecov.io/gh/apache/incubator-openwhisk/pull/2282?src=pr&el=h1)
Report
> Merging
[#2282](https://codecov.io/g
75 matches
Mail list logo
