[GitHub] [ozone] ChenSammi commented on pull request #3648: HDDS-7083. Spread container-copy directories

2023-01-09 Thread GitBox
ChenSammi commented on PR #3648: URL: https://github.com/apache/ozone/pull/3648#issuecomment-1376842291 TestKeyValueContainer.testContainerImportExport failure could be related. @symious could you check it? -- This is an automated message from the Apache Git Service. To respond to the me

[jira] [Assigned] (HDDS-7754) Download of container is failing with SSL/TLS error during re-replication

2023-01-09 Thread Ritesh H Shukla (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritesh H Shukla reassigned HDDS-7754: - Assignee: Stephen O'Donnell (was: Ritesh H Shukla) > Download of container is failing wi

[jira] [Commented] (HDDS-7754) Download of container is failing with SSL/TLS error during re-replication

2023-01-09 Thread Ritesh H Shukla (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656463#comment-17656463 ] Ritesh H Shukla commented on HDDS-7754: --- [~varsharavi] do you have the entire log fo

[GitHub] [ozone] duongkame commented on a diff in pull request #4044: HDDS-7517. Register OM-S3G gRPC performance metrics

2023-01-09 Thread GitBox
duongkame commented on code in PR #4044: URL: https://github.com/apache/ozone/pull/4044#discussion_r1065397764 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/grpc/GrpcOmServerRequestInterceptor.java: ## @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache So

[GitHub] [ozone] duongkame commented on a diff in pull request #4044: HDDS-7517. Register OM-S3G gRPC performance metrics

2023-01-09 Thread GitBox
duongkame commented on code in PR #4044: URL: https://github.com/apache/ozone/pull/4044#discussion_r1065397764 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/grpc/GrpcOmServerRequestInterceptor.java: ## @@ -0,0 +1,113 @@ +/** + * Licensed to the Apache So

[jira] [Updated] (HDDS-7751) Volume quota must have all bucket quota set

2023-01-09 Thread Sumit Agrawal (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7751?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sumit Agrawal updated HDDS-7751: Summary: Volume quota must have all bucket quota set (was: Performance while calculating bucket quo

[jira] [Commented] (HDDS-7751) Performance while calculating bucket quota usages

2023-01-09 Thread Sumit Agrawal (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7751?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656441#comment-17656441 ] Sumit Agrawal commented on HDDS-7751: - [~sammichen]  As Discussion, there is a broken

[jira] [Created] (HDDS-7765) [Snapshot] Handle OzoneManager#getKeyInfo with OmMetadataReader

2023-01-09 Thread Siyao Meng (Jira)
Siyao Meng created HDDS-7765: Summary: [Snapshot] Handle OzoneManager#getKeyInfo with OmMetadataReader Key: HDDS-7765 URL: https://issues.apache.org/jira/browse/HDDS-7765 Project: Apache Ozone I

[GitHub] [ozone] devmadhuu commented on a diff in pull request #4042: HDDS-5541. Namespace summary endpoint can carry basic information on the entity as well.

2023-01-09 Thread GitBox
devmadhuu commented on code in PR #4042: URL: https://github.com/apache/ozone/pull/4042#discussion_r1065349620 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/LegacyBucketHandler.java: ## @@ -322,4 +323,11 @@ public Table getKeyTable() { g

[GitHub] [ozone] devmadhuu commented on a diff in pull request #4042: HDDS-5541. Namespace summary endpoint can carry basic information on the entity as well.

2023-01-09 Thread GitBox
devmadhuu commented on code in PR #4042: URL: https://github.com/apache/ozone/pull/4042#discussion_r1065346710 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/BucketObjectDBInfo.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Founda

[GitHub] [ozone] nishitpatira commented on a diff in pull request #4097: HDDS-7372. Fixing missing jars in classpath by specifying jar versions

2023-01-09 Thread GitBox
nishitpatira commented on code in PR #4097: URL: https://github.com/apache/ozone/pull/4097#discussion_r1065332050 ## pom.xml: ## @@ -1202,6 +1232,11 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs jul-to-slf4j ${slf4j.versio

[GitHub] [ozone] nishitpatira commented on a diff in pull request #4097: HDDS-7372. Fixing missing jars in classpath by specifying jar versions

2023-01-09 Thread GitBox
nishitpatira commented on code in PR #4097: URL: https://github.com/apache/ozone/pull/4097#discussion_r1065332050 ## pom.xml: ## @@ -1202,6 +1232,11 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs jul-to-slf4j ${slf4j.versio

[GitHub] [ozone] SaketaChalamchala commented on a diff in pull request #4157: HDDS-7747. Ozone cli to support listing of encrypted buckets.

2023-01-09 Thread GitBox
SaketaChalamchala commented on code in PR #4157: URL: https://github.com/apache/ozone/pull/4157#discussion_r1065310579 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/ListBucketHandler.java: ## @@ -44,6 +45,10 @@ public class ListBucketHandler extends Vo

[GitHub] [ozone] SaketaChalamchala commented on pull request #4157: HDDS-7747. Ozone cli to support listing of encrypted buckets.

2023-01-09 Thread GitBox
SaketaChalamchala commented on PR #4157: URL: https://github.com/apache/ozone/pull/4157#issuecomment-1376693234 Thanks @kerneltime and @adoroszlai for the review. I added a robot test and updated the option description as suggested. -- This is an automated message from the Apache Git Serv

[GitHub] [ozone] symious commented on pull request #3648: HDDS-7083. Spread container-copy directories

2023-01-09 Thread GitBox
symious commented on PR #3648: URL: https://github.com/apache/ozone/pull/3648#issuecomment-1376643804 @ChenSammi Thank you for the review. Updated the PR, please have a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and

[GitHub] [ozone] symious commented on a diff in pull request #3648: HDDS-7083. Spread container-copy directories

2023-01-09 Thread GitBox
symious commented on code in PR #3648: URL: https://github.com/apache/ozone/pull/3648#discussion_r1065281795 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/TarContainerPacker.java: ## @@ -289,4 +305,40 @@ OutputStream compress(OutputStr

[GitHub] [ozone] Xushaohong commented on a diff in pull request #4128: HDDS-5686. Support transfer leadership

2023-01-09 Thread GitBox
Xushaohong commented on code in PR #4128: URL: https://github.com/apache/ozone/pull/4128#discussion_r1064520034 ## hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/ratis/RatisHelper.java: ## @@ -483,4 +488,81 @@ public static void debug(ByteBuf buf, String name, Logger l

[GitHub] [ozone] fapifta commented on a diff in pull request #4138: HDDS-5934. Add OM NodeID to VERSION file.

2023-01-09 Thread GitBox
fapifta commented on code in PR #4138: URL: https://github.com/apache/ozone/pull/4138#discussion_r1065251181 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/OMStorage.java: ## @@ -32,52 +32,178 @@ import static org.apache.hadoop.ozone.om.OmUpgradeConfig.

[jira] [Resolved] (HDDS-7638) Ozone client change to support HSync

2023-01-09 Thread Tsz-wo Sze (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tsz-wo Sze resolved HDDS-7638. -- Fix Version/s: 1.4.0 Resolution: Fixed The pull request is now merged. > Ozone client change to

[GitHub] [ozone] szetszwo commented on pull request #4104: HDDS-7638. Ozone client change to support HSync.

2023-01-09 Thread GitBox
szetszwo commented on PR #4104: URL: https://github.com/apache/ozone/pull/4104#issuecomment-1376569135 Thanks @jojochuang and @umamaheswararao for reviewing this! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the UR

[GitHub] [ozone] szetszwo merged pull request #4104: HDDS-7638. Ozone client change to support HSync.

2023-01-09 Thread GitBox
szetszwo merged PR #4104: URL: https://github.com/apache/ozone/pull/4104 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache

[jira] [Commented] (HDDS-7764) Potential discrepancy of key creation time may cause premature open key clean up

2023-01-09 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656348#comment-17656348 ] Ethan Rose commented on HDDS-7764: -- Looks like something we should fix. Since existing ke

[jira] [Commented] (HDDS-7764) Potential discrepancy of key creation time may cause premature open key clean up

2023-01-09 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7764?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656347#comment-17656347 ] Wei-Chiu Chuang commented on HDDS-7764: --- [~erose] [~ckj]  thoughts on this one? To b

[jira] [Created] (HDDS-7764) Potential discrepancy of key creation time may cause premature open key clean up

2023-01-09 Thread Wei-Chiu Chuang (Jira)
Wei-Chiu Chuang created HDDS-7764: - Summary: Potential discrepancy of key creation time may cause premature open key clean up Key: HDDS-7764 URL: https://issues.apache.org/jira/browse/HDDS-7764 Projec

[jira] [Comment Edited] (HDDS-7756) Bucket Name Can't be CAPS

2023-01-09 Thread Dave Teng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656335#comment-17656335 ] Dave Teng edited comment on HDDS-7756 at 1/9/23 11:48 PM: -- Yes, c

[jira] [Commented] (HDDS-7756) Bucket Name Can't be CAPS

2023-01-09 Thread Dave Teng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656335#comment-17656335 ] Dave Teng commented on HDDS-7756: - Yes, currently ozone bucket name only supports lowercas

[GitHub] [ozone] jojochuang commented on a diff in pull request #4073: HDDS-7624. Reuse MultipartInputStream in BlockInputStream

2023-01-09 Thread GitBox
jojochuang commented on code in PR #4073: URL: https://github.com/apache/ozone/pull/4073#discussion_r1065190288 ## hadoop-ozone/client/src/main/java/org/apache/hadoop/ozone/client/io/MultipartCryptoKeyInputStream.java: ## @@ -0,0 +1,46 @@ +/** + * Licensed to the Apache Software

[GitHub] [ozone] hemantk-12 commented on a diff in pull request #4119: HDDS-7690. [Snapshot] Use SST file list output from compaction DAG as SnapshotDiff input

2023-01-09 Thread GitBox
hemantk-12 commented on code in PR #4119: URL: https://github.com/apache/ozone/pull/4119#discussion_r1065107437 ## hadoop-ozone/ozone-manager/src/main/java/org/apache/hadoop/ozone/om/snapshot/SnapshotDiffManager.java: ## @@ -107,38 +165,41 @@ public SnapshotDiffReport getSnapsho

[jira] [Assigned] (HDDS-7756) Bucket Name Can't be CAPS

2023-01-09 Thread Ritesh H Shukla (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritesh H Shukla reassigned HDDS-7756: - Assignee: Tanvi Penumudy > Bucket Name Can't be CAPS > - > >

[jira] [Assigned] (HDDS-7754) Download of container is failing with SSL/TLS error during re-replication

2023-01-09 Thread Ritesh H Shukla (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7754?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritesh H Shukla reassigned HDDS-7754: - Assignee: Ritesh H Shukla > Download of container is failing with SSL/TLS error during re

[jira] [Assigned] (HDDS-7755) S3G cannot acquire VOLUME_LOCK lock while holding [BUCKET_LOCK]

2023-01-09 Thread Ritesh H Shukla (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ritesh H Shukla reassigned HDDS-7755: - Assignee: Ethan Rose > S3G cannot acquire VOLUME_LOCK lock while holding [BUCKET_LOCK] >

[jira] [Created] (HDDS-7763) Recon: Support FSO buckets in container to key mapping

2023-01-09 Thread Ethan Rose (Jira)
Ethan Rose created HDDS-7763: Summary: Recon: Support FSO buckets in container to key mapping Key: HDDS-7763 URL: https://issues.apache.org/jira/browse/HDDS-7763 Project: Apache Ozone Issue Type:

[jira] [Updated] (HDDS-7560) Placement Policy Interface changes to handle Overreplication

2023-01-09 Thread Stephen O'Donnell (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen O'Donnell updated HDDS-7560: Fix Version/s: 1.4.0 Resolution: Fixed Status: Resolved (was: Patch Availa

[GitHub] [ozone] sodonnel merged pull request #4014: HDDS-7560. Placement Policy Interface changes to handle Overreplication

2023-01-09 Thread GitBox
sodonnel merged PR #4014: URL: https://github.com/apache/ozone/pull/4014 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache

[jira] [Created] (HDDS-7762) Rename Replication Manager to RedundancyManager

2023-01-09 Thread Uma Maheswara Rao G (Jira)
Uma Maheswara Rao G created HDDS-7762: - Summary: Rename Replication Manager to RedundancyManager Key: HDDS-7762 URL: https://issues.apache.org/jira/browse/HDDS-7762 Project: Apache Ozone

[GitHub] [ozone] adoroszlai commented on a diff in pull request #4157: HDDS-7747. Ozone cli to support listing of encrypted buckets.

2023-01-09 Thread GitBox
adoroszlai commented on code in PR #4157: URL: https://github.com/apache/ozone/pull/4157#discussion_r1065069803 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/bucket/ListBucketHandler.java: ## @@ -44,6 +45,10 @@ public class ListBucketHandler extends VolumeHan

[GitHub] [ozone] kerneltime commented on a diff in pull request #3835: HDDS-7329. Extend ozone admin datanode usageinfo and list info to accept hostname parameter

2023-01-09 Thread GitBox
kerneltime commented on code in PR #3835: URL: https://github.com/apache/ozone/pull/3835#discussion_r1065034099 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java: ## @@ -373,6 +375,8 @@ public RegisteredCommand register( String dn

[jira] [Updated] (HDDS-7506) Expose more snapshot metrics under OMMetrics

2023-01-09 Thread Christos Bisias (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christos Bisias updated HDDS-7506: -- Status: Patch Available (was: In Progress) > Expose more snapshot metrics under OMMetrics > ---

[GitHub] [ozone] xBis7 commented on pull request #4164: HDDS-7506. Expose more snapshot metrics under OMMetrics

2023-01-09 Thread GitBox
xBis7 commented on PR #4164: URL: https://github.com/apache/ozone/pull/4164#issuecomment-1376171912 @GeorgeJahad @smengcl Can you take a look at this PR? I'm not that familiar with snapshot code, so I don't know if there is something I missed or another metric you would like me to add. If t

[jira] [Updated] (HDDS-7506) Expose more snapshot metrics under OMMetrics

2023-01-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7506?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-7506: - Labels: pull-request-available (was: ) > Expose more snapshot metrics under OMMetrics > -

[GitHub] [ozone] xBis7 opened a new pull request, #4164: HDDS-7506. Expose more snapshot metrics under OMMetrics

2023-01-09 Thread GitBox
xBis7 opened a new pull request, #4164: URL: https://github.com/apache/ozone/pull/4164 ## What changes were proposed in this pull request? This PR is adding more snapshot metrics in `OMMetrics` to keep track of the count of each snapshot status. Right now there is no implementatio

[GitHub] [ozone] smengcl commented on pull request #4049: HDDS-4539. Container Health Task should not run until Recon has reached steady state.

2023-01-09 Thread GitBox
smengcl commented on PR #4049: URL: https://github.com/apache/ozone/pull/4049#issuecomment-1376167500 Thanks @devmadhuu for working on this! Thanks @sumitagrawl and @dombizita for the reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please l

[jira] [Resolved] (HDDS-4539) Container Health Task should not run until Recon has reached steady state.

2023-01-09 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng resolved HDDS-4539. -- Fix Version/s: 1.3.0 Resolution: Fixed > Container Health Task should not run until Recon has rea

[jira] [Updated] (HDDS-4539) Container Health Task should not run until Recon has reached steady state.

2023-01-09 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-4539?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-4539: - Fix Version/s: 1.4.0 (was: 1.3.0) > Container Health Task should not run until Reco

[GitHub] [ozone] smengcl merged pull request #4049: HDDS-4539. Container Health Task should not run until Recon has reached steady state.

2023-01-09 Thread GitBox
smengcl merged PR #4049: URL: https://github.com/apache/ozone/pull/4049 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.

[GitHub] [ozone] adoroszlai commented on a diff in pull request #4150: HDDS-7719. [HTTPFSGW] Fix secure integration tests for the HttpFS module

2023-01-09 Thread GitBox
adoroszlai commented on code in PR #4150: URL: https://github.com/apache/ozone/pull/4150#discussion_r1064949267 ## hadoop-ozone/dist/src/main/compose/ozonesecure-ha/test.sh: ## @@ -39,8 +39,7 @@ execute_robot_test ${SCM} s3 execute_robot_test ${SCM} admincli -# commented ou

[GitHub] [ozone] adoroszlai commented on a diff in pull request #4150: HDDS-7719. [HTTPFSGW] Fix secure integration tests for the HttpFS module

2023-01-09 Thread GitBox
adoroszlai commented on code in PR #4150: URL: https://github.com/apache/ozone/pull/4150#discussion_r1065017754 ## hadoop-ozone/dist/src/main/compose/ozone-ha/docker-compose.yaml: ## @@ -103,7 +103,7 @@ services: httpfs: <<: *common-config environment: - OZONE_

[GitHub] [ozone] smengcl commented on a diff in pull request #4049: HDDS-4539. Container Health Task should not run until Recon has reached steady state.

2023-01-09 Thread GitBox
smengcl commented on code in PR #4049: URL: https://github.com/apache/ozone/pull/4049#discussion_r1065023232 ## hadoop-hdds/common/src/main/java/org/apache/hadoop/hdds/recon/ReconConfigKeys.java: ## @@ -68,4 +68,7 @@ private ReconConfigKeys() { public static final String OZ

[jira] [Updated] (HDDS-7690) [Snapshot] Use SST file list output from compaction DAG as SnapshotDiff input

2023-01-09 Thread Siyao Meng (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7690?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Siyao Meng updated HDDS-7690: - Fix Version/s: HDDS-6517-Snapshot Resolution: Fixed Status: Resolved (was: Patch Availab

[GitHub] [ozone] prashantpogde commented on pull request #4015: HDDS-6984. [Snapshot] Prevent bucket from being deleted if snapshot exists

2023-01-09 Thread GitBox
prashantpogde commented on PR #4015: URL: https://github.com/apache/ozone/pull/4015#issuecomment-1376155837 @sadanand48 can we close this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spec

[GitHub] [ozone] smengcl commented on pull request #4119: HDDS-7690. [Snapshot] Use SST file list output from compaction DAG as SnapshotDiff input

2023-01-09 Thread GitBox
smengcl commented on PR #4119: URL: https://github.com/apache/ozone/pull/4119#issuecomment-1376155706 Thanks @prashantpogde for reviewing this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ozone] smengcl merged pull request #4119: HDDS-7690. [Snapshot] Use SST file list output from compaction DAG as SnapshotDiff input

2023-01-09 Thread GitBox
smengcl merged PR #4119: URL: https://github.com/apache/ozone/pull/4119 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apache.

[GitHub] [ozone] smengcl commented on a diff in pull request #4042: HDDS-5541. Namespace summary endpoint can carry basic information on the entity as well.

2023-01-09 Thread GitBox
smengcl commented on code in PR #4042: URL: https://github.com/apache/ozone/pull/4042#discussion_r1065017764 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/types/BucketObjectDBInfo.java: ## @@ -0,0 +1,168 @@ +/* + * Licensed to the Apache Software Foundati

[GitHub] [ozone] prashantpogde commented on pull request #4119: HDDS-7690. [Snapshot] Use SST file list output from compaction DAG as SnapshotDiff input

2023-01-09 Thread GitBox
prashantpogde commented on PR #4119: URL: https://github.com/apache/ozone/pull/4119#issuecomment-1376154278 Thanks for updating @smengcl . Looks good. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [ozone] smengcl commented on a diff in pull request #4042: HDDS-5541. Namespace summary endpoint can carry basic information on the entity as well.

2023-01-09 Thread GitBox
smengcl commented on code in PR #4042: URL: https://github.com/apache/ozone/pull/4042#discussion_r1065016580 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/LegacyBucketHandler.java: ## @@ -322,4 +323,11 @@ public Table getKeyTable() { get

[GitHub] [ozone] xBis7 commented on a diff in pull request #4125: HDDS-7277. [Snapshot] ozone sh key list /vol1/bucket1/.snapshot/snap1 fails

2023-01-09 Thread GitBox
xBis7 commented on code in PR #4125: URL: https://github.com/apache/ozone/pull/4125#discussion_r1064866481 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/snapshot/ListSnapshotKeyHandler.java: ## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [ozone] hemantk-12 opened a new pull request, #4163: HDDS-7524. SST file pruning

2023-01-09 Thread GitBox
hemantk-12 opened a new pull request, #4163: URL: https://github.com/apache/ozone/pull/4163 ## What changes were proposed in this pull request? This change is to proactively remove the unnecessary SST files from the backup directory which are not needed to generate diff using compacti

[jira] [Commented] (HDDS-7756) Bucket Name Can't be CAPS

2023-01-09 Thread Wei-Chiu Chuang (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7756?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17656240#comment-17656240 ] Wei-Chiu Chuang commented on HDDS-7756: --- cc [~dteng]  > Bucket Name Can't be CAPS >

[GitHub] [ozone] xBis7 commented on a diff in pull request #3741: HDDS-6449. Failed container delete can leave artifacts on disk

2023-01-09 Thread GitBox
xBis7 commented on code in PR #3741: URL: https://github.com/apache/ozone/pull/3741#discussion_r1064968407 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java: ## @@ -395,4 +413,179 @@ public static Path ge

[GitHub] [ozone] xBis7 commented on pull request #4134: HDDS-7513. [Snapshot] Support list snapshots using fs -ls

2023-01-09 Thread GitBox
xBis7 commented on PR #4134: URL: https://github.com/apache/ozone/pull/4134#issuecomment-1376072298 @GeorgeJahad Thanks for looking into this PR and suggesting using `GenericTestUtils.SystemOutCapturer`. I have been looking for something like that. I've addressed all your comments. Could yo

[jira] [Assigned] (HDDS-7227) EC: Implement Changed placement policy interface to allow existing nodes to be specified for Pipeline Placement Policy.

2023-01-09 Thread Uma Maheswara Rao G (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7227?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uma Maheswara Rao G reassigned HDDS-7227: - Assignee: (was: Swaminathan Balachandran) > EC: Implement Changed placement p

[jira] [Assigned] (HDDS-7226) EC: Implement Changed placement policy interface to allow existing nodes to be specified for Rack Aware Policy.

2023-01-09 Thread Uma Maheswara Rao G (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7226?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Uma Maheswara Rao G reassigned HDDS-7226: - Assignee: (was: Swaminathan Balachandran) > EC: Implement Changed placement p

[jira] [Created] (HDDS-7761) Over replication Handler Changes corresponding to Placement Policy Interface Change

2023-01-09 Thread Swaminathan Balachandran (Jira)
Swaminathan Balachandran created HDDS-7761: -- Summary: Over replication Handler Changes corresponding to Placement Policy Interface Change Key: HDDS-7761 URL: https://issues.apache.org/jira/browse/HDDS-776

[GitHub] [ozone] adoroszlai commented on a diff in pull request #4097: HDDS-7372. Fixing missing jars in classpath by specifying jar versions

2023-01-09 Thread GitBox
adoroszlai commented on code in PR #4097: URL: https://github.com/apache/ozone/pull/4097#discussion_r1064914666 ## pom.xml: ## @@ -1202,6 +1232,11 @@ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xs jul-to-slf4j ${slf4j.version}

[GitHub] [ozone] rohit-kb commented on pull request #4162: HDDS-7760. snakeyaml workaround due to CVE-2022-1471

2023-01-09 Thread GitBox
rohit-kb commented on PR #4162: URL: https://github.com/apache/ozone/pull/4162#issuecomment-1376012239 thanks @adoroszlai, just want to a little about the role of SafeConstructor instance in Yaml object creations. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [ozone] kerneltime commented on pull request #4044: HDDS-7517. Register OM-S3G gRPC performance metrics

2023-01-09 Thread GitBox
kerneltime commented on PR #4044: URL: https://github.com/apache/ozone/pull/4044#issuecomment-1376004321 @duongkame can you take a look again? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ozone] kerneltime commented on pull request #4161: HDDS-7753. Simplify DatanodeDetails#toString to improve log messages

2023-01-09 Thread GitBox
kerneltime commented on PR #4161: URL: https://github.com/apache/ozone/pull/4161#issuecomment-1376002515 @xBis7 can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [ozone] kerneltime commented on pull request #4129: HDDS-7650. Recon - Data Management Metrics - Understand the Age of Data.

2023-01-09 Thread GitBox
kerneltime commented on PR #4129: URL: https://github.com/apache/ozone/pull/4129#issuecomment-1375990020 @duongkame can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Updated] (HDDS-7760) snakeyaml workaround due to CVE-2022-1471

2023-01-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7760?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-7760: - Labels: pull-request-available (was: ) > snakeyaml workaround due to CVE-2022-1471 >

[GitHub] [ozone] rohit-kb opened a new pull request, #4162: HDDS-7760. snakeyaml workaround due to CVE-2022-1471

2023-01-09 Thread GitBox
rohit-kb opened a new pull request, #4162: URL: https://github.com/apache/ozone/pull/4162 ## What changes were proposed in this pull request? Finding and replacing Constructor() class of snakeyaml with SafeConstructor() due to CVE-2022-1471 ## What is the link to the Apache JIR

[jira] [Updated] (HDDS-7753) Simplify DatanodeDetails#toString to improve log messages

2023-01-09 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7753?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated HDDS-7753: - Labels: pull-request-available (was: ) > Simplify DatanodeDetails#toString to improve log message

[GitHub] [ozone] adoroszlai opened a new pull request, #4161: HDDS-7753. Simplify DatanodeDetails#toString to improve log messages

2023-01-09 Thread GitBox
adoroszlai opened a new pull request, #4161: URL: https://github.com/apache/ozone/pull/4161 ## What changes were proposed in this pull request? `DatanodeDetails#toString` outputs too much detail for it to be usable in each and every log message related to datanodes. Thus log statemen

[GitHub] [ozone] kerneltime commented on pull request #4123: HDDS-7703. Add num of datanodes metrics in ScmBlockDeletingServiceMetrics

2023-01-09 Thread GitBox
kerneltime commented on PR #4123: URL: https://github.com/apache/ozone/pull/4123#issuecomment-1375969160 @swamirishi can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[GitHub] [ozone] kerneltime commented on pull request #4145: HDDS-7590. Use keyManager and trustManager provided by keyStoreFactory in om grpc services

2023-01-09 Thread GitBox
kerneltime commented on PR #4145: URL: https://github.com/apache/ozone/pull/4145#issuecomment-1375967658 @neils-dev -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsu

[GitHub] [ozone] kerneltime commented on pull request #4150: HDDS-7719. [HTTPFSGW] Fix secure integration tests for the HttpFS module

2023-01-09 Thread GitBox
kerneltime commented on PR #4150: URL: https://github.com/apache/ozone/pull/4150#issuecomment-1375966753 @xBis7 can you take a look please? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the spe

[GitHub] [ozone] kerneltime commented on pull request #4156: HDDS-7722. FSO buckets fail to invalidate open file table cache when committing a key

2023-01-09 Thread GitBox
kerneltime commented on PR #4156: URL: https://github.com/apache/ozone/pull/4156#issuecomment-1375964403 @duongkame can you please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [ozone] kerneltime commented on pull request #4158: HDDS-6056 Recon /containers endpoint should return SCM container data instead of OM container data.

2023-01-09 Thread GitBox
kerneltime commented on PR #4158: URL: https://github.com/apache/ozone/pull/4158#issuecomment-1375961928 @dombizita @devmadhuu can you'll please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abov

[GitHub] [ozone] kerneltime commented on pull request #4160: HDDS-7705. Fix OM Bootstrap request

2023-01-09 Thread GitBox
kerneltime commented on PR #4160: URL: https://github.com/apache/ozone/pull/4160#issuecomment-1375960898 @aswinshakil @duongkame can you'll please take a look? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Created] (HDDS-7760) snakeyaml workaround due to CVE-2022-1471

2023-01-09 Thread Rohit Kumar Badeau (Jira)
Rohit Kumar Badeau created HDDS-7760: Summary: snakeyaml workaround due to CVE-2022-1471 Key: HDDS-7760 URL: https://issues.apache.org/jira/browse/HDDS-7760 Project: Apache Ozone Issue Ty

[GitHub] [ozone] xBis7 commented on a diff in pull request #4125: HDDS-7277. [Snapshot] ozone sh key list /vol1/bucket1/.snapshot/snap1 fails

2023-01-09 Thread GitBox
xBis7 commented on code in PR #4125: URL: https://github.com/apache/ozone/pull/4125#discussion_r1064866481 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/snapshot/ListSnapshotKeyHandler.java: ## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [ozone] xBis7 commented on a diff in pull request #4125: HDDS-7277. [Snapshot] ozone sh key list /vol1/bucket1/.snapshot/snap1 fails

2023-01-09 Thread GitBox
xBis7 commented on code in PR #4125: URL: https://github.com/apache/ozone/pull/4125#discussion_r1064866481 ## hadoop-ozone/tools/src/main/java/org/apache/hadoop/ozone/shell/snapshot/ListSnapshotKeyHandler.java: ## @@ -0,0 +1,80 @@ +/** + * Licensed to the Apache Software Foundat

[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #4135: HDDS-7634. Recon: Show Datanode UUID on Pipeline page

2023-01-09 Thread GitBox
smitajoshi12 commented on code in PR #4135: URL: https://github.com/apache/ozone/pull/4135#discussion_r1064863479 ## hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/pipelines/pipelines.tsx: ## @@ -111,7 +111,15 @@ const COLUMNS = [ dataIndex: '

[jira] [Updated] (HDDS-6572) EC: ReplicationManager - add move manager for container move

2023-01-09 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-6572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Rose updated HDDS-6572: - Parent Issue: HDDS-7759 (was: HDDS-6462) > EC: ReplicationManager - add move manager for container move >

[GitHub] [ozone] smitajoshi12 commented on a diff in pull request #4135: HDDS-7634. Recon: Show Datanode UUID on Pipeline page

2023-01-09 Thread GitBox
smitajoshi12 commented on code in PR #4135: URL: https://github.com/apache/ozone/pull/4135#discussion_r1064861464 ## hadoop-ozone/recon/src/main/resources/webapps/recon/ozone-recon-web/src/views/pipelines/pipelines.tsx: ## @@ -111,7 +111,15 @@ const COLUMNS = [ dataIndex: '

[jira] [Updated] (HDDS-7190) EC: ReplicationManager - consider deprecating maintenance.replica.minimum

2023-01-09 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7190?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Rose updated HDDS-7190: - Parent Issue: HDDS-7759 (was: HDDS-6462) > EC: ReplicationManager - consider deprecating maintenance.repl

[jira] [Updated] (HDDS-6447) Refine SCM handling of unhealthy container replicas

2023-01-09 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-6447?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Rose updated HDDS-6447: - Parent Issue: HDDS-7759 (was: HDDS-6548) > Refine SCM handling of unhealthy container replicas >

[jira] [Updated] (HDDS-7759) Improve Ozone Replication Manager

2023-01-09 Thread Ethan Rose (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7759?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ethan Rose updated HDDS-7759: - Description: Parent Jira to capture tasks related to migrating from Ozone's legacy replication manager to

[GitHub] [ozone] smitajoshi12 closed pull request #4092: HDDS-899. Include pipeline info and leader info in scm UI metric page

2023-01-09 Thread GitBox
smitajoshi12 closed pull request #4092: HDDS-899. Include pipeline info and leader info in scm UI metric page URL: https://github.com/apache/ozone/pull/4092 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Created] (HDDS-7759) Improve Ozone

2023-01-09 Thread Ethan Rose (Jira)
Ethan Rose created HDDS-7759: Summary: Improve Ozone Key: HDDS-7759 URL: https://issues.apache.org/jira/browse/HDDS-7759 Project: Apache Ozone Issue Type: Improvement Reporter: Ethan

[jira] [Updated] (HDDS-7755) S3G cannot acquire VOLUME_LOCK lock while holding [BUCKET_LOCK]

2023-01-09 Thread Arun Sarin (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7755?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arun Sarin updated HDDS-7755: - Description: S3G cannot acquire VOLUME_LOCK lock while holding [BUCKET_LOCK]. Log from internal tests: {c

[jira] [Assigned] (HDDS-7378) Ensure certificate hierarchy is set up properly

2023-01-09 Thread Jira
[ https://issues.apache.org/jira/browse/HDDS-7378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Szabolcs Gál reassigned HDDS-7378: -- Assignee: Szabolcs Gál (was: István Fajth) > Ensure certificate hierarchy is set up properly >

[jira] [Updated] (HDDS-899) Include pipeline info and leader info in scm UI metric page

2023-01-09 Thread Zita Dombi (Jira)
[ https://issues.apache.org/jira/browse/HDDS-899?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Zita Dombi updated HDDS-899: Resolution: Won't Fix Status: Resolved (was: Patch Available) we won't add this, [this comment|http

[GitHub] [ozone] xBis7 commented on a diff in pull request #3741: HDDS-6449. Failed container delete can leave artifacts on disk

2023-01-09 Thread GitBox
xBis7 commented on code in PR #3741: URL: https://github.com/apache/ozone/pull/3741#discussion_r1064764590 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java: ## @@ -326,6 +345,70 @@ public void createDbStore(MutableVol

[jira] [Updated] (HDDS-7726) EC: Enhance datanode reconstruction log message

2023-01-09 Thread Stephen O'Donnell (Jira)
[ https://issues.apache.org/jira/browse/HDDS-7726?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stephen O'Donnell updated HDDS-7726: Fix Version/s: 1.4.0 Resolution: Fixed Status: Resolved (was: Patch Availa

[GitHub] [ozone] xBis7 commented on a diff in pull request #3741: HDDS-6449. Failed container delete can leave artifacts on disk

2023-01-09 Thread GitBox
xBis7 commented on code in PR #3741: URL: https://github.com/apache/ozone/pull/3741#discussion_r1064751059 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/volume/HddsVolume.java: ## @@ -326,6 +345,70 @@ public void createDbStore(MutableVol

[jira] [Resolved] (HDDS-6966) EC: Handle the placement policy satisfaction in HealthChecks handling

2023-01-09 Thread Swaminathan Balachandran (Jira)
[ https://issues.apache.org/jira/browse/HDDS-6966?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Swaminathan Balachandran resolved HDDS-6966. Resolution: Duplicate > EC: Handle the placement policy satisfaction in Heal

[GitHub] [ozone] xBis7 commented on a diff in pull request #3741: HDDS-6449. Failed container delete can leave artifacts on disk

2023-01-09 Thread GitBox
xBis7 commented on code in PR #3741: URL: https://github.com/apache/ozone/pull/3741#discussion_r1064743619 ## hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/keyvalue/helpers/KeyValueContainerUtil.java: ## @@ -395,4 +413,179 @@ public static Path ge

[GitHub] [ozone] dombizita commented on pull request #4049: HDDS-4539. Container Health Task should not run until Recon has reached steady state.

2023-01-09 Thread GitBox
dombizita commented on PR #4049: URL: https://github.com/apache/ozone/pull/4049#issuecomment-1375761877 > > thanks for working on this @devmadhuu, overall it looks good to me, I just added a minor comment inline. > > @dombizita - I have pushed the change. Please re-review. I have aske

[GitHub] [ozone] adoroszlai commented on pull request #4155: HDDS-7726. EC: Enhance datanode reconstruction log message

2023-01-09 Thread GitBox
adoroszlai commented on PR #4155: URL: https://github.com/apache/ozone/pull/4155#issuecomment-1375746626 Thanks @sodonnel for reviewing and merging this. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [ozone] dombizita commented on a diff in pull request #4042: HDDS-5541. Namespace summary endpoint can carry basic information on the entity as well.

2023-01-09 Thread GitBox
dombizita commented on code in PR #4042: URL: https://github.com/apache/ozone/pull/4042#discussion_r1064686773 ## hadoop-ozone/recon/src/main/java/org/apache/hadoop/ozone/recon/api/handlers/LegacyBucketHandler.java: ## @@ -322,4 +323,11 @@ public Table getKeyTable() { g

  1   2   >