Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-17 Thread via GitHub
slfan1989 commented on PR #6960: URL: https://github.com/apache/ozone/pull/6960#issuecomment-2355378329 @ivandika3 @dombizita @smitajoshi12 Thank you very much for reviewing the code! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-17 Thread via GitHub
ivandika3 commented on PR #6960: URL: https://github.com/apache/ozone/pull/6960#issuecomment-2355165942 Thank you @slfan1989 for the improvement, @dombizita and @smitajoshi12 for the reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-17 Thread via GitHub
ivandika3 merged PR #6960: URL: https://github.com/apache/ozone/pull/6960 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@ozone.apach

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-17 Thread via GitHub
slfan1989 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1762616264 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java: ## @@ -447,6 +449,8 @@ public RegisteredCommand register( proces

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-16 Thread via GitHub
ivandika3 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1762253229 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java: ## @@ -508,6 +512,18 @@ private boolean updateDnsToUuidMap( return ipC

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-16 Thread via GitHub
ivandika3 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1762252906 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMMXBean.java: ## @@ -74,6 +75,8 @@ public interface SCMMXBean extends ServiceRuntimeInfo {

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-16 Thread via GitHub
ivandika3 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1762252093 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java: ## @@ -2131,10 +2136,69 @@ public ContainerTokenGenerator getCo

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-16 Thread via GitHub
ivandika3 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1762247773 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java: ## @@ -447,6 +449,8 @@ public RegisteredCommand register( proces

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-16 Thread via GitHub
slfan1989 commented on PR #6960: URL: https://github.com/apache/ozone/pull/6960#issuecomment-2354401522 Non-HA ![image](https://github.com/user-attachments/assets/22091a32-4026-4ecc-b1bd-8aab83066e42) HA ![image](https://github.com/user-attachments/assets/e44b3475-2

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-16 Thread via GitHub
slfan1989 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1761182477 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/SCMMXBean.java: ## @@ -74,6 +75,8 @@ public interface SCMMXBean extends ServiceRuntimeInfo {

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-16 Thread via GitHub
slfan1989 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1761175565 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java: ## @@ -508,6 +512,18 @@ private boolean updateDnsToUuidMap( return ipC

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-16 Thread via GitHub
slfan1989 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1761161476 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java: ## @@ -447,6 +449,8 @@ public RegisteredCommand register( proces

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-16 Thread via GitHub
slfan1989 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1761130233 ## hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html: ## @@ -153,6 +155,35 @@ Meta-Data Volume Information +SCM Roles (HA) +{{$ctrl.over

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-16 Thread via GitHub
ivandika3 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1760859932 ## hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html: ## @@ -153,6 +155,35 @@ Meta-Data Volume Information +SCM Roles (HA) +{{$ctrl.over

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-16 Thread via GitHub
ivandika3 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1760774709 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java: ## @@ -447,6 +449,8 @@ public RegisteredCommand register( proces

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-16 Thread via GitHub
ivandika3 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1760774709 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/node/SCMNodeManager.java: ## @@ -447,6 +449,8 @@ public RegisteredCommand register( proces

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-09-13 Thread via GitHub
slfan1989 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1759659553 ## hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html: ## @@ -153,6 +155,35 @@ Meta-Data Volume Information +SCM Roles (HA) +{{$ctrl.over

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-08-26 Thread via GitHub
slfan1989 commented on PR #6960: URL: https://github.com/apache/ozone/pull/6960#issuecomment-2310454824 @ivandika3 Thank you very much for reviewing this pr. I will work on improving the code. -- This is an automated message from the Apache Git Service. To respond to the message, please l

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-08-23 Thread via GitHub
dombizita commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1728724730 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java: ## @@ -2136,6 +2136,23 @@ public String getScmRatisRoles() {

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-07-19 Thread via GitHub
slfan1989 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1684529728 ## hadoop-hdds/server-scm/src/main/java/org/apache/hadoop/hdds/scm/server/StorageContainerManager.java: ## @@ -2136,6 +2136,23 @@ public String getScmRatisRoles() {

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-07-18 Thread via GitHub
smitajoshi12 commented on PR #6960: URL: https://github.com/apache/ozone/pull/6960#issuecomment-2238098823 Can you Highlight version UUID on screenshots and Node status screenshot is not clear can you attach clear screenshot -- This is an automated message from the Apache Git Service. To

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-07-18 Thread via GitHub
ivandika3 commented on PR #6960: URL: https://github.com/apache/ozone/pull/6960#issuecomment-2237977130 @smitajoshi12 Please help take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-07-18 Thread via GitHub
ivandika3 commented on code in PR #6960: URL: https://github.com/apache/ozone/pull/6960#discussion_r1683708446 ## hadoop-hdds/server-scm/src/main/resources/webapps/scm/scm-overview.html: ## @@ -153,6 +155,35 @@ Meta-Data Volume Information +SCM Roles (HA) +{{$ctrl.over

Re: [PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-07-17 Thread via GitHub
slfan1989 commented on PR #6960: URL: https://github.com/apache/ozone/pull/6960#issuecomment-2235600926 @adoroszlai Can you help review this pr? Thank you very much! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the

[PR] HDDS-11196. Improve SCM WebUI Display. [ozone]

2024-07-17 Thread via GitHub
slfan1989 opened a new pull request, #6960: URL: https://github.com/apache/ozone/pull/6960 ## What changes were proposed in this pull request? There are several areas in SCM WebUI that need optimization: JVM Properties display: The current display of JVM Properties as a long st