[jira] [Commented] (PHOENIX-5912) Improve code coverage for the 'org.apache.phoenix.coprocessor.tasks' package

2020-05-21 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113797#comment-17113797 ] Sandeep Guggilam commented on PHOENIX-5912: --- [~dasanjan1296] Somehow I could

[jira] [Comment Edited] (PHOENIX-5912) Improve code coverage for the 'org.apache.phoenix.coprocessor.tasks' package

2020-05-21 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113782#comment-17113782 ] Sandeep Guggilam edited comment on PHOENIX-5912 at 5/22/20, 6:40 AM:

[jira] [Commented] (PHOENIX-5912) Improve code coverage for the 'org.apache.phoenix.coprocessor.tasks' package

2020-05-21 Thread Anjan Das (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113783#comment-17113783 ] Anjan Das commented on PHOENIX-5912: [~sandeep.guggilam] I don't have the right pri

[jira] [Commented] (PHOENIX-5912) Improve code coverage for the 'org.apache.phoenix.coprocessor.tasks' package

2020-05-21 Thread Sandeep Guggilam (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113782#comment-17113782 ] Sandeep Guggilam commented on PHOENIX-5912: --- Yes [~anjan.das] feel free to a

[jira] [Commented] (PHOENIX-5910) IndexTool verification-only runs should have counters for unverified rows

2020-05-21 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113767#comment-17113767 ] Hadoop QA commented on PHOENIX-5910: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-5905) Reset user to hbase by changing rpc context before getting user permissions on access controller service

2020-05-21 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113759#comment-17113759 ] Istvan Toth commented on PHOENIX-5905: -- [~rajeshbabu] Your explanation and the c

[jira] [Commented] (PHOENIX-5912) Improve code coverage for the 'org.apache.phoenix.coprocessor.tasks' package

2020-05-21 Thread Anjan Das (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113742#comment-17113742 ] Anjan Das commented on PHOENIX-5912: [~ckulkarni] [~sandeep.guggilam] I would like

[jira] [Issue Comment Deleted] (PHOENIX-5912) Improve code coverage for the 'org.apache.phoenix.coprocessor.tasks' package

2020-05-21 Thread Anjan Das (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Anjan Das updated PHOENIX-5912: --- Comment: was deleted (was: [~ckulkarni] [~sandeep.guggilam] I would like to help with this JIRA. Ca

[jira] [Commented] (PHOENIX-5875) Optional logging for IndexTool verification

2020-05-21 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5875?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113735#comment-17113735 ] Hadoop QA commented on PHOENIX-5875: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-5912) Improve code coverage for the 'org.apache.phoenix.coprocessor.tasks' package

2020-05-21 Thread Anjan Das (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113734#comment-17113734 ] Anjan Das commented on PHOENIX-5912: [~ckulkarni] [~sandeep.guggilam] I would like

[jira] [Commented] (PHOENIX-5910) IndexTool verification-only runs should have counters for unverified rows

2020-05-21 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113721#comment-17113721 ] Hadoop QA commented on PHOENIX-5910: {color:red}-1 overall{color}. Here are the re

[jira] [Commented] (PHOENIX-5910) IndexTool verification-only runs should have counters for unverified rows

2020-05-21 Thread Kadir OZDEMIR (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113717#comment-17113717 ] Kadir OZDEMIR commented on PHOENIX-5910: I run the above failed tests locally a

[jira] [Commented] (PHOENIX-5904) Add log if the configed kerberos principal login failed

2020-05-21 Thread Guanghao Zhang (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5904?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113663#comment-17113663 ] Guanghao Zhang commented on PHOENIX-5904: - [~stoty] [~elserj] Any more comments

[jira] [Commented] (PHOENIX-5910) IndexTool verification-only runs should have counters for unverified rows

2020-05-21 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5910?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113662#comment-17113662 ] Hadoop QA commented on PHOENIX-5910: {color:red}-1 overall{color}. Here are the re

[GitHub] [phoenix] gjacoby126 opened a new pull request #786: PHOENIX-5909 - Table and index-level metrics for indexing coprocs

2020-05-21 Thread GitBox
gjacoby126 opened a new pull request #786: URL: https://github.com/apache/phoenix/pull/786 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PHOENIX-5909) Table and index-level metrics for indexing coprocs

2020-05-21 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113646#comment-17113646 ] Geoffrey Jacoby commented on PHOENIX-5909: -- [~ChinmayKulkarni], [~priyankporwa

[GitHub] [phoenix] kadirozde commented on a change in pull request #785: PHOENIX-5910 IndexTool verification-only runs should have counters fo…

2020-05-21 Thread GitBox
kadirozde commented on a change in pull request #785: URL: https://github.com/apache/phoenix/pull/785#discussion_r428975847 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java ## @@ -489,6 +490,42 @@ private boolean isDeleteFa

[GitHub] [phoenix] priyankporwal commented on a change in pull request #785: PHOENIX-5910 IndexTool verification-only runs should have counters fo…

2020-05-21 Thread GitBox
priyankporwal commented on a change in pull request #785: URL: https://github.com/apache/phoenix/pull/785#discussion_r428969459 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java ## @@ -489,6 +490,42 @@ private boolean isDele

[GitHub] [phoenix] kadirozde commented on a change in pull request #785: PHOENIX-5910 IndexTool verification-only runs should have counters fo…

2020-05-21 Thread GitBox
kadirozde commented on a change in pull request #785: URL: https://github.com/apache/phoenix/pull/785#discussion_r428968164 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java ## @@ -635,6 +672,9 @@ public boolean verifySingle

[GitHub] [phoenix] kadirozde commented on a change in pull request #785: PHOENIX-5910 IndexTool verification-only runs should have counters fo…

2020-05-21 Thread GitBox
kadirozde commented on a change in pull request #785: URL: https://github.com/apache/phoenix/pull/785#discussion_r428964187 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java ## @@ -489,6 +490,42 @@ private boolean isDeleteFa

[GitHub] [phoenix] kadirozde commented on a change in pull request #785: PHOENIX-5910 IndexTool verification-only runs should have counters fo…

2020-05-21 Thread GitBox
kadirozde commented on a change in pull request #785: URL: https://github.com/apache/phoenix/pull/785#discussion_r428964080 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java ## @@ -446,6 +458,19 @@ public void testFailPostIndexRo

[GitHub] [phoenix] kadirozde commented on a change in pull request #785: PHOENIX-5910 IndexTool verification-only runs should have counters fo…

2020-05-21 Thread GitBox
kadirozde commented on a change in pull request #785: URL: https://github.com/apache/phoenix/pull/785#discussion_r428961658 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java ## @@ -635,6 +672,9 @@ public boolean verifySingle

[GitHub] [phoenix] kadirozde commented on a change in pull request #785: PHOENIX-5910 IndexTool verification-only runs should have counters fo…

2020-05-21 Thread GitBox
kadirozde commented on a change in pull request #785: URL: https://github.com/apache/phoenix/pull/785#discussion_r428961658 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java ## @@ -635,6 +672,9 @@ public boolean verifySingle

[GitHub] [phoenix] swaroopak commented on a change in pull request #785: PHOENIX-5910 IndexTool verification-only runs should have counters fo…

2020-05-21 Thread GitBox
swaroopak commented on a change in pull request #785: URL: https://github.com/apache/phoenix/pull/785#discussion_r428958872 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java ## @@ -489,6 +490,42 @@ private boolean isDeleteFa

[GitHub] [phoenix] swaroopak commented on a change in pull request #785: PHOENIX-5910 IndexTool verification-only runs should have counters fo…

2020-05-21 Thread GitBox
swaroopak commented on a change in pull request #785: URL: https://github.com/apache/phoenix/pull/785#discussion_r428958650 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexCheckerIT.java ## @@ -446,6 +458,19 @@ public void testFailPostIndexRo

[GitHub] [phoenix] swaroopak commented on a change in pull request #785: PHOENIX-5910 IndexTool verification-only runs should have counters fo…

2020-05-21 Thread GitBox
swaroopak commented on a change in pull request #785: URL: https://github.com/apache/phoenix/pull/785#discussion_r428956248 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRebuildRegionScanner.java ## @@ -635,6 +672,9 @@ public boolean verifySingle

[jira] [Commented] (PHOENIX-5919) Add tests and improve code coverage in PhoenixConnection

2020-05-21 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5919?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113599#comment-17113599 ] Chinmay Kulkarni commented on PHOENIX-5919: --- FYI [~sandeep.guggilam] > Add t

[jira] [Commented] (PHOENIX-5918) Add testing and improve code coverage for PhoenixResultSet

2020-05-21 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5918?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113596#comment-17113596 ] Chinmay Kulkarni commented on PHOENIX-5918: --- FYI [~sandeep.guggilam] > Add t

[jira] [Commented] (PHOENIX-5917) Refactor ConnectionQueryServicesImpl and add more testing

2020-05-21 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5917?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113594#comment-17113594 ] Chinmay Kulkarni commented on PHOENIX-5917: --- FYI [~sandeep.guggilam] > Refac

[jira] [Commented] (PHOENIX-5916) Add testing and improve code coverage for ClientRpcControllerFactory and ServerRpcControllerFactory

2020-05-21 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5916?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113592#comment-17113592 ] Chinmay Kulkarni commented on PHOENIX-5916: --- FYI [~sandeep.guggilam] > Add t

[jira] [Commented] (PHOENIX-5915) Improve code coverage in the 'org.apache.phoenix.util' package

2020-05-21 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5915?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113590#comment-17113590 ] Chinmay Kulkarni commented on PHOENIX-5915: --- FYI [~sandeep.guggilam] > Impro

[jira] [Commented] (PHOENIX-5914) Add tests for UpgradeUtil and improve code coverage

2020-05-21 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5914?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113589#comment-17113589 ] Chinmay Kulkarni commented on PHOENIX-5914: --- FYI [~sandeep.guggilam]   > Ad

[jira] [Commented] (PHOENIX-5806) Add a framework to assert relevant metric values between runs of each test

2020-05-21 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5806?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113586#comment-17113586 ] Chinmay Kulkarni commented on PHOENIX-5806: --- FYI [~sandeep.guggilam] > Add a

[jira] [Commented] (PHOENIX-5913) Improve code coverage for the 'org.apache.phoenix.job' package

2020-05-21 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113582#comment-17113582 ] Chinmay Kulkarni commented on PHOENIX-5913: --- FYI [~sandeep.guggilam] > Impro

[jira] [Commented] (PHOENIX-5912) Improve code coverage for the 'org.apache.phoenix.coprocessor.tasks' package

2020-05-21 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5912?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113581#comment-17113581 ] Chinmay Kulkarni commented on PHOENIX-5912: --- FYI [~sandeep.guggilam] > Impro

[jira] [Commented] (PHOENIX-5911) Ignore generated classes in Jacoco code coverage

2020-05-21 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5911?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17113577#comment-17113577 ] Chinmay Kulkarni commented on PHOENIX-5911: --- FYI [~sandeep.guggilam] > Ignor

[GitHub] [phoenix] kadirozde opened a new pull request #785: PHOENIX-5910 IndexTool verification-only runs should have counters fo…

2020-05-21 Thread GitBox
kadirozde opened a new pull request #785: URL: https://github.com/apache/phoenix/pull/785 …r unverified rows This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [phoenix] gjacoby126 commented on a change in pull request #782: PHOENIX-5875 - Optional logging for IndexTool verification

2020-05-21 Thread GitBox
gjacoby126 commented on a change in pull request #782: URL: https://github.com/apache/phoenix/pull/782#discussion_r428815584 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/BaseScannerRegionObserver.java ## @@ -88,6 +88,8 @@ public static final Str