[jira] [Commented] (PHOENIX-5946) Implement SchemaExtractionTool utility to get effective DDL from cluster

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5946?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214441#comment-17214441 ] ASF GitHub Bot commented on PHOENIX-5946: - swaroopak opened a new pull request

[GitHub] [phoenix] swaroopak opened a new pull request #922: PHOENIX-5946 (Addendum to use slf4j logging)

2020-10-14 Thread GitBox
swaroopak opened a new pull request #922: URL: https://github.com/apache/phoenix/pull/922 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PHOENIX-6186) Store table metadata last modified timestamp in PTable / System.Catalog

2020-10-14 Thread Bharath Vissapragada (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214315#comment-17214315 ] Bharath Vissapragada commented on PHOENIX-6186: --- Makes sense to me. As fo

[jira] [Commented] (PHOENIX-6186) Store table metadata last modified timestamp in PTable / System.Catalog

2020-10-14 Thread Geoffrey Jacoby (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214299#comment-17214299 ] Geoffrey Jacoby commented on PHOENIX-6186: -- [~kadir] suggested to me yesterday

[jira] [Commented] (PHOENIX-6142) Make DDL operations resilient to orphan parent->child linking rows in SYSTEM.CHILD_LINK

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214252#comment-17214252 ] ASF GitHub Bot commented on PHOENIX-6142: - ChinmaySKulkarni commented on pull r

[GitHub] [phoenix] ChinmaySKulkarni commented on pull request #903: PHOENIX-6142: Make DDL operations resilient to orphan parent->child linking rows in SYSTEM.CHILD_LINK

2020-10-14 Thread GitBox
ChinmaySKulkarni commented on pull request #903: URL: https://github.com/apache/phoenix/pull/903#issuecomment-708638034 Thanks for the review @twdsilva! @kadirozde @gjacoby126 @jpisaac @yanxinyi as discussed offline, I have written a design doc outlining my approach: [PHOENIX-6142 Desig

[jira] [Commented] (PHOENIX-6181) IndexRepairRegionScanner to verify and repair every global index row

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214228#comment-17214228 ] ASF GitHub Bot commented on PHOENIX-6181: - kadirozde commented on a change in p

[GitHub] [phoenix] kadirozde commented on a change in pull request #915: PHOENIX-6181 IndexRepairRegionScanner to verify and repair every glob…

2020-10-14 Thread GitBox
kadirozde commented on a change in pull request #915: URL: https://github.com/apache/phoenix/pull/915#discussion_r504924842 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java ## @@ -1103,13 +1104,21 @@ private RegionSc

[jira] [Commented] (PHOENIX-6181) IndexRepairRegionScanner to verify and repair every global index row

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214225#comment-17214225 ] ASF GitHub Bot commented on PHOENIX-6181: - kadirozde commented on a change in p

[GitHub] [phoenix] kadirozde commented on a change in pull request #915: PHOENIX-6181 IndexRepairRegionScanner to verify and repair every glob…

2020-10-14 Thread GitBox
kadirozde commented on a change in pull request #915: URL: https://github.com/apache/phoenix/pull/915#discussion_r504922136 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java ## @@ -240,4 +320,1033 @@ protected boolean isColum

[GitHub] [phoenix] kadirozde commented on a change in pull request #915: PHOENIX-6181 IndexRepairRegionScanner to verify and repair every glob…

2020-10-14 Thread GitBox
kadirozde commented on a change in pull request #915: URL: https://github.com/apache/phoenix/pull/915#discussion_r504917195 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java ## @@ -240,4 +320,1033 @@ protected boolean isColum

[jira] [Commented] (PHOENIX-6181) IndexRepairRegionScanner to verify and repair every global index row

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214217#comment-17214217 ] ASF GitHub Bot commented on PHOENIX-6181: - kadirozde commented on a change in p

[jira] [Commented] (PHOENIX-6181) IndexRepairRegionScanner to verify and repair every global index row

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214214#comment-17214214 ] ASF GitHub Bot commented on PHOENIX-6181: - kadirozde commented on a change in p

[GitHub] [phoenix] kadirozde commented on a change in pull request #915: PHOENIX-6181 IndexRepairRegionScanner to verify and repair every glob…

2020-10-14 Thread GitBox
kadirozde commented on a change in pull request #915: URL: https://github.com/apache/phoenix/pull/915#discussion_r504916360 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java ## @@ -240,4 +320,1033 @@ protected boolean isColum

[jira] [Commented] (PHOENIX-6188) Jenkins job history uses too much storage

2020-10-14 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214208#comment-17214208 ] Istvan Toth commented on PHOENIX-6188: -- Pushed the reduced discard times to all jo

[jira] [Commented] (PHOENIX-6181) IndexRepairRegionScanner to verify and repair every global index row

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214204#comment-17214204 ] ASF GitHub Bot commented on PHOENIX-6181: - kadirozde commented on a change in p

[GitHub] [phoenix] kadirozde commented on a change in pull request #915: PHOENIX-6181 IndexRepairRegionScanner to verify and repair every glob…

2020-10-14 Thread GitBox
kadirozde commented on a change in pull request #915: URL: https://github.com/apache/phoenix/pull/915#discussion_r504909513 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/IndexRepairRegionScanner.java ## @@ -0,0 +1,426 @@ +/* + * Licensed to the Apache

[GitHub] [phoenix] m2je opened a new pull request #921: PHOENIX-6187 Avoid swallowing UPSERT... ON DUPLICATION KEY UPDATE failures

2020-10-14 Thread GitBox
m2je opened a new pull request #921: URL: https://github.com/apache/phoenix/pull/921 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Commented] (PHOENIX-6187) Avoid swallowing UPSERT... ON DUPLICATION KEY UPDATE failures

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17214186#comment-17214186 ] ASF GitHub Bot commented on PHOENIX-6187: - m2je opened a new pull request #921:

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213997#comment-17213997 ] ASF GitHub Bot commented on PHOENIX-6129: - richardantal commented on a change i

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213998#comment-17213998 ] ASF GitHub Bot commented on PHOENIX-6129: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-14 Thread GitBox
virajjasani commented on a change in pull request #920: URL: https://github.com/apache/phoenix/pull/920#discussion_r504760069 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4294,11 +4295,9 @@ public boolean acquireUpgr

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213996#comment-17213996 ] ASF GitHub Bot commented on PHOENIX-6129: - virajjasani commented on a change in

[GitHub] [phoenix] richardantal commented on a change in pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-14 Thread GitBox
richardantal commented on a change in pull request #920: URL: https://github.com/apache/phoenix/pull/920#discussion_r504753124 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4294,11 +4295,9 @@ public boolean acquireUpg

[GitHub] [phoenix] virajjasani commented on a change in pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-14 Thread GitBox
virajjasani commented on a change in pull request #920: URL: https://github.com/apache/phoenix/pull/920#discussion_r504759424 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4294,11 +4295,9 @@ public boolean acquireUpgr

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213994#comment-17213994 ] ASF GitHub Bot commented on PHOENIX-6129: - richardantal commented on a change i

[GitHub] [phoenix] richardantal commented on a change in pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-14 Thread GitBox
richardantal commented on a change in pull request #920: URL: https://github.com/apache/phoenix/pull/920#discussion_r504750907 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4294,11 +4295,9 @@ public boolean acquireUpg

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213991#comment-17213991 ] ASF GitHub Bot commented on PHOENIX-6129: - richardantal commented on a change i

[GitHub] [phoenix] richardantal commented on a change in pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-14 Thread GitBox
richardantal commented on a change in pull request #920: URL: https://github.com/apache/phoenix/pull/920#discussion_r504750907 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4294,11 +4295,9 @@ public boolean acquireUpg

[jira] [Commented] (PHOENIX-6172) Updating VIEW_INDEX_ID column type and ts in Syscat with a 4.16 upgrade script

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213988#comment-17213988 ] ASF GitHub Bot commented on PHOENIX-6172: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #908: PHOENIX-6172 Updating VIEW_INDEX_ID column type and ts in Syscat with…

2020-10-14 Thread GitBox
virajjasani commented on a change in pull request #908: URL: https://github.com/apache/phoenix/pull/908#discussion_r504748552 ## File path: phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ## @@ -2252,6 +2255,36 @@ public static void upgradeTable(PhoenixConne

[jira] [Issue Comment Deleted] (PHOENIX-6085) Remove duplicate calls to getSysMutexPhysicalTableNameBytes() during the upgrade path

2020-10-14 Thread Richard Antal (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Richard Antal updated PHOENIX-6085: --- Comment: was deleted (was: You have already done the rebasing, thanks.) > Remove duplicate

[jira] [Commented] (PHOENIX-6085) Remove duplicate calls to getSysMutexPhysicalTableNameBytes() during the upgrade path

2020-10-14 Thread Richard Antal (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213969#comment-17213969 ] Richard Antal commented on PHOENIX-6085: You have already done the rebasing, th

[jira] [Commented] (PHOENIX-6085) Remove duplicate calls to getSysMutexPhysicalTableNameBytes() during the upgrade path

2020-10-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213965#comment-17213965 ] Viraj Jasani commented on PHOENIX-6085: --- Sounds good (y) > Remove duplicate call

[jira] [Commented] (PHOENIX-6085) Remove duplicate calls to getSysMutexPhysicalTableNameBytes() during the upgrade path

2020-10-14 Thread Richard Antal (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213964#comment-17213964 ] Richard Antal commented on PHOENIX-6085: My patches don't cover PHOENIX-6129 fo

[jira] [Comment Edited] (PHOENIX-6085) Remove duplicate calls to getSysMutexPhysicalTableNameBytes() during the upgrade path

2020-10-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213940#comment-17213940 ] Viraj Jasani edited comment on PHOENIX-6085 at 10/14/20, 2:10 PM: ---

[jira] [Comment Edited] (PHOENIX-6085) Remove duplicate calls to getSysMutexPhysicalTableNameBytes() during the upgrade path

2020-10-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213940#comment-17213940 ] Viraj Jasani edited comment on PHOENIX-6085 at 10/14/20, 2:07 PM: ---

[jira] [Commented] (PHOENIX-6085) Remove duplicate calls to getSysMutexPhysicalTableNameBytes() during the upgrade path

2020-10-14 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6085?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213940#comment-17213940 ] Viraj Jasani commented on PHOENIX-6085: --- [~RichardAntal], sorry to bother, but do

[jira] [Commented] (PHOENIX-6124) Block adding/dropping a column on a parent view for clients <4.15 and for clients that have phoenix.allow.system.catalog.rollback=true

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6124?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213933#comment-17213933 ] ASF GitHub Bot commented on PHOENIX-6124: - virajjasani commented on pull reques

[GitHub] [phoenix] virajjasani commented on pull request #917: PHOENIX-6124 : Conditionally block adding/dropping a column on a parent view

2020-10-14 Thread GitBox
virajjasani commented on pull request #917: URL: https://github.com/apache/phoenix/pull/917#issuecomment-708421724 INFRA Jira is filed. FYI https://issues.apache.org/jira/browse/INFRA-20984 This is an automated message from t

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213877#comment-17213877 ] ASF GitHub Bot commented on PHOENIX-6129: - virajjasani commented on pull reques

[GitHub] [phoenix] virajjasani commented on pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-14 Thread GitBox
virajjasani commented on pull request #920: URL: https://github.com/apache/phoenix/pull/920#issuecomment-708372414 Since it is not allowed to mutate SYSTEM tables, providing corresponding IT test seems difficult. This is an

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-14 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17213845#comment-17213845 ] ASF GitHub Bot commented on PHOENIX-6129: - virajjasani opened a new pull reques

[GitHub] [phoenix] virajjasani opened a new pull request #920: PHOENIX-6129 : Avoid redundant Admin API call in the absence of SYSTEM.MUTEX table

2020-10-14 Thread GitBox
virajjasani opened a new pull request #920: URL: https://github.com/apache/phoenix/pull/920 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t