[jira] [Commented] (PHOENIX-6197) AggregateIT and StoreNullsIT hangs

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218739#comment-17218739 ] ASF GitHub Bot commented on PHOENIX-6197: - stoty commented on a change in pull

[GitHub] [phoenix] stoty commented on a change in pull request #933: PHOENIX-6197 AggregateIT and StoreNullsIT hangs

2020-10-21 Thread GitBox
stoty commented on a change in pull request #933: URL: https://github.com/apache/phoenix/pull/933#discussion_r509877509 ## File path: phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java ## @@ -840,10 +840,16 @@ public static void doMajorCompaction(Connection conn,

[jira] [Commented] (PHOENIX-6129) Optimize tableExists() call while retrieving correct MUTEX table

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218627#comment-17218627 ] ASF GitHub Bot commented on PHOENIX-6129: - stoty commented on pull request #920

[GitHub] [phoenix] stoty commented on pull request #920: PHOENIX-6129 : Optimize tableExists() call while retrieving correct MUTEX table

2020-10-21 Thread GitBox
stoty commented on pull request #920: URL: https://github.com/apache/phoenix/pull/920#issuecomment-713905498 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 36s | Doc

[GitHub] [phoenix] virajjasani commented on pull request #920: PHOENIX-6129 : Optimize tableExists() call while retrieving correct MUTEX table

2020-10-21 Thread GitBox
virajjasani commented on pull request #920: URL: https://github.com/apache/phoenix/pull/920#issuecomment-713828158 @ChinmaySKulkarni I have addressed your comments, updated Jira message and created Jira [PHOENIX-6203](https://issues.apache.org/jira/browse/PHOENIX-6203) for TNFE issue. C

[jira] [Commented] (PHOENIX-6129) Optimize tableExists() call while retrieving correct MUTEX table

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218543#comment-17218543 ] ASF GitHub Bot commented on PHOENIX-6129: - virajjasani commented on pull reques

[jira] [Commented] (PHOENIX-6129) Optimize tableExists() call while retrieving correct MUTEX table

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218535#comment-17218535 ] ASF GitHub Bot commented on PHOENIX-6129: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #920: PHOENIX-6129 : Optimize tableExists() call while retrieving correct MUTEX table

2020-10-21 Thread GitBox
virajjasani commented on a change in pull request #920: URL: https://github.com/apache/phoenix/pull/920#discussion_r509600822 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4364,17 +4353,17 @@ public void deleteMutexCe

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218518#comment-17218518 ] ASF GitHub Bot commented on PHOENIX-6129: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #920: PHOENIX-6129 : Optimize tableExists() call while retrieving correct MUTEX table

2020-10-21 Thread GitBox
virajjasani commented on a change in pull request #920: URL: https://github.com/apache/phoenix/pull/920#discussion_r509600822 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4364,17 +4353,17 @@ public void deleteMutexCe

[jira] [Comment Edited] (PHOENIX-6203) CQS.getTable(byte[] tableName) does not throw TNFE even if table doesn't exist

2020-10-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218501#comment-17218501 ] Viraj Jasani edited comment on PHOENIX-6203 at 10/21/20, 7:06 PM: ---

[jira] [Commented] (PHOENIX-6192) UpgradeUtil.syncUpdateCacheFreqAllIndexes() does not use tenant-specific connection to resolve tenant views

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218505#comment-17218505 ] ASF GitHub Bot commented on PHOENIX-6192: - yanxinyi commented on pull request #

[GitHub] [phoenix] yanxinyi commented on pull request #928: PHOENIX-6192 : Use tenant connection to resolve tenant views in syncUpdateCacheFreqAllIndexes()

2020-10-21 Thread GitBox
yanxinyi commented on pull request #928: URL: https://github.com/apache/phoenix/pull/928#issuecomment-713810637 @virajjasani thanks for the patch. Can you rebase and solve the conflict? This is an automated message from the

[jira] [Commented] (PHOENIX-6192) UpgradeUtil.syncUpdateCacheFreqAllIndexes() does not use tenant-specific connection to resolve tenant views

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218502#comment-17218502 ] ASF GitHub Bot commented on PHOENIX-6192: - yanxinyi commented on a change in pu

[jira] [Commented] (PHOENIX-6203) CQS.getTable(byte[] tableName) does not throw TNFE even if table doesn't exist

2020-10-21 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218501#comment-17218501 ] Viraj Jasani commented on PHOENIX-6203: --- FYI [~ckulkarni] > CQS.getTable(byte[]

[GitHub] [phoenix] yanxinyi commented on a change in pull request #928: PHOENIX-6192 : Use tenant connection to resolve tenant views in syncUpdateCacheFreqAllIndexes()

2020-10-21 Thread GitBox
yanxinyi commented on a change in pull request #928: URL: https://github.com/apache/phoenix/pull/928#discussion_r509591674 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/GlobalConnectionTenantTable2IT.java ## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache

[jira] [Commented] (PHOENIX-6192) UpgradeUtil.syncUpdateCacheFreqAllIndexes() does not use tenant-specific connection to resolve tenant views

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218471#comment-17218471 ] ASF GitHub Bot commented on PHOENIX-6192: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #928: PHOENIX-6192 : Use tenant connection to resolve tenant views in syncUpdateCacheFreqAllIndexes()

2020-10-21 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #928: URL: https://github.com/apache/phoenix/pull/928#discussion_r509507594 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/GlobalConnectionTenantTable2IT.java ## @@ -0,0 +1,216 @@ +/* + * Licensed to the

[jira] [Commented] (PHOENIX-6192) UpgradeUtil.syncUpdateCacheFreqAllIndexes() does not use tenant-specific connection to resolve tenant views

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6192?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218469#comment-17218469 ] ASF GitHub Bot commented on PHOENIX-6192: - yanxinyi commented on a change in pu

[GitHub] [phoenix] yanxinyi commented on a change in pull request #928: PHOENIX-6192 : Use tenant connection to resolve tenant views in syncUpdateCacheFreqAllIndexes()

2020-10-21 Thread GitBox
yanxinyi commented on a change in pull request #928: URL: https://github.com/apache/phoenix/pull/928#discussion_r509540735 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/GlobalConnectionTenantTable2IT.java ## @@ -0,0 +1,216 @@ +/* + * Licensed to the Apache

[jira] [Commented] (PHOENIX-6197) AggregateIT and StoreNullsIT hangs

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218464#comment-17218464 ] ASF GitHub Bot commented on PHOENIX-6197: - stoty commented on pull request #933

[GitHub] [phoenix] stoty commented on pull request #933: PHOENIX-6197 AggregateIT and StoreNullsIT hangs

2020-10-21 Thread GitBox
stoty commented on pull request #933: URL: https://github.com/apache/phoenix/pull/933#issuecomment-713758320 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 6m 14s | Doc

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218460#comment-17218460 ] ASF GitHub Bot commented on PHOENIX-6129: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #920: PHOENIX-6129 : Optimize tableExists() call while retrieving correct MUTEX table

2020-10-21 Thread GitBox
virajjasani commented on a change in pull request #920: URL: https://github.com/apache/phoenix/pull/920#discussion_r509509727 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4364,17 +4353,17 @@ public void deleteMutexCe

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218453#comment-17218453 ] ASF GitHub Bot commented on PHOENIX-6129: - ChinmaySKulkarni commented on pull r

[GitHub] [phoenix] ChinmaySKulkarni commented on pull request #920: PHOENIX-6129 : Optimize tableExists() call while retrieving correct MUTEX table

2020-10-21 Thread GitBox
ChinmaySKulkarni commented on pull request #920: URL: https://github.com/apache/phoenix/pull/920#issuecomment-713742801 @virajjasani please also make the commit message the same as the Jira (or update the Jira if you think this is more appropriate). ---

[jira] [Commented] (PHOENIX-6129) Remove unnecessary HBase admin API calls when writing and deleting mutex cells

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218452#comment-17218452 ] ASF GitHub Bot commented on PHOENIX-6129: - ChinmaySKulkarni commented on a chan

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #920: PHOENIX-6129 : Optimize tableExists() call while retrieving correct MUTEX table

2020-10-21 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #920: URL: https://github.com/apache/phoenix/pull/920#discussion_r509482018 ## File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java ## @@ -4364,17 +4353,17 @@ public void deleteMu

[jira] [Commented] (PHOENIX-6202) New column in index gets added as PK with CASCADE INDEX

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218449#comment-17218449 ] ASF GitHub Bot commented on PHOENIX-6202: - swaroopak opened a new pull request

[GitHub] [phoenix] swaroopak opened a new pull request #934: PHOENIX-6202: New column in index gets added as PK with CASCADE INDEX

2020-10-21 Thread GitBox
swaroopak opened a new pull request #934: URL: https://github.com/apache/phoenix/pull/934 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PHOENIX-6202) New column in index gets added as PK with CASCADE INDEX

2020-10-21 Thread Swaroopa Kadam (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6202?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218434#comment-17218434 ] Swaroopa Kadam commented on PHOENIX-6202: - Thank you for bringing this to the a

[jira] [Commented] (PHOENIX-6142) Make DDL operations resilient to orphan parent->child linking rows in SYSTEM.CHILD_LINK

2020-10-21 Thread Chinmay Kulkarni (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218417#comment-17218417 ] Chinmay Kulkarni commented on PHOENIX-6142: --- Thanks for the reviews [~tdsilva

[jira] [Commented] (PHOENIX-6142) Make DDL operations resilient to orphan parent->child linking rows in SYSTEM.CHILD_LINK

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6142?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218392#comment-17218392 ] ASF GitHub Bot commented on PHOENIX-6142: - ChinmaySKulkarni merged pull request

[GitHub] [phoenix] ChinmaySKulkarni merged pull request #903: PHOENIX-6142: Make DDL operations resilient to orphan parent->child linking rows in SYSTEM.CHILD_LINK

2020-10-21 Thread GitBox
ChinmaySKulkarni merged pull request #903: URL: https://github.com/apache/phoenix/pull/903 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PHOENIX-6197) AggregateIT and StoreNullsIT hangs

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218366#comment-17218366 ] ASF GitHub Bot commented on PHOENIX-6197: - stoty commented on a change in pull

[GitHub] [phoenix] stoty commented on a change in pull request #933: PHOENIX-6197 AggregateIT and StoreNullsIT hangs

2020-10-21 Thread GitBox
stoty commented on a change in pull request #933: URL: https://github.com/apache/phoenix/pull/933#discussion_r509404314 ## File path: phoenix-core/src/test/java/org/apache/phoenix/util/TestUtil.java ## @@ -840,10 +840,16 @@ public static void doMajorCompaction(Connection conn,

[jira] [Commented] (PHOENIX-6197) AggregateIT and StoreNullsIT hangs

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218345#comment-17218345 ] ASF GitHub Bot commented on PHOENIX-6197: - stoty commented on a change in pull

[GitHub] [phoenix] stoty commented on a change in pull request #933: PHOENIX-6197 AggregateIT and StoreNullsIT hangs

2020-10-21 Thread GitBox
stoty commented on a change in pull request #933: URL: https://github.com/apache/phoenix/pull/933#discussion_r509383290 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/StoreNullsIT.java ## @@ -76,6 +81,15 @@ private final String ddlFormat; priv

[jira] [Commented] (PHOENIX-6197) AggregateIT and StoreNullsIT hangs

2020-10-21 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6197?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17218310#comment-17218310 ] ASF GitHub Bot commented on PHOENIX-6197: - richardantal opened a new pull reque

[GitHub] [phoenix] richardantal opened a new pull request #933: PHOENIX-6197 AggregateIT and StoreNullsIT hangs

2020-10-21 Thread GitBox
richardantal opened a new pull request #933: URL: https://github.com/apache/phoenix/pull/933 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [phoenix] stoty commented on pull request #910: Phoenix 6144

2020-10-21 Thread GitBox
stoty commented on pull request #910: URL: https://github.com/apache/phoenix/pull/910#issuecomment-713515173 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 31s | Doc