[GitHub] [phoenix] tkhurana commented on pull request #937: PHOENIX-6198 Add option to IndexTool to specify the source table for scan

2020-10-29 Thread GitBox
tkhurana commented on pull request #937: URL: https://github.com/apache/phoenix/pull/937#issuecomment-718440351 > Having an IT that test that index table is used would be great (extra tables in index table, run IndexTool without this option see that it doesn't return anything, with this op

[jira] [Commented] (PHOENIX-6198) Add option to IndexTool to specify the source table for scan

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222753#comment-17222753 ] ASF GitHub Bot commented on PHOENIX-6198: - tkhurana commented on pull request #

[GitHub] [phoenix] virajjasani commented on pull request #945: PHOENIX-6210 Change credentials for Yetus result postback to github

2020-10-29 Thread GitBox
virajjasani commented on pull request #945: URL: https://github.com/apache/phoenix/pull/945#issuecomment-718535861 Glad to know this change is coming :) +1 (non-binding) if corresponding bot account is able to comment. Thi

[jira] [Commented] (PHOENIX-6210) Change credentials for Yetus result postback to github

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222791#comment-17222791 ] ASF GitHub Bot commented on PHOENIX-6210: - virajjasani commented on pull reques

[jira] [Commented] (PHOENIX-6002) Fix connection leaks throughout instances where we use QueryUtil.getConnectionOnServer

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222803#comment-17222803 ] ASF GitHub Bot commented on PHOENIX-6002: - virajjasani opened a new pull reques

[GitHub] [phoenix] virajjasani opened a new pull request #946: PHOENIX-6002 : Resolve connection leak through QueryUtil.getConnectionOnServer()

2020-10-29 Thread GitBox
virajjasani opened a new pull request #946: URL: https://github.com/apache/phoenix/pull/946 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[GitHub] [phoenix] stoty commented on pull request #937: PHOENIX-6198 Add option to IndexTool to specify the source table for scan

2020-10-29 Thread GitBox
stoty commented on pull request #937: URL: https://github.com/apache/phoenix/pull/937#issuecomment-718592832 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | Doc

[jira] [Commented] (PHOENIX-6198) Add option to IndexTool to specify the source table for scan

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222814#comment-17222814 ] ASF GitHub Bot commented on PHOENIX-6198: - stoty commented on pull request #937

[GitHub] [phoenix] virajjasani commented on pull request #945: PHOENIX-6210 Change credentials for Yetus result postback to github

2020-10-29 Thread GitBox
virajjasani commented on pull request #945: URL: https://github.com/apache/phoenix/pull/945#issuecomment-718658505 > try 9fa62308-3a11-4abe-a22a-b6bb63d07362 @stoty you tried this in first commit and then changed it to `683f5dcf-5552-4b28-9fb1-6a6b77cf53dd` in 2nd commit?

[jira] [Commented] (PHOENIX-6210) Change credentials for Yetus result postback to github

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222833#comment-17222833 ] ASF GitHub Bot commented on PHOENIX-6210: - virajjasani commented on pull reques

[GitHub] [phoenix] stoty commented on pull request #945: PHOENIX-6210 Change credentials for Yetus result postback to github

2020-10-29 Thread GitBox
stoty commented on pull request #945: URL: https://github.com/apache/phoenix/pull/945#issuecomment-718660567 Yes, I tested 4 different credentials, but none of them worked :( This is an automated message from the Apache Git S

[jira] [Commented] (PHOENIX-6210) Change credentials for Yetus result postback to github

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222836#comment-17222836 ] ASF GitHub Bot commented on PHOENIX-6210: - stoty commented on pull request #945

[GitHub] [phoenix] virajjasani commented on pull request #945: PHOENIX-6210 Change credentials for Yetus result postback to github

2020-10-29 Thread GitBox
virajjasani commented on pull request #945: URL: https://github.com/apache/phoenix/pull/945#issuecomment-718662986 Sad, message is still same :( ``` Could not update commit status, please check if your scan credentials belong to a member of the organization or a collaborator of th

[jira] [Commented] (PHOENIX-6210) Change credentials for Yetus result postback to github

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222838#comment-17222838 ] ASF GitHub Bot commented on PHOENIX-6210: - virajjasani commented on pull reques

[jira] [Commented] (PHOENIX-6207) Paged server side grouped aggregate operations

2020-10-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222837#comment-17222837 ] Hadoop QA commented on PHOENIX-6207: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [phoenix] virajjasani edited a comment on pull request #945: PHOENIX-6210 Change credentials for Yetus result postback to github

2020-10-29 Thread GitBox
virajjasani edited a comment on pull request #945: URL: https://github.com/apache/phoenix/pull/945#issuecomment-718662986 Sad, message is still same in the recent successful build result :( ``` Could not update commit status, please check if your scan credentials belong to a membe

[jira] [Commented] (PHOENIX-6210) Change credentials for Yetus result postback to github

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6210?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222839#comment-17222839 ] ASF GitHub Bot commented on PHOENIX-6210: - virajjasani edited a comment on pull

[GitHub] [phoenix] stoty commented on pull request #946: PHOENIX-6002 : Resolve connection leak through QueryUtil.getConnectionOnServer()

2020-10-29 Thread GitBox
stoty commented on pull request #946: URL: https://github.com/apache/phoenix/pull/946#issuecomment-718716960 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 4m 14s | Doc

[jira] [Commented] (PHOENIX-6002) Fix connection leaks throughout instances where we use QueryUtil.getConnectionOnServer

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222861#comment-17222861 ] ASF GitHub Bot commented on PHOENIX-6002: - stoty commented on pull request #946

[jira] [Commented] (PHOENIX-6091) Calling MetaDataProtocol.getVersion() on a 4.16 timestamp gives version as 4.15.x

2020-10-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6091?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222906#comment-17222906 ] Hadoop QA commented on PHOENIX-6091: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [phoenix] virajjasani commented on pull request #942: PHOENIX-6179 : Relax maxLookBackAge check during an upgrade

2020-10-29 Thread GitBox
virajjasani commented on pull request #942: URL: https://github.com/apache/phoenix/pull/942#issuecomment-718861130 FYI @yanxinyi This is an automated message from the Apache Git Service. To respond to the message, please log

[jira] [Commented] (PHOENIX-6179) Relax the MaxLookBack age checks during an upgrade

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17222995#comment-17222995 ] ASF GitHub Bot commented on PHOENIX-6179: - virajjasani commented on pull reques

[GitHub] [phoenix] kadirozde opened a new pull request #947: PHOENIX-6207 Paged server side grouped aggregate operations

2020-10-29 Thread GitBox
kadirozde opened a new pull request #947: URL: https://github.com/apache/phoenix/pull/947 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[jira] [Commented] (PHOENIX-6207) Paged server side grouped aggregate operations

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223074#comment-17223074 ] ASF GitHub Bot commented on PHOENIX-6207: - kadirozde opened a new pull request

[GitHub] [phoenix] virajjasani opened a new pull request #948: PHOENIX-6126 : All createViewAddChildLink requests should go to corresponding region of SYSTEM.CHILD_LINK

2020-10-29 Thread GitBox
virajjasani opened a new pull request #948: URL: https://github.com/apache/phoenix/pull/948 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above t

[jira] [Commented] (PHOENIX-6126) All createViewAddChildLink requests will go to the same region of SYSTEM.CHILD_LINK

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223146#comment-17223146 ] ASF GitHub Bot commented on PHOENIX-6126: - virajjasani opened a new pull reques

[jira] [Commented] (PHOENIX-6207) Paged server side grouped aggregate operations

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223209#comment-17223209 ] ASF GitHub Bot commented on PHOENIX-6207: - stoty commented on pull request #947

[GitHub] [phoenix] stoty commented on pull request #947: PHOENIX-6207 Paged server side grouped aggregate operations

2020-10-29 Thread GitBox
stoty commented on pull request #947: URL: https://github.com/apache/phoenix/pull/947#issuecomment-719021108 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 14s | Doc

[GitHub] [phoenix] priyankporwal commented on a change in pull request #937: PHOENIX-6198 Add option to IndexTool to specify the source table for scan

2020-10-29 Thread GitBox
priyankporwal commented on a change in pull request #937: URL: https://github.com/apache/phoenix/pull/937#discussion_r514594621 ## File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java ## @@ -660,6 +663,19 @@ public static String

[jira] [Commented] (PHOENIX-6198) Add option to IndexTool to specify the source table for scan

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223243#comment-17223243 ] ASF GitHub Bot commented on PHOENIX-6198: - priyankporwal commented on a change

[GitHub] [phoenix] tkhurana commented on a change in pull request #937: PHOENIX-6198 Add option to IndexTool to specify the source table for scan

2020-10-29 Thread GitBox
tkhurana commented on a change in pull request #937: URL: https://github.com/apache/phoenix/pull/937#discussion_r514599687 ## File path: phoenix-core/src/main/java/org/apache/phoenix/mapreduce/util/PhoenixConfigurationUtil.java ## @@ -660,6 +663,19 @@ public static String get

[jira] [Commented] (PHOENIX-6198) Add option to IndexTool to specify the source table for scan

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223248#comment-17223248 ] ASF GitHub Bot commented on PHOENIX-6198: - tkhurana commented on a change in pu

[jira] [Commented] (PHOENIX-6126) All createViewAddChildLink requests will go to the same region of SYSTEM.CHILD_LINK

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6126?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223252#comment-17223252 ] ASF GitHub Bot commented on PHOENIX-6126: - stoty commented on pull request #948

[GitHub] [phoenix] stoty commented on pull request #948: PHOENIX-6126 : All createViewAddChildLink requests should go to corresponding region of SYSTEM.CHILD_LINK

2020-10-29 Thread GitBox
stoty commented on pull request #948: URL: https://github.com/apache/phoenix/pull/948#issuecomment-719059910 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 5m 21s | Doc

[jira] [Commented] (PHOENIX-6186) Store table metadata last modified timestamp in PTable / System.Catalog

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223283#comment-17223283 ] ASF GitHub Bot commented on PHOENIX-6186: - stoty commented on pull request #935

[GitHub] [phoenix] stoty commented on pull request #935: PHOENIX-6186 - Store last DDL timestamp in System.Catalog

2020-10-29 Thread GitBox
stoty commented on pull request #935: URL: https://github.com/apache/phoenix/pull/935#issuecomment-719090292 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 38s | Doc

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223289#comment-17223289 ] ASF GitHub Bot commented on PHOENIX-6032: - ChinmaySKulkarni opened a new pull r

[GitHub] [phoenix] ChinmaySKulkarni opened a new pull request #949: PHOENIX-6032: When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

2020-10-29 Thread GitBox
ChinmaySKulkarni opened a new pull request #949: URL: https://github.com/apache/phoenix/pull/949 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [phoenix] ChinmaySKulkarni commented on pull request #949: PHOENIX-6032: When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

2020-10-29 Thread GitBox
ChinmaySKulkarni commented on pull request #949: URL: https://github.com/apache/phoenix/pull/949#issuecomment-719102066 Please review @yanxinyi @jpisaac @gjacoby126 @twdsilva This is an automated message from the Apache Git

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223291#comment-17223291 ] ASF GitHub Bot commented on PHOENIX-6032: - ChinmaySKulkarni commented on pull r

[jira] [Commented] (PHOENIX-6171) Child views should not be allowed to override the parent view PHOENIX_TTL attribute.

2020-10-29 Thread Jacob Isaac (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223338#comment-17223338 ] Jacob Isaac commented on PHOENIX-6171: -- [~yanxinyi] [~ChinmayKulkarni] The offendi

[GitHub] [phoenix] yanxinyi commented on a change in pull request #942: PHOENIX-6179 : Relax maxLookBackAge check during an upgrade

2020-10-29 Thread GitBox
yanxinyi commented on a change in pull request #942: URL: https://github.com/apache/phoenix/pull/942#discussion_r514719933 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java ## @@ -437,8 +472,17 @@ public void run() { } /

[jira] [Commented] (PHOENIX-6179) Relax the MaxLookBack age checks during an upgrade

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223344#comment-17223344 ] ASF GitHub Bot commented on PHOENIX-6179: - yanxinyi commented on a change in pu

[GitHub] [phoenix] yanxinyi commented on a change in pull request #942: PHOENIX-6179 : Relax maxLookBackAge check during an upgrade

2020-10-29 Thread GitBox
yanxinyi commented on a change in pull request #942: URL: https://github.com/apache/phoenix/pull/942#discussion_r514721760 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java ## @@ -437,8 +472,17 @@ public void run() { } /

[jira] [Commented] (PHOENIX-6179) Relax the MaxLookBack age checks during an upgrade

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223346#comment-17223346 ] ASF GitHub Bot commented on PHOENIX-6179: - yanxinyi commented on a change in pu

[GitHub] [phoenix] yanxinyi commented on a change in pull request #943: PHOENIX-6087 : Resolve Phoenix Connection leak in UpgradeUtil.addViewIndexToParentLinks() and Admin leak in UpgradeUtil.syncTabl

2020-10-29 Thread GitBox
yanxinyi commented on a change in pull request #943: URL: https://github.com/apache/phoenix/pull/943#discussion_r514726107 ## File path: phoenix-core/src/main/java/org/apache/phoenix/util/UpgradeUtil.java ## @@ -1211,36 +1213,56 @@ public static void addViewIndexToParentLinks(

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

2020-10-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223349#comment-17223349 ] Hadoop QA commented on PHOENIX-6032: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[jira] [Commented] (PHOENIX-6087) Phoenix Connection leak in UpgradeUtil.addViewIndexToParentLinks()

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6087?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223350#comment-17223350 ] ASF GitHub Bot commented on PHOENIX-6087: - yanxinyi commented on a change in pu

[GitHub] [phoenix] yanxinyi commented on a change in pull request #949: PHOENIX-6032: When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

2020-10-29 Thread GitBox
yanxinyi commented on a change in pull request #949: URL: https://github.com/apache/phoenix/pull/949#discussion_r514738269 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogRollbackEnabledIT.java ## @@ -0,0 +1,271 @@ +/* + * Licensed to the Apache

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223358#comment-17223358 ] ASF GitHub Bot commented on PHOENIX-6032: - yanxinyi commented on a change in pu

[GitHub] [phoenix] yanxinyi commented on a change in pull request #949: PHOENIX-6032: When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

2020-10-29 Thread GitBox
yanxinyi commented on a change in pull request #949: URL: https://github.com/apache/phoenix/pull/949#discussion_r514740510 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogRollbackEnabledIT.java ## @@ -0,0 +1,271 @@ +/* + * Licensed to the Apache

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223361#comment-17223361 ] ASF GitHub Bot commented on PHOENIX-6032: - yanxinyi commented on a change in pu

[GitHub] [phoenix] ChinmaySKulkarni commented on a change in pull request #949: PHOENIX-6032: When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

2020-10-29 Thread GitBox
ChinmaySKulkarni commented on a change in pull request #949: URL: https://github.com/apache/phoenix/pull/949#discussion_r514753994 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemCatalogRollbackEnabledIT.java ## @@ -0,0 +1,271 @@ +/* + * Licensed to the

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223375#comment-17223375 ] ASF GitHub Bot commented on PHOENIX-6032: - ChinmaySKulkarni commented on a chan

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223398#comment-17223398 ] ASF GitHub Bot commented on PHOENIX-6032: - stoty commented on pull request #949

[GitHub] [phoenix] stoty commented on pull request #949: PHOENIX-6032: When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

2020-10-29 Thread GitBox
stoty commented on pull request #949: URL: https://github.com/apache/phoenix/pull/949#issuecomment-719158406 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 1m 5s | Doc

[GitHub] [phoenix] yanxinyi opened a new pull request #950: PHOENIX-5940 Pre-4.15 client cannot connect to 4.15+ server after SYS…

2020-10-29 Thread GitBox
yanxinyi opened a new pull request #950: URL: https://github.com/apache/phoenix/pull/950 …TEM.CATALOG region has split This is an automated message from the Apache Git Service. To respond to the message, please log on to GitH

[jira] [Commented] (PHOENIX-5940) Pre-4.15 client cannot connect to 4.15+ server after SYSTEM.CATALOG region has split

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223399#comment-17223399 ] ASF GitHub Bot commented on PHOENIX-5940: - yanxinyi opened a new pull request #

[jira] [Commented] (PHOENIX-6032) When phoenix.allow.system.catalog.rollback=true, a view still sees data from a column that was dropped

2020-10-29 Thread Hadoop QA (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223416#comment-17223416 ] Hadoop QA commented on PHOENIX-6032: | (x) *{color:red}-1 overall{color}* | \\ \\ |

[GitHub] [phoenix] virajjasani commented on a change in pull request #950: PHOENIX-5940 Pre-4.15 client cannot connect to 4.15+ server after SYS…

2020-10-29 Thread GitBox
virajjasani commented on a change in pull request #950: URL: https://github.com/apache/phoenix/pull/950#discussion_r514890776 ## File path: phoenix-core/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java ## @@ -3295,11 +3295,14 @@ public void getVersion(Rpc

[jira] [Commented] (PHOENIX-5940) Pre-4.15 client cannot connect to 4.15+ server after SYSTEM.CATALOG region has split

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223433#comment-17223433 ] ASF GitHub Bot commented on PHOENIX-5940: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #942: PHOENIX-6179 : Relax maxLookBackAge check during an upgrade

2020-10-29 Thread GitBox
virajjasani commented on a change in pull request #942: URL: https://github.com/apache/phoenix/pull/942#discussion_r514894140 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java ## @@ -437,8 +472,17 @@ public void run() { }

[jira] [Commented] (PHOENIX-6179) Relax the MaxLookBack age checks during an upgrade

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223436#comment-17223436 ] ASF GitHub Bot commented on PHOENIX-6179: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #942: PHOENIX-6179 : Relax maxLookBackAge check during an upgrade

2020-10-29 Thread GitBox
virajjasani commented on a change in pull request #942: URL: https://github.com/apache/phoenix/pull/942#discussion_r514894983 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/BackwardCompatibilityIT.java ## @@ -437,8 +472,17 @@ public void run() { }

[jira] [Commented] (PHOENIX-6179) Relax the MaxLookBack age checks during an upgrade

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6179?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223440#comment-17223440 ] ASF GitHub Bot commented on PHOENIX-6179: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on pull request #946: PHOENIX-6002 : Resolve connection leak through QueryUtil.getConnectionOnServer()

2020-10-29 Thread GitBox
virajjasani commented on pull request #946: URL: https://github.com/apache/phoenix/pull/946#issuecomment-719315804 Thanks for the review @yanxinyi , I have uploaded both master and 4.x patches on Jira. This is an automated m

[jira] [Commented] (PHOENIX-6002) Fix connection leaks throughout instances where we use QueryUtil.getConnectionOnServer

2020-10-29 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17223458#comment-17223458 ] ASF GitHub Bot commented on PHOENIX-6002: - virajjasani commented on pull reques