stoty closed pull request #984:
URL: https://github.com/apache/phoenix/pull/984
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
[
https://issues.apache.org/jira/browse/PHOENIX-6231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238014#comment-17238014
]
ASF GitHub Bot commented on PHOENIX-6231:
-
stoty closed pull request #984:
URL:
[
https://issues.apache.org/jira/browse/PHOENIX-5057?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238025#comment-17238025
]
Istvan Toth commented on PHOENIX-5057:
--
I suggest that we close this, as we do not
[
https://issues.apache.org/jira/browse/PHOENIX-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238031#comment-17238031
]
Istvan Toth commented on PHOENIX-4524:
--
I agree that this is a good a idea, but I
[
https://issues.apache.org/jira/browse/PHOENIX-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238045#comment-17238045
]
Istvan Toth commented on PHOENIX-4524:
--
I agree that this would be beneficial, but
[
https://issues.apache.org/jira/browse/PHOENIX-4524?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Istvan Toth updated PHOENIX-4524:
-
Comment: was deleted
(was: I agree that this would be beneficial, but
I don't think that this
[
https://issues.apache.org/jira/browse/PHOENIX-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238059#comment-17238059
]
chenglei commented on PHOENIX-6010:
---
[~stoty]. why it is not applied to 4.x? Not appl
[
https://issues.apache.org/jira/browse/PHOENIX-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238062#comment-17238062
]
Hadoop QA commented on PHOENIX-6211:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-732952029
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 1m 23s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238097#comment-17238097
]
ASF GitHub Bot commented on PHOENIX-6211:
-
stoty commented on pull request #973
[
https://issues.apache.org/jira/browse/PHOENIX-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238104#comment-17238104
]
Istvan Toth commented on PHOENIX-6010:
--
It was not applied, because it's not stric
[
https://issues.apache.org/jira/browse/PHOENIX-6010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238109#comment-17238109
]
Istvan Toth commented on PHOENIX-6010:
--
Opened a discuss thread on the mailing lis
stoty commented on pull request #39:
URL: https://github.com/apache/phoenix-connectors/pull/39#issuecomment-732971437
(!) A patch to the testing environment has been detected.
Re-executing against the patched versions to perform further tests.
The console is at
https://ci-hadoop.apa
[
https://issues.apache.org/jira/browse/PHOENIX-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238119#comment-17238119
]
ASF GitHub Bot commented on PHOENIX-6180:
-
stoty commented on pull request #39:
[
https://issues.apache.org/jira/browse/PHOENIX-6137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238137#comment-17238137
]
Istvan Toth commented on PHOENIX-6137:
--
Omid update is done.
> Update Omid to 1.0
richardantal closed pull request #35:
URL: https://github.com/apache/phoenix-connectors/pull/35
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL abo
[
https://issues.apache.org/jira/browse/PHOENIX-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238159#comment-17238159
]
ASF GitHub Bot commented on PHOENIX-6180:
-
richardantal closed pull request #35
stoty commented on pull request #39:
URL: https://github.com/apache/phoenix-connectors/pull/39#issuecomment-733060793
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 3
[
https://issues.apache.org/jira/browse/PHOENIX-6180?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238227#comment-17238227
]
ASF GitHub Bot commented on PHOENIX-6180:
-
stoty commented on pull request #39:
gokceni commented on pull request #986:
URL: https://github.com/apache/phoenix/pull/986#issuecomment-733128022
@kadirozde @swaroopak @ChinmaySKulkarni @gjacoby126 @tkhurana
This is an automated message from the Apache Git Se
[
https://issues.apache.org/jira/browse/PHOENIX-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238277#comment-17238277
]
ASF GitHub Bot commented on PHOENIX-6120:
-
gokceni commented on pull request #9
dbwong commented on pull request #775:
URL: https://github.com/apache/phoenix/pull/775#issuecomment-733166764
Updated @ChinmaySKulkarni @gjacoby126 for master changes please review i'll
update the patch on the jira as well. @sakshamgangwar fyi for master path for
your follow up jira as we
[
https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238313#comment-17238313
]
ASF GitHub Bot commented on PHOENIX-5872:
-
dbwong commented on pull request #77
[
https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238321#comment-17238321
]
Hadoop QA commented on PHOENIX-5872:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|
dbwong commented on pull request #767:
URL: https://github.com/apache/phoenix/pull/767#issuecomment-733180207
Trying this again, this is critical imo for at least 4.16 since we missed
4.15 We had discussed this offline and had verbal agreement on the approach
months ago. @ChinmaySKulka
stoty commented on pull request #775:
URL: https://github.com/apache/phoenix/pull/775#issuecomment-733180362
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 5m 16s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238327#comment-17238327
]
ASF GitHub Bot commented on PHOENIX-5872:
-
stoty commented on pull request #775
[
https://issues.apache.org/jira/browse/PHOENIX-5833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238326#comment-17238326
]
ASF GitHub Bot commented on PHOENIX-5833:
-
dbwong commented on pull request #76
[
https://issues.apache.org/jira/browse/PHOENIX-6233?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238329#comment-17238329
]
Hadoop QA commented on PHOENIX-6233:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|
tkhurana closed pull request #968:
URL: https://github.com/apache/phoenix/pull/968
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to t
[
https://issues.apache.org/jira/browse/PHOENIX-6198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238352#comment-17238352
]
ASF GitHub Bot commented on PHOENIX-6198:
-
tkhurana closed pull request #968:
U
stoty commented on pull request #986:
URL: https://github.com/apache/phoenix/pull/986#issuecomment-733239460
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 6m 26s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-6120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238382#comment-17238382
]
ASF GitHub Bot commented on PHOENIX-6120:
-
stoty commented on pull request #986
[
https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238395#comment-17238395
]
Hadoop QA commented on PHOENIX-5872:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|
tkhurana commented on pull request #958:
URL: https://github.com/apache/phoenix/pull/958#issuecomment-733360744
@gokceni @kadirozde @swaroopak
This is an automated message from the Apache Git Service.
To respond to the messa
[
https://issues.apache.org/jira/browse/PHOENIX-6199?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238420#comment-17238420
]
ASF GitHub Bot commented on PHOENIX-6199:
-
tkhurana commented on pull request #
ChinmaySKulkarni commented on a change in pull request #972:
URL: https://github.com/apache/phoenix/pull/972#discussion_r528968696
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/filter/SyscatViewIndexIdFilter.java
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apach
[
https://issues.apache.org/jira/browse/PHOENIX-5872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238428#comment-17238428
]
Hadoop QA commented on PHOENIX-5872:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|
ChinmaySKulkarni commented on pull request #972:
URL: https://github.com/apache/phoenix/pull/972#issuecomment-733394782
Had a quick glance and added some review comments. As discussed offline,
please add more comments based on various `if/else` conditions for when we do
the conversion vs.
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238429#comment-17238429
]
ASF GitHub Bot commented on PHOENIX-5712:
-
ChinmaySKulkarni commented on a chan
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238430#comment-17238430
]
ASF GitHub Bot commented on PHOENIX-5712:
-
ChinmaySKulkarni commented on pull r
ChinmaySKulkarni commented on a change in pull request #972:
URL: https://github.com/apache/phoenix/pull/972#discussion_r530041005
##
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIndexIdRetrieveIT.java
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache S
ChinmaySKulkarni edited a comment on pull request #972:
URL: https://github.com/apache/phoenix/pull/972#issuecomment-733394782
Had a quick glance and added some review comments. As discussed offline,
please add more comments based on various `if/else` conditions for when we do
the conversi
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238442#comment-17238442
]
ASF GitHub Bot commented on PHOENIX-5712:
-
ChinmaySKulkarni edited a comment on
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238441#comment-17238441
]
ASF GitHub Bot commented on PHOENIX-5712:
-
ChinmaySKulkarni commented on a chan
stoty commented on pull request #978:
URL: https://github.com/apache/phoenix/pull/978#issuecomment-733434254
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 33s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-6213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238478#comment-17238478
]
ASF GitHub Bot commented on PHOENIX-6213:
-
stoty commented on pull request #978
yanxinyi commented on a change in pull request #972:
URL: https://github.com/apache/phoenix/pull/972#discussion_r530083783
##
File path:
phoenix-core/src/it/java/org/apache/phoenix/end2end/ViewIndexIdRetrieveIT.java
##
@@ -0,0 +1,169 @@
+/*
+ * Licensed to the Apache Software
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238480#comment-17238480
]
ASF GitHub Bot commented on PHOENIX-5712:
-
yanxinyi commented on a change in pu
yanxinyi commented on a change in pull request #972:
URL: https://github.com/apache/phoenix/pull/972#discussion_r530084220
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/SyscatRegionObserver.java
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Softw
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238482#comment-17238482
]
ASF GitHub Bot commented on PHOENIX-5712:
-
yanxinyi commented on a change in pu
yanxinyi commented on a change in pull request #972:
URL: https://github.com/apache/phoenix/pull/972#discussion_r530085070
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/SyscatRegionObserver.java
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Softw
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238484#comment-17238484
]
ASF GitHub Bot commented on PHOENIX-5712:
-
yanxinyi commented on a change in pu
yanxinyi commented on a change in pull request #972:
URL: https://github.com/apache/phoenix/pull/972#discussion_r530100936
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/filter/SyscatViewIndexIdFilter.java
##
@@ -0,0 +1,131 @@
+/*
+ * Licensed to the Apache Softwa
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238502#comment-17238502
]
ASF GitHub Bot commented on PHOENIX-5712:
-
yanxinyi commented on a change in pu
yanxinyi commented on a change in pull request #972:
URL: https://github.com/apache/phoenix/pull/972#discussion_r530084220
##
File path:
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/SyscatRegionObserver.java
##
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Softw
[
https://issues.apache.org/jira/browse/PHOENIX-5712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238503#comment-17238503
]
ASF GitHub Bot commented on PHOENIX-5712:
-
yanxinyi commented on a change in pu
[
https://issues.apache.org/jira/browse/PHOENIX-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238567#comment-17238567
]
Hadoop QA commented on PHOENIX-6211:
| (x) *{color:red}-1 overall{color}* |
\\
\\
|
stoty commented on pull request #973:
URL: https://github.com/apache/phoenix/pull/973#issuecomment-733523095
:broken_heart: **-1 overall**
| Vote | Subsystem | Runtime | Comment |
|::|--:|:|:|
| +0 :ok: | reexec | 0m 39s | Doc
[
https://issues.apache.org/jira/browse/PHOENIX-6211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17238575#comment-17238575
]
ASF GitHub Bot commented on PHOENIX-6211:
-
stoty commented on pull request #973
60 matches
Mail list logo