[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271920#comment-17271920 ] ASF GitHub Bot commented on PHOENIX-5296: - stoty commented on a change in pull

[GitHub] [phoenix] stoty commented on a change in pull request #1097: PHOENIX-5296 : refCount leak checks

2021-01-25 Thread GitBox
stoty commented on a change in pull request #1097: URL: https://github.com/apache/phoenix/pull/1097#discussion_r564288734 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemTablesCreationOnConnectionIT.java ## @@ -81,27 +88,27 @@ private static final

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271917#comment-17271917 ] ASF GitHub Bot commented on PHOENIX-5296: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #1097: PHOENIX-5296 : refCount leak checks

2021-01-25 Thread GitBox
virajjasani commented on a change in pull request #1097: URL: https://github.com/apache/phoenix/pull/1097#discussion_r564287947 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemTablesCreationOnConnectionIT.java ## @@ -81,27 +88,27 @@ private static

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271914#comment-17271914 ] ASF GitHub Bot commented on PHOENIX-5296: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #1097: PHOENIX-5296 : refCount leak checks

2021-01-25 Thread GitBox
virajjasani commented on a change in pull request #1097: URL: https://github.com/apache/phoenix/pull/1097#discussion_r564287329 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemTablesCreationOnConnectionIT.java ## @@ -81,27 +88,27 @@ private static

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271913#comment-17271913 ] ASF GitHub Bot commented on PHOENIX-5296: - stoty commented on a change in pull

[GitHub] [phoenix] stoty commented on a change in pull request #1097: PHOENIX-5296 : refCount leak checks

2021-01-25 Thread GitBox
stoty commented on a change in pull request #1097: URL: https://github.com/apache/phoenix/pull/1097#discussion_r564286071 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemTablesCreationOnConnectionIT.java ## @@ -81,27 +88,27 @@ private static final

[jira] [Commented] (PHOENIX-6339) Older client using aggregate queries shows incorrect results.

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271903#comment-17271903 ] ASF GitHub Bot commented on PHOENIX-6339: - kadirozde opened a new pull request

[GitHub] [phoenix] kadirozde opened a new pull request #1111: PHOENIX-6339 Older client using aggregate queries shows incorrect res…

2021-01-25 Thread GitBox
kadirozde opened a new pull request #: URL: https://github.com/apache/phoenix/pull/ …ults This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271891#comment-17271891 ] ASF GitHub Bot commented on PHOENIX-5296: - stoty commented on a change in pull

[GitHub] [phoenix] stoty commented on a change in pull request #1097: PHOENIX-5296 : refCount leak checks

2021-01-25 Thread GitBox
stoty commented on a change in pull request #1097: URL: https://github.com/apache/phoenix/pull/1097#discussion_r564252606 ## File path: phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexAsyncThresholdIT.java ## @@ -69,51 +70,52 @@ private final boolean overTh

[jira] [Commented] (PHOENIX-6339) Older client using aggregate queries shows incorrect results.

2021-01-25 Thread Viraj Jasani (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271890#comment-17271890 ] Viraj Jasani commented on PHOENIX-6339: --- Splitting/Merging regions while testing

[GitHub] [phoenix] stoty commented on pull request #1096: PHOENIX-5296 : refCount leak checks

2021-01-25 Thread GitBox
stoty commented on pull request #1096: URL: https://github.com/apache/phoenix/pull/1096#issuecomment-766756455 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 2s | D

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271872#comment-17271872 ] ASF GitHub Bot commented on PHOENIX-5296: - stoty commented on pull request #109

[jira] [Commented] (PHOENIX-6338) TxCheckpointIT frequently hangs on 4.x

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271866#comment-17271866 ] ASF GitHub Bot commented on PHOENIX-6338: - stoty closed pull request #1108: URL

[GitHub] [phoenix] stoty closed pull request #1108: PHOENIX-6338 TxCheckpointIT frequently hangs on 4.x

2021-01-25 Thread GitBox
stoty closed pull request #1108: URL: https://github.com/apache/phoenix/pull/1108 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271861#comment-17271861 ] ASF GitHub Bot commented on PHOENIX-5296: - virajjasani commented on a change in

[GitHub] [phoenix] virajjasani commented on a change in pull request #1096: PHOENIX-5296 : refCount leak checks

2021-01-25 Thread GitBox
virajjasani commented on a change in pull request #1096: URL: https://github.com/apache/phoenix/pull/1096#discussion_r563507218 ## File path: phoenix-hbase-compat-2.3.0/pom.xml ## @@ -97,6 +97,18 @@ ${hbase23.compat.version} provided + + org.slf4j +

[jira] [Commented] (PHOENIX-6273) Add support to handle MR Snapshot restore externally

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271858#comment-17271858 ] ASF GitHub Bot commented on PHOENIX-6273: - gjacoby126 merged pull request #1110

[GitHub] [phoenix] gjacoby126 merged pull request #1110: PHOENIX-6273: Add support to handle MR Snapshot restore externally

2021-01-25 Thread GitBox
gjacoby126 merged pull request #1110: URL: https://github.com/apache/phoenix/pull/1110 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (PHOENIX-6273) Add support to handle MR Snapshot restore externally

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271854#comment-17271854 ] ASF GitHub Bot commented on PHOENIX-6273: - sakshamgangwar opened a new pull req

[jira] [Commented] (PHOENIX-6338) TxCheckpointIT frequently hangs on 4.x

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271830#comment-17271830 ] ASF GitHub Bot commented on PHOENIX-6338: - stoty commented on pull request #110

[GitHub] [phoenix] stoty commented on pull request #1109: PHOENIX-6338 Lots of TxCheckpointIT hangs on 4.x

2021-01-25 Thread GitBox
stoty commented on pull request #1109: URL: https://github.com/apache/phoenix/pull/1109#issuecomment-766562710 > @stoty how come [unit](https://ci-hadoop.apache.org/job/Phoenix/job/Phoenix-PreCommit-GitHub-PR/job/PR-1109/1/artifact/yetus-general-check/output/patch-unit-phoenix-core.txt) di

[jira] [Commented] (PHOENIX-6273) Add support to handle MR Snapshot restore externally

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271827#comment-17271827 ] ASF GitHub Bot commented on PHOENIX-6273: - stoty commented on pull request #111

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271828#comment-17271828 ] ASF GitHub Bot commented on PHOENIX-5296: - stoty commented on a change in pull

[GitHub] [phoenix] stoty commented on a change in pull request #1096: PHOENIX-5296 : refCount leak checks

2021-01-25 Thread GitBox
stoty commented on a change in pull request #1096: URL: https://github.com/apache/phoenix/pull/1096#discussion_r563503258 ## File path: phoenix-hbase-compat-2.3.0/pom.xml ## @@ -97,6 +97,18 @@ ${hbase23.compat.version} provided + + org.slf4j +

[GitHub] [phoenix] stoty commented on pull request #1110: PHOENIX-6273: Add support to handle MR Snapshot restore externally

2021-01-25 Thread GitBox
stoty commented on pull request #1110: URL: https://github.com/apache/phoenix/pull/1110#issuecomment-767024052 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and us

[jira] [Commented] (PHOENIX-6338) TxCheckpointIT frequently hangs on 4.x

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271816#comment-17271816 ] ASF GitHub Bot commented on PHOENIX-6338: - stoty closed pull request #1109: URL

[GitHub] [phoenix] stoty closed pull request #1109: PHOENIX-6338 TxCheckpointIT frequently hangs on 4.x

2021-01-25 Thread GitBox
stoty closed pull request #1109: URL: https://github.com/apache/phoenix/pull/1109 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271810#comment-17271810 ] ASF GitHub Bot commented on PHOENIX-5296: - virajjasani commented on pull reques

[GitHub] [phoenix] virajjasani commented on pull request #1096: PHOENIX-5296 : refCount leak checks

2021-01-25 Thread GitBox
virajjasani commented on pull request #1096: URL: https://github.com/apache/phoenix/pull/1096#issuecomment-766599332 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271795#comment-17271795 ] ASF GitHub Bot commented on PHOENIX-5296: - stoty commented on pull request #109

[GitHub] [phoenix] stoty commented on pull request #1097: PHOENIX-5296 : refCount leak checks

2021-01-25 Thread GitBox
stoty commented on pull request #1097: URL: https://github.com/apache/phoenix/pull/1097#issuecomment-766369929 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 35s | D

[jira] [Commented] (PHOENIX-6339) Older client using aggregate queries shows incorrect results.

2021-01-25 Thread Jacob Isaac (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6339?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271690#comment-17271690 ] Jacob Isaac commented on PHOENIX-6339: -- [~kadir] [~yanxinyi] [~ChinmayKulkarni] [~

[jira] [Commented] (PHOENIX-6273) Add support to handle MR Snapshot restore externally

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271681#comment-17271681 ] ASF GitHub Bot commented on PHOENIX-6273: - gjacoby126 merged pull request #1110

[GitHub] [phoenix] gjacoby126 merged pull request #1110: PHOENIX-6273: Add support to handle MR Snapshot restore externally

2021-01-25 Thread GitBox
gjacoby126 merged pull request #1110: URL: https://github.com/apache/phoenix/pull/1110 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[jira] [Commented] (PHOENIX-6273) Add support to handle MR Snapshot restore externally

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271680#comment-17271680 ] ASF GitHub Bot commented on PHOENIX-6273: - stoty commented on pull request #111

[GitHub] [phoenix] stoty commented on pull request #1110: PHOENIX-6273: Add support to handle MR Snapshot restore externally

2021-01-25 Thread GitBox
stoty commented on pull request #1110: URL: https://github.com/apache/phoenix/pull/1110#issuecomment-767118308 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 32s | D

[jira] [Commented] (PHOENIX-6273) Add support to handle MR Snapshot restore externally

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271596#comment-17271596 ] ASF GitHub Bot commented on PHOENIX-6273: - stoty commented on pull request #111

[GitHub] [phoenix] stoty commented on pull request #1110: PHOENIX-6273: Add support to handle MR Snapshot restore externally

2021-01-25 Thread GitBox
stoty commented on pull request #1110: URL: https://github.com/apache/phoenix/pull/1110#issuecomment-767024052 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 0m 30s | D

[jira] [Commented] (PHOENIX-6273) Add support to handle MR Snapshot restore externally

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-6273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271383#comment-17271383 ] ASF GitHub Bot commented on PHOENIX-6273: - sakshamgangwar opened a new pull req

[GitHub] [phoenix] sakshamgangwar opened a new pull request #1110: PHOENIX-6273: Add support to handle MR Snapshot restore externally

2021-01-25 Thread GitBox
sakshamgangwar opened a new pull request #1110: URL: https://github.com/apache/phoenix/pull/1110 https://issues.apache.org/jira/browse/PHOENIX-6273 This is an automated message from the Apache Git Service. To respond to the m

[GitHub] [phoenix] virajjasani commented on pull request #1096: PHOENIX-5296 : refCount leak checks

2021-01-25 Thread GitBox
virajjasani commented on pull request #1096: URL: https://github.com/apache/phoenix/pull/1096#issuecomment-766776720 @stoty Thanks for the suggestion, i have updated PR for `hbase-compat` modules to get rid of guava dependency. Any other suggestions you have in mind? -

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271275#comment-17271275 ] ASF GitHub Bot commented on PHOENIX-5296: - virajjasani commented on pull reques

[jira] [Commented] (PHOENIX-5296) Ensure store file reader refcount is zero at end of relevant unit tests

2021-01-25 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-5296?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17271263#comment-17271263 ] ASF GitHub Bot commented on PHOENIX-5296: - stoty commented on pull request #109

[GitHub] [phoenix] stoty commented on pull request #1096: PHOENIX-5296 : refCount leak checks

2021-01-25 Thread GitBox
stoty commented on pull request #1096: URL: https://github.com/apache/phoenix/pull/1096#issuecomment-766756455 :broken_heart: **-1 overall** | Vote | Subsystem | Runtime | Comment | |::|--:|:|:| | +0 :ok: | reexec | 2m 2s | D