[
https://issues.apache.org/jira/browse/PHOENIX-7088?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780585#comment-17780585
]
Istvan Toth commented on PHOENIX-7088:
--
It also maintains a resultSets list, but P
[
https://issues.apache.org/jira/browse/PHOENIX-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780564#comment-17780564
]
ASF GitHub Bot commented on PHOENIX-7032:
-
kadirozde commented on code in PR #1
[
https://issues.apache.org/jira/browse/PHOENIX-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780565#comment-17780565
]
ASF GitHub Bot commented on PHOENIX-7032:
-
kadirozde commented on code in PR #1
kadirozde commented on code in PR #1701:
URL: https://github.com/apache/phoenix/pull/1701#discussion_r1375126319
##
phoenix-core/src/test/java/org/apache/phoenix/compile/WhereCompilerTest.java:
##
@@ -1026,4 +1029,81 @@ public void testScanCaching_CustomFetchSizeOnStatement()
t
kadirozde commented on code in PR #1701:
URL: https://github.com/apache/phoenix/pull/1701#discussion_r1375126212
##
phoenix-core/src/test/java/org/apache/phoenix/compile/WhereCompilerTest.java:
##
@@ -1026,4 +1029,81 @@ public void testScanCaching_CustomFetchSizeOnStatement()
t
[
https://issues.apache.org/jira/browse/PHOENIX-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780558#comment-17780558
]
ASF GitHub Bot commented on PHOENIX-7032:
-
tkhurana commented on code in PR #17
tkhurana commented on code in PR #1701:
URL: https://github.com/apache/phoenix/pull/1701#discussion_r1375110733
##
phoenix-core/src/test/java/org/apache/phoenix/compile/WhereCompilerTest.java:
##
@@ -1026,4 +1029,81 @@ public void testScanCaching_CustomFetchSizeOnStatement()
th
[
https://issues.apache.org/jira/browse/PHOENIX-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780557#comment-17780557
]
ASF GitHub Bot commented on PHOENIX-7032:
-
tkhurana commented on code in PR #17
tkhurana commented on code in PR #1701:
URL: https://github.com/apache/phoenix/pull/1701#discussion_r1375107341
##
phoenix-core/src/test/java/org/apache/phoenix/compile/WhereCompilerTest.java:
##
@@ -1026,4 +1029,81 @@ public void testScanCaching_CustomFetchSizeOnStatement()
th
[
https://issues.apache.org/jira/browse/PHOENIX-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780545#comment-17780545
]
ASF GitHub Bot commented on PHOENIX-7032:
-
kadirozde commented on code in PR #1
kadirozde commented on code in PR #1701:
URL: https://github.com/apache/phoenix/pull/1701#discussion_r1375086094
##
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateIndexCompiler.java:
##
@@ -17,24 +17,38 @@
*/
package org.apache.phoenix.compile;
-import java.sql
[
https://issues.apache.org/jira/browse/PHOENIX-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780546#comment-17780546
]
ASF GitHub Bot commented on PHOENIX-7032:
-
kadirozde commented on code in PR #1
[
https://issues.apache.org/jira/browse/PHOENIX-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780543#comment-17780543
]
ASF GitHub Bot commented on PHOENIX-7032:
-
kadirozde commented on code in PR #1
kadirozde commented on code in PR #1701:
URL: https://github.com/apache/phoenix/pull/1701#discussion_r1375086255
##
phoenix-core/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java:
##
@@ -197,17 +199,41 @@ private List getApplicablePlans(QueryPlan
dataPlan, PhoenixSt
[
https://issues.apache.org/jira/browse/PHOENIX-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780544#comment-17780544
]
ASF GitHub Bot commented on PHOENIX-7032:
-
kadirozde commented on code in PR #1
[
https://issues.apache.org/jira/browse/PHOENIX-7032?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780542#comment-17780542
]
ASF GitHub Bot commented on PHOENIX-7032:
-
kadirozde commented on code in PR #1
kadirozde commented on code in PR #1701:
URL: https://github.com/apache/phoenix/pull/1701#discussion_r1375085983
##
phoenix-core/src/main/java/org/apache/phoenix/coprocessor/GlobalIndexRegionScanner.java:
##
@@ -1330,24 +1345,43 @@ public static List
prepareIndexMutationsForReb
kadirozde commented on code in PR #1701:
URL: https://github.com/apache/phoenix/pull/1701#discussion_r1375085888
##
phoenix-core/src/main/java/org/apache/phoenix/compile/CreateIndexCompiler.java:
##
@@ -45,11 +59,92 @@ public CreateIndexCompiler(PhoenixStatement statement,
Oper
kadirozde commented on code in PR #1701:
URL: https://github.com/apache/phoenix/pull/1701#discussion_r1375083564
##
phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialIndexIT.java:
##
@@ -0,0 +1,479 @@
+/*
Review Comment:
Done
##
phoenix-core/src/mai
virajjasani commented on PR #1697:
URL: https://github.com/apache/phoenix/pull/1697#issuecomment-1783491101
> FYI, we are resuming this effort on #1724 The latest revision has all
tests passing
sorry for the confusion, i meant to create that PR only to check how many
cases need fixes
[
https://issues.apache.org/jira/browse/PHOENIX-7004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780521#comment-17780521
]
ASF GitHub Bot commented on PHOENIX-7004:
-
virajjasani commented on PR #1697:
U
[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780513#comment-17780513
]
ASF GitHub Bot commented on PHOENIX-7038:
-
mihir6692 commented on PR #1682:
URL
mihir6692 commented on PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#issuecomment-1783400093
> I am in general very wary of overriding HBase properties from a Phoenix
application, as this can very easily lead to failures for properties that must
be in sync across the cluster fo
virajjasani commented on PR #1658:
URL: https://github.com/apache/phoenix/pull/1658#issuecomment-1783383195
we need rebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
T
[
https://issues.apache.org/jira/browse/PHOENIX-6523?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780510#comment-17780510
]
ASF GitHub Bot commented on PHOENIX-6523:
-
virajjasani commented on PR #1658:
U
[
https://issues.apache.org/jira/browse/PHOENIX-7004?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780504#comment-17780504
]
ASF GitHub Bot commented on PHOENIX-7004:
-
virajjasani commented on PR #1724:
U
virajjasani commented on PR #1724:
URL: https://github.com/apache/phoenix/pull/1724#issuecomment-1783362587
> @virajjasani Thinking what changed from this PR #1697 ?
this is the main diff:
```
public static void verifyKeyInScanRange(ImmutableBytesWritable ptr,
[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780480#comment-17780480
]
ASF GitHub Bot commented on PHOENIX-7038:
-
mihir6692 commented on PR #1682:
URL
mihir6692 commented on PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#issuecomment-1783251091
> My main concern is this is too sfdc focused. A conection profile doesn't
exist within the concept space of phoenix. I'd rebrand this as ConnectionInfo
metrics.
That's right. I
[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780479#comment-17780479
]
ASF GitHub Bot commented on PHOENIX-7038:
-
mihir6692 commented on code in PR #1
mihir6692 commented on code in PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#discussion_r1374848007
##
phoenix-core/src/main/java/org/apache/phoenix/monitoring/PhoenixConnectionProfileMetric.java:
##
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundatio
[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780478#comment-17780478
]
ASF GitHub Bot commented on PHOENIX-7038:
-
mihir6692 commented on code in PR #1
mihir6692 commented on code in PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#discussion_r1374847551
##
phoenix-core/src/main/java/org/apache/phoenix/monitoring/connqueryservice/ConnectionQueryServiceMetricsHistograms.java:
##
@@ -0,0 +1,60 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/PHOENIX-7070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780477#comment-17780477
]
ASF GitHub Bot commented on PHOENIX-7070:
-
virajjasani merged PR #1723:
URL: ht
virajjasani merged PR #1723:
URL: https://github.com/apache/phoenix/pull/1723
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@phoenix
mihir6692 commented on code in PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#discussion_r1374844085
##
phoenix-core/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java:
##
@@ -28,6 +28,10 @@
import static
org.apache.phoenix.query.QueryServices.CLIENT_
mihir6692 commented on code in PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#discussion_r1374843398
##
phoenix-core/src/main/java/org/apache/phoenix/monitoring/connqueryservice/PhoenixConnectionQueryServiceMetrics.java:
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the A
[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780474#comment-17780474
]
ASF GitHub Bot commented on PHOENIX-7038:
-
mihir6692 commented on code in PR #1
[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780475#comment-17780475
]
ASF GitHub Bot commented on PHOENIX-7038:
-
mihir6692 commented on code in PR #1
[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780473#comment-17780473
]
ASF GitHub Bot commented on PHOENIX-7038:
-
mihir6692 commented on code in PR #1
[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780476#comment-17780476
]
ASF GitHub Bot commented on PHOENIX-7038:
-
mihir6692 commented on code in PR #1
mihir6692 commented on code in PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#discussion_r1374843852
##
phoenix-core/src/test/java/org/apache/phoenix/monitoring/connqueryservice/ConnectionQueryServiceNameMetricsGenerateAndVerifyTestData.java:
##
@@ -0,0 +1,82 @@
+/**
mihir6692 commented on code in PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#discussion_r1374843652
##
phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServices.java:
##
@@ -221,4 +221,8 @@ default void closeAllConnections(SQLExceptionInfo.Builder
[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780471#comment-17780471
]
ASF GitHub Bot commented on PHOENIX-7038:
-
mihir6692 commented on code in PR #1
[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780472#comment-17780472
]
ASF GitHub Bot commented on PHOENIX-7038:
-
mihir6692 commented on code in PR #1
mihir6692 commented on code in PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#discussion_r1374843109
##
phoenix-core/src/main/java/org/apache/phoenix/monitoring/connqueryservice/PhoenixConnectionQueryServiceMetrics.java:
##
@@ -0,0 +1,116 @@
+/*
+ * Licensed to the A
mihir6692 commented on code in PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#discussion_r1374842870
##
phoenix-core/src/main/java/org/apache/phoenix/monitoring/connqueryservice/ConnectionQueryServicesMetricsManager.java:
##
@@ -0,0 +1,375 @@
+/*
+ * Licensed to the
mihir6692 commented on code in PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#discussion_r1374840685
##
phoenix-core/src/main/java/org/apache/phoenix/monitoring/connqueryservice/ConnectionQueryServicesMetricsManager.java:
##
@@ -0,0 +1,375 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780469#comment-17780469
]
ASF GitHub Bot commented on PHOENIX-7038:
-
mihir6692 commented on code in PR #1
[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780467#comment-17780467
]
ASF GitHub Bot commented on PHOENIX-7038:
-
mihir6692 commented on code in PR #1
[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780466#comment-17780466
]
ASF GitHub Bot commented on PHOENIX-7038:
-
mihir6692 commented on code in PR #1
mihir6692 commented on code in PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#discussion_r1374839769
##
phoenix-core/src/main/java/org/apache/phoenix/monitoring/connqueryservice/ConnectionQueryServicesMetricsManager.java:
##
@@ -0,0 +1,375 @@
+/*
+ * Licensed to the
mihir6692 commented on code in PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#discussion_r1374839499
##
phoenix-core/src/main/java/org/apache/phoenix/monitoring/connqueryservice/ConnectionQueryServicesMetricsManager.java:
##
@@ -0,0 +1,375 @@
+/*
+ * Licensed to the
[
https://issues.apache.org/jira/browse/PHOENIX-7038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17780465#comment-17780465
]
ASF GitHub Bot commented on PHOENIX-7038:
-
mihir6692 commented on code in PR #1
mihir6692 commented on code in PR #1682:
URL: https://github.com/apache/phoenix/pull/1682#discussion_r1374838430
##
phoenix-core/src/main/java/org/apache/phoenix/monitoring/connqueryservice/ConnectionQueryServicesMetricsManager.java:
##
@@ -0,0 +1,375 @@
+/*
+ * Licensed to the
NihalJain commented on PR #148:
URL: https://github.com/apache/phoenix-omid/pull/148#issuecomment-1782645463
Tested following:
- Ran checkstyle and ensured checkstyle errors are seen and report is saved
- Ran mvn pmd:pmd and verified no build fail
- Ran run-coverage.sh and verified c
NihalJain opened a new pull request, #148:
URL: https://github.com/apache/phoenix-omid/pull/148
- Bump apache parent pom version to 30
- Remove maven-assembly-plugin-version and surefire.version as it is coming
from parent pom
- Bump following plugins/dependencies
- os.plugin.vers
57 matches
Mail list logo
