Re: [PR] PHOENIX-7605 Adding ability to configure threadpool at CQSI level [phoenix]

2025-05-16 Thread via GitHub
ritegarg commented on PR #2138: URL: https://github.com/apache/phoenix/pull/2138#issuecomment-2887940575 @virajjasani https://github.com/apache/phoenix/pull/2158/files https://github.com/apache/phoenix/pull/2159/files -- This is an automated message from the Apache Git Service. To r

[PR] PHOENIX-7605 Addendum Using interface ClusterConnection as ConnectionImplementation is not public in hbase2.4 [phoenix]

2025-05-16 Thread via GitHub
ritegarg opened a new pull request, #2159: URL: https://github.com/apache/phoenix/pull/2159 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

[PR] PHOENIX-7605 Using interface ClusterConnection as ConnectionImplementation is not public in hbase2.4 [phoenix]

2025-05-16 Thread via GitHub
ritegarg opened a new pull request, #2158: URL: https://github.com/apache/phoenix/pull/2158 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] PHOENIX-7614 : Fix atomic update return result with case sensitive table name [phoenix]

2025-05-16 Thread via GitHub
virajjasani merged PR #2157: URL: https://github.com/apache/phoenix/pull/2157 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix

Re: [PR] PHOENIX-7605 Adding ability to configure threadpool at CQSI level [phoenix]

2025-05-16 Thread via GitHub
virajjasani commented on PR #2138: URL: https://github.com/apache/phoenix/pull/2138#issuecomment-2887863117 @ritegarg this PR has broken HBase 2.4 profile build: ``` 10:37:47 [INFO] 10:37:47 [INFO] BUILD

[PR] PHOENIX-7614 : Fix atomic update return result with case sensitive table name [phoenix]

2025-05-16 Thread via GitHub
palashc opened a new pull request, #2157: URL: https://github.com/apache/phoenix/pull/2157 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [PR] PHOENIX-7612 Fix Cell references in IndexRegionObserver [phoenix]

2025-05-16 Thread via GitHub
tkhurana commented on PR #2154: URL: https://github.com/apache/phoenix/pull/2154#issuecomment-2887591777 There are some test failures, looking at it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

Re: [PR] PHOENIX-7612 Fix Cell references in IndexRegionObserver [phoenix]

2025-05-16 Thread via GitHub
virajjasani commented on code in PR #2154: URL: https://github.com/apache/phoenix/pull/2154#discussion_r2093508276 ## phoenix-core-client/src/main/java/org/apache/phoenix/util/MutationUtil.java: ## @@ -0,0 +1,63 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under o

Re: [PR] PHOENIX-7612 Fix Cell references in IndexRegionObserver [phoenix]

2025-05-16 Thread via GitHub
tkhurana commented on code in PR #2154: URL: https://github.com/apache/phoenix/pull/2154#discussion_r2093507692 ## phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java: ## @@ -910,7 +911,12 @@ private void applyPendingPutMutations(MiniBatchO

Re: [PR] PHOENIX-7612 Fix Cell references in IndexRegionObserver [phoenix]

2025-05-16 Thread via GitHub
virajjasani commented on code in PR #2154: URL: https://github.com/apache/phoenix/pull/2154#discussion_r2093502009 ## phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java: ## @@ -910,7 +911,12 @@ private void applyPendingPutMutations(MiniBat

Re: [PR] PHOENIX-7605 (Addendum) Fixing unit test mocking [phoenix]

2025-05-16 Thread via GitHub
palashc merged PR #2155: URL: https://github.com/apache/phoenix/pull/2155 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apa

Re: [PR] PHOENIX-7605 (Addendum) Fixing unit test mocking [phoenix]

2025-05-16 Thread via GitHub
palashc merged PR #2156: URL: https://github.com/apache/phoenix/pull/2156 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.apa

Re: [PR] PHOENIX-7358 Upsert select result wrong when use order by in query [phoenix]

2025-05-16 Thread via GitHub
sanjeet006py commented on PR #2148: URL: https://github.com/apache/phoenix/pull/2148#issuecomment-2887261051 > we realized that the test case is not written correctly. You are inserting multiple rows in a batch which means HBase will assign the same timestamp for all these cells. When query

Re: [PR] PHOENIX-7358 Upsert select result wrong when use order by in query [phoenix]

2025-05-16 Thread via GitHub
sanjeet006py commented on PR #2148: URL: https://github.com/apache/phoenix/pull/2148#issuecomment-2887226741 > I think it is the real reasonwe could disscuss and confirm it~ @chaijunjie0101 yes, I also think so. I think the bug will get triggered if server side upsert select happe

Re: [PR] PHOENIX-7612 Fix Cell references in IndexRegionObserver [phoenix]

2025-05-16 Thread via GitHub
tkhurana commented on code in PR #2154: URL: https://github.com/apache/phoenix/pull/2154#discussion_r2093348948 ## phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java: ## @@ -910,7 +911,12 @@ private void applyPendingPutMutations(MiniBatchO

Re: [PR] PHOENIX-7612 Fix Cell references in IndexRegionObserver [phoenix]

2025-05-16 Thread via GitHub
tkhurana commented on code in PR #2154: URL: https://github.com/apache/phoenix/pull/2154#discussion_r2093337298 ## phoenix-core-client/src/main/java/org/apache/phoenix/util/IndexUtil.java: ## @@ -856,6 +856,40 @@ public static void removeEmptyColumn(Mutation m, byte[] emptyCF,