Re: [PR] OMID-318 Don't add Apache Snapshot Maven Repo by Default [phoenix-omid]

2025-08-05 Thread via GitHub
stoty merged PR #199: URL: https://github.com/apache/phoenix-omid/pull/199 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@phoenix.ap

Re: [PR] PHOENIX-7651 Support RETURNING * with UPSERT and DELETE [phoenix]

2025-08-05 Thread via GitHub
virajjasani commented on code in PR #2226: URL: https://github.com/apache/phoenix/pull/2226#discussion_r2255821004 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKey2IT.java: ## @@ -591,8 +598,8 @@ private static void validateReturnedRowBeforeUpsert(Connectio

Re: [PR] PHOENIX-7651 Support RETURNING * with UPSERT and DELETE [phoenix]

2025-08-05 Thread via GitHub
virajjasani commented on code in PR #2226: URL: https://github.com/apache/phoenix/pull/2226#discussion_r2255820130 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKey2IT.java: ## @@ -591,8 +598,8 @@ private static void validateReturnedRowBeforeUpsert(Connectio

Re: [PR] PHOENIX-7651 Support RETURNING * with UPSERT and DELETE [phoenix]

2025-08-05 Thread via GitHub
haridsv commented on code in PR #2226: URL: https://github.com/apache/phoenix/pull/2226#discussion_r2255816615 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKey2IT.java: ## @@ -591,8 +598,8 @@ private static void validateReturnedRowBeforeUpsert(Connection co

Re: [PR] PHOENIX-7651 Support RETURNING * with UPSERT and DELETE [phoenix]

2025-08-05 Thread via GitHub
haridsv commented on code in PR #2226: URL: https://github.com/apache/phoenix/pull/2226#discussion_r2255814260 ## phoenix-core-client/src/main/java/org/apache/phoenix/util/TupleUtil.java: ## @@ -226,14 +226,16 @@ public static int write(Tuple result, DataOutput out) throws IOEx

Re: [PR] Phoenix-7651: Support RETURNING * with UPSERT and DELETE [phoenix]

2025-08-05 Thread via GitHub
virajjasani commented on code in PR #2226: URL: https://github.com/apache/phoenix/pull/2226#discussion_r2255278869 ## phoenix-core-client/src/main/java/org/apache/phoenix/util/TupleUtil.java: ## @@ -226,14 +226,16 @@ public static int write(Tuple result, DataOutput out) throws

Re: [PR] Phoenix-7651: Support RETURNING * with UPSERT and DELETE [phoenix]

2025-08-05 Thread via GitHub
virajjasani commented on code in PR #2226: URL: https://github.com/apache/phoenix/pull/2226#discussion_r2255236274 ## phoenix-core/src/it/java/org/apache/phoenix/end2end/OnDuplicateKey2IT.java: ## @@ -591,8 +598,8 @@ private static void validateReturnedRowBeforeUpsert(Connectio

Re: [PR] PHOENIX-7582 Accept phoenix.skip.system.tables.existence.check from h… [phoenix]

2025-08-05 Thread via GitHub
meszinorbi commented on PR #2229: URL: https://github.com/apache/phoenix/pull/2229#issuecomment-3155081893 I've added the IT, but another used the SkipSystemTablesExistenceCheckIT name which is rather a result iterator check, so I renamed it. -- This is an automated message from the Apach

[jira] [Commented] (PHOENIX-7685) 5.1 tests are very broken, especially with HBase 2.5

2025-08-05 Thread Istvan Toth (Jira)
[ https://issues.apache.org/jira/browse/PHOENIX-7685?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=18012107#comment-18012107 ] Istvan Toth commented on PHOENIX-7685: -- Mockito needs to be updated and the HBase

Re: [PR] PHOENIX-7613 Update Apache parent pom to 31 [phoenix]

2025-08-05 Thread via GitHub
stoty commented on PR #2172: URL: https://github.com/apache/phoenix/pull/2172#issuecomment-3154063857 I had to clean up some dependencies to satisfy the new maven-dependency-plugin. Please tak another look @NihalJain @richardantal -- This is an automated message from the Apache Git Se