Re: [PR] main: Update medyagh/setup-minikube action to v0.0.19 [polaris]

2025-04-16 Thread via GitHub
github-actions[bot] closed pull request #1162: main: Update medyagh/setup-minikube action to v0.0.19 URL: https://github.com/apache/polaris/pull/1162 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2047507382 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -0,0 +1,184 @@ +/* + *

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1353: URL: https://github.com/apache/polaris/pull/1353#discussion_r2047887344 ## spec/polaris-management-service.yml: ## @@ -1089,6 +1089,10 @@ components: clientId: type: string description: The output-only OAuth c

Re: [PR] [JDBC] Part3: Plumb JDBC module to quarkus [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1371: URL: https://github.com/apache/polaris/pull/1371#discussion_r2047785450 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -171,6 +181,20 @@ publi

Re: [PR] Allow BasePolarisTableOperations to skip refreshing metadata after a commit [polaris]

2025-04-16 Thread via GitHub
eric-maynard commented on code in PR #1378: URL: https://github.com/apache/polaris/pull/1378#discussion_r2047933494 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -1328,6 +1344,25 @@ public void doCommit(TableMetadata base,

Re: [PR] Allow BasePolarisTableOperations to skip refreshing metadata after a commit [polaris]

2025-04-16 Thread via GitHub
eric-maynard commented on code in PR #1378: URL: https://github.com/apache/polaris/pull/1378#discussion_r2047907227 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -1328,6 +1346,41 @@ public void doCommit(TableMetadata base,

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1353: URL: https://github.com/apache/polaris/pull/1353#discussion_r2047877788 ## polaris-core/src/main/java/org/apache/polaris/core/entity/PrincipalRoleEntity.java: ## @@ -65,6 +65,13 @@ public Builder(PrincipalRoleEntity original) { super

Re: [PR] Replace authentication filters with Quarkus Security [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1373: URL: https://github.com/apache/polaris/pull/1373#discussion_r2047771949 ## quarkus/service/src/main/java/org/apache/polaris/service/quarkus/auth/ActiveRolesAugmentor.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundati

Re: [PR] [JDBC] Part3: Plumb JDBC module to quarkus [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1371: URL: https://github.com/apache/polaris/pull/1371#discussion_r2048008152 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java: ## @@ -45,14 +46,15

Re: [PR] Allow BasePolarisTableOperations to skip refreshing metadata after a commit [polaris]

2025-04-16 Thread via GitHub
eric-maynard commented on code in PR #1378: URL: https://github.com/apache/polaris/pull/1378#discussion_r2047909097 ## polaris-core/src/main/java/org/apache/polaris/core/config/BehaviorChangeConfiguration.java: ## @@ -59,4 +59,13 @@ protected BehaviorChangeConfiguration(

Re: [D] Unable to find chart repo [polaris]

2025-04-16 Thread via GitHub
GitHub user aj-hadrian closed a discussion: Unable to find chart repo Is the cart hosted in any sort of repo? Im automating deployment and having some issues here. GitHub link: https://github.com/apache/polaris/discussions/1385 This is an automatically sent email for issues@polaris.apach

Re: [PR] main: Update medyagh/setup-minikube action to v0.0.19 [polaris]

2025-04-16 Thread via GitHub
forking-renovate[bot] commented on PR #1162: URL: https://github.com/apache/polaris/pull/1162#issuecomment-2811539717 ### Renovate Ignore Notification Because you closed this PR without merging, Renovate will ignore this update (`v0.0.19`). You will get a PR once a newer version is re

Re: [PR] Add Polaris synchronization and migration tool to polaris-tools. [polaris-tools]

2025-04-16 Thread via GitHub
mansehajsingh commented on code in PR #4: URL: https://github.com/apache/polaris-tools/pull/4#discussion_r2048003974 ## polaris-synchronizer/README.md: ## @@ -0,0 +1,162 @@ +# Objective + +To provide users of [Apache Polaris (Incubating)](https://github.com/apache/polaris) a to

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2048063806 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/IdGenerator.java: ## @@ -0,0 +1,44 @@ +/* + * License

Re: [PR] Allow BasePolarisTableOperations to skip refreshing metadata after a commit [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1378: URL: https://github.com/apache/polaris/pull/1378#discussion_r2048013301 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -1328,6 +1383,21 @@ public void doCommit(TableMetadata base, Table

Re: [PR] Implement PolicyCatalogHandler and Add Policy Privileges Stage 1: CRUD + ListPolicies [polaris]

2025-04-16 Thread via GitHub
HonahX commented on code in PR #1357: URL: https://github.com/apache/polaris/pull/1357#discussion_r2047912023 ## service/common/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalogHandler.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Foundat

Re: [PR] Push Docker Images on New Release [polaris]

2025-04-16 Thread via GitHub
adnanhemani commented on PR #1377: URL: https://github.com/apache/polaris/pull/1377#issuecomment-2811471803 > I propose to wait after 0.10.0-beta-incubating release as I will push the image as part of the release last step. I'm okay with this but wanted to make sure - wouldn't it be e

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1353: URL: https://github.com/apache/polaris/pull/1353#discussion_r2047887344 ## spec/polaris-management-service.yml: ## @@ -1089,6 +1089,10 @@ components: clientId: type: string description: The output-only OAuth c

Re: [PR] Push Docker Images on New Release [polaris]

2025-04-16 Thread via GitHub
adnanhemani commented on code in PR #1377: URL: https://github.com/apache/polaris/pull/1377#discussion_r2048030302 ## .github/workflows/publish-docker.yml: ## @@ -0,0 +1,71 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreeme

Re: [PR] Allow BasePolarisTableOperations to skip refreshing metadata after a commit [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1378: URL: https://github.com/apache/polaris/pull/1378#discussion_r2047938788 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -1328,6 +1344,25 @@ public void doCommit(TableMetadata base, Table

Re: [PR] [JDBC] Part3: Plumb JDBC module to quarkus [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1371: URL: https://github.com/apache/polaris/pull/1371#discussion_r2048020287 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java: ## @@ -45,14 +46,15 @@

Re: [PR] [JDBC] Part3: Plumb JDBC module to quarkus [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1371: URL: https://github.com/apache/polaris/pull/1371#discussion_r2048014006 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -171,6 +181,20 @@ pu

Re: [PR] [JDBC] Part3: Plumb JDBC module to quarkus [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1371: URL: https://github.com/apache/polaris/pull/1371#discussion_r2048008152 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java: ## @@ -45,14 +46,15

Re: [PR] [JDBC] Part3: Plumb JDBC module to quarkus [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1371: URL: https://github.com/apache/polaris/pull/1371#discussion_r2048006676 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -171,6 +181,20 @@ pu

Re: [PR] [JDBC] Part3: Plumb JDBC module to quarkus [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1371: URL: https://github.com/apache/polaris/pull/1371#discussion_r2048007286 ## quarkus/admin/src/test/java/org/apache/polaris/admintool/relational/jdbc/RelationalJdbcProfile.java: ## @@ -0,0 +1,41 @@ +/* + * Licensed to the Apache Software F

Re: [PR] Add Polaris synchronization and migration tool to polaris-tools. [polaris-tools]

2025-04-16 Thread via GitHub
mansehajsingh commented on code in PR #4: URL: https://github.com/apache/polaris-tools/pull/4#discussion_r2048006221 ## polaris-synchronizer/cli/src/main/java/org/apache/polaris/tools/sync/polaris/SyncPolarisCommand.java: ## @@ -0,0 +1,132 @@ +/* + * Licensed to the Apache Softw

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2048005116 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/models/ModelPrincipalAuthenticationData.java: ## @@ -

Re: [PR] Allow BasePolarisTableOperations to skip refreshing metadata after a commit [polaris]

2025-04-16 Thread via GitHub
eric-maynard commented on code in PR #1378: URL: https://github.com/apache/polaris/pull/1378#discussion_r2047907456 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -1328,6 +1344,25 @@ public void doCommit(TableMetadata base,

Re: [PR] Add Polaris synchronization and migration tool to polaris-tools. [polaris-tools]

2025-04-16 Thread via GitHub
mansehajsingh commented on code in PR #4: URL: https://github.com/apache/polaris-tools/pull/4#discussion_r2048003622 ## polaris-synchronizer/api/src/main/java/org/apache/polaris/tools/sync/polaris/service/IcebergCatalogService.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Ap

Re: [PR] Add Polaris synchronization and migration tool to polaris-tools. [polaris-tools]

2025-04-16 Thread via GitHub
mansehajsingh commented on code in PR #4: URL: https://github.com/apache/polaris-tools/pull/4#discussion_r2048004198 ## polaris-synchronizer/api/src/main/java/org/apache/polaris/tools/sync/polaris/PolarisSynchronizer.java: ## @@ -0,0 +1,1135 @@ +/* + * Licensed to the Apache Sof

Re: [PR] Add Polaris synchronization and migration tool to polaris-tools. [polaris-tools]

2025-04-16 Thread via GitHub
mansehajsingh commented on code in PR #4: URL: https://github.com/apache/polaris-tools/pull/4#discussion_r2048003492 ## polaris-synchronizer/cli/src/main/java/org/apache/polaris/tools/sync/polaris/CreateOmnipotentPrincipalCommand.java: ## @@ -79,8 +93,17 @@ public class CreateOm

Re: [PR] Push Docker Images on New Release [polaris]

2025-04-16 Thread via GitHub
adnanhemani commented on code in PR #1377: URL: https://github.com/apache/polaris/pull/1377#discussion_r2047997075 ## .github/workflows/publish-docker.yml: ## @@ -0,0 +1,71 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreeme

Re: [PR] Implement PolicyCatalogHandler and Add Policy Privileges Stage 1: CRUD + ListPolicies [polaris]

2025-04-16 Thread via GitHub
HonahX commented on code in PR #1357: URL: https://github.com/apache/polaris/pull/1357#discussion_r2047954518 ## polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java: ## @@ -457,6 +463,36 @@ public class PolarisAuthorizerImpl implements PolarisAuth

Re: [PR] Push Docker Images on New Release [polaris]

2025-04-16 Thread via GitHub
adnanhemani commented on code in PR #1377: URL: https://github.com/apache/polaris/pull/1377#discussion_r2047992721 ## .github/workflows/publish-docker.yml: ## @@ -0,0 +1,71 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreeme

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1353: URL: https://github.com/apache/polaris/pull/1353#discussion_r2047914839 ## service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java: ## @@ -771,6 +771,9 @@ public PrincipalWithCredentials createPrincipal(Polar

Re: [PR] Add Polaris synchronization and migration tool to polaris-tools. [polaris-tools]

2025-04-16 Thread via GitHub
mansehajsingh commented on code in PR #4: URL: https://github.com/apache/polaris-tools/pull/4#discussion_r2047987579 ## polaris-synchronizer/api/src/main/java/org/apache/polaris/tools/sync/polaris/service/impl/PolarisIcebergCatalogService.java: ## @@ -0,0 +1,150 @@ +/* + * Licen

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2047986634 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcCrudQueryGenerator.java: ## @@ -0,0 +1,241 @@ +/*

Re: [PR] Allow BasePolarisTableOperations to skip refreshing metadata after a commit [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1378: URL: https://github.com/apache/polaris/pull/1378#discussion_r2047928580 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -1328,6 +1344,25 @@ public void doCommit(TableMetadata base, Table

Re: [I] Hosted helm chart in a Helm Repository [polaris]

2025-04-16 Thread via GitHub
jbonofre commented on issue #1269: URL: https://github.com/apache/polaris/issues/1269#issuecomment-2810902338 I sent a message on the dev mailing list about 0.10.0-beta-incubating release: the helm charts will be published on dist.apache.org (stage/release). It will end on download.apache.o

Re: [PR] Implement PolicyCatalogHandler and Add Policy Privileges Stage 1: CRUD + ListPolicies [polaris]

2025-04-16 Thread via GitHub
gh-yzou commented on code in PR #1357: URL: https://github.com/apache/polaris/pull/1357#discussion_r2047814705 ## polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java: ## @@ -457,6 +463,36 @@ public class PolarisAuthorizerImpl implements PolarisAut

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2047962674 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -0,0 +1,184 @@ +/* +

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2047963048 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -0,0 +1,178 @@ +/* +

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-04-16 Thread via GitHub
collado-mike commented on code in PR #1353: URL: https://github.com/apache/polaris/pull/1353#discussion_r2047861024 ## spec/polaris-management-service.yml: ## @@ -1089,6 +1089,10 @@ components: clientId: type: string description: The output-only OA

Re: [PR] Allow BasePolarisTableOperations to skip refreshing metadata after a commit [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1378: URL: https://github.com/apache/polaris/pull/1378#discussion_r2047946624 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -1328,6 +1344,25 @@ public void doCommit(TableMetadata base, Table

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2047580589 ## extension/persistence/relational-jdbc/src/test/java/org/apache/polaris/extension/persistence/impl/relational/jdbc/JdbcAtomicMetastoreManagerTest.java: ## @@ -0,0 +1,

Re: [PR] Allow BasePolarisTableOperations to skip refreshing metadata after a commit [polaris]

2025-04-16 Thread via GitHub
eric-maynard commented on code in PR #1378: URL: https://github.com/apache/polaris/pull/1378#discussion_r2047936123 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -1328,6 +1344,25 @@ public void doCommit(TableMetadata base,

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2047934749 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerBackedByStoreFactory.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the

Re: [PR] Implement PolicyCatalogHandler and Add Policy Privileges Stage 1: CRUD + ListPolicies [polaris]

2025-04-16 Thread via GitHub
gh-yzou commented on code in PR #1357: URL: https://github.com/apache/polaris/pull/1357#discussion_r2047926198 ## service/common/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalogHandler.java: ## @@ -0,0 +1,181 @@ +/* + * Licensed to the Apache Software Founda

Re: [PR] Implement PolicyCatalogHandler and Add Policy Privileges Stage 1: CRUD + ListPolicies [polaris]

2025-04-16 Thread via GitHub
gh-yzou commented on code in PR #1357: URL: https://github.com/apache/polaris/pull/1357#discussion_r2047932853 ## polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java: ## @@ -457,6 +463,36 @@ public class PolarisAuthorizerImpl implements PolarisAut

Re: [PR] Push Docker Images on New Release [polaris]

2025-04-16 Thread via GitHub
jbonofre commented on PR #1377: URL: https://github.com/apache/polaris/pull/1377#issuecomment-2811033673 > Could you push a current version please? Would love to use this now (having issue with gradlew) @aj-hadrian you have to wait 0.10.0-beta-incubating release that will include bin

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1353: URL: https://github.com/apache/polaris/pull/1353#discussion_r2047919467 ## spec/polaris-management-service.yml: ## @@ -1089,6 +1089,10 @@ components: clientId: type: string description: The output-only OAuth c

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1353: URL: https://github.com/apache/polaris/pull/1353#discussion_r2047914839 ## service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java: ## @@ -771,6 +771,9 @@ public PrincipalWithCredentials createPrincipal(Polar

Re: [PR] Implement PolicyCatalogHandler and Add Policy Privileges Stage 1: CRUD + ListPolicies [polaris]

2025-04-16 Thread via GitHub
HonahX commented on code in PR #1357: URL: https://github.com/apache/polaris/pull/1357#discussion_r2047909544 ## service/common/src/main/java/org/apache/polaris/service/catalog/policy/PolicyCatalog.java: ## @@ -213,7 +214,8 @@ public Policy updatePolicy( currentPo

Re: [PR] Allow BasePolarisTableOperations to skip refreshing metadata after a commit [polaris]

2025-04-16 Thread via GitHub
eric-maynard commented on code in PR #1378: URL: https://github.com/apache/polaris/pull/1378#discussion_r2047908842 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -1184,16 +1197,19 @@ public ViewBuilder withLocation(String n

Re: [PR] Implement PolicyCatalogHandler and Add Policy Privileges Stage 1: CRUD + ListPolicies [polaris]

2025-04-16 Thread via GitHub
HonahX commented on code in PR #1357: URL: https://github.com/apache/polaris/pull/1357#discussion_r2047908085 ## polaris-core/src/main/java/org/apache/polaris/core/auth/PolarisAuthorizerImpl.java: ## @@ -457,6 +463,36 @@ public class PolarisAuthorizerImpl implements PolarisAuth

Re: [PR] Allow BasePolarisTableOperations to skip refreshing metadata after a commit [polaris]

2025-04-16 Thread via GitHub
collado-mike commented on code in PR #1378: URL: https://github.com/apache/polaris/pull/1378#discussion_r2047895695 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -1328,6 +1346,41 @@ public void doCommit(TableMetadata base,

Re: [PR] Push Docker Images on New Release [polaris]

2025-04-16 Thread via GitHub
jbonofre commented on PR #1377: URL: https://github.com/apache/polaris/pull/1377#issuecomment-2811029341 As part of the release process (again 😄 ), we can push multi platform images. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to Gi

Re: [PR] Push Docker Images on New Release [polaris]

2025-04-16 Thread via GitHub
aj-hadrian commented on PR #1377: URL: https://github.com/apache/polaris/pull/1377#issuecomment-2811018687 Another Q, I see your image is set to support only arm64, could you also build for x86_64? -- This is an automated message from the Apache Git Service. To respond to the message, ple

Re: [PR] Add Polaris synchronization and migration tool to polaris-tools. [polaris-tools]

2025-04-16 Thread via GitHub
mansehajsingh commented on code in PR #4: URL: https://github.com/apache/polaris-tools/pull/4#discussion_r2047882297 ## polaris-synchronizer/api/src/main/java/org/apache/polaris/tools/sync/polaris/service/IcebergCatalogService.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Ap

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-04-16 Thread via GitHub
collado-mike commented on code in PR #1353: URL: https://github.com/apache/polaris/pull/1353#discussion_r2047857076 ## polaris-core/src/main/java/org/apache/polaris/core/entity/PrincipalRoleEntity.java: ## @@ -65,6 +65,13 @@ public Builder(PrincipalRoleEntity original) {

Re: [PR] Allow BasePolarisTableOperations to skip refreshing metadata after a commit [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1378: URL: https://github.com/apache/polaris/pull/1378#discussion_r2047821651 ## service/common/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalog.java: ## @@ -1328,6 +1344,25 @@ public void doCommit(TableMetadata base, Table

Re: [I] Hosted helm chart in a Helm Repository [polaris]

2025-04-16 Thread via GitHub
shantanu-dahiya commented on issue #1269: URL: https://github.com/apache/polaris/issues/1269#issuecomment-2810893347 I'm happy to work on this with some guidance. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2047808744 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/IdGenerator.java: ## @@ -0,0 +1,57 @@ +/* + * License

Re: [PR] Push Docker Images on New Release [polaris]

2025-04-16 Thread via GitHub
aj-hadrian commented on PR #1377: URL: https://github.com/apache/polaris/pull/1377#issuecomment-2810834301 Could you push a current version please? Would love to use this now (having issue with gradlew) -- This is an automated message from the Apache Git Service. To respond to the message

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2047781450 ## extension/persistence/relational-jdbc/build.gradle.kts: ## @@ -0,0 +1,37 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributo

Re: [PR] Replace authentication filters with Quarkus Security [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1373: URL: https://github.com/apache/polaris/pull/1373#discussion_r2047774803 ## quarkus/service/src/main/java/org/apache/polaris/service/quarkus/auth/PolarisAuthenticationMechanism.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Softwar

Re: [PR] Replace authentication filters with Quarkus Security [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1373: URL: https://github.com/apache/polaris/pull/1373#discussion_r2047773998 ## server-templates/api.mustache: ## @@ -105,7 +105,8 @@ public class {{classname}} { @{{httpMethod}}{{#subresourceOperation}} @Path("{{{path}}}"){{/subresourceO

Re: [I] Hosted helm chart in a Helm Repository [polaris]

2025-04-16 Thread via GitHub
aj-hadrian commented on issue #1269: URL: https://github.com/apache/polaris/issues/1269#issuecomment-2810758553 It seems you didn't host a docker image as well? ``` Warning Failed 10m (x4 over 11m)kubeletFailed to pull image "apache/polaris:latest": rpc error: code

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2047720482 ## README.md: ## @@ -55,6 +55,7 @@ Apache Polaris is organized into the following modules: - Persistence modules: - `polaris-jpa-model` - The JPA entity definiti

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2047718539 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -0,0 +1,178 @@ +/* +

[PR] Add CODEOWNERS for default reviewers [polaris-tools]

2025-04-16 Thread via GitHub
jbonofre opened a new pull request, #7: URL: https://github.com/apache/polaris-tools/pull/7 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Fix releaseEmailTemplate task [polaris]

2025-04-16 Thread via GitHub
jbonofre commented on PR #1384: URL: https://github.com/apache/polaris/pull/1384#issuecomment-2810230583 @snazy ^^ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsub

Re: [I] Hosted helm chart in a Helm Repository [polaris]

2025-04-16 Thread via GitHub
aj-hadrian commented on issue #1269: URL: https://github.com/apache/polaris/issues/1269#issuecomment-2810627403 What's the timeline for this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the s

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2047527202 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerBackedByStoreFactory.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the

Re: [D] Unable to find chart repo [polaris]

2025-04-16 Thread via GitHub
GitHub user aj-hadrian added a comment to the discussion: Unable to find chart repo found an outstanding issues on this exact subject - https://github.com/apache/polaris/issues/1269 GitHub link: https://github.com/apache/polaris/discussions/1385#discussioncomment-12859302 This is an aut

Re: [PR] Allow BasePolarisTableOperations to skip refreshing metadata after a commit [polaris]

2025-04-16 Thread via GitHub
eric-maynard commented on PR #1378: URL: https://github.com/apache/polaris/pull/1378#issuecomment-2810248981 @singhpk234 > Can you please elaborate which storage layer call you are referring here explicitly ? From the Iceberg perspective, it's `TableMetadataParser.read`. From

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2047504459 ## README.md: ## @@ -55,6 +55,7 @@ Apache Polaris is organized into the following modules: - Persistence modules: - `polaris-jpa-model` - The JPA entity definitions

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
singhpk234 commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2047531682 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/DatasourceOperations.java: ## @@ -0,0 +1,184 @@ +/* +

Re: [PR] Add generic table documentations [polaris]

2025-04-16 Thread via GitHub
eric-maynard commented on code in PR #1374: URL: https://github.com/apache/polaris/pull/1374#discussion_r2047445091 ## site/content/in-dev/unreleased/access-control.md: ## @@ -124,6 +124,19 @@ To grant the full set of privileges (drop, list, read, write, etc.) on an object | T

Re: [PR] [JDBC] Part2: Add Relational JDBC module [polaris]

2025-04-16 Thread via GitHub
dimas-b commented on code in PR #1287: URL: https://github.com/apache/polaris/pull/1287#discussion_r2047482795 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/LocalPolarisMetaStoreManagerBackedByStoreFactory.java: ## @@ -0,0 +1,69 @@ +/* + * Licensed to the Apa

Re: [I] [BUG] Site link for Iceberg OpenAPI spec hits an incorrect URL resulting in a 404 [polaris]

2025-04-16 Thread via GitHub
jbonofre closed issue #1359: [BUG] Site link for Iceberg OpenAPI spec hits an incorrect URL resulting in a 404 URL: https://github.com/apache/polaris/issues/1359 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL abo

Re: [PR] Update the link to OpenAPI in the documentation [polaris]

2025-04-16 Thread via GitHub
jbonofre merged PR #1379: URL: https://github.com/apache/polaris/pull/1379 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.ap

Re: [PR] Add nightly build GH action to publish SNAPSHOT on Nexus [polaris]

2025-04-16 Thread via GitHub
jbonofre commented on code in PR #1383: URL: https://github.com/apache/polaris/pull/1383#discussion_r2047360032 ## .github/workflows/nightly.yml: ## @@ -0,0 +1,62 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See

Re: [PR] Entity cache with indexed cache [polaris]

2025-04-16 Thread via GitHub
ben-manes commented on PR #1339: URL: https://github.com/apache/polaris/pull/1339#issuecomment-2810172689 > where the changes made to the id-to-name index are made visible before cache operations complete. I think you could mask that by using retry loops and versioning so that its tr

Re: [PR] Entity cache with indexed cache [polaris]

2025-04-16 Thread via GitHub
ben-manes commented on code in PR #1339: URL: https://github.com/apache/polaris/pull/1339#discussion_r2047332444 ## polaris-core/src/main/java/org/apache/polaris/core/persistence/cache/IndexedCache.java: ## @@ -0,0 +1,219 @@ +/* + * Licensed to the Apache Software Foundation (AS

Re: [PR] Add nightly build GH action to publish SNAPSHOT on Nexus [polaris]

2025-04-16 Thread via GitHub
adutra commented on code in PR #1383: URL: https://github.com/apache/polaris/pull/1383#discussion_r2047313701 ## .github/workflows/nightly.yml: ## @@ -0,0 +1,62 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See th

[PR] Remove sequential simulations and add continuous auth to Polaris benchmarks [polaris-tools]

2025-04-16 Thread via GitHub
pingtimeout opened a new pull request, #6: URL: https://github.com/apache/polaris-tools/pull/6 This PR is part of a preliminary work before more benchmarks are added. * Remove sequential simulations now that the concurrent simulation throughput is configurable (and can be set to 1 unt

Re: [PR] #1186 html tags are not working in hugo [polaris]

2025-04-16 Thread via GitHub
fabio-rizzo-01 commented on PR #1382: URL: https://github.com/apache/polaris/pull/1382#issuecomment-2809857330 > Can you please provide a quick description about this PR ? I'm ok about goldmark, but this PR seems to include other formatting changes 😄 the other thing that I updated are

[PR] Add nightly build GH action to publish SNAPSHOT on Nexus [polaris]

2025-04-16 Thread via GitHub
jbonofre opened a new pull request, #1383: URL: https://github.com/apache/polaris/pull/1383 This PR adds a new GitHub Action to publish SNAPSHOT on Apache Nexus every day (nightly build). -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] #1186 html tags are not working in hugo [polaris]

2025-04-16 Thread via GitHub
jbonofre commented on PR #1382: URL: https://github.com/apache/polaris/pull/1382#issuecomment-2809844988 Can you please provide a quick description about this PR ? I'm ok about goldmark, but this PR seems to include other formatting changes 😄 -- This is an automated message from the Apac

[PR] Private main [polaris]

2025-04-16 Thread via GitHub
fabio-rizzo-01 opened a new pull request, #1382: URL: https://github.com/apache/polaris/pull/1382 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mai

Re: [PR] Replace authentication filters with Quarkus Security [polaris]

2025-04-16 Thread via GitHub
adutra commented on code in PR #1373: URL: https://github.com/apache/polaris/pull/1373#discussion_r2047042114 ## server-templates/api.mustache: ## @@ -105,7 +105,8 @@ public class {{classname}} { @{{httpMethod}}{{#subresourceOperation}} @Path("{{{path}}}"){{/subresourceOp

Re: [PR] Replace authentication filters with Quarkus Security [polaris]

2025-04-16 Thread via GitHub
adutra commented on code in PR #1373: URL: https://github.com/apache/polaris/pull/1373#discussion_r2047058940 ## quarkus/service/src/main/java/org/apache/polaris/service/quarkus/auth/PolarisAuthenticationMechanism.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software

Re: [PR] Replace authentication filters with Quarkus Security [polaris]

2025-04-16 Thread via GitHub
adutra commented on code in PR #1373: URL: https://github.com/apache/polaris/pull/1373#discussion_r2047042114 ## server-templates/api.mustache: ## @@ -105,7 +105,8 @@ public class {{classname}} { @{{httpMethod}}{{#subresourceOperation}} @Path("{{{path}}}"){{/subresourceOp

Re: [PR] Replace authentication filters with Quarkus Security [polaris]

2025-04-16 Thread via GitHub
adutra commented on code in PR #1373: URL: https://github.com/apache/polaris/pull/1373#discussion_r2047023382 ## quarkus/service/src/main/java/org/apache/polaris/service/quarkus/auth/PolarisAuthenticationMechanism.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software

Re: [PR] Replace authentication filters with Quarkus Security [polaris]

2025-04-16 Thread via GitHub
adutra commented on code in PR #1373: URL: https://github.com/apache/polaris/pull/1373#discussion_r2046999430 ## quarkus/service/src/main/java/org/apache/polaris/service/quarkus/auth/PolarisAuthenticationMechanism.java: ## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software

Re: [PR] Replace authentication filters with Quarkus Security [polaris]

2025-04-16 Thread via GitHub
adutra commented on code in PR #1373: URL: https://github.com/apache/polaris/pull/1373#discussion_r2046988608 ## quarkus/service/src/main/java/org/apache/polaris/service/quarkus/auth/ActiveRolesAugmentor.java: ## @@ -0,0 +1,67 @@ +/* + * Licensed to the Apache Software Foundatio

Re: [PR] Entity cache with indexed cache [polaris]

2025-04-16 Thread via GitHub
pingtimeout commented on PR #1339: URL: https://github.com/apache/polaris/pull/1339#issuecomment-2809480671 Just a heads up, I tried to rewrite the EntityCache using two distinct Caffeine caches but failed. The `getOrLoadEntityById` and `getOrLoadEntityByName` methods may fail to find the

Re: [PR] Add generic table documentations [polaris]

2025-04-16 Thread via GitHub
gfakbar20 commented on code in PR #1374: URL: https://github.com/apache/polaris/pull/1374#discussion_r2046832003 ## site/content/in-dev/unreleased/access-control.md: ## @@ -124,6 +124,19 @@ To grant the full set of privileges (drop, list, read, write, etc.) on an object | TABL

Re: [PR] Add generic table documentations [polaris]

2025-04-16 Thread via GitHub
gfakbar20 commented on code in PR #1374: URL: https://github.com/apache/polaris/pull/1374#discussion_r2046832003 ## site/content/in-dev/unreleased/access-control.md: ## @@ -124,6 +124,19 @@ To grant the full set of privileges (drop, list, read, write, etc.) on an object | TABL

  1   2   >