Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
jbonofre commented on code in PR #1493: URL: https://github.com/apache/polaris/pull/1493#discussion_r2067819649 ## quarkus/server/build.gradle.kts: ## @@ -91,7 +91,7 @@ distributions { from(project.layout.buildDirectory.dir("quarkus-app")) from("distribution/NOTICE

Re: [I] Persistence layer improvement [polaris]

2025-04-29 Thread via GitHub
jbonofre closed issue #985: Persistence layer improvement URL: https://github.com/apache/polaris/issues/985 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-ma

Re: [I] Persistence layer improvement [polaris]

2025-04-29 Thread via GitHub
jbonofre commented on issue #985: URL: https://github.com/apache/polaris/issues/985#issuecomment-2840741596 It sounds good yeah. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comm

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-04-29 Thread via GitHub
collado-mike commented on code in PR #1353: URL: https://github.com/apache/polaris/pull/1353#discussion_r2067815515 ## polaris-core/src/main/java/org/apache/polaris/core/entity/PrincipalRoleEntity.java: ## @@ -65,6 +65,13 @@ public Builder(PrincipalRoleEntity original) {

Re: [PR] [JDBC] Support multiple Quarkus datasources [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2067743561 ## quarkus/commons/src/main/java/org/apache/polaris/commons/QuarkusDatasourceSupplier.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] Automatic license check for Python [polaris]

2025-04-29 Thread via GitHub
github-actions[bot] closed pull request #1102: Automatic license check for Python URL: https://github.com/apache/polaris/pull/1102 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific commen

Re: [I] Entity creation rejected with unrelated transaction error [polaris]

2025-04-29 Thread via GitHub
flyrain closed issue #1123: Entity creation rejected with unrelated transaction error URL: https://github.com/apache/polaris/issues/1123 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

Re: [I] Entity creation rejected with unrelated transaction error [polaris]

2025-04-29 Thread via GitHub
flyrain commented on issue #1123: URL: https://github.com/apache/polaris/issues/1123#issuecomment-2840591173 Close this as the JDBC implementation was done. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[PR] Fix Outdated Information and Add Information regarding `docker compose down` to Quickstart [polaris]

2025-04-29 Thread via GitHub
adnanhemani opened a new pull request, #1497: URL: https://github.com/apache/polaris/pull/1497 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail:

Re: [I] Eclipselink module not prepared for multiple realms [polaris]

2025-04-29 Thread via GitHub
flyrain commented on issue #760: URL: https://github.com/apache/polaris/issues/760#issuecomment-2840578421 I don't think it is a 1.0 blocker, as we are going to deprecate EclipseLink. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067674620 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -93,11 +93,7 @@ p

Re: [PR] [JDBC] Support multiple Quarkus datasources [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2067688330 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -315,6 +315,12 @@

Re: [PR] Implement federation to HadoopCatalog [polaris]

2025-04-29 Thread via GitHub
adnanhemani commented on code in PR #1466: URL: https://github.com/apache/polaris/pull/1466#discussion_r2067662627 ## integration-tests/src/main/java/org/apache/polaris/service/it/env/ManagementApi.java: ## @@ -173,6 +173,9 @@ public void createCatalog(String principalRoleName,

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067674620 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -93,11 +93,7 @@ p

Re: [PR] [JDBC] Support multiple Quarkus datasources [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2067665004 ## quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java: ## @@ -76,4 +83,11 @@ public PolarisConfigurationStore configurationStore()

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
dimas-b commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067652715 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -93,11 +93,7 @@ publ

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
dimas-b commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067652715 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -93,11 +93,7 @@ publ

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067651243 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -189,6 +185,17 @@

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
dimas-b commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067592409 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -189,6 +185,17 @@ pr

Re: [I] Overly expensive resource utilization via object-storage (and related) clients [polaris]

2025-04-29 Thread via GitHub
flyrain commented on issue #564: URL: https://github.com/apache/polaris/issues/564#issuecomment-2840460846 Closed this as it's fixed by #1386. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

Re: [I] Overly expensive resource utilization via object-storage (and related) clients [polaris]

2025-04-29 Thread via GitHub
flyrain closed issue #564: Overly expensive resource utilization via object-storage (and related) clients URL: https://github.com/apache/polaris/issues/564 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067584368 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -93,11 +93,7 @@ p

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067584368 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -93,11 +93,7 @@ p

Re: [PR] [JDBC] Support multiple Quarkus datasources [polaris]

2025-04-29 Thread via GitHub
dimas-b commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2067578696 ## quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java: ## @@ -76,4 +83,11 @@ public PolarisConfigurationStore configurationStore() {

Re: [PR] [JDBC] Support multiple Quarkus datasources [polaris]

2025-04-29 Thread via GitHub
dimas-b commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2067577401 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -315,6 +315,12 @@ pr

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
dimas-b commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067574436 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -93,11 +93,7 @@ publ

Re: [I] Make Polaris safe against certain unparseable locations [polaris]

2025-04-29 Thread via GitHub
flyrain commented on issue #552: URL: https://github.com/apache/polaris/issues/552#issuecomment-2840443163 Hi @snazy , can you provide more details of which part of Polaris code has this issue? -- This is an automated message from the Apache Git Service. To respond to the message, please

Re: [PR] Add Delta and Iceberg Integration tests for Spark Client [polaris]

2025-04-29 Thread via GitHub
gh-yzou closed pull request #1427: Add Delta and Iceberg Integration tests for Spark Client URL: https://github.com/apache/polaris/pull/1427 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the speci

[PR] Configurable StorageConfigInfo for Polaris benchmark [polaris-tools]

2025-04-29 Thread via GitHub
eric-maynard opened a new pull request, #20: URL: https://github.com/apache/polaris-tools/pull/20 When trying to run the benchmark against a catalog that stores data in S3, I found that the StorageType is currently hardcoded to `FILE`. -- This is an automated message from the Apache Git S

Re: [I] Persistence layer improvement [polaris]

2025-04-29 Thread via GitHub
flyrain commented on issue #985: URL: https://github.com/apache/polaris/issues/985#issuecomment-2840411408 Hi @jbonofre, can we close this one, as the [first effort](https://www.google.com/url?q=https://docs.google.com/document/d/1U9rprj8w8-Q0SnQvRMvoVlbX996z-89eOkVwWTQaZG0/edit?usp%3Dsharin

Re: [PR] [JDBC] Support multiple Quarkus datasources [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2067538887 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -315,6 +315,12 @@

Re: [I] Client's "venv" is never updated [polaris]

2025-04-29 Thread via GitHub
flyrain commented on issue #1221: URL: https://github.com/apache/polaris/issues/1221#issuecomment-2840397226 Can we close it as #1222 has merged? At least it shouldn't be a 1.0 blocker now. -- This is an automated message from the Apache Git Service. To respond to the message, please log

Re: [PR] Add setup CLI command for entities bootstrap [polaris]

2025-04-29 Thread via GitHub
MonkeyCanCode closed pull request #1474: Add setup CLI command for entities bootstrap URL: https://github.com/apache/polaris/pull/1474 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific co

Re: [PR] Add setup CLI command for entities bootstrap [polaris]

2025-04-29 Thread via GitHub
MonkeyCanCode commented on PR #1474: URL: https://github.com/apache/polaris/pull/1474#issuecomment-2840395822 > Sorry for the delay in reviewing (I'll be able to respond to comments quicker though). > > I do think that it would be better to integrate this into the sync tool (at the v

Re: [PR] [JDBC] Support multiple Quarkus datasources [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2067521323 ## quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java: ## @@ -76,4 +83,11 @@ public PolarisConfigurationStore configurationStore()

Re: [PR] Add CI for Python client [polaris]

2025-04-29 Thread via GitHub
sfc-gh-jojiang commented on code in PR #1096: URL: https://github.com/apache/polaris/pull/1096#discussion_r2067516305 ## .github/workflows/python-client.yml: ## @@ -0,0 +1,84 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agree

Re: [PR] Upgrade Iceberg REST Spec to match Iceberg 1.8 [polaris]

2025-04-29 Thread via GitHub
adutra commented on code in PR #1283: URL: https://github.com/apache/polaris/pull/1283#discussion_r2067502509 ## .github/workflows/gradle.yml: ## @@ -57,10 +57,10 @@ jobs: validate-wrappers: false - name: Code style checks and tests -run: ./gradlew --

Re: [PR] [JDBC] Support multiple Quarkus datasources [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2067505748 ## quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java: ## @@ -76,4 +81,9 @@ public PolarisConfigurationStore configurationStore()

Re: [PR] Upgrade Iceberg REST Spec to match Iceberg 1.8 [polaris]

2025-04-29 Thread via GitHub
adutra commented on code in PR #1283: URL: https://github.com/apache/polaris/pull/1283#discussion_r2067502509 ## .github/workflows/gradle.yml: ## @@ -57,10 +57,10 @@ jobs: validate-wrappers: false - name: Code style checks and tests -run: ./gradlew --

[PR] Add CI for Python client [polaris]

2025-04-29 Thread via GitHub
DaniilRoman opened a new pull request, #1096: URL: https://github.com/apache/polaris/pull/1096 https://github.com/apache/polaris/issues/1058 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to th

Re: [PR] Add CI for Python client [polaris]

2025-04-29 Thread via GitHub
flyrain closed pull request #1096: Add CI for Python client URL: https://github.com/apache/polaris/pull/1096 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [PR] Add setup CLI command for entities bootstrap [polaris]

2025-04-29 Thread via GitHub
travis-bowen commented on PR #1474: URL: https://github.com/apache/polaris/pull/1474#issuecomment-2840339845 Sorry for the delay in reviewing (I'll be able to respond to comments quicker though). I do think that it would be better to integrate this into the sync tool (at the very lea

Re: [PR] [JDBC] Support multiple Quarkus datasources [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2067489063 ## quarkus/admin/src/main/resources/application.properties: ## @@ -49,3 +49,21 @@ quarkus.index-dependency.guava.group-id=com.google.guava quarkus.index-dependency.

Re: [PR] [JDBC] Support multiple Quarkus datasources [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2067488312 ## extension/persistence/relational-jdbc/build.gradle.kts: ## @@ -32,6 +32,7 @@ dependencies { compileOnly(libs.jakarta.inject.api) implementation(libs.small

Re: [PR] [JDBC] Support multiple Quarkus datasources [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2067487484 ## quarkus/commons/src/main/java/org/apache/polaris/commons/QuarkusDatasourceSupplier.java: ## @@ -0,0 +1,54 @@ +/* + * Licensed to the Apache Software Foundation (A

Re: [PR] [JDBC] Support multiple Quarkus datasources [polaris]

2025-04-29 Thread via GitHub
dimas-b commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2067462025 ## quarkus/commons/src/main/java/org/apache/polaris/commons/PostgresRelationalJdbcLifeCycleManagement.java: ## @@ -53,19 +60,42 @@ public Map start() { context.c

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067469845 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -93,11 +93,7 @@ p

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067469845 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -93,11 +93,7 @@ p

Re: [PR] Upgrade Iceberg REST Spec to match Iceberg 1.8 [polaris]

2025-04-29 Thread via GitHub
eric-maynard commented on code in PR #1283: URL: https://github.com/apache/polaris/pull/1283#discussion_r2067461591 ## .github/workflows/gradle.yml: ## @@ -57,10 +57,10 @@ jobs: validate-wrappers: false - name: Code style checks and tests -run: ./grad

Re: [PR] [JDBC] Support multiple Quarkus datasources [polaris]

2025-04-29 Thread via GitHub
dimas-b commented on code in PR #1482: URL: https://github.com/apache/polaris/pull/1482#discussion_r2067452821 ## quarkus/admin/src/main/java/org/apache/polaris/admintool/config/QuarkusProducers.java: ## @@ -76,4 +81,9 @@ public PolarisConfigurationStore configurationStore() {

Re: [PR] Fix: Remove Dev Containers pulling diff postgres version [polaris]

2025-04-29 Thread via GitHub
flyrain merged PR #1495: URL: https://github.com/apache/polaris/pull/1495 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
dimas-b commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067437261 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -93,11 +93,7 @@ publ

Re: [PR] Add getting-started for Polaris Spark Client with Delta tables [polaris]

2025-04-29 Thread via GitHub
flyrain merged PR #1488: URL: https://github.com/apache/polaris/pull/1488 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polaris.apa

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
dimas-b commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067382671 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -93,11 +93,7 @@ publ

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on PR #1496: URL: https://github.com/apache/polaris/pull/1496#issuecomment-2840226396 @dimas-b here is the logs for he same : ``` 2025-04-29 20:35:59.540 UTC [1] LOG: listening on Unix socket "/var/run/postgresql/.s.PGSQL.5432" 2025-04-29 20:35:59.545 UTC [63]

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
sfc-gh-prsingh commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067410980 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -93,11 +93,7

Re: [PR] Add getting-started for Polaris Spark Client with Delta tables [polaris]

2025-04-29 Thread via GitHub
gh-yzou commented on code in PR #1488: URL: https://github.com/apache/polaris/pull/1488#discussion_r2067410453 ## plugins/spark/README.md: ## @@ -30,11 +30,66 @@ and depends on iceberg-spark-runtime 1.8.1. # Build Plugin Jar A task createPolarisSparkJar is added to build a j

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
dimas-b commented on code in PR #1496: URL: https://github.com/apache/polaris/pull/1496#discussion_r2067382671 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -93,11 +93,7 @@ publ

Re: [PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
dimas-b commented on PR #1496: URL: https://github.com/apache/polaris/pull/1496#issuecomment-2840163190 @singhpk234 : could you give a bit more details on the error that prompted this PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on

Re: [PR] Fix: Remove Dev Containers pulling diff postgres version [polaris]

2025-04-29 Thread via GitHub
adutra commented on PR #1495: URL: https://github.com/apache/polaris/pull/1495#issuecomment-2840088654 > For some reason when i disable dev.service it messes up my datasource injection for example replacing these confs with quarkus.devservices.enabled=false in the exact same place makes my

Re: [PR] Add KMS support for S3 [polaris]

2025-04-29 Thread via GitHub
adnanhemani commented on PR #1424: URL: https://github.com/apache/polaris/pull/1424#issuecomment-2840027353 Synced offline with @collado-mike - while there is still not an issue with users who are _only using_ SSE, if the user is using CSE anywhere else within their AWS account, this could

Re: [PR] Fix: Remove Dev Containers pulling diff postgres version [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on PR #1495: URL: https://github.com/apache/polaris/pull/1495#issuecomment-2839934645 Thank you @adutra ! For some reason when i disable dev.service it messes up my datasource injection for example replacing these confs with `quarkus.devservices.enabled=false` in

Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
flyrain commented on code in PR #1493: URL: https://github.com/apache/polaris/pull/1493#discussion_r2067161227 ## quarkus/server/build.gradle.kts: ## @@ -91,7 +91,7 @@ distributions { from(project.layout.buildDirectory.dir("quarkus-app")) from("distribution/NOTICE"

[PR] JDBC: Remove transaction from atomic writes [polaris]

2025-04-29 Thread via GitHub
singhpk234 opened a new pull request, #1496: URL: https://github.com/apache/polaris/pull/1496 ### About the change Change attempts to remove the runInTransaction from atomic operations as this is contributing to error of transaction having cyclic dependency and throwing 5xx if w

Re: [PR] Add getting-started for Polaris Spark Client with Delta tables [polaris]

2025-04-29 Thread via GitHub
eric-maynard commented on code in PR #1488: URL: https://github.com/apache/polaris/pull/1488#discussion_r2067155584 ## plugins/spark/README.md: ## @@ -30,11 +30,66 @@ and depends on iceberg-spark-runtime 1.8.1. # Build Plugin Jar A task createPolarisSparkJar is added to buil

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-04-29 Thread via GitHub
adutra commented on code in PR #1353: URL: https://github.com/apache/polaris/pull/1353#discussion_r2067155086 ## polaris-core/src/main/java/org/apache/polaris/core/entity/PrincipalRoleEntity.java: ## @@ -65,6 +65,13 @@ public Builder(PrincipalRoleEntity original) { super(

Re: [PR] Lazy iteration over JDBC ResultSet [polaris]

2025-04-29 Thread via GitHub
eric-maynard commented on code in PR #1487: URL: https://github.com/apache/polaris/pull/1487#discussion_r2067151744 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/ResultSetIterator.java: ## @@ -0,0 +1,75 @@ +/* + *

Re: [PR] Add support for federated principal and role with block for manual role assignment [polaris]

2025-04-29 Thread via GitHub
dimas-b commented on code in PR #1353: URL: https://github.com/apache/polaris/pull/1353#discussion_r2067146918 ## polaris-core/src/main/java/org/apache/polaris/core/entity/PrincipalRoleEntity.java: ## @@ -65,6 +65,13 @@ public Builder(PrincipalRoleEntity original) { super

Re: [PR] Lazy iteration over JDBC ResultSet [polaris]

2025-04-29 Thread via GitHub
eric-maynard commented on code in PR #1487: URL: https://github.com/apache/polaris/pull/1487#discussion_r2067144887 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java: ## @@ -417,9 +415,17

Re: [PR] Create a wrapper script to generate python client; regenerate the python client [polaris]

2025-04-29 Thread via GitHub
XJDKC commented on code in PR #1347: URL: https://github.com/apache/polaris/pull/1347#discussion_r2067145144 ## client/python/polaris/management/models/__init__.py: ## @@ -33,15 +34,18 @@ # import models into model package from polaris.management.models.add_grant_request imp

Re: [PR] Add getting-started for Polaris Spark Client with Delta tables [polaris]

2025-04-29 Thread via GitHub
flyrain commented on code in PR #1488: URL: https://github.com/apache/polaris/pull/1488#discussion_r2067116435 ## plugins/spark/README.md: ## @@ -30,11 +30,66 @@ and depends on iceberg-spark-runtime 1.8.1. # Build Plugin Jar A task createPolarisSparkJar is added to build a j

Re: [PR] Add getting-started for Polaris Spark Client with Delta tables [polaris]

2025-04-29 Thread via GitHub
flyrain commented on code in PR #1488: URL: https://github.com/apache/polaris/pull/1488#discussion_r2067106703 ## plugins/spark/v3.5/getting-started/README.md: ## @@ -0,0 +1,78 @@ + + +# Getting Started with Apache Spark and Apache Polaris With Delta and Iceberg + +This getting

Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
adutra commented on code in PR #1493: URL: https://github.com/apache/polaris/pull/1493#discussion_r2067096646 ## quarkus/server/build.gradle.kts: ## @@ -91,7 +91,7 @@ distributions { from(project.layout.buildDirectory.dir("quarkus-app")) from("distribution/NOTICE")

Re: [PR] Lazy iteration over JDBC ResultSet [polaris]

2025-04-29 Thread via GitHub
singhpk234 commented on code in PR #1487: URL: https://github.com/apache/polaris/pull/1487#discussion_r2067079635 ## extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/ResultSetIterator.java: ## @@ -0,0 +1,75 @@ +/* + * L

Re: [PR] Eliminate getCurrentContext() call in PolarisAuthorizerImpl [polaris]

2025-04-29 Thread via GitHub
eric-maynard merged PR #1494: URL: https://github.com/apache/polaris/pull/1494 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@polari

Re: [PR] Docs: Fix the wrong catalog name in `using polaris` page [polaris]

2025-04-29 Thread via GitHub
adnanhemani commented on code in PR #1471: URL: https://github.com/apache/polaris/pull/1471#discussion_r2067052225 ## site/content/in-dev/unreleased/getting-started/using-polaris.md: ## @@ -174,7 +174,7 @@ Replace the credentials used in the Docker container using the following

[PR] Fix: Remove Dev Containers pulling diff postgres version [polaris]

2025-04-29 Thread via GitHub
singhpk234 opened a new pull request, #1495: URL: https://github.com/apache/polaris/pull/1495 ### About the change Some of the user experience at 409 for docker pull of postgres-17 image during (./gradlew build), which gets fixed by docker pull of postgres:17 i.e making the image of

Re: [PR] Add getting-started for Polaris Spark Client with Delta tables [polaris]

2025-04-29 Thread via GitHub
gh-yzou commented on code in PR #1488: URL: https://github.com/apache/polaris/pull/1488#discussion_r2067010048 ## plugins/spark/v3.5/getting-started/README.md: ## @@ -0,0 +1,78 @@ + + +# Getting Started with Apache Spark and Apache Polaris With Delta and Iceberg + +This getting

Re: [PR] Add getting-started for Polaris Spark Client with Delta tables [polaris]

2025-04-29 Thread via GitHub
gh-yzou commented on code in PR #1488: URL: https://github.com/apache/polaris/pull/1488#discussion_r2067006226 ## plugins/spark/README.md: ## @@ -30,11 +30,63 @@ and depends on iceberg-spark-runtime 1.8.1. # Build Plugin Jar A task createPolarisSparkJar is added to build a j

Re: [PR] Add getting-started for Polaris Spark Client with Delta tables [polaris]

2025-04-29 Thread via GitHub
gh-yzou commented on code in PR #1488: URL: https://github.com/apache/polaris/pull/1488#discussion_r2067001151 ## plugins/spark/README.md: ## @@ -30,11 +30,63 @@ and depends on iceberg-spark-runtime 1.8.1. # Build Plugin Jar A task createPolarisSparkJar is added to build a j

Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
jbonofre commented on code in PR #1493: URL: https://github.com/apache/polaris/pull/1493#discussion_r2066958201 ## quarkus/server/build.gradle.kts: ## @@ -91,7 +91,7 @@ distributions { from(project.layout.buildDirectory.dir("quarkus-app")) from("distribution/NOTICE

Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
jbonofre commented on PR #1493: URL: https://github.com/apache/polaris/pull/1493#issuecomment-2839563382 @flyrain agree let me do that in another Pr -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
jbonofre commented on code in PR #1493: URL: https://github.com/apache/polaris/pull/1493#discussion_r2066955409 ## quarkus/server/build.gradle.kts: ## @@ -91,7 +91,7 @@ distributions { from(project.layout.buildDirectory.dir("quarkus-app")) from("distribution/NOTICE

[PR] Eliminate getCurrentContext() call in PolarisAuthorizerImpl [polaris]

2025-04-29 Thread via GitHub
gh-yzou opened a new pull request, #1494: URL: https://github.com/apache/polaris/pull/1494 CallContext.getCurrentContext() needs to be deprecated to enable move away from thread local. This PR removes the getCurrentContext() by passing callContext as an arguments to the functions. NOTE

Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
flyrain commented on PR #1493: URL: https://github.com/apache/polaris/pull/1493#issuecomment-2839442921 Sorry to miss this one. Are we going to "pass $args to run.sh" in this PR? I'm OK if we made that change in another PR. -- This is an automated message from the Apache Git Service. To r

Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
flyrain commented on code in PR #1493: URL: https://github.com/apache/polaris/pull/1493#discussion_r2066882394 ## quarkus/server/build.gradle.kts: ## @@ -91,7 +91,7 @@ distributions { from(project.layout.buildDirectory.dir("quarkus-app")) from("distribution/NOTICE"

Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
flyrain commented on code in PR #1493: URL: https://github.com/apache/polaris/pull/1493#discussion_r2066882394 ## quarkus/server/build.gradle.kts: ## @@ -91,7 +91,7 @@ distributions { from(project.layout.buildDirectory.dir("quarkus-app")) from("distribution/NOTICE"

Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
flyrain commented on code in PR #1493: URL: https://github.com/apache/polaris/pull/1493#discussion_r2066874682 ## quarkus/server/build.gradle.kts: ## @@ -91,7 +91,7 @@ distributions { from(project.layout.buildDirectory.dir("quarkus-app")) from("distribution/NOTICE"

Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
flyrain commented on code in PR #1493: URL: https://github.com/apache/polaris/pull/1493#discussion_r2066874682 ## quarkus/server/build.gradle.kts: ## @@ -91,7 +91,7 @@ distributions { from(project.layout.buildDirectory.dir("quarkus-app")) from("distribution/NOTICE"

Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
jbonofre commented on code in PR #1493: URL: https://github.com/apache/polaris/pull/1493#discussion_r2066522832 ## quarkus/server/build.gradle.kts: ## @@ -91,7 +91,7 @@ distributions { from(project.layout.buildDirectory.dir("quarkus-app")) from("distribution/NOTICE

Re: [I] Getting Started Postgres example fails [polaris]

2025-04-29 Thread via GitHub
adutra commented on issue #1484: URL: https://github.com/apache/polaris/issues/1484#issuecomment-2838943386 OK, I found the issue, I was running with IntelliJ and it can't properly detect the containers to launchwhen they are split into several files, and the postgres container ended up in

Re: [I] Getting Started Postgres example fails [polaris]

2025-04-29 Thread via GitHub
adutra closed issue #1484: Getting Started Postgres example fails URL: https://github.com/apache/polaris/issues/1484 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscr

Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
adutra commented on code in PR #1493: URL: https://github.com/apache/polaris/pull/1493#discussion_r2066341088 ## quarkus/server/build.gradle.kts: ## @@ -91,7 +91,7 @@ distributions { from(project.layout.buildDirectory.dir("quarkus-app")) from("distribution/NOTICE")

Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
jbonofre commented on PR #1493: URL: https://github.com/apache/polaris/pull/1493#issuecomment-2838800159 By the way, I'm checking `LICENSE` and `NOTICE` content too as we have new artifacts in the distribution. -- This is an automated message from the Apache Git Service. To respond to the

Re: [PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
jbonofre commented on PR #1493: URL: https://github.com/apache/polaris/pull/1493#issuecomment-2838769081 @flyrain @adutra as discussed on the mailing list I'm also push a new commit to pass arg to `run.sh` in the admin distribution to be able to do `./run.sh --help` for instance. --

[PR] Include quarkus-container-image and README in the binary distributions [polaris]

2025-04-29 Thread via GitHub
jbonofre opened a new pull request, #1493: URL: https://github.com/apache/polaris/pull/1493 (no comment) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-m

Re: [I] Getting Started Postgres example fails [polaris]

2025-04-29 Thread via GitHub
knishant commented on issue #1484: URL: https://github.com/apache/polaris/issues/1484#issuecomment-2838307779 As a first time user, I was able to run the example in getting-started eclipselink README (HEAD -> main). I was able to successfully run spark-sql sample as well. -- This is an

Re: [PR] JDBC: create objects without reflection [polaris]

2025-04-29 Thread via GitHub
eric-maynard commented on PR #1434: URL: https://github.com/apache/polaris/pull/1434#issuecomment-2837950158 In #1487 I solved this by just having the caller pass in an instance of the `Converter`, which seems easy enough -- This is an automated message from the Apache Git Service. To res

Re: [PR] Implement federation to HadoopCatalog [polaris]

2025-04-29 Thread via GitHub
eric-maynard commented on code in PR #1466: URL: https://github.com/apache/polaris/pull/1466#discussion_r2065756665 ## polaris-core/src/main/java/org/apache/polaris/core/connection/hadoop/HadoopConnectionConfigInfoDpo.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Soft

Re: [PR] Implement federation to HadoopCatalog [polaris]

2025-04-29 Thread via GitHub
eric-maynard commented on code in PR #1466: URL: https://github.com/apache/polaris/pull/1466#discussion_r2065758136 ## polaris-core/src/main/java/org/apache/polaris/core/connection/hadoop/HadoopConnectionConfigInfoDpo.java: ## @@ -0,0 +1,88 @@ +/* + * Licensed to the Apache Soft

  1   2   >