singhpk234 commented on code in PR #1496:
URL: https://github.com/apache/polaris/pull/1496#discussion_r2067674620
##########
extension/persistence/relational-jdbc/src/main/java/org/apache/polaris/extension/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##########
@@ -93,11 +93,7 @@ public void writeEntity(
boolean nameOrParentChanged,
PolarisBaseEntity originalEntity) {
try {
- datasourceOperations.runWithinTransaction(
- statement -> {
- persistEntity(callCtx, entity, originalEntity, statement);
- return true;
- });
+ persistEntity(callCtx, entity, originalEntity, datasourceOperations);
Review Comment:
Apologies, if the description was not that clear, i never intended to solve
the serializability issue as there are places where can't just avoid
transactions, just wanted to avoid it, atleast it sounded like that way when i
looked at the description. let me see if i can rephrase the description and
call out the intention more clearly.
> minus the if/else/instanceof code
I added an explanation in the description for the PR, i tried passing a
consumer and even sneaky throw it introduces more complexity than readability,
i didn't go into define interface for this, being said please let me
re-evaluate this once more if i can truly get rid of the read
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
