poojanilangekar commented on code in PR #2223:
URL: https://github.com/apache/polaris/pull/2223#discussion_r2255846250
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -1679,14 +1680,29 @@ public boolean grantPrivilegeOnNamespaceTo
bacek opened a new issue, #2272:
URL: https://github.com/apache/polaris/issues/2272
https://github.com/apache/polaris/blob/bae5444cf37ef86a2c472ded33c513dff3350053/helm/polaris/values.yaml#L567
`type` for both `authenticator` and `roleProvider` should be one of
`internal`, `external`
poojanilangekar commented on code in PR #2223:
URL: https://github.com/apache/polaris/pull/2223#discussion_r2255846641
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -2034,6 +2136,74 @@ private boolean grantPrivilegeOnTableLikeTo
snazy merged PR #2269:
URL: https://github.com/apache/polaris/pull/2269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy merged PR #2271:
URL: https://github.com/apache/polaris/pull/2271
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy merged PR #2270:
URL: https://github.com/apache/polaris/pull/2270
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
renovate-bot opened a new pull request, #2271:
URL: https://github.com/apache/polaris/pull/2271
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
|
[actions/download-artifact](https://redirect.github.com/actions/download-artifact)
|
aacampbell commented on PR #2244:
URL: https://github.com/apache/polaris/pull/2244#issuecomment-3157180685
This new example is very helpful, and very clearly shows how things work.
One thing to note: The `create_catalog.sh` script doesn't work except for the
first realm, because it's hardco
fivetran-arunsuri commented on PR #2197:
URL: https://github.com/apache/polaris/pull/2197#issuecomment-3157066154
@dimas-b 've addressed most of the comments on the PR and would appreciate
your suggestions on a few remaining points. Looking forward to your review and
hoping to get this merg
fivetran-arunsuri commented on PR #2197:
URL: https://github.com/apache/polaris/pull/2197#issuecomment-3157033398
> * Helm testsExpected — Waiting for status to be reported
@dimas-b Also , I don't have access to run the ci checks by myself
--
This is an automated message from t
aacampbell commented on code in PR #2244:
URL: https://github.com/apache/polaris/pull/2244#discussion_r2255591447
##
getting-started/keycloak/README.md:
##
@@ -0,0 +1,163 @@
+
+
+# Getting Started with Apache Polaris, External Authentication and Keycloak
+
+## Overview
+
+This e
flyrain commented on PR #2251:
URL: https://github.com/apache/polaris/pull/2251#issuecomment-3157020536
Hi @HonahX, would you mind taking a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
aacampbell commented on code in PR #2244:
URL: https://github.com/apache/polaris/pull/2244#discussion_r2255584261
##
getting-started/keycloak/README.md:
##
@@ -0,0 +1,163 @@
+
+
+# Getting Started with Apache Polaris, External Authentication and Keycloak
+
+## Overview
+
+This e
aacampbell commented on issue #2243:
URL: https://github.com/apache/polaris/issues/2243#issuecomment-3156971365
Hi @adutra your example does indeed work, and I couldn't make it not work.
I've tried to recreate here what I observed, and I think I made a mistake with
OIDC tenant configuration
flyrain commented on code in PR #2261:
URL: https://github.com/apache/polaris/pull/2261#discussion_r2255541412
##
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -200,6 +205,43 @@ private Optional
findCatalogRoleByName(String catal
flyrain commented on code in PR #2262:
URL: https://github.com/apache/polaris/pull/2262#discussion_r2255430564
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java:
##
@@ -268,45 +268,6 @@ List lookupEntities(
List lookupEntityVersions(
flyrain commented on code in PR #2262:
URL: https://github.com/apache/polaris/pull/2262#discussion_r2255430564
##
polaris-core/src/main/java/org/apache/polaris/core/persistence/BasePersistence.java:
##
@@ -268,45 +268,6 @@ List lookupEntities(
List lookupEntityVersions(
renovate-bot opened a new pull request, #2270:
URL: https://github.com/apache/polaris/pull/2270
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
|
[com.nimbusds:nimbus-jose-jwt](https://bitbucket.org/connect2id/nimbus-jose-jwt)
|
renovate-bot opened a new pull request, #2269:
URL: https://github.com/apache/polaris/pull/2269
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| [boto3](https://redirect.github.com/boto/boto3) | `==1.40.2` -> `==1.40.3`
|
[![ag
sfc-gh-ahemani commented on PR #1904:
URL: https://github.com/apache/polaris/pull/1904#issuecomment-3156149040
@snazy - I've replied on the referenced email thread >2 weeks ago but there
is not any response to any of the comments on the thread since then. If you
have a hard opinion on this,
adnanhemani commented on PR #1904:
URL: https://github.com/apache/polaris/pull/1904#issuecomment-3156150644
@snazy - I've replied on the referenced email thread >2 weeks ago but there
is not any response to any of the comments on the thread since then. If you
have a hard opinion on this, ca
eric-maynard commented on PR #2228:
URL: https://github.com/apache/polaris/pull/2228#issuecomment-3156072079
closing for now to confirm that --repair can address this -- thanks
@MonkeyCanCode !
--
This is an automated message from the Apache Git Service.
To respond to the message, please
snazy commented on code in PR #2268:
URL: https://github.com/apache/polaris/pull/2268#discussion_r2254912628
##
build-logic/src/main/kotlin/polaris-java.gradle.kts:
##
@@ -107,11 +107,13 @@ testing {
dependencies {
implementation(project())
implementatio
rockwotj closed pull request #2188: client/python: loosen boto3 dep
URL: https://github.com/apache/polaris/pull/2188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscr
rockwotj commented on PR #2188:
URL: https://github.com/apache/polaris/pull/2188#issuecomment-3156020654
Closing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsu
adutra commented on code in PR #2268:
URL: https://github.com/apache/polaris/pull/2268#discussion_r2254888650
##
runtime/defaults/src/main/resources/application-it.properties:
##
@@ -17,15 +17,22 @@
# under the License.
#
-# Configuration common to ALL integration tests (exe
adutra commented on code in PR #2268:
URL: https://github.com/apache/polaris/pull/2268#discussion_r2254887623
##
runtime/defaults/src/main/resources/application.properties:
##
@@ -68,9 +68,16 @@ quarkus.log.file.path=./logs/polaris.log
quarkus.log.file.rotation.file-suffix=.yyy
adutra opened a new pull request, #2268:
URL: https://github.com/apache/polaris/pull/2268
This change enforces the following test logging patterns:
- Non-Quarkus modules use Logback Classic, configured via logback-test.xml
- Quarkus modules use JBoss Logging Manager, configured in Q
snazy commented on PR #2258:
URL: https://github.com/apache/polaris/pull/2258#issuecomment-3155855509
Fixing the root cause sounds like the better path forwards. Provided a
possible option in
https://github.com/apache/polaris/pull/2261#pullrequestreview-3088951142
--
This is an automated
flyrain commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2254804591
##
releasey/README.md:
##
@@ -0,0 +1,131 @@
+
+
+# Polaris Release Automation Scripts
+
+This directory contains scripts to automate the Apache Polaris release
process
flyrain commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2254802640
##
releasey/05-build-and-stage-distributions.sh:
##
@@ -0,0 +1,155 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contribut
HotSushi commented on PR #2258:
URL: https://github.com/apache/polaris/pull/2258#issuecomment-3155836628
Thanks @XN137, agree if there's a better place for the fix to be checked in.
Thank you for jumping in.
After that fix, I do not think tests would serve additional benefit. Do use
flyrain commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2254773511
##
releasey/03-create-release-candidate-tag.sh:
##
@@ -0,0 +1,142 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributo
flyrain commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2254743543
##
releasey/02-create-release-branch.sh:
##
@@ -0,0 +1,201 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor licen
XN137 commented on code in PR #2261:
URL: https://github.com/apache/polaris/pull/2261#discussion_r2254501167
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -200,6 +205,43 @@ private Optional
findCatalogRoleByName(String catalogN
XN137 commented on code in PR #2261:
URL: https://github.com/apache/polaris/pull/2261#discussion_r2254462012
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -200,6 +205,43 @@ private Optional
findCatalogRoleByName(String catalogN
XN137 commented on code in PR #2261:
URL: https://github.com/apache/polaris/pull/2261#discussion_r2254455846
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -200,6 +205,43 @@ private Optional
findCatalogRoleByName(String catalogN
XN137 commented on PR #2248:
URL: https://github.com/apache/polaris/pull/2248#issuecomment-3155350132
rebased after conflicts with 20febdaede19fb7c46e120652fdd1a262c2138e4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
XN137 commented on PR #2249:
URL: https://github.com/apache/polaris/pull/2249#issuecomment-3155342037
rebased after conflicts with 20febdaede19fb7c46e120652fdd1a262c2138e4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
XN137 commented on PR #2251:
URL: https://github.com/apache/polaris/pull/2251#issuecomment-3155335063
rebased after conflicts with 20febdaede19fb7c46e120652fdd1a262c2138e4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and us
Subham-KRLX opened a new pull request, #2267:
URL: https://github.com/apache/polaris/pull/2267
This PR improves the documentation for Apache Polaris by enhancing the
"Getting Started with Binary Distribution" guide and updating the related
README file. The changes include formatting fixes,
snazy merged PR #2217:
URL: https://github.com/apache/polaris/pull/2217
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
adutra merged PR #2233:
URL: https://github.com/apache/polaris/pull/2233
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apac
adutra commented on PR #2233:
URL: https://github.com/apache/polaris/pull/2233#issuecomment-3155214806
Hi, since this PR is generating constant rebase conflicts with other ongoing
PRs, I'm going to go ahead and merge it. I hope that's ok for everybody. 🙏
--
This is an automated message f
pingtimeout commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2254317979
##
releasey/06-build-and-stage-docker-images.sh:
##
@@ -0,0 +1,137 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contr
tmater commented on code in PR #2261:
URL: https://github.com/apache/polaris/pull/2261#discussion_r2253890033
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -200,6 +205,43 @@ private Optional
findCatalogRoleByName(String catalog
adutra commented on issue #1590:
URL: https://github.com/apache/polaris/issues/1590#issuecomment-3154984865
> I would like to work on this issue can you please assign this issue to me.
It's all yours 😄
--
This is an automated message from the Apache Git Service.
To respond to the m
snazy commented on issue #463:
URL: https://github.com/apache/polaris/issues/463#issuecomment-3154941211
closing as of @XN137's comment
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specifi
snazy closed issue #463: Remove and ban usage of `[Inheritable]ThreadLocal`
URL: https://github.com/apache/polaris/issues/463
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
snazy commented on code in PR #2217:
URL: https://github.com/apache/polaris/pull/2217#discussion_r2254131691
##
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##
@@ -96,14 +96,17 @@ private void initiali
Subham-KRLX commented on issue #1590:
URL: https://github.com/apache/polaris/issues/1590#issuecomment-3154908970
I would like to work on this issue can you please assign this issue to me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on
adutra commented on code in PR #2217:
URL: https://github.com/apache/polaris/pull/2217#discussion_r2254122340
##
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##
@@ -96,14 +96,17 @@ private void initial
snazy merged PR #2219:
URL: https://github.com/apache/polaris/pull/2219
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy merged PR #2236:
URL: https://github.com/apache/polaris/pull/2236
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy commented on code in PR #2248:
URL: https://github.com/apache/polaris/pull/2248#discussion_r2254085051
##
service/common/src/test/java/org/apache/polaris/service/task/TaskExecutorImplTest.java:
##
@@ -58,6 +58,7 @@ void testEventsAreEmitted() {
new TaskEntity.Buil
snazy commented on PR #2236:
URL: https://github.com/apache/polaris/pull/2236#issuecomment-3154825267
Rebased after #2234 + #2235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comm
forking-renovate[bot] commented on PR #2259:
URL: https://github.com/apache/polaris/pull/2259#issuecomment-3154822944
### Edited/Blocked Notification
Renovate will not automatically rebase this PR, because it does not
recognize the last commit author and assumes somebody else may have
snazy merged PR #2266:
URL: https://github.com/apache/polaris/pull/2266
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy merged PR #2235:
URL: https://github.com/apache/polaris/pull/2235
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy commented on code in PR #2217:
URL: https://github.com/apache/polaris/pull/2217#discussion_r2254048357
##
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcMetaStoreManagerFactory.java:
##
@@ -96,14 +96,17 @@ private void initiali
snazy merged PR #2265:
URL: https://github.com/apache/polaris/pull/2265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
renovate-bot opened a new pull request, #2266:
URL: https://github.com/apache/polaris/pull/2266
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| registry.access.redhat.com/ubi9/openjdk-21-runtime | final | patch |
`1.22-1.175267641
renovate-bot opened a new pull request, #2265:
URL: https://github.com/apache/polaris/pull/2265
This PR contains the following updates:
| Package | Type | Update | Change |
|---|---|---|---|
| [gradle/actions](https://redirect.github.com/gradle/actions) | action |
digest | `ac63
snazy merged PR #2264:
URL: https://github.com/apache/polaris/pull/2264
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy commented on code in PR #1844:
URL: https://github.com/apache/polaris/pull/1844#discussion_r2253895594
##
runtime/service/src/main/java/org/apache/polaris/service/quarkus/events/QuarkusPolarisInMemoryBufferEventListenerConfiguration.java:
##
@@ -0,0 +1,51 @@
+/*
+ * Licens
ajantha-bhat commented on issue #1656:
URL: https://github.com/apache/polaris/issues/1656#issuecomment-3154655982
Maybe we need to close this issue as we community couldn't come to consensus
on this.
https://lists.apache.org/thread/krytbk8zfx4x82krcfp6pr5hsd78q0cq
--
This is an au
tmater commented on code in PR #2261:
URL: https://github.com/apache/polaris/pull/2261#discussion_r2253920002
##
service/common/src/main/java/org/apache/polaris/service/admin/PolarisAdminService.java:
##
@@ -200,6 +205,43 @@ private Optional
findCatalogRoleByName(String catalog
renovate-bot opened a new pull request, #2264:
URL: https://github.com/apache/polaris/pull/2264
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| org.jetbrains.changelog | `2.3.0` -> `2.4.0` |
[
--
This is an automated message from the Apache Git Service.
To respond to the message, ple
snazy merged PR #2255:
URL: https://github.com/apache/polaris/pull/2255
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy commented on PR #2235:
URL: https://github.com/apache/polaris/pull/2235#issuecomment-3154207231
Rebased after merge conflict w/ #2234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the spe
snazy merged PR #2234:
URL: https://github.com/apache/polaris/pull/2234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy merged PR #2257:
URL: https://github.com/apache/polaris/pull/2257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy merged PR #2260:
URL: https://github.com/apache/polaris/pull/2260
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
XN137 opened a new pull request, #2262:
URL: https://github.com/apache/polaris/pull/2262
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
79 matches
Mail list logo
