XN137 opened a new pull request, #2302:
URL: https://github.com/apache/polaris/pull/2302
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
snazy commented on PR #2223:
URL: https://github.com/apache/polaris/pull/2223#issuecomment-319528
I think this needs more attention and some more clarity on how things work.
So let's wait with this and not merge yet, but give everybody enough time to
think about this.
--
This i
ebyhr merged PR #2300:
URL: https://github.com/apache/polaris/pull/2300
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
ebyhr merged PR #2298:
URL: https://github.com/apache/polaris/pull/2298
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
dennishuo commented on code in PR #2262:
URL: https://github.com/apache/polaris/pull/2262#discussion_r2261954000
##
persistence/relational-jdbc/src/main/java/org/apache/polaris/persistence/relational/jdbc/JdbcBasePersistenceImpl.java:
##
@@ -420,50 +419,13 @@ public List
lookup
MonkeyCanCode commented on code in PR #2192:
URL: https://github.com/apache/polaris/pull/2192#discussion_r2261855186
##
client/python/generate_clients.py:
##
@@ -0,0 +1,267 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreemen
MonkeyCanCode commented on PR #2192:
URL: https://github.com/apache/polaris/pull/2192#issuecomment-3166445019
> > I think we also need to update the scripts in getting-started examples,
otherwise it will break
> >
https://github.com/apache/polaris/blob/5983c816596bdf7827ce6e7557835e1b5ed
MonkeyCanCode commented on issue #2245:
URL: https://github.com/apache/polaris/issues/2245#issuecomment-3166415605
This is due to recent change where we preferred podman over docker. For the
above, u can try the following:
```
export DOCKER=docker
sh getting-started/spark/launch-doc
MonkeyCanCode commented on PR #2192:
URL: https://github.com/apache/polaris/pull/2192#issuecomment-3166411558
> I think we also need to update the scripts in getting-started examples,
otherwise it will break
>
>
https://github.com/apache/polaris/blob/5983c816596bdf7827ce6e7557835e1b5
MonkeyCanCode commented on code in PR #2192:
URL: https://github.com/apache/polaris/pull/2192#discussion_r2261827685
##
client/python/generate_clients.py:
##
@@ -0,0 +1,267 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreemen
MonkeyCanCode merged PR #2140:
URL: https://github.com/apache/polaris/pull/2140
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polar
MonkeyCanCode commented on code in PR #2192:
URL: https://github.com/apache/polaris/pull/2192#discussion_r2261802484
##
client/python/generate_clients.py:
##
@@ -0,0 +1,267 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreemen
MonkeyCanCode commented on issue #2293:
URL: https://github.com/apache/polaris/issues/2293#issuecomment-3166365924
> I also hit this locally in a newly cloned repo, changing the last line in
the script to
>
> ```
> exec poetry -C "${dir}/client/python" run polaris "$@"
> ```
rockwotj commented on PR #2188:
URL: https://github.com/apache/polaris/pull/2188#issuecomment-3166210567
Ping @snazy
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To uns
adnanhemani commented on code in PR #1844:
URL: https://github.com/apache/polaris/pull/1844#discussion_r2258598256
##
service/common/src/main/java/org/apache/polaris/service/events/listeners/PolarisPersistenceEventListener.java:
##
@@ -0,0 +1,144 @@
+/*
+ * Licensed to the Apach
Subham-KRLX commented on PR #2267:
URL: https://github.com/apache/polaris/pull/2267#issuecomment-3166154691
I will fix it but it will take some time as I am currently busy with my
exams.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
poojanilangekar commented on PR #2301:
URL: https://github.com/apache/polaris/pull/2301#issuecomment-3166132023
CC @eric-maynard @dennishuo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the sp
poojanilangekar opened a new pull request, #2301:
URL: https://github.com/apache/polaris/pull/2301
Based on the discussion in the community sync, this PR modularizes
federation calls to a separate factory. Beyond the catalog initialization, all
the calls are identical for internal and feder
adutra commented on PR #2296:
URL: https://github.com/apache/polaris/pull/2296#issuecomment-3165590779
> I think that this should have been used in #1938; does pagination now
ignore this flag?
@snazy do you know?
--
This is an automated message from the Apache Git Service.
To respo
renovate-bot opened a new pull request, #2300:
URL: https://github.com/apache/polaris/pull/2300
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| [boto3](https://redirect.github.com/boto/boto3) | `==1.40.4` -> `==1.40.5`
|
[ , can you try running
`./polaris --repair`?
> >
> > [@MonkeyCanCode](https://github.com/MonkeyCanCode) I'm afraid that
FredKhayat commented on issue #2293:
URL: https://github.com/apache/polaris/issues/2293#issuecomment-3165011965
> Hi [@FredKhayat](https://github.com/FredKhayat) , can you try running
`./polaris --repair`?
>
> [@MonkeyCanCode](https://github.com/MonkeyCanCode) I'm afraid that the new
adutra commented on PR #2296:
URL: https://github.com/apache/polaris/pull/2296#issuecomment-3165012762
> Why is this unused?
I have no idea. It was introduced in #1528, that's all I know.
--
This is an automated message from the Apache Git Service.
To respond to the message, please
MonkeyCanCode commented on issue #2293:
URL: https://github.com/apache/polaris/issues/2293#issuecomment-3164922685
> Hi @FredKhayat , can you try running `./polaris --repair`?
>
> @MonkeyCanCode I'm afraid that the new CLI will be broken for everyone, I
wonder if we can also add some
eric-maynard commented on issue #2293:
URL: https://github.com/apache/polaris/issues/2293#issuecomment-3164918485
Hi @FredKhayat , can you try running `./polaris --repair`?
@MonkeyCanCode I'm afraid that the new CLI will be broken for everyone, I
wonder if we can also add some intelli
renovate-bot opened a new pull request, #2298:
URL: https://github.com/apache/polaris/pull/2298
This PR contains the following updates:
| Package | Change | Age | Confidence |
|---|---|---|---|
| [org.assertj:assertj-core](https://assertj.github.io/doc/#assertj-core)
([source](h
eric-maynard commented on PR #2296:
URL: https://github.com/apache/polaris/pull/2296#issuecomment-3164885745
Why is this unused?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comme
eric-maynard merged PR #2297:
URL: https://github.com/apache/polaris/pull/2297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polari
tmater commented on PR #2283:
URL: https://github.com/apache/polaris/pull/2283#issuecomment-3164829967
Thanks @snazy for the thorough review and great suggestions!
- Added the Gradle function described by you, I hope I used it properly
- Made base classes abstract, suffixed them with
flyrain commented on code in PR #2267:
URL: https://github.com/apache/polaris/pull/2267#discussion_r2260746999
##
site/content/in-dev/unreleased/getting-started/_index.md:
##
@@ -23,3 +23,117 @@ weight: 101
build:
render: never
---
+
+# Getting Started with Apache Polaris B
adutra opened a new pull request, #2297:
URL: https://github.com/apache/polaris/pull/2297
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issue
adutra opened a new pull request, #2296:
URL: https://github.com/apache/polaris/pull/2296
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mai
RussellSpitzer commented on PR #2156:
URL: https://github.com/apache/polaris/pull/2156#issuecomment-3164584383
> Just a heads up, I am giving a try at a Github-workflow based release
automation. Hopefully this should reduce the amount of code, given that it will
only be runnable by Github.
RussellSpitzer commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2260609903
##
releasey/test/test-04-build-and-test.sh:
##
@@ -0,0 +1,101 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contrib
snazy opened a new issue, #2295:
URL: https://github.com/apache/polaris/issues/2295
### Describe the bug
The design of the persistence infrastructure makes the
`validateNoLocationOverlap()` prone to false results.
With the right timing, it is possible to create multiple tables
RussellSpitzer commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2260547255
##
releasey/libs/_github.sh:
##
@@ -0,0 +1,154 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
RussellSpitzer commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2260547255
##
releasey/libs/_github.sh:
##
@@ -0,0 +1,154 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
RussellSpitzer commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2260517561
##
releasey/libs/_github.sh:
##
@@ -0,0 +1,154 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
RussellSpitzer commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2260509657
##
releasey/libs/_exec.sh:
##
@@ -0,0 +1,40 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agree
RussellSpitzer commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2260533565
##
releasey/libs/_constants.sh:
##
@@ -0,0 +1,55 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
RussellSpitzer commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2260533565
##
releasey/libs/_constants.sh:
##
@@ -0,0 +1,55 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
RussellSpitzer commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2260505946
##
releasey/libs/_github.sh:
##
@@ -0,0 +1,154 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
RussellSpitzer commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2260505946
##
releasey/libs/_github.sh:
##
@@ -0,0 +1,154 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license ag
pingtimeout commented on PR #2156:
URL: https://github.com/apache/polaris/pull/2156#issuecomment-3164425731
Just a heads up, I am giving a try at a Github-workflow based release
automation. Hopefully this should reduce the amount of code, given that it
will only be runnable by Github. If
adutra commented on code in PR #2280:
URL: https://github.com/apache/polaris/pull/2280#discussion_r2260479484
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/signer/S3RequestSignerImpl.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Fou
adutra commented on code in PR #2280:
URL: https://github.com/apache/polaris/pull/2280#discussion_r2260480360
##
runtime/service/src/main/java/org/apache/polaris/service/storage/aws/signer/S3RequestSignerImpl.java:
##
@@ -0,0 +1,154 @@
+/*
+ * Licensed to the Apache Software Fou
pingtimeout commented on PR #2156:
URL: https://github.com/apache/polaris/pull/2156#issuecomment-3164396010
@snazy This message says that I cannot test as many things as PMC members,
and that I can only rely on the information in the current release guide. So
if a PMC member requests chang
RussellSpitzer commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2260474084
##
releasey/libs/_constants.sh:
##
@@ -0,0 +1,43 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license
pingtimeout commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2260445008
##
releasey/01-prerequisites.sh:
##
@@ -0,0 +1,135 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license a
XN137 commented on code in PR #2291:
URL: https://github.com/apache/polaris/pull/2291#discussion_r2260304308
##
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java:
##
@@ -640,7 +661,7 @@ public Response addGrantToCatalogRole(
.log
XN137 commented on code in PR #2291:
URL: https://github.com/apache/polaris/pull/2291#discussion_r2260304308
##
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java:
##
@@ -640,7 +661,7 @@ public Response addGrantToCatalogRole(
.log
snazy commented on PR #2156:
URL: https://github.com/apache/polaris/pull/2156#issuecomment-3163867323
> @flyrain @snazy I think there is some misunderstanding. I believe that
only PMC members have write access to SVN distribution directory as well as
permissions to create Nexus repositories
snazy commented on code in PR #2291:
URL: https://github.com/apache/polaris/pull/2291#discussion_r2260085835
##
runtime/service/src/main/java/org/apache/polaris/service/admin/PolarisServiceImpl.java:
##
@@ -640,7 +661,7 @@ public Response addGrantToCatalogRole(
.log
snazy opened a new pull request, #2294:
URL: https://github.com/apache/polaris/pull/2294
The function is only needed to create a "safe clone" of `PolarisCallContext`
in `TaskExecutorImpl`, which doesn't have references to CDI request scoped
beans.
To still let `TaskExecutorImpl` maki
FredKhayat opened a new issue, #2293:
URL: https://github.com/apache/polaris/issues/2293
### Describe the bug
Cloning the repo then running `./polaris` does not work
### To Reproduce
_No response_
### Actual Behavior
The `./gradlew regeneratePythonClient` ta
snazy opened a new pull request, #2292:
URL: https://github.com/apache/polaris/pull/2292
Setting an S3 internal endpoint doesn't work, because the property's not
carried over from the OpenAPI model type into `AwsStorageConfigInfo`.
--
This is an automated message from the Apache Git Servi
snazy merged PR #2250:
URL: https://github.com/apache/polaris/pull/2250
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
pingtimeout commented on PR #2156:
URL: https://github.com/apache/polaris/pull/2156#issuecomment-3163366001
@flyrain @snazy I think there is some misunderstanding. I believe that only
PMC members have write access to SVN distribution directory as well as
permissions to create Nexus reposit
XN137 opened a new pull request, #2291:
URL: https://github.com/apache/polaris/pull/2291
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
pingtimeout commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2259734747
##
releasey/03-create-release-candidate-tag.sh:
##
@@ -0,0 +1,142 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contri
pingtimeout commented on code in PR #2156:
URL: https://github.com/apache/polaris/pull/2156#discussion_r2259732997
##
releasey/03-create-release-candidate-tag.sh:
##
@@ -0,0 +1,142 @@
+#!/bin/bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contri
snazy commented on code in PR #2149:
URL: https://github.com/apache/polaris/pull/2149#discussion_r2259668563
##
polaris-core/src/main/java/org/apache/polaris/core/storage/StorageUtil.java:
##
@@ -62,4 +68,50 @@ public class StorageUtil {
public static @Nonnull String getBucke
snazy commented on issue #2173:
URL: https://github.com/apache/polaris/issues/2173#issuecomment-3163233184
It's quite a difference if an official guide asks users to store plain text
credentials into easily accessible text files or whether someone does it on its
own. There have been too man
snazy commented on code in PR #2280:
URL: https://github.com/apache/polaris/pull/2280#discussion_r2259531408
##
runtime/service/src/main/java/org/apache/polaris/service/catalog/iceberg/IcebergCatalogAdapter.java:
##
@@ -797,4 +812,24 @@ public Response getConfig(
snazy commented on code in PR #2283:
URL: https://github.com/apache/polaris/pull/2283#discussion_r2259381321
##
build-logic/src/main/kotlin/polaris-runtime.gradle.kts:
##
@@ -52,6 +52,14 @@ testing {
}
sources { java.srcDirs(tasks.named("quarkusGenerateCodeTests"))
adutra commented on issue #2272:
URL: https://github.com/apache/polaris/issues/2272#issuecomment-3162885295
@bacek
Your configuration above is correct. I deployed a Polaris pod with it and
the pod came up without problems.
Which version of Polaris are you deploying? Can you tr
XN137 opened a new pull request, #2290:
URL: https://github.com/apache/polaris/pull/2290
WIP
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-
snazy merged PR #2288:
URL: https://github.com/apache/polaris/pull/2288
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
XN137 commented on PR #2258:
URL: https://github.com/apache/polaris/pull/2258#issuecomment-3162787688
since the other PR has been merged i'd suggest to close this PR now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
snazy merged PR #2285:
URL: https://github.com/apache/polaris/pull/2285
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy merged PR #2281:
URL: https://github.com/apache/polaris/pull/2281
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy merged PR #2261:
URL: https://github.com/apache/polaris/pull/2261
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
snazy merged PR #2284:
URL: https://github.com/apache/polaris/pull/2284
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@polaris.apach
88 matches
Mail list logo
