Re: [PR] RATIS-2112. Improve repeat-test workflow [ratis]

2024-06-12 Thread via GitHub
szetszwo commented on code in PR #1112: URL: https://github.com/apache/ratis/pull/1112#discussion_r1637576420 ## dev-support/checks/unit.sh: ## @@ -65,6 +65,12 @@ for i in $(seq 1 ${ITERATIONS}); do fi if [[ ${ITERATIONS} -gt 1 ]]; then +if ! grep -q "Running

Re: [PR] RATIS-2112. Improve repeat-test workflow [ratis]

2024-06-12 Thread via GitHub
adoroszlai commented on code in PR #1112: URL: https://github.com/apache/ratis/pull/1112#discussion_r1637570927 ## dev-support/checks/unit.sh: ## @@ -65,6 +65,12 @@ for i in $(seq 1 ${ITERATIONS}); do fi if [[ ${ITERATIONS} -gt 1 ]]; then +if ! grep -q "Running

Re: [PR] RATIS-2095. Extract common logic of ratis-shell to RaftUtils for reuse [ratis]

2024-06-12 Thread via GitHub
szetszwo commented on code in PR #1098: URL: https://github.com/apache/ratis/pull/1098#discussion_r1637266788 ## ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java: ## @@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup) {

Re: [PR] RATIS-2095. Extract common logic of ratis-shell to RaftUtils for reuse [ratis]

2024-06-12 Thread via GitHub
szetszwo commented on code in PR #1098: URL: https://github.com/apache/ratis/pull/1098#discussion_r1637264045 ## ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java: ## @@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup) {

Re: [PR] RATIS-2095. Extract common logic of ratis-shell to RaftUtils for reuse [ratis]

2024-06-12 Thread via GitHub
szetszwo commented on code in PR #1098: URL: https://github.com/apache/ratis/pull/1098#discussion_r1637257198 ## ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java: ## @@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup) {

Re: [PR] RATIS-2112. Improve repeat-test workflow [ratis]

2024-06-12 Thread via GitHub
szetszwo commented on code in PR #1112: URL: https://github.com/apache/ratis/pull/1112#discussion_r1637251822 ## dev-support/checks/unit.sh: ## @@ -65,6 +65,12 @@ for i in $(seq 1 ${ITERATIONS}); do fi if [[ ${ITERATIONS} -gt 1 ]]; then +if ! grep -q "Running

Re: [PR] RATIS-2095. Extract common logic of ratis-shell to RaftUtils for reuse [ratis]

2024-06-12 Thread via GitHub
DaveTeng0 commented on PR #1098: URL: https://github.com/apache/ratis/pull/1098#issuecomment-2163582121 Hello guys! Changes for addressing comments have been completed. Feel free to take a final look, thanks! (cc. @szetszwo -- This is an automated message from the Apache Git Service. To

[PR] RATIS-2112. repeat-test should upload artifact only for failed split [ratis]

2024-06-12 Thread via GitHub
adoroszlai opened a new pull request, #1112: URL: https://github.com/apache/ratis/pull/1112 ## What changes were proposed in this pull request? Improve `repeat-test` workflow: * Skip artifact upload if all iterations passed * Rename artifact using run number/ID * Fail fast if

[jira] [Updated] (RATIS-2112) repeat-test should upload artifact only for failed split

2024-06-12 Thread Attila Doroszlai (Jira)
[ https://issues.apache.org/jira/browse/RATIS-2112?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Attila Doroszlai updated RATIS-2112: Description: Improve {{repeat-test}} workflow: * Skip artifact upload if all iterations

[jira] [Created] (RATIS-2112) repeat-test should upload artifact only for failed split

2024-06-12 Thread Attila Doroszlai (Jira)
Attila Doroszlai created RATIS-2112: --- Summary: repeat-test should upload artifact only for failed split Key: RATIS-2112 URL: https://issues.apache.org/jira/browse/RATIS-2112 Project: Ratis

Re: [PR] [RATIS-2111] Reinitialize should load the latest snapshot [ratis]

2024-06-12 Thread via GitHub
AngersZh commented on code in PR #: URL: https://github.com/apache/ratis/pull/#discussion_r1635957841 ## ratis-server/src/main/java/org/apache/ratis/statemachine/impl/SimpleStateMachineStorage.java: ## @@ -228,6 +228,17 @@ public SingleFileSnapshotInfo

Re: [PR] [RATIS-2111] Reinitialize should load the latest snapshot [ratis]

2024-06-12 Thread via GitHub
szetszwo commented on code in PR #: URL: https://github.com/apache/ratis/pull/#discussion_r1635951987 ## ratis-server/src/main/java/org/apache/ratis/statemachine/impl/SimpleStateMachineStorage.java: ## @@ -228,6 +228,17 @@ public SingleFileSnapshotInfo

Re: [PR] [RATIS-2111] Reinitialize should load the latest snapshot [ratis]

2024-06-12 Thread via GitHub
AngersZh commented on PR #: URL: https://github.com/apache/ratis/pull/#issuecomment-2162241993 ping @szetszwo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment.

[PR] [RATIS-2111] Reinitialize should load the latest snapshot [ratis]

2024-06-12 Thread via GitHub
AngersZh opened a new pull request, #: URL: https://github.com/apache/ratis/pull/ ## What changes were proposed in this pull request? When we setting `INSTALL_SNAPSHOT_ENABLED_KEY` as true and when master sync snapshot to follower, the status will be PAUSED and won't take

[jira] [Created] (RATIS-2111) SimpleStateMachineStorage reinitialize won't load the latest snapshot

2024-06-12 Thread Yi Zhu (Jira)
Yi Zhu created RATIS-2111: - Summary: SimpleStateMachineStorage reinitialize won't load the latest snapshot Key: RATIS-2111 URL: https://issues.apache.org/jira/browse/RATIS-2111 Project: Ratis Issue