szetszwo merged PR #1124:
URL: https://github.com/apache/ratis/pull/1124
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
szetszwo commented on PR #1126:
URL: https://github.com/apache/ratis/pull/1126#issuecomment-2257393582
@duongkame , instead of reverting this, how about replacing the guava Cache
with a `WeakHashMap`?
```java
diff --git
weimingdiit commented on PR #1124:
URL: https://github.com/apache/ratis/pull/1124#issuecomment-2257322310
> @weimingdiit , there is a checkstyle warning (long line). Could you fix it?
ok, please review again
--
This is an automated message from the Apache Git Service.
To respond to
duongkame commented on PR #1126:
URL: https://github.com/apache/ratis/pull/1126#issuecomment-225722
cc. @szetszwo @smengcl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mridulm commented on PR #1125:
URL: https://github.com/apache/ratis/pull/1125#issuecomment-2250274426
Thanks @szetszwo !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
szetszwo merged PR #1125:
URL: https://github.com/apache/ratis/pull/1125
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
mridulm commented on PR #1125:
URL: https://github.com/apache/ratis/pull/1125#issuecomment-2249542892
+CC @szetszwo based on git blame.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
mridulm commented on PR #1125:
URL: https://github.com/apache/ratis/pull/1125#issuecomment-2249538311
+CC @waitinfuture, @RexXiong
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
mridulm commented on PR #1125:
URL: https://github.com/apache/ratis/pull/1125#issuecomment-2249537204
Verified with Apache Celeborn, which uses 3.1.0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
szetszwo commented on PR #1124:
URL: https://github.com/apache/ratis/pull/1124#issuecomment-2241066087
@weimingdiit , there is a checkstyle warning (long line). Could you fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
weimingdiit commented on code in PR #1124:
URL: https://github.com/apache/ratis/pull/1124#discussion_r1683734431
##
ratis-common/src/main/java/org/apache/ratis/protocol/exceptions/NotLeaderException.java:
##
@@ -30,7 +30,7 @@ public class NotLeaderException extends
weimingdiit commented on code in PR #1124:
URL: https://github.com/apache/ratis/pull/1124#discussion_r1683734431
##
ratis-common/src/main/java/org/apache/ratis/protocol/exceptions/NotLeaderException.java:
##
@@ -30,7 +30,7 @@ public class NotLeaderException extends
szetszwo commented on PR #1122:
URL: https://github.com/apache/ratis/pull/1122#issuecomment-2232451144
Thanks @adoroszlai and @SzyWilliam for reviewing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
szetszwo merged PR #1122:
URL: https://github.com/apache/ratis/pull/1122
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
szetszwo commented on code in PR #1124:
URL: https://github.com/apache/ratis/pull/1124#discussion_r1680192656
##
ratis-common/src/main/java/org/apache/ratis/protocol/exceptions/NotLeaderException.java:
##
@@ -30,7 +30,7 @@ public class NotLeaderException extends RaftException {
szetszwo commented on code in PR #1122:
URL: https://github.com/apache/ratis/pull/1122#discussion_r1680186412
##
ratis-test/src/test/java/org/apache/ratis/netty/TestNettyClientRpcAsync.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
jojochuang commented on PR #1122:
URL: https://github.com/apache/ratis/pull/1122#issuecomment-2231447620
cc @duongkame @smengcl
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
adoroszlai commented on code in PR #1122:
URL: https://github.com/apache/ratis/pull/1122#discussion_r1679791881
##
ratis-test/src/test/java/org/apache/ratis/netty/TestNettyClientRpcAsync.java:
##
@@ -0,0 +1,67 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under
adoroszlai commented on PR #1123:
URL: https://github.com/apache/ratis/pull/1123#issuecomment-2228242789
Thanks @szetszwo for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
adoroszlai merged PR #1123:
URL: https://github.com/apache/ratis/pull/1123
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
adoroszlai commented on PR #1123:
URL: https://github.com/apache/ratis/pull/1123#issuecomment-2227045401
Reproducibility check for javadoc works on Java 8, but fails with newer
Java. The problem is in the search index JSON files. So it's reverted for now.
--
This is an automated
adoroszlai opened a new pull request, #1123:
URL: https://github.com/apache/ratis/pull/1123
## What changes were proposed in this pull request?
Ratis build generates javadoc when using `-Prelease`. The javadoc jars have
unexpected content, e.g. other jars, `classes` dir (with all
szetszwo commented on PR #204:
URL: https://github.com/apache/ratis/pull/204#issuecomment-2226739729
@amaliujia , thanks a lot for your initial work! I will continue this pull
request in https://github.com/apache/ratis/pull/204 .
--
This is an automated message from the Apache Git
szetszwo opened a new pull request, #1122:
URL: https://github.com/apache/ratis/pull/1122
See RATIS-1071 and https://github.com/apache/ratis/pull/204
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
adoroszlai commented on PR #1121:
URL: https://github.com/apache/ratis/pull/1121#issuecomment-2209372002
Thanks @szetszwo for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
adoroszlai merged PR #1121:
URL: https://github.com/apache/ratis/pull/1121
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
szetszwo commented on PR #1121:
URL: https://github.com/apache/ratis/pull/1121#issuecomment-2208442918
@adoroszlai , could you also update `3.1.0.md` as below? It is to replace
`maintenance` with `minor` and break the long line.
```patch
+++ b/content/post/3.1.0.md
@@ -18,7 +18,9
szetszwo commented on code in PR #1120:
URL: https://github.com/apache/ratis/pull/1120#discussion_r1665351236
##
content/post/3.1.0.md:
##
@@ -0,0 +1,24 @@
+---
+title: Release 3.1.0 is available
+date: 2024-06-29
+type: release
+linked: true
+---
+
+
szetszwo commented on code in PR #1121:
URL: https://github.com/apache/ratis/pull/1121#discussion_r1665330951
##
content/post/2.5.1.md:
##
@@ -2,7 +2,7 @@
title: Release 2.5.1 is available
date: 2023-05-05
type: release
-linked: true
+linked: false
Review Comment:
adoroszlai opened a new pull request, #1121:
URL: https://github.com/apache/ratis/pull/1121
## What changes were proposed in this pull request?
List only 3.0.1 and 3.1.0 in
[Downloads](https://ratis.apache.org/downloads.html) page.
SzyWilliam merged PR #1114:
URL: https://github.com/apache/ratis/pull/1114
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
adoroszlai opened a new pull request, #1118:
URL: https://github.com/apache/ratis/pull/1118
## What changes were proposed in this pull request?
Ratis 3.1.0 was released, we should bump version on `master` to
`3.2.0-SNAPSHOT`.
https://issues.apache.org/jira/browse/RATIS-2120
adoroszlai opened a new pull request, #52:
URL: https://github.com/apache/ratis-thirdparty/pull/52
## What changes were proposed in this pull request?
- Bump `maven-shade-plugin` to fix:
```
$ mvn artifact:check-buildplan
...
[ERROR] plugin with
szetszwo merged PR #1098:
URL: https://github.com/apache/ratis/pull/1098
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1638668722
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1638660102
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1638659191
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
szetszwo merged PR #:
URL: https://github.com/apache/ratis/pull/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
AngersZh commented on PR #:
URL: https://github.com/apache/ratis/pull/#issuecomment-2165078941
@szetszwo GA passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
adoroszlai commented on PR #1112:
URL: https://github.com/apache/ratis/pull/1112#issuecomment-2164590297
Thanks @szetszwo for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
adoroszlai merged PR #1112:
URL: https://github.com/apache/ratis/pull/1112
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
szetszwo commented on code in PR #1112:
URL: https://github.com/apache/ratis/pull/1112#discussion_r1637576420
##
dev-support/checks/unit.sh:
##
@@ -65,6 +65,12 @@ for i in $(seq 1 ${ITERATIONS}); do
fi
if [[ ${ITERATIONS} -gt 1 ]]; then
+if ! grep -q "Running
adoroszlai commented on code in PR #1112:
URL: https://github.com/apache/ratis/pull/1112#discussion_r1637570927
##
dev-support/checks/unit.sh:
##
@@ -65,6 +65,12 @@ for i in $(seq 1 ${ITERATIONS}); do
fi
if [[ ${ITERATIONS} -gt 1 ]]; then
+if ! grep -q "Running
szetszwo commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1637266788
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
szetszwo commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1637264045
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
szetszwo commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1637257198
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
szetszwo commented on code in PR #1112:
URL: https://github.com/apache/ratis/pull/1112#discussion_r1637251822
##
dev-support/checks/unit.sh:
##
@@ -65,6 +65,12 @@ for i in $(seq 1 ${ITERATIONS}); do
fi
if [[ ${ITERATIONS} -gt 1 ]]; then
+if ! grep -q "Running
DaveTeng0 commented on PR #1098:
URL: https://github.com/apache/ratis/pull/1098#issuecomment-2163582121
Hello guys! Changes for addressing comments have been completed. Feel free
to take a final look, thanks! (cc. @szetszwo
--
This is an automated message from the Apache Git Service.
To
adoroszlai opened a new pull request, #1112:
URL: https://github.com/apache/ratis/pull/1112
## What changes were proposed in this pull request?
Improve `repeat-test` workflow:
* Skip artifact upload if all iterations passed
* Rename artifact using run number/ID
* Fail fast if
AngersZh commented on code in PR #:
URL: https://github.com/apache/ratis/pull/#discussion_r1635957841
##
ratis-server/src/main/java/org/apache/ratis/statemachine/impl/SimpleStateMachineStorage.java:
##
@@ -228,6 +228,17 @@ public SingleFileSnapshotInfo
szetszwo commented on code in PR #:
URL: https://github.com/apache/ratis/pull/#discussion_r1635951987
##
ratis-server/src/main/java/org/apache/ratis/statemachine/impl/SimpleStateMachineStorage.java:
##
@@ -228,6 +228,17 @@ public SingleFileSnapshotInfo
AngersZh commented on PR #:
URL: https://github.com/apache/ratis/pull/#issuecomment-2162241993
ping @szetszwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
AngersZh opened a new pull request, #:
URL: https://github.com/apache/ratis/pull/
## What changes were proposed in this pull request?
When we setting `INSTALL_SNAPSHOT_ENABLED_KEY` as true and when master sync
snapshot to follower,
the status will be PAUSED and won't take
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1635388784
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/sh/command/AbstractRatisCommand.java:
##
@@ -168,14 +148,8 @@ protected RaftPeerProto getLeader(RoleInfoProto
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1635388172
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1635382904
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1635382904
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1635369219
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1635369219
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1635366416
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1635361802
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1635359021
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1635356697
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1635355940
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
adoroszlai merged PR #51:
URL: https://github.com/apache/ratis-thirdparty/pull/51
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
adoroszlai commented on PR #51:
URL: https://github.com/apache/ratis-thirdparty/pull/51#issuecomment-2157311709
Thanks @szetszwo for the review.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
adoroszlai opened a new pull request, #1110:
URL: https://github.com/apache/ratis/pull/1110
## What changes were proposed in this pull request?
Create and publish Software Bill of Materials (SBOM) for Ratis.
adoroszlai opened a new pull request, #51:
URL: https://github.com/apache/ratis-thirdparty/pull/51
## What changes were proposed in this pull request?
Create and publish Software Bill of Materials (SBOM) for Ratis.
szetszwo commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1631917108
##
ratis-shell/src/main/java/org/apache/ratis/shell/cli/RaftUtils.java:
##
@@ -86,4 +103,111 @@ public static RaftClient createClient(RaftGroup raftGroup)
{
smengcl commented on PR #1107:
URL: https://github.com/apache/ratis/pull/1107#issuecomment-2151006330
Thanks @szetszwo for reviewing and merging this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
szetszwo merged PR #1109:
URL: https://github.com/apache/ratis/pull/1109
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
szetszwo merged PR #1107:
URL: https://github.com/apache/ratis/pull/1107
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
smengcl commented on code in PR #1107:
URL: https://github.com/apache/ratis/pull/1107#discussion_r1626617774
##
ratis-docs/src/site/markdown/configurations.md:
##
@@ -675,4 +675,73 @@ For examples,
2. However, setConf to a 3-member group by removing 2 of members and adding
smengcl commented on code in PR #1107:
URL: https://github.com/apache/ratis/pull/1107#discussion_r1626429940
##
ratis-docs/src/site/markdown/configurations.md:
##
@@ -675,4 +675,73 @@ For examples,
2. However, setConf to a 3-member group by removing 2 of members and adding
szetszwo commented on PR #1108:
URL: https://github.com/apache/ratis/pull/1108#issuecomment-2148105196
Even I have commented out `setZeroCopyEnabled(properties, true)`
```java
diff --git
a/ratis-grpc/src/test/java/org/apache/ratis/grpc/MiniRaftClusterWithGrpc.java
szetszwo commented on PR #1108:
URL: https://github.com/apache/ratis/pull/1108#issuecomment-2148103362
@duongkame , I applied the patch but still get the same
IllegalStateException:
```
[ERROR]
szetszwo commented on code in PR #1107:
URL: https://github.com/apache/ratis/pull/1107#discussion_r1625667060
##
ratis-docs/src/site/markdown/configurations.md:
##
@@ -675,4 +675,73 @@ For examples,
2. However, setConf to a 3-member group by removing 2 of members and adding
duongkame commented on PR #1108:
URL: https://github.com/apache/ratis/pull/1108#issuecomment-2146359706
c.c @szetszwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To
duongkame opened a new pull request, #1108:
URL: https://github.com/apache/ratis/pull/1108
## What changes were proposed in this pull request?
`TestLeaderInstallSnapshot.testInstallSnapshotLeaderSwitch` calls
`cluster.shutdown` twice. The second shutdown seems to create weird
smengcl opened a new pull request, #1107:
URL: https://github.com/apache/ratis/pull/1107
## What changes were proposed in this pull request?
Add config doc for `RaftClient`. Like what RATIS-1732 did for `RaftServer`.
## What is the link to the Apache JIRA
szetszwo merged PR #1106:
URL: https://github.com/apache/ratis/pull/1106
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
szetszwo commented on PR #1106:
URL: https://github.com/apache/ratis/pull/1106#issuecomment-2144062303
@duongkame , "This pull request is still a work in progress". I guess it is
not the case?
--
This is an automated message from the Apache Git Service.
To respond to the message, please
szetszwo commented on code in PR #1106:
URL: https://github.com/apache/ratis/pull/1106#discussion_r1622823140
##
ratis-common/src/main/java/org/apache/ratis/util/ReferenceCountedObject.java:
##
@@ -152,6 +153,10 @@ public boolean release() {
};
}
+ default
duongkame opened a new pull request, #1106:
URL: https://github.com/apache/ratis/pull/1106
## What changes were proposed in this pull request?
As discuss in RATIS-2094, the usage of TransactionContext's
`getStateMachineLogEntry` and `getStateMachineContext` may cause corruptions
duongkame commented on PR #1106:
URL: https://github.com/apache/ratis/pull/1106#issuecomment-2142716387
@szetszwo can you have a look?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
SzyWilliam merged PR #1091:
URL: https://github.com/apache/ratis/pull/1091
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
SzyWilliam commented on PR #1091:
URL: https://github.com/apache/ratis/pull/1091#issuecomment-2138885724
Thanks @szetszwo very much for the reviews and resolutions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
szetszwo commented on code in PR #1091:
URL: https://github.com/apache/ratis/pull/1091#discussion_r1619906598
##
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##
@@ -1853,6 +1853,7 @@ CompletableFuture
SzyWilliam commented on code in PR #1091:
URL: https://github.com/apache/ratis/pull/1091#discussion_r1619711666
##
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##
@@ -1853,6 +1853,7 @@ CompletableFuture
DaveTeng0 commented on code in PR #1098:
URL: https://github.com/apache/ratis/pull/1098#discussion_r1619570302
##
ratis-shell/pom.xml:
##
@@ -48,6 +48,14 @@
org.slf4j
slf4j-simple
+
+ org.apache.ratis
+ ratis-grpc
+
+
+
smengcl commented on PR #1104:
URL: https://github.com/apache/ratis/pull/1104#issuecomment-2138001402
Thanks @szetszwo for reviewing this!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
szetszwo merged PR #1104:
URL: https://github.com/apache/ratis/pull/1104
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
smengcl commented on PR #1105:
URL: https://github.com/apache/ratis/pull/1105#issuecomment-2137966704
Thanks a lot @ivandika3 for working on this one!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
szetszwo commented on code in PR #1091:
URL: https://github.com/apache/ratis/pull/1091#discussion_r1619199546
##
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##
@@ -1853,6 +1853,7 @@ CompletableFuture
szetszwo commented on code in PR #1091:
URL: https://github.com/apache/ratis/pull/1091#discussion_r1619188649
##
ratis-server/src/main/java/org/apache/ratis/server/impl/RaftServerImpl.java:
##
@@ -1853,6 +1853,7 @@ CompletableFuture
ivandika3 commented on PR #1105:
URL: https://github.com/apache/ratis/pull/1105#issuecomment-2136360048
@szetszwo Thank you for the review and merge. Created HDDS-10932 to remove
the need for the second watch commit in case of `NotReplicatedException`, will
do after Ratis 3.1.0 release.
szetszwo merged PR #1105:
URL: https://github.com/apache/ratis/pull/1105
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail:
szetszwo commented on code in PR #1091:
URL: https://github.com/apache/ratis/pull/1091#discussion_r1617700921
##
ratis-server/src/main/java/org/apache/ratis/server/impl/ConfigurationManager.java:
##
@@ -61,10 +61,10 @@ private void setCurrentConf(RaftConfigurationImpl
SzyWilliam commented on PR #1091:
URL: https://github.com/apache/ratis/pull/1091#issuecomment-2134190240
@szetszwo Hi Tsz-Wo, this patch is merged and tested in IoTDB snapshot
version and so far so good. I hope it could catch on board with 3.1.0, what do
you think?
--
This is an
ivandika3 commented on PR #1105:
URL: https://github.com/apache/ratis/pull/1105#issuecomment-2132749185
cc: @smengcl @szetszwo
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
1 - 100 of 1713 matches
Mail list logo
