[
https://issues.apache.org/jira/browse/RATIS-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248338#comment-16248338
]
Hadoop QA commented on RATIS-133:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukul Kumar Singh updated RATIS-133:
Attachment: RATIS-133.002.patch
Thanks for the review [~szetszwo], patch v2 fixes the review
[
https://issues.apache.org/jira/browse/RATIS-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248298#comment-16248298
]
Tsz Wo Nicholas Sze commented on RATIS-133:
---
{code}
+ Preconditions
+
[
https://issues.apache.org/jira/browse/RATIS-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248294#comment-16248294
]
Tsz Wo Nicholas Sze commented on RATIS-133:
---
- Since client also uses MESSAGE_SIZ
[
https://issues.apache.org/jira/browse/RATIS-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248283#comment-16248283
]
Jing Zhao commented on RATIS-133:
-
[~msingh], I see your point. Thanks for the explanation.
[
https://issues.apache.org/jira/browse/RATIS-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248273#comment-16248273
]
Mukul Kumar Singh commented on RATIS-133:
-
Thanks for review [~jingzhao]. I did see
[
https://issues.apache.org/jira/browse/RATIS-141?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248261#comment-16248261
]
Tsz Wo Nicholas Sze commented on RATIS-141:
---
It seems that we need a new id, name
Tsz Wo Nicholas Sze created RATIS-141:
-
Summary: In RaftClientProtocolService, the assumption of
consecutive callId is invalid
Key: RATIS-141
URL: https://issues.apache.org/jira/browse/RATIS-141
P
[
https://issues.apache.org/jira/browse/RATIS-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248079#comment-16248079
]
Tsz Wo Nicholas Sze commented on RATIS-113:
---
Some other comments on the patch
- L
[
https://issues.apache.org/jira/browse/RATIS-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248068#comment-16248068
]
Tsz Wo Nicholas Sze commented on RATIS-113:
---
The conf is a good idea!
- Let's cal
[
https://issues.apache.org/jira/browse/RATIS-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248054#comment-16248054
]
Hadoop QA commented on RATIS-133:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248027#comment-16248027
]
Tsz Wo Nicholas Sze commented on RATIS-137:
---
TestRaftWithNetty just failed in my
[
https://issues.apache.org/jira/browse/RATIS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16248022#comment-16248022
]
Tsz Wo Nicholas Sze commented on RATIS-137:
---
Thanks Lokesh, the patch looks good.
[
https://issues.apache.org/jira/browse/RATIS-113?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247978#comment-16247978
]
Lokesh Jain commented on RATIS-113:
---
Thanks for the review [~szetszwo]. v2 patch addresse
[
https://issues.apache.org/jira/browse/RATIS-113?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lokesh Jain updated RATIS-113:
--
Attachment: RATIS-113.002.patch
> Add Async send interface to RaftClient
> --
[
https://issues.apache.org/jira/browse/RATIS-133?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247932#comment-16247932
]
Jing Zhao commented on RATIS-133:
-
This limit actually can be increased by manipulating
Ne
[
https://issues.apache.org/jira/browse/RATIS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247905#comment-16247905
]
Tsz Wo Nicholas Sze commented on RATIS-129:
---
That's great. However, it still fai
[
https://issues.apache.org/jira/browse/RATIS-133?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukul Kumar Singh updated RATIS-133:
Attachment: RATIS-133.001.patch
> Raft gRPC client should check proto size before sending a m
[
https://issues.apache.org/jira/browse/RATIS-129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247279#comment-16247279
]
Elek, Marton commented on RATIS-129:
Thank you [~szetszwo]. Finally we got good daily b
[
https://issues.apache.org/jira/browse/RATIS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16247265#comment-16247265
]
Hadoop QA commented on RATIS-137:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-137?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Lokesh Jain updated RATIS-137:
--
Attachment: RATIS-137.002.patch
> RaftBasicTests.testBasicAppendEntries may fail
> --
21 matches
Mail list logo
