[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660090#comment-16660090
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660089#comment-16660089
]
Tsz Wo Nicholas Sze commented on RATIS-364:
---
+1 the 002 patch looks good.
> Raft should persist
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16660012#comment-16660012
]
Sergey Soldatov commented on RATIS-334:
---
bq. Let's spin this out into its own Jira issue if you
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659968#comment-16659968
]
Josh Elser commented on RATIS-334:
--
{quote}this class is ambiguous
{quote}
Let's spin this out into its
[
https://issues.apache.org/jira/browse/RATIS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jitendra Nath Pandey updated RATIS-366:
---
Fix Version/s: 0.3.0
> In StateMachineUpdater, the stopIndex should use Long.
>
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659879#comment-16659879
]
Sergey Soldatov commented on RATIS-334:
---
[~vrodionov] well, my point is that this class is ambiguous
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659600#comment-16659600
]
Josh Elser commented on RATIS-334:
--
{quote}I don't quite understand what LogService class is supposed to
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659342#comment-16659342
]
Vladimir Rodionov commented on RATIS-334:
-
LogService looks like a client, agree. I would leave
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659297#comment-16659297
]
Sergey Soldatov commented on RATIS-334:
---
[~rajeshbabu] I don't quite understand what LogService
[
https://issues.apache.org/jira/browse/RATIS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659284#comment-16659284
]
Hadoop QA commented on RATIS-366:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659241#comment-16659241
]
Rajeshbabu Chintaguntla edited comment on RATIS-334 at 10/22/18 6:01 PM:
[
https://issues.apache.org/jira/browse/RATIS-334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659241#comment-16659241
]
Rajeshbabu Chintaguntla commented on RATIS-334:
---
[~sergey.soldatov] I have gone through the
[
https://issues.apache.org/jira/browse/RATIS-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659187#comment-16659187
]
Hadoop QA commented on RATIS-365:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659185#comment-16659185
]
Hadoop QA commented on RATIS-366:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659167#comment-16659167
]
Jitendra Nath Pandey commented on RATIS-366:
+1 for the patch.
> In StateMachineUpdater, the
[
https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659147#comment-16659147
]
Tsz Wo Nicholas Sze commented on RATIS-363:
---
Filed RATIS-366.
> StateMachineUpdater should wait
[
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659146#comment-16659146
]
Hadoop QA commented on RATIS-364:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
Tsz Wo Nicholas Sze created RATIS-366:
-
Summary: In StateMachineUpdater, the stopIndex should use Long.
Key: RATIS-366
URL: https://issues.apache.org/jira/browse/RATIS-366
Project: Ratis
[
https://issues.apache.org/jira/browse/RATIS-366?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-366:
--
Attachment: r366_20181023.patch
> In StateMachineUpdater, the stopIndex should use
[
https://issues.apache.org/jira/browse/RATIS-365?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659142#comment-16659142
]
Tsz Wo Nicholas Sze commented on RATIS-365:
---
r365_20181023.patch: uses map.keySet() and removes
Tsz Wo Nicholas Sze created RATIS-365:
-
Summary: Implement RaftServer.getGroupIds() using the key set of
ImplMap
Key: RATIS-365
URL: https://issues.apache.org/jira/browse/RATIS-365
Project: Ratis
[
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659115#comment-16659115
]
Mukul Kumar Singh commented on RATIS-364:
-
Thanks for the review [~szetszwo]. patch v2 fixes the
[
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukul Kumar Singh updated RATIS-364:
Attachment: RATIS-364.002.patch
> Raft should persist configuration entries to meta file
>
[
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukul Kumar Singh updated RATIS-364:
Attachment: (was: RATIS-364.001.patch)
> Raft should persist configuration entries to
[
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659100#comment-16659100
]
Tsz Wo Nicholas Sze commented on RATIS-364:
---
[~msingh], thanks for working on this. The
[
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-364:
--
Issue Type: Improvement (was: Bug)
> Raft should persist configuration entries to meta
[
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659090#comment-16659090
]
Hadoop QA commented on RATIS-364:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659089#comment-16659089
]
Tsz Wo Nicholas Sze commented on RATIS-363:
---
Just found a bug -- stopIndex is better to use Long
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659087#comment-16659087
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659076#comment-16659076
]
Tsz Wo Nicholas Sze commented on RATIS-338:
---
The failed tests do not seem related.
>
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659064#comment-16659064
]
Hadoop QA commented on RATIS-338:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659059#comment-16659059
]
Tsz Wo Nicholas Sze commented on RATIS-338:
---
+1 the v5 patch looks good. Thanks
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-352:
--
Attachment: (was: r352_20181022d.patch)
> Persist commit index in Raft log.
>
[
https://issues.apache.org/jira/browse/RATIS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-361:
--
Attachment: (was: r361_20181022.patch)
> Fix the NPE bug in MemoryRaftLog
>
[
https://issues.apache.org/jira/browse/RATIS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-361:
--
Attachment: r361_20181022.patch
> Fix the NPE bug in MemoryRaftLog
>
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-352:
--
Attachment: r352_20181022d.patch
> Persist commit index in Raft log.
>
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659053#comment-16659053
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659050#comment-16659050
]
Tsz Wo Nicholas Sze commented on RATIS-352:
---
r352_20181022d.patch: checks null for logConsumer.
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-352:
--
Attachment: (was: r352_20181022c.patch)
> Persist commit index in Raft log.
>
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-352:
--
Attachment: r352_20181022d.patch
> Persist commit index in Raft log.
>
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-338:
--
Attachment: (was: RATIS-338-v4.patch)
> ServerInformationReply should include
[
https://issues.apache.org/jira/browse/RATIS-364?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mukul Kumar Singh updated RATIS-364:
Attachment: RATIS-364.001.patch
> Raft should persist configuration entries to meta file
>
Mukul Kumar Singh created RATIS-364:
---
Summary: Raft should persist configuration entries to meta file
Key: RATIS-364
URL: https://issues.apache.org/jira/browse/RATIS-364
Project: Ratis
[
https://issues.apache.org/jira/browse/RATIS-361?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659042#comment-16659042
]
Lokesh Jain commented on RATIS-361:
---
[~szetszwo] Thanks for working on this! The patch looks good to me.
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659019#comment-16659019
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16659004#comment-16659004
]
Hadoop QA commented on RATIS-352:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658968#comment-16658968
]
Tsz Wo Nicholas Sze commented on RATIS-352:
---
r352_20181022c.patch: fixes unit tests.
> Persist
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-352:
--
Attachment: (was: r352_20181022b.patch)
> Persist commit index in Raft log.
>
[
https://issues.apache.org/jira/browse/RATIS-352?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Tsz Wo Nicholas Sze updated RATIS-352:
--
Attachment: r352_20181022c.patch
> Persist commit index in Raft log.
>
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658954#comment-16658954
]
Hadoop QA commented on RATIS-338:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658909#comment-16658909
]
Sergey Soldatov commented on RATIS-338:
---
[~szetszwo] addressed all 3 bullets in v5.
>
[
https://issues.apache.org/jira/browse/RATIS-338?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sergey Soldatov updated RATIS-338:
--
Attachment: RATIS-338-v5.patch
> ServerInformationReply should include multiple groups
>
[
https://issues.apache.org/jira/browse/RATIS-331?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Shashikant Banerjee resolved RATIS-331.
---
Resolution: Fixed
> Ratis client should provide a method to wait for commit from all
[
https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658799#comment-16658799
]
Tsz Wo Nicholas Sze commented on RATIS-363:
---
+1 the .5 patch looks good.
> StateMachineUpdater
[
https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658759#comment-16658759
]
Hadoop QA commented on RATIS-363:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658721#comment-16658721
]
Jitendra Nath Pandey commented on RATIS-363:
RATIS-363.5.patch fixes the checkstyle issues.
[
https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jitendra Nath Pandey updated RATIS-363:
---
Attachment: RATIS-363.5.patch
> StateMachineUpdater should wait for committed
[
https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658657#comment-16658657
]
Hadoop QA commented on RATIS-363:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem ||
[
https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16658622#comment-16658622
]
Jitendra Nath Pandey commented on RATIS-363:
Thanks for review comments [~szetszwo] and
[
https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jitendra Nath Pandey updated RATIS-363:
---
Attachment: RATIS-363.4.patch
> StateMachineUpdater should wait for committed
[
https://issues.apache.org/jira/browse/RATIS-363?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jitendra Nath Pandey updated RATIS-363:
---
Attachment: (was: RATIS-363.3.patch)
> StateMachineUpdater should wait for
61 matches
Mail list logo
