[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16808709#comment-16808709
]
Tsz Wo Nicholas Sze commented on RATIS-498:
---
+1 the 008 patch looks good.
> Not
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16808255#comment-16808255
]
Hanisha Koneru commented on RATIS-498:
--
Yes agree. I have opened a new Jira RATIS-514
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807366#comment-16807366
]
Tsz Wo Nicholas Sze commented on RATIS-498:
---
How about we modify the proto as be
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16807211#comment-16807211
]
Hanisha Koneru commented on RATIS-498:
--
Thank you [~szetszwo] for the review.
{quote}
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16805781#comment-16805781
]
Tsz Wo Nicholas Sze commented on RATIS-498:
---
Thanks for update. The 008 patch l
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804632#comment-16804632
]
Hadoop QA commented on RATIS-498:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804575#comment-16804575
]
Hanisha Koneru commented on RATIS-498:
--
Patch v08 is rebased with master.
> Notify F
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804553#comment-16804553
]
Tsz Wo Nicholas Sze commented on RATIS-498:
---
[~hanishakoneru], please run "git p
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804315#comment-16804315
]
Hadoop QA commented on RATIS-498:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16804264#comment-16804264
]
Hanisha Koneru commented on RATIS-498:
--
Patch v07 fixes test failures.
> Notify Foll
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803660#comment-16803660
]
Hadoop QA commented on RATIS-498:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16803556#comment-16803556
]
Hanisha Koneru commented on RATIS-498:
--
{quote}When a server is installing snapshot,
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801401#comment-16801401
]
Tsz Wo Nicholas Sze commented on RATIS-498:
---
[~hanishakoneru] thanks for the exa
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801280#comment-16801280
]
Hadoop QA commented on RATIS-498:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16801275#comment-16801275
]
Hanisha Koneru commented on RATIS-498:
--
Thanks for the review [~szetszwo].
I think w
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800680#comment-16800680
]
Tsz Wo Nicholas Sze commented on RATIS-498:
---
In notifyStateMachineToInstallSnaps
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800313#comment-16800313
]
Hadoop QA commented on RATIS-498:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16800310#comment-16800310
]
Hanisha Koneru commented on RATIS-498:
--
Thank you for the review. I have updated the
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797902#comment-16797902
]
Tsz Wo Nicholas Sze commented on RATIS-498:
---
Thanks for the update. Some more c
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797518#comment-16797518
]
Hadoop QA commented on RATIS-498:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797502#comment-16797502
]
Hanisha Koneru commented on RATIS-498:
--
Thanks [~szetszwo].
Update the patch to add
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16797075#comment-16797075
]
Tsz Wo Nicholas Sze commented on RATIS-498:
---
Thanks, [~hanishakoneru]. I have t
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796728#comment-16796728
]
Hanisha Koneru commented on RATIS-498:
--
I have updated the patch to add notify option
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16796472#comment-16796472
]
Hanisha Koneru commented on RATIS-498:
--
Thank you [~msingh] and [~szetszwo] for the r
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795783#comment-16795783
]
Tsz Wo Nicholas Sze commented on RATIS-498:
---
{quote}
I am thinking that on the f
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795702#comment-16795702
]
Mukul Kumar Singh commented on RATIS-498:
-
Thanks for working on this [~hanishakon
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795526#comment-16795526
]
Hadoop QA commented on RATIS-498:
-
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote ||
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16795522#comment-16795522
]
Hanisha Koneru commented on RATIS-498:
--
Thanks for the review [~szetszwo].
{quote}I s
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793412#comment-16793412
]
Tsz Wo Nicholas Sze commented on RATIS-498:
---
Have a look at the patch. The work
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16793140#comment-16793140
]
Tsz Wo Nicholas Sze commented on RATIS-498:
---
Thanks [~hanishakoneru], will revie
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792282#comment-16792282
]
Hadoop QA commented on RATIS-498:
-
| (/) *{color:green}+1 overall{color}* |
\\
\\
|| Vote
[
https://issues.apache.org/jira/browse/RATIS-498?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16792253#comment-16792253
]
Hanisha Koneru commented on RATIS-498:
--
Attached an initial patch. This patch (v0) do
32 matches
Mail list logo