dsmiley commented on a change in pull request #2:
URL: https://github.com/apache/solr/pull/2#discussion_r594859845
##
File path: solr/core/src/java/org/apache/solr/search/SortedIntDocSet.java
##
@@ -671,107 +673,141 @@ public DocSet union(DocSet other) {
return new
dsmiley commented on a change in pull request #2:
URL: https://github.com/apache/solr/pull/2#discussion_r594847721
##
File path: solr/core/src/java/org/apache/solr/search/BitDocSet.java
##
@@ -237,68 +235,15 @@ public BitDocSet clone() {
return new BitDocSet(bits.clone(),
dsmiley commented on a change in pull request #17:
URL: https://github.com/apache/solr/pull/17#discussion_r594760829
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CollApiCmds.java
##
@@ -226,8 +226,8 @@ public void call(ClusterState clusterState,
[
https://issues.apache.org/jira/browse/SOLR-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-15261.
-
Resolution: Fixed
> SortedDocValues no longer extends BinaryDocValues
>
[
https://issues.apache.org/jira/browse/SOLR-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302177#comment-17302177
]
David Smiley commented on SOLR-15261:
-
I'm pushed a fix to the test. It was a simple matter of using
[
https://issues.apache.org/jira/browse/SOLR-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302176#comment-17302176
]
ASF subversion and git services commented on SOLR-15261:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302150#comment-17302150
]
Michael Gibney commented on SOLR-15261:
---
This failure seems consistent. FWIW I don't see
[
https://issues.apache.org/jira/browse/SOLR-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302136#comment-17302136
]
Chris M. Hostetter commented on SOLR-15265:
---
Replying here to some comments from [~dweiss] in
[
https://issues.apache.org/jira/browse/SOLR-15251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302100#comment-17302100
]
Dwane Hall edited comment on SOLR-15251 at 3/16/21, 12:05 AM:
--
MBean
[
https://issues.apache.org/jira/browse/SOLR-15251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302100#comment-17302100
]
Dwane Hall edited comment on SOLR-15251 at 3/16/21, 12:02 AM:
--
MBean
[
https://issues.apache.org/jira/browse/SOLR-15251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302100#comment-17302100
]
Dwane Hall edited comment on SOLR-15251 at 3/15/21, 11:50 PM:
--
MBean
[
https://issues.apache.org/jira/browse/SOLR-15251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302102#comment-17302102
]
Dwane Hall commented on SOLR-15251:
---
Also adding this [link
[
https://issues.apache.org/jira/browse/SOLR-15251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dwane Hall updated SOLR-15251:
--
Comment: was deleted
(was: Also adding this [link
[
https://issues.apache.org/jira/browse/SOLR-15251?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dwane Hall resolved SOLR-15251.
---
Fix Version/s: 8.8.1
Resolution: Not A Bug
MBean collection of operating system statistics
[
https://issues.apache.org/jira/browse/SOLR-15251?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302098#comment-17302098
]
Dwane Hall commented on SOLR-15251:
---
[~epugh] FYI I'm just closing this off now as there's nothing Solr
madrob merged pull request #19:
URL: https://github.com/apache/solr/pull/19
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
madrob opened a new pull request #19:
URL: https://github.com/apache/solr/pull/19
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
[
https://issues.apache.org/jira/browse/SOLR-14096?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302027#comment-17302027
]
Mike Drob commented on SOLR-14096:
--
I see this same failure with SOLR-15268 TestEnumFields
>
[
https://issues.apache.org/jira/browse/SOLR-15268?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob resolved SOLR-15268.
--
Resolution: Duplicate
Duplicate of SOLR-14096
> TestEnumFields fails due to AccessControlException
>
[
https://issues.apache.org/jira/browse/SOLR-15222?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302019#comment-17302019
]
Mike Drob commented on SOLR-15222:
--
Potentially related to SOLR-15268
> Solr should not auto-create the
Mike Drob created SOLR-15268:
Summary: TestEnumFields fails due to AccessControlException
Key: SOLR-15268
URL: https://issues.apache.org/jira/browse/SOLR-15268
Project: Solr
Issue Type: Bug
[
https://issues.apache.org/jira/browse/SOLR-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mike Drob reopened SOLR-15261:
--
> SortedDocValues no longer extends BinaryDocValues
> -
>
[
https://issues.apache.org/jira/browse/SOLR-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17302013#comment-17302013
]
Mike Drob commented on SOLR-15261:
--
I see a test failure in TestFieldCacheSortRandom that may be
[
https://issues.apache.org/jira/browse/SOLR-15264?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301975#comment-17301975
]
Dawid Weiss commented on SOLR-15264:
See these relevant comments I left in the code:
[
https://issues.apache.org/jira/browse/SOLR-15262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301974#comment-17301974
]
Dawid Weiss commented on SOLR-15262:
Hi Chris. Sorry I wasn't able to fix this myself - too little
mikemccand commented on pull request #18:
URL: https://github.com/apache/solr/pull/18#issuecomment-799687139
Maybe try to get a minimal PR pushed, first, to un-block Solr build, and
then follow-on PR to better optimize things? Ahh it looks like we've already
done just that (first step),
[
https://issues.apache.org/jira/browse/SOLR-15262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301890#comment-17301890
]
ASF subversion and git services commented on SOLR-15262:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter resolved SOLR-15263.
---
Fix Version/s: main (9.0)
Assignee: Chris M. Hostetter
Resolution:
[
https://issues.apache.org/jira/browse/SOLR-15263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301889#comment-17301889
]
ASF subversion and git services commented on SOLR-15263:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Chris M. Hostetter reassigned SOLR-15267:
-
Assignee: Chris M. Hostetter
> ref-guide link checking doesn't fail on bad
Chris M. Hostetter created SOLR-15267:
-
Summary: ref-guide link checking doesn't fail on bad links in
index.html???
Key: SOLR-15267
URL: https://issues.apache.org/jira/browse/SOLR-15267
Project:
[
https://issues.apache.org/jira/browse/SOLR-15266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301819#comment-17301819
]
Chris M. Hostetter commented on SOLR-15266:
---
I would suggest that folks help tackle these in
Chris M. Hostetter created SOLR-15266:
-
Summary: Audit all refs to lucene.apache.org in solr git repo
Key: SOLR-15266
URL: https://issues.apache.org/jira/browse/SOLR-15266
Project: Solr
Chris M. Hostetter created SOLR-15265:
-
Summary: decide if/how to validate lucene javadoc links
Key: SOLR-15265
URL: https://issues.apache.org/jira/browse/SOLR-15265
Project: Solr
Issue
Chris M. Hostetter created SOLR-15264:
-
Summary: refactor ref-guide htmlLuceneJavadocs build variable to
be based on lucene version from ivy properties
Key: SOLR-15264
URL:
Chris M. Hostetter created SOLR-15263:
-
Summary: re-enable local ref-guide link checks by forcing remote
url for lucene javadocs
Key: SOLR-15263
URL: https://issues.apache.org/jira/browse/SOLR-15263
Chris M. Hostetter created SOLR-15262:
-
Summary: deal with "local" ref-guide link checking after
lucene/solr repo split
Key: SOLR-15262
URL: https://issues.apache.org/jira/browse/SOLR-15262
[
https://issues.apache.org/jira/browse/SOLR-15262?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301812#comment-17301812
]
Chris M. Hostetter commented on SOLR-15262:
---
Some context of this issue...
The ref-guide
uschindler commented on pull request #18:
URL: https://github.com/apache/solr/pull/18#issuecomment-799609181
I agree, some of them are completely useless to comment on or fix them: E.g.
SolrDocumentFetcher is just emulating stored fields, on every call to get a
virtual stored field it
[
https://issues.apache.org/jira/browse/SOLR-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant resolved SOLR-15261.
---
Fix Version/s: main (9.0)
Resolution: Fixed
> SortedDocValues no longer extends
dsmiley commented on pull request #18:
URL: https://github.com/apache/solr/pull/18#issuecomment-799588251
> I disagree with this. Maybe you're right, but we can leave the comment in
until we've had more time to think this through.
Then let's discuss now. I reviewed each one of them
alessandrobenedetti commented on a change in pull request #8:
URL: https://github.com/apache/solr/pull/8#discussion_r594462247
##
File path: solr/contrib/ltr/src/java/org/apache/solr/ltr/LTRRescorer.java
##
@@ -124,10 +125,13 @@ public TopDocs rescore(IndexSearcher searcher,
[
https://issues.apache.org/jira/browse/SOLR-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301775#comment-17301775
]
ASF subversion and git services commented on SOLR-15261:
Commit
[
https://issues.apache.org/jira/browse/SOLR-15246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301768#comment-17301768
]
Matthew Flowerday commented on SOLR-15246:
--
Hi David
Thanks for getting back to me. Yes -
bruno-roustant commented on pull request #18:
URL: https://github.com/apache/solr/pull/18#issuecomment-799553517
I'll take into account the comments. At the moment I'm fixing more classes
as tests break.
This is an
alessandrobenedetti commented on a change in pull request #12:
URL: https://github.com/apache/solr/pull/12#discussion_r594452221
##
File path: solr/solr-ref-guide/src/morelikethis.adoc
##
@@ -16,97 +16,624 @@
// specific language governing permissions and limitations
//
alessandrobenedetti commented on a change in pull request #12:
URL: https://github.com/apache/solr/pull/12#discussion_r594452871
##
File path: solr/solr-ref-guide/src/morelikethis.adoc
##
@@ -16,97 +16,624 @@
// specific language governing permissions and limitations
//
alessandrobenedetti commented on a change in pull request #12:
URL: https://github.com/apache/solr/pull/12#discussion_r594452221
##
File path: solr/solr-ref-guide/src/morelikethis.adoc
##
@@ -16,97 +16,624 @@
// specific language governing permissions and limitations
//
madrob commented on pull request #18:
URL: https://github.com/apache/solr/pull/18#issuecomment-799505762
> I propose that you remove the comment "//TODO: SortedDocValues quick fix"
everywhere that you put it. In two places, I suggested alternative comments
scoped to the feature of a
[
https://issues.apache.org/jira/browse/SOLR-15211?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301695#comment-17301695
]
Houston Putman commented on SOLR-15211:
---
The Solr Operator is an official subproject of apache
[
https://issues.apache.org/jira/browse/SOLR-15167?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301694#comment-17301694
]
Houston Putman commented on SOLR-15167:
---
The repo has been renamed. A PR is up that addresses all
alessandrobenedetti commented on a change in pull request #12:
URL: https://github.com/apache/solr/pull/12#discussion_r593042789
##
File path: solr/solr-ref-guide/src/morelikethis.adoc
##
@@ -16,97 +16,624 @@
// specific language governing permissions and limitations
//
dsmiley commented on a change in pull request #18:
URL: https://github.com/apache/solr/pull/18#discussion_r594394186
##
File path: solr/core/src/java/org/apache/solr/search/HashQParserPlugin.java
##
@@ -112,7 +112,7 @@ public LongValues getValues(LeafReaderContext ctx,
bruno-roustant commented on a change in pull request #18:
URL: https://github.com/apache/solr/pull/18#discussion_r594385042
##
File path: solr/core/src/java/org/apache/solr/uninverting/FieldCacheImpl.java
##
@@ -1076,10 +1076,6 @@ public BinaryDocValues getTerms(LeafReader
[
https://issues.apache.org/jira/browse/SOLR-15246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
David Smiley resolved SOLR-15246.
-
Assignee: David Smiley
Resolution: Not A Bug
I'm closing as "not a bug" because there
NazerkeBS commented on a change in pull request #17:
URL: https://github.com/apache/solr/pull/17#discussion_r594376813
##
File path:
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
##
@@ -374,7 +376,7 @@ public void call(ClusterState
bruno-roustant opened a new pull request #18:
URL: https://github.com/apache/solr/pull/18
Adapts Solr to Lucene changes where SortedDocValues no longer extends
BinaryDocValues (LUCENE-9796).
This is an automated message
[
https://issues.apache.org/jira/browse/SOLR-15261?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Bruno Roustant reassigned SOLR-15261:
-
Assignee: Bruno Roustant
> SortedDocValues no longer extends BinaryDocValues
>
[
https://issues.apache.org/jira/browse/SOLR-15246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301659#comment-17301659
]
David Smiley commented on SOLR-15246:
-
The log lines (showing request params) don't show the params
[
https://issues.apache.org/jira/browse/SOLR-15253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301636#comment-17301636
]
Jan Høydahl edited comment on SOLR-15253 at 3/15/21, 1:19 PM:
--
Done. Please
[
https://issues.apache.org/jira/browse/SOLR-15253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-15253:
---
Attachment: branchToTag.sh
> Prune git branches in solr.git
> --
>
>
NazerkeBS opened a new pull request #17:
URL: https://github.com/apache/solr/pull/17
# Description
Please provide a short description of the changes you're making with this
pull request.
# Solution
Please provide a short description of the approach taken to
[
https://issues.apache.org/jira/browse/SOLR-15253?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl updated SOLR-15253:
---
Attachment: branch-log.txt
> Prune git branches in solr.git
> --
>
>
Christine Poerschke created SOLR-15261:
--
Summary: SortedDocValues no longer extends BinaryDocValues
Key: SOLR-15261
URL: https://issues.apache.org/jira/browse/SOLR-15261
Project: Solr
[
https://issues.apache.org/jira/browse/SOLR-15104?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301588#comment-17301588
]
Christine Poerschke commented on SOLR-15104:
The {{SOLR_LOG_PRESTART_ROTATION}} option was
cpoerschke opened a new pull request #16:
URL: https://github.com/apache/solr/pull/16
Default value of `SOLR_GC_LOG_PRESTART_ARCHIVE` to be confirmed, current
value corresponds to existing behaviour.
* `solr` and `solr.in.sh` changes: done but not yet tested
* `solr.cmd` and
[
https://issues.apache.org/jira/browse/SOLR-15246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301548#comment-17301548
]
Matthew Flowerday commented on SOLR-15246:
--
Hi David
As a test I carried out the query with
[
https://issues.apache.org/jira/browse/SOLR-14216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301475#comment-17301475
]
Jan Høydahl commented on SOLR-14216:
Ok, so seems like there is some support for this idea. Feel free
[
https://issues.apache.org/jira/browse/SOLR-14216?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301475#comment-17301475
]
Jan Høydahl edited comment on SOLR-14216 at 3/15/21, 8:10 AM:
--
Ok, so seems
[
https://issues.apache.org/jira/browse/SOLR-14216?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jan Høydahl reassigned SOLR-14216:
--
Assignee: (was: Jan Høydahl)
> Exclude HealthCheck from authentication
>
[
https://issues.apache.org/jira/browse/SOLR-15246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17301409#comment-17301409
]
Matthew Flowerday commented on SOLR-15246:
--
Hi David
Thanks for working on this and for letting
71 matches
Mail list logo
