[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

2021-03-17 Thread GitBox
dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r596508662 ## File path: solr/core/src/java/org/apache/solr/core/ConfigSetService.java ## @@ -211,6 +215,73 @@ protected NamedList loadConfigSetFlags(CoreDescriptor cd, So

[jira] [Commented] (SOLR-15002) Upgrade HttpClient to 4.5.13

2021-03-17 Thread Robert Muir (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303810#comment-17303810 ] Robert Muir commented on SOLR-15002: I merged the lucene part (impacts the replicator

[GitHub] [solr] dsmiley commented on pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

2021-03-17 Thread GitBox
dsmiley commented on pull request #23: URL: https://github.com/apache/solr/pull/23#issuecomment-801565991 It's probable the ConfigSetService needs to be registered sooner then. This is an automated message from the Apache Git

[GitHub] [solr] NazerkeBS commented on pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

2021-03-17 Thread GitBox
NazerkeBS commented on pull request #23: URL: https://github.com/apache/solr/pull/23#issuecomment-801506003 @dsmiley , `TestConfigsApi` class is failing due to NPE from `OverseerConfigSetMessageHandler` where configSetService is null. -

[jira] [Commented] (SOLR-14660) Migrating HDFS into a package

2021-03-17 Thread Istvan Farkas (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14660?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303745#comment-17303745 ] Istvan Farkas commented on SOLR-14660: -- Thanks [~dsmiley], I'll keep those in mind.

[jira] [Commented] (SOLR-15170) Elevation file in data dir not working in Solr Cloud

2021-03-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303741#comment-17303741 ] David Smiley commented on SOLR-15170: - Amending my last statement -- the line is a bi

[jira] [Commented] (SOLR-15170) Elevation file in data dir not working in Solr Cloud

2021-03-17 Thread David Smiley (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15170?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303737#comment-17303737 ] David Smiley commented on SOLR-15170: - bq. I would need to reload the collection, is

[jira] [Commented] (SOLR-4903) Solr sends all doc ids to all shards in the query counting facets

2021-03-17 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-4903?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303736#comment-17303736 ] Cassandra Targett commented on SOLR-4903: - Someone asked me the other day when the

[jira] [Commented] (SOLR-15212) Update Ref Guide page template header links

2021-03-17 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303716#comment-17303716 ] ASF subversion and git services commented on SOLR-15212: Commit d

[GitHub] [solr] ctargett merged pull request #25: SOLR-15212: Update Ref Guide links

2021-03-17 Thread GitBox
ctargett merged pull request #25: URL: https://github.com/apache/solr/pull/25 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the sp

[GitHub] [solr] dsmiley commented on pull request #2: SOLR-14185: introduce DocSet.iterator(LeafReaderContext), replacing Filter where possible

2021-03-17 Thread GitBox
dsmiley commented on pull request #2: URL: https://github.com/apache/solr/pull/2#issuecomment-801360299 I think all my concerns have been addressed. A meaningful perf test would probably be some "q" query that matches a lot of documents plus a cached "fq" that matches very little (th

[GitHub] [solr] madrob commented on a change in pull request #10: SOLR-15244 Switch File to Path

2021-03-17 Thread GitBox
madrob commented on a change in pull request #10: URL: https://github.com/apache/solr/pull/10#discussion_r596299172 ## File path: solr/solrj/src/java/org/apache/solr/common/cloud/PerReplicaStatesOps.java ## @@ -65,13 +65,7 @@ private void persist(List operations, String znode

[GitHub] [solr-operator] HoustonPutman merged pull request #240: Add separate documentation page for Upgrade Notes

2021-03-17 Thread GitBox
HoustonPutman merged pull request #240: URL: https://github.com/apache/solr-operator/pull/240 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[jira] [Commented] (SOLR-15265) decide if/how to validate lucene javadoc links

2021-03-17 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303653#comment-17303653 ] Chris M. Hostetter commented on SOLR-15265: --- {quote}It's a maven requirement –

[GitHub] [solr] ctargett commented on pull request #25: SOLR-15212: Update Ref Guide links

2021-03-17 Thread GitBox
ctargett commented on pull request #25: URL: https://github.com/apache/solr/pull/25#issuecomment-801320073 Since this was previously approved and I made the one recommended change, I'll wait for precommit check to finish and then merge this. ---

[GitHub] [solr] ctargett opened a new pull request #25: SOLR-15212: Update Ref Guide links

2021-03-17 Thread GitBox
ctargett opened a new pull request #25: URL: https://github.com/apache/solr/pull/25 PR moved from apache/lucene-solr#2447. The commits bring the branch up to date with `main` and update the javadocs path to the correct non-redirected path. --

[jira] [Updated] (SOLR-15267) ref-guide link checking doesn't fail on bad links in index.html???

2021-03-17 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chris M. Hostetter updated SOLR-15267: -- Attachment: SOLR-15267.patch Status: Open (was: Open) bq. Could we just shorte

[jira] [Commented] (SOLR-15266) Audit all refs to lucene.apache.org in solr git repo

2021-03-17 Thread Chris M. Hostetter (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15266?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303637#comment-17303637 ] Chris M. Hostetter commented on SOLR-15266: --- FWIW: This issue "is part of" SOLR

[jira] [Commented] (SOLR-15267) ref-guide link checking doesn't fail on bad links in index.html???

2021-03-17 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15267?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303591#comment-17303591 ] Cassandra Targett commented on SOLR-15267: -- The only thing is I don't like the l

[jira] [Commented] (SOLR-13075) Harden SaslZkACLProviderTest.

2021-03-17 Thread Mike Drob (Jira)
[ https://issues.apache.org/jira/browse/SOLR-13075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303585#comment-17303585 ] Mike Drob commented on SOLR-13075: -- I've been running this one a bunch locally and haven

[GitHub] [solr] dsmiley commented on a change in pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

2021-03-17 Thread GitBox
dsmiley commented on a change in pull request #23: URL: https://github.com/apache/solr/pull/23#discussion_r596028789 ## File path: solr/contrib/prometheus-exporter/src/test/org/apache/solr/prometheus/scraper/SolrFileSystemConfigSetServiceScraperTest.java ## @@ -40,7 +40,7 @@

[GitHub] [solr] asalamon74 opened a new pull request #24: SOLR-15111 Use JDK8 Base64 instead of own implementation

2021-03-17 Thread GitBox
asalamon74 opened a new pull request #24: URL: https://github.com/apache/solr/pull/24 Original lucene-solr pull request: https://github.com/apache/lucene-solr/pull/2252 I removed the lucene part of it. # Description JDK8 has a builtin Base64 encoder and decoder, there

[GitHub] [solr] magibney commented on pull request #2: SOLR-14185: introduce DocSet.iterator(LeafReaderContext), replacing Filter where possible

2021-03-17 Thread GitBox
magibney commented on pull request #2: URL: https://github.com/apache/solr/pull/2#issuecomment-801172368 >Another option would be to make it final and eagerly compute it in the constructor Hmm. on second thought I think there's another practical problem with any approach seeking to

[GitHub] [solr] ctargett commented on a change in pull request #12: SOLR-15243: Update MoreLikeThis docs

2021-03-17 Thread GitBox
ctargett commented on a change in pull request #12: URL: https://github.com/apache/solr/pull/12#discussion_r596081822 ## File path: solr/solr-ref-guide/src/morelikethis.adoc ## @@ -16,97 +16,624 @@ // specific language governing permissions and limitations // under the Licens

[jira] [Created] (SOLR-15272) Solr Admin UI uses non-standard unit for the number of docs

2021-03-17 Thread Andrzej Bialecki (Jira)
Andrzej Bialecki created SOLR-15272: --- Summary: Solr Admin UI uses non-standard unit for the number of docs Key: SOLR-15272 URL: https://issues.apache.org/jira/browse/SOLR-15272 Project: Solr

[GitHub] [solr] magibney commented on pull request #2: SOLR-14185: introduce DocSet.iterator(LeafReaderContext), replacing Filter where possible

2021-03-17 Thread GitBox
magibney commented on pull request #2: URL: https://github.com/apache/solr/pull/2#issuecomment-801119305 Made cachedOrdIdxMap `volatile` in 8007e5c. Another option would be to make it `final` and eagerly compute it in the constructor (trading `volatile` overhead for some unnecessary work o

[GitHub] [solr] NazerkeBS opened a new pull request #23: SOLR-15258: ConfigSetService add CRUD operations, subsume ZkConfigManager

2021-03-17 Thread GitBox
NazerkeBS opened a new pull request #23: URL: https://github.com/apache/solr/pull/23 - `Standalone` class renamed to `FileSystemConfigSet` - `CloudConfigSetService` class renamed to `ZkConfigSetService` - Removed `ZkConfigManager` - `TestZkConfigManager`renamed to `TestZkConfigSetS

[GitHub] [solr] asalamon74 opened a new pull request #22: SOLR-15169 SolrPaths.assertPathAllowed normalization problem

2021-03-17 Thread GitBox
asalamon74 opened a new pull request #22: URL: https://github.com/apache/solr/pull/22 Original lucene-solr pull request: https://github.com/apache/lucene-solr/pull/2406 # Description In the SolrPaths.assertPathAllowed the normalize() method is only called for pathToAs

[jira] [Commented] (SOLR-15265) decide if/how to validate lucene javadoc links

2021-03-17 Thread Dawid Weiss (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15265?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303176#comment-17303176 ] Dawid Weiss commented on SOLR-15265: bq. if lucene start publishing javadoc jars It'

[jira] [Commented] (SOLR-14827) Refactor schema loading to not use XPath

2021-03-17 Thread Noble Paul (Jira)
[ https://issues.apache.org/jira/browse/SOLR-14827?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17303157#comment-17303157 ] Noble Paul commented on SOLR-14827: --- are you referring to the {{storeConfig()}} method?