[jira] [Comment Edited] (SOLR-15581) Expand the benchmark DocMaker api to allow for a wider array of value generation strategies.

2021-08-17 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400788#comment-17400788 ] Mark Robert Miller edited comment on SOLR-15581 at 8/18/21, 5:16 AM: --

[jira] [Comment Edited] (SOLR-15581) Expand the benchmark DocMaker api to allow for a wider array of value generation strategies.

2021-08-17 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400788#comment-17400788 ] Mark Robert Miller edited comment on SOLR-15581 at 8/18/21, 5:15 AM: --

[jira] [Commented] (SOLR-15581) Expand the benchmark DocMaker api to allow for a wider array of value generation strategies.

2021-08-17 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400788#comment-17400788 ] Mark Robert Miller commented on SOLR-15581: --- [~mdrob] - high level on the new d

[jira] [Assigned] (SOLR-15581) Expand the benchmark DocMaker api to allow for a wider array of value generation strategies.

2021-08-17 Thread Mark Robert Miller (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15581?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Robert Miller reassigned SOLR-15581: - Assignee: Mark Robert Miller > Expand the benchmark DocMaker api to allow for a

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

2021-08-17 Thread GitBox
HoustonPutman commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690739575 ## File path: controllers/solrcloud_controller.go ## @@ -364,51 +364,57 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request) (ctrl.Resu

[GitHub] [solr-operator] HoustonPutman commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

2021-08-17 Thread GitBox
HoustonPutman commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690739265 ## File path: controllers/util/solr_util.go ## @@ -601,6 +552,11 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud, solrCloudStatus *solr.S

[GitHub] [solr-operator] thelabdude opened a new issue #310: Enable scheduled restarts of Prometheus Exporter pods

2021-08-17 Thread GitBox
thelabdude opened a new issue #310: URL: https://github.com/apache/solr-operator/issues/310 Similar to what was done for https://github.com/apache/solr-operator/issues/281 This would be useful for environments where TLS certs get injected into exporter pods and the certs need to be

[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

2021-08-17 Thread GitBox
thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690705380 ## File path: controllers/util/prometheus_exporter_util.go ## @@ -46,17 +45,9 @@ type SolrConnectionInfo struct { StandaloneAddress st

[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

2021-08-17 Thread GitBox
thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690704848 ## File path: controllers/solrprometheusexporter_controller.go ## @@ -197,28 +197,30 @@ func (r *SolrPrometheusExporterReconciler) Reconcile(req c

[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

2021-08-17 Thread GitBox
thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690703569 ## File path: controllers/solrcloud_controller.go ## @@ -364,51 +364,57 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request) (ctrl.Result,

[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

2021-08-17 Thread GitBox
thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690697734 ## File path: controllers/util/solr_util.go ## @@ -601,6 +552,11 @@ func GenerateStatefulSet(solrCloud *solr.SolrCloud, solrCloudStatus *solr.Solr

[GitHub] [solr-operator] thelabdude commented on issue #308: Refactor TLS code

2021-08-17 Thread GitBox
thelabdude commented on issue #308: URL: https://github.com/apache/solr-operator/issues/308#issuecomment-900601695 Once we get through this refactor, I'll tackle #300 and we should also refactor the security.json / Basic Auth code to take the same append at the end approach as it too is in

[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

2021-08-17 Thread GitBox
thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690689552 ## File path: controllers/solrcloud_controller_tls_test.go ## @@ -126,7 +126,6 @@ func TestMountedTLSDir(t *testing.T) { mountedDir := &sol

[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

2021-08-17 Thread GitBox
thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690688691 ## File path: controllers/solrcloud_controller.go ## @@ -215,15 +215,15 @@ func (r *SolrCloudReconciler) Reconcile(req ctrl.Request) (ctrl.Result,

[GitHub] [solr-operator] thelabdude commented on a change in pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

2021-08-17 Thread GitBox
thelabdude commented on a change in pull request #309: URL: https://github.com/apache/solr-operator/pull/309#discussion_r690688351 ## File path: controllers/controller_utils_test.go ## @@ -190,14 +190,6 @@ func verifyUserSuppliedTLSConfig(t *testing.T, tls *solr.SolrTLSOptions

[GitHub] [solr-operator] thelabdude opened a new pull request #309: Refactor TLS setup code into a separate file and consolidate logic between the StatefulSet and exporter Deployment

2021-08-17 Thread GitBox
thelabdude opened a new pull request #309: URL: https://github.com/apache/solr-operator/pull/309 Fixes #308 Consolidated most of the TLS related utility code into a new file in the `util` package: `solr_tls_util.go` All the TLS related config (env vars, annotations, initConta

[GitHub] [solr-operator] thelabdude opened a new issue #308: Refactor TLS code

2021-08-17 Thread GitBox
thelabdude opened a new issue #308: URL: https://github.com/apache/solr-operator/issues/308 The code that enables TLS for Solr and Prometheus exporter pods has evolved over the past several months, and still has some additional changes we want to add. Let's clean-up the TLS code before add

[jira] [Assigned] (SOLR-10887) Add .xml extension to managed-schema

2021-08-17 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-10887?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] David Eric Pugh reassigned SOLR-10887: -- Assignee: David Eric Pugh > Add .xml extension to managed-schema > ---

[jira] [Updated] (SOLR-15588) Implement random replica placement strategy

2021-08-17 Thread Megan Carey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Megan Carey updated SOLR-15588: --- Description: This is a stopgap replica placement strategy that randomly selects a node in the cluste

[jira] [Updated] (SOLR-15588) Implement random replica placement strategy

2021-08-17 Thread Megan Carey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15588?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Megan Carey updated SOLR-15588: --- Affects Version/s: (was: main (9.0)) > Implement random replica placement strategy >

[jira] [Commented] (SOLR-15466) sample_techproducts_configs files reference the old Solr wiki

2021-08-17 Thread David Eric Pugh (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400516#comment-17400516 ] David Eric Pugh commented on SOLR-15466: I just bumped (again) into this issue wh

[jira] [Commented] (SOLR-15588) Implement random replica placement strategy

2021-08-17 Thread Megan Carey (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400517#comment-17400517 ] Megan Carey commented on SOLR-15588: [~ctargett] Thanks for that context - I agree th

[GitHub] [solr] dsmiley commented on pull request #155: SOLR-15438: Simplify SolrDispatchFilter.destroy

2021-08-17 Thread GitBox
dsmiley commented on pull request #155: URL: https://github.com/apache/solr/pull/155#issuecomment-900494248 @gus-asf you may be interested in this fairly recent PR. It kinda stalled; I'm not sure how to reconcile some of Mark's feedback. Actually I responded to him so maybe it's in his c

[jira] [Commented] (SOLR-15592) Admin UI translations

2021-08-17 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15592?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400473#comment-17400473 ] Christine Poerschke commented on SOLR-15592: https://lists.apache.org/thread.

[jira] [Updated] (SOLR-15592) Admin UI translations

2021-08-17 Thread Christine Poerschke (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15592?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Christine Poerschke updated SOLR-15592: --- Attachment: SOLR-15592.patch > Admin UI translations > - > >

[jira] [Created] (SOLR-15592) Admin UI translations

2021-08-17 Thread Christine Poerschke (Jira)
Christine Poerschke created SOLR-15592: -- Summary: Admin UI translations Key: SOLR-15592 URL: https://issues.apache.org/jira/browse/SOLR-15592 Project: Solr Issue Type: New Feature

[GitHub] [solr] cpoerschke commented on pull request #248: SOLR-6156: Fix NullPointerException if group.field grouping is used with rows=0 and timeAllowed

2021-08-17 Thread GitBox
cpoerschke commented on pull request #248: URL: https://github.com/apache/solr/pull/248#issuecomment-900419308 selected code path links that may be helpful when code reviewing this change: * `CommandHandler.searchWithTimeLimiter` is passed a null `collector` if called from https://g

[GitHub] [solr] sonatype-lift[bot] commented on a change in pull request #265: SOLR-15590 - Startup and CoreContainer managed by Core Service

2021-08-17 Thread GitBox
sonatype-lift[bot] commented on a change in pull request #265: URL: https://github.com/apache/solr/pull/265#discussion_r690499793 ## File path: solr/core/src/java/org/apache/solr/servlet/CoreService.java ## @@ -0,0 +1,451 @@ +/* + * Licensed to the Apache Software Foundation (A

[jira] [Created] (SOLR-15591) NullPointerException in ExternalPaths.determineSourceHome makes debugging cumbersome

2021-08-17 Thread Mike Drob (Jira)
Mike Drob created SOLR-15591: Summary: NullPointerException in ExternalPaths.determineSourceHome makes debugging cumbersome Key: SOLR-15591 URL: https://issues.apache.org/jira/browse/SOLR-15591 Project: S

[jira] [Commented] (SOLR-15590) Start up Core Container via ServletContextListener

2021-08-17 Thread Gus Heck (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15590?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400425#comment-17400425 ] Gus Heck commented on SOLR-15590: - Note that the first candidate for extraction is the ad

[GitHub] [solr] gus-asf opened a new pull request #265: SOLR-15590 - Startup and CoreContainer managed by Core Service

2021-08-17 Thread GitBox
gus-asf opened a new pull request #265: URL: https://github.com/apache/solr/pull/265 https://issues.apache.org/jira/browse/SOLR-15590 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[jira] [Created] (SOLR-15590) Start up Core Container via ServletContextListener

2021-08-17 Thread Gus Heck (Jira)
Gus Heck created SOLR-15590: --- Summary: Start up Core Container via ServletContextListener Key: SOLR-15590 URL: https://issues.apache.org/jira/browse/SOLR-15590 Project: Solr Issue Type: Improvement

[jira] [Commented] (SOLR-15588) Implement random replica placement strategy

2021-08-17 Thread Cassandra Targett (Jira)
[ https://issues.apache.org/jira/browse/SOLR-15588?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17400394#comment-17400394 ] Cassandra Targett commented on SOLR-15588: -- A RandomPlacementFactory already exi

[GitHub] [solr] janhoy commented on pull request #264: SOLR-10887: Append .xml to managed-schema file

2021-08-17 Thread GitBox
janhoy commented on pull request #264: URL: https://github.com/apache/solr/pull/264#issuecomment-900204661 Think I agree with @dsmiley here. Change the default for new versions, but look support fallback to old going forward. No surprises. Users can then easily do a manual rename of the fi